)]}'
{"specs/pike/deprecate-job-binary-internal.rst":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"735a03ab1fa749d7de013e630b823ee51e7b7fa4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Deprecate Job Binary Internal"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/sahara/+spec/example"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_2a1c83bf","line":2,"updated":"2017-04-09 23:15:50.000000000","message":"I would probably say \"Internal Job Binaries\" (repeat this comment for the rest of the spec)","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"4cf2a8ab38dde9a42b940e1c27d12ea114427395","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Deprecate Job Binary Internal"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/sahara/+spec/example"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_62305da0","line":2,"in_reply_to":"bff0334d_2a1c83bf","updated":"2017-04-10 14:49:58.000000000","message":"I don\u0027t agree with this because in the code and docs it\u0027s referenced as \"Job Binary Internal\". Do you have a good reason why not to use job binary internal? Thanks!","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"735a03ab1fa749d7de013e630b823ee51e7b7fa4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Deprecate Job Binary Internal"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/sahara/+spec/example"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Job binary internal is not needed now, since swift and manila"},{"line_number":8,"context_line":"are available (and possibly other storage options in the future)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_4a1fc7b6","line":5,"updated":"2017-04-09 23:15:50.000000000","message":"replace this with an actual launchpad url (it\u0027s needed to track status)","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"4cf2a8ab38dde9a42b940e1c27d12ea114427395","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Deprecate Job Binary Internal"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/sahara/+spec/example"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Job binary internal is not needed now, since swift and manila"},{"line_number":8,"context_line":"are available (and possibly other storage options in the future)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_22db754f","line":5,"in_reply_to":"bff0334d_4a1fc7b6","updated":"2017-04-10 14:49:58.000000000","message":"oops, sorry!","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"735a03ab1fa749d7de013e630b823ee51e7b7fa4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Besides that, Sahara\u0027s internal database should be used only to"},{"line_number":19,"context_line":"Sahara\u0027s data storage. Allowing job binaries to be storage in"},{"line_number":20,"context_line":"Sahara\u0027s database isn\u0027t only unneeded, but also a possible source"},{"line_number":21,"context_line":"of problems."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_0ac9bf24","line":21,"updated":"2017-04-09 23:15:50.000000000","message":"maybe explicitly say how it has been inappropriate to be storing large files in a regular db","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"4cf2a8ab38dde9a42b940e1c27d12ea114427395","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Besides that, Sahara\u0027s internal database should be used only to"},{"line_number":19,"context_line":"Sahara\u0027s data storage. Allowing job binaries to be storage in"},{"line_number":20,"context_line":"Sahara\u0027s database isn\u0027t only unneeded, but also a possible source"},{"line_number":21,"context_line":"of problems."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_7d459e42","line":21,"in_reply_to":"bff0334d_0ac9bf24","updated":"2017-04-10 14:49:58.000000000","message":"I added more details, but if you think I\u0027m missing something important please comment :).","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"735a03ab1fa749d7de013e630b823ee51e7b7fa4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This change proposes to deprecate job binary internal in"},{"line_number":27,"context_line":"favour of other storage options."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This can be done in five major patches:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_6a54cb53","line":26,"updated":"2017-04-09 23:15:50.000000000","message":"You say deprecate, but all the steps involve removal. So maybe the spec should be titled \"Remove...\"","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"4cf2a8ab38dde9a42b940e1c27d12ea114427395","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This change proposes to deprecate job binary internal in"},{"line_number":27,"context_line":"favour of other storage options."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This can be done in five major patches:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_5d2ada7e","line":26,"in_reply_to":"bff0334d_6a54cb53","updated":"2017-04-10 14:49:58.000000000","message":"Done","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"735a03ab1fa749d7de013e630b823ee51e7b7fa4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  (possibly a few patches)"},{"line_number":96,"context_line":"* remove job binary internal from database"},{"line_number":97,"context_line":"* remove job binary internal option from Horizon"},{"line_number":98,"context_line":"* update documentation involving job binary internal"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_ca8077c2","line":98,"updated":"2017-04-09 23:15:50.000000000","message":"don\u0027t actually mention the following thing in the spec, but let\u0027s make sure it gets removed here too:\n\nhttp://git.openstack.org/cgit/openstack/puppet-sahara/tree/examples/basic.pp","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"f1d939f9f84454e34a04dc14e19f6721f3f61277","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  (possibly a few patches)"},{"line_number":96,"context_line":"* remove job binary internal from database"},{"line_number":97,"context_line":"* remove job binary internal option from Horizon"},{"line_number":98,"context_line":"* update documentation involving job binary internal"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_3de4b6e0","line":98,"in_reply_to":"bff0334d_ca8077c2","updated":"2017-04-10 14:54:24.000000000","message":"Done","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"735a03ab1fa749d7de013e630b823ee51e7b7fa4","unresolved":false,"context_lines":[{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Update documentation to related to job binary internal,"},{"line_number":115,"context_line":"and add a warning about job binary internal\u0027s deprecation."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"References"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_8a6eef2c","line":115,"updated":"2017-04-09 23:15:50.000000000","message":"to clarify here: pike\u003ddeprecate, queens\u003dremove?","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"4cf2a8ab38dde9a42b940e1c27d12ea114427395","unresolved":false,"context_lines":[{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Update documentation to related to job binary internal,"},{"line_number":115,"context_line":"and add a warning about job binary internal\u0027s deprecation."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"References"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_c2f8497c","line":115,"in_reply_to":"bff0334d_8a6eef2c","updated":"2017-04-10 14:49:58.000000000","message":"Yes, it makes sense \\o/.","commit_id":"6eacf76be16b619387701c3a8c0e705463201c5b"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"45feb70ca74db4e4efe38705710e2e16ad36147e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Another option for this change would be not remove job"},{"line_number":44,"context_line":"binary internal, wich could bring future problems to Sahara."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bff0334d_6c1a8fcc","line":44,"updated":"2017-04-10 16:25:54.000000000","message":"which","commit_id":"451edbdf0b8d76a9da65529ea7ba2f00f4fe37b5"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"81b96ed5a114d4e6ab0b214a9690a4227e912166","unresolved":false,"context_lines":[{"line_number":41,"context_line":"------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Another option for this change would be not remove job"},{"line_number":44,"context_line":"binary internal, wich could bring future problems to Sahara."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bff0334d_6c204fad","line":44,"in_reply_to":"bff0334d_6c1a8fcc","updated":"2017-04-10 16:34:07.000000000","message":"Done","commit_id":"451edbdf0b8d76a9da65529ea7ba2f00f4fe37b5"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"45feb70ca74db4e4efe38705710e2e16ad36147e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"* remove job binary internal option from Horizon"},{"line_number":100,"context_line":"* update documentation involving job binary internal"},{"line_number":101,"context_line":"* make changes in the related files at puppet sahara"},{"line_number":102,"context_line":"  http://git.openstack.org/cgit/openstack/puppet-sahara/tree/examples/basic.pp"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Dependencies"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bff0334d_acd417ea","line":102,"updated":"2017-04-10 16:25:54.000000000","message":"well actually for puppet-sahara I meant not to directly mention it in the spec -- I just commented about it so that we would remember it.","commit_id":"451edbdf0b8d76a9da65529ea7ba2f00f4fe37b5"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"81b96ed5a114d4e6ab0b214a9690a4227e912166","unresolved":false,"context_lines":[{"line_number":99,"context_line":"* remove job binary internal option from Horizon"},{"line_number":100,"context_line":"* update documentation involving job binary internal"},{"line_number":101,"context_line":"* make changes in the related files at puppet sahara"},{"line_number":102,"context_line":"  http://git.openstack.org/cgit/openstack/puppet-sahara/tree/examples/basic.pp"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Dependencies"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bff0334d_ac53f738","line":102,"in_reply_to":"bff0334d_acd417ea","updated":"2017-04-10 16:34:07.000000000","message":"cool, sorry, I misunderstood this.","commit_id":"451edbdf0b8d76a9da65529ea7ba2f00f4fe37b5"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"ad59d0a6a5b234820b7403176d524b5df30fa07a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"anymore since there are better storage options (swift, manila, ...)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Besides that, Sahara\u0027s internal database should be used only to"},{"line_number":19,"context_line":"Sahara\u0027s data storage. Allowing job binaries to be storage in"},{"line_number":20,"context_line":"Sahara\u0027s database isn\u0027t only unneeded, but also a possible source"},{"line_number":21,"context_line":"of problems, since it increases the size of the database, and it\u0027s"},{"line_number":22,"context_line":"definitely the wrong tool for the job."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_ef01f139","line":19,"range":{"start_line":19,"start_character":51,"end_line":19,"end_character":58},"updated":"2017-04-10 17:05:07.000000000","message":"stored","commit_id":"3c01892be27aac6947d36d1e4dc8d56ee97209de"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"9fcdfb1d0b4b54326a812d98466ce3b8a253c984","unresolved":false,"context_lines":[{"line_number":16,"context_line":"anymore since there are better storage options (swift, manila, ...)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Besides that, Sahara\u0027s internal database should be used only to"},{"line_number":19,"context_line":"Sahara\u0027s data storage. Allowing job binaries to be storage in"},{"line_number":20,"context_line":"Sahara\u0027s database isn\u0027t only unneeded, but also a possible source"},{"line_number":21,"context_line":"of problems, since it increases the size of the database, and it\u0027s"},{"line_number":22,"context_line":"definitely the wrong tool for the job."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_32b4dcd0","line":19,"range":{"start_line":19,"start_character":51,"end_line":19,"end_character":58},"in_reply_to":"bff0334d_ef01f139","updated":"2017-04-10 17:34:56.000000000","message":"Done","commit_id":"3c01892be27aac6947d36d1e4dc8d56ee97209de"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"ad59d0a6a5b234820b7403176d524b5df30fa07a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Job binary internal related requests must be removed."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Other end user impact"},{"line_number":58,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_8fbf0560","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":53},"updated":"2017-04-10 17:05:07.000000000","message":"You should mention that this won\u0027t affect the current API, only when APIv2 is released","commit_id":"3c01892be27aac6947d36d1e4dc8d56ee97209de"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"9fcdfb1d0b4b54326a812d98466ce3b8a253c984","unresolved":false,"context_lines":[{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Job binary internal related requests must be removed."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Other end user impact"},{"line_number":58,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_32a17c47","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":53},"in_reply_to":"bff0334d_8fbf0560","updated":"2017-04-10 17:34:56.000000000","message":"Done","commit_id":"3c01892be27aac6947d36d1e4dc8d56ee97209de"}],"specs/pike/remove-job-binary-internal.rst":[{"author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"change_message_id":"0187343aa98f676020661f990177472fdffd87d4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"favour of other storage options. Planning to deprecate"},{"line_number":32,"context_line":"it in Pike release, and fully remove it in Queens."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"This can be done in five major patches:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7ffa3b31_658235cb","line":34,"range":{"start_line":34,"start_character":19,"end_line":34,"end_character":25},"updated":"2017-04-14 03:17:03.000000000","message":"I think we should concern about saharaclient which has higher priority to sahara-dashboard.","commit_id":"9e94899bbdeafc225a3ef6fd75a73b7c86564de5"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"7fa4433e9d8c241aafb6483d65fa731b5c12bb15","unresolved":false,"context_lines":[{"line_number":31,"context_line":"favour of other storage options. Planning to deprecate"},{"line_number":32,"context_line":"it in Pike release, and fully remove it in Queens."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"This can be done in five major patches:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7ffa3b31_b2519a11","line":34,"range":{"start_line":34,"start_character":19,"end_line":34,"end_character":25},"in_reply_to":"7ffa3b31_658235cb","updated":"2017-04-14 12:08:49.000000000","message":"Done","commit_id":"9e94899bbdeafc225a3ef6fd75a73b7c86564de5"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"5665d2e76563ee0e79eecbf1f3e6e896b71a0f99","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Sahara\u0027s data storage. Allowing job binaries to be stored in"},{"line_number":20,"context_line":"Sahara\u0027s database isn\u0027t only unneeded, but also a possible source"},{"line_number":21,"context_line":"of problems, since it increases the size of the database, and it\u0027s"},{"line_number":22,"context_line":"definitely the wrong tool for the job."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Also, it\u0027s important to notice that this change is related to"},{"line_number":25,"context_line":"APIv2 and should not break APIv1."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff0f0b1f_7ad64e2a","line":22,"updated":"2017-05-25 21:19:59.000000000","message":"I might call out that this is particularly true in the public cloud case, in which multiple tenants may need to store arbitrarily large binaries in the one control plane DB. All other storage options available store this data in the tenant plane, where its size can be monitored (and billed) per tenant.","commit_id":"d63b64eea39ebed022cd0808ed7e6940038447f1"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"d75ab3c40fede87364f6be569795742a448f4ff3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"},{"line_number":38,"context_line":"  (possibly a few patches)"},{"line_number":39,"context_line":"* remove job binary internal from database"},{"line_number":40,"context_line":"* remove job binary internal from saharaclient"},{"line_number":41,"context_line":"* remove job binary internal option from Horizon"},{"line_number":42,"context_line":"  (sahara-dashboard)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5ff73747_417dd6af","line":39,"updated":"2017-04-24 14:34:18.000000000","message":"So, just to clarify, am I right that we are going to completely remove job binary internal support even for api v1.1 ? If no, I suspect that database should stay since we still support that feature for api v1.1.\nSo, waiting for clarifications.","commit_id":"d63b64eea39ebed022cd0808ed7e6940038447f1"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"94192134942f0b08cbbd9d12b7b63cbfbcab509e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"},{"line_number":38,"context_line":"  (possibly a few patches)"},{"line_number":39,"context_line":"* remove job binary internal from database"},{"line_number":40,"context_line":"* remove job binary internal from saharaclient"},{"line_number":41,"context_line":"* remove job binary internal option from Horizon"},{"line_number":42,"context_line":"  (sahara-dashboard)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5ff73747_44a96479","line":39,"in_reply_to":"5ff73747_249bf8c9","updated":"2017-04-24 21:03:07.000000000","message":"I don\u0027t think that is the best approach. We should remove only on v2.","commit_id":"d63b64eea39ebed022cd0808ed7e6940038447f1"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"5665d2e76563ee0e79eecbf1f3e6e896b71a0f99","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"},{"line_number":38,"context_line":"  (possibly a few patches)"},{"line_number":39,"context_line":"* remove job binary internal from database"},{"line_number":40,"context_line":"* remove job binary internal from saharaclient"},{"line_number":41,"context_line":"* remove job binary internal option from Horizon"},{"line_number":42,"context_line":"  (sahara-dashboard)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff0f0b1f_bac4e660","line":39,"in_reply_to":"5ff73747_39c2f634","updated":"2017-05-25 21:19:59.000000000","message":"Yeah, sadly we can\u0027t remove REST methods except at a major version switch. We can really mostly only add params on minor API version updates.","commit_id":"d63b64eea39ebed022cd0808ed7e6940038447f1"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"0ce686a08a52541f9b7ce45aa1da52f7600057f4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"},{"line_number":38,"context_line":"  (possibly a few patches)"},{"line_number":39,"context_line":"* remove job binary internal from database"},{"line_number":40,"context_line":"* remove job binary internal from saharaclient"},{"line_number":41,"context_line":"* remove job binary internal option from Horizon"},{"line_number":42,"context_line":"  (sahara-dashboard)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5ff73747_249bf8c9","line":39,"in_reply_to":"5ff73747_417dd6af","updated":"2017-04-24 14:40:57.000000000","message":"Yes, I think so, but waiting for other clarifications.","commit_id":"d63b64eea39ebed022cd0808ed7e6940038447f1"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"42ffc4cf1a15bd15e1e9ed7ebb39867851a3ce6a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"},{"line_number":38,"context_line":"  (possibly a few patches)"},{"line_number":39,"context_line":"* remove job binary internal from database"},{"line_number":40,"context_line":"* remove job binary internal from saharaclient"},{"line_number":41,"context_line":"* remove job binary internal option from Horizon"},{"line_number":42,"context_line":"  (sahara-dashboard)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5ff73747_99dc6a75","line":39,"in_reply_to":"5ff73747_44a96479","updated":"2017-04-24 21:05:38.000000000","message":"Telles, so we won\u0027t remove it from the db?","commit_id":"d63b64eea39ebed022cd0808ed7e6940038447f1"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"7285a7fbb43b1dba6f78dd9952f84a717728318a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"},{"line_number":38,"context_line":"  (possibly a few patches)"},{"line_number":39,"context_line":"* remove job binary internal from database"},{"line_number":40,"context_line":"* remove job binary internal from saharaclient"},{"line_number":41,"context_line":"* remove job binary internal option from Horizon"},{"line_number":42,"context_line":"  (sahara-dashboard)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5ff73747_b9ba86db","line":39,"in_reply_to":"5ff73747_99dc6a75","updated":"2017-04-24 21:14:49.000000000","message":"I think we will, but not now. We can do it after we remove API v1.1. Otherwise we might break some stuff.","commit_id":"d63b64eea39ebed022cd0808ed7e6940038447f1"},{"author":{"_account_id":16625,"name":"Marianne Linhares Monteiro","email":"mariannelinharesm@gmail.com","username":"marianneLinhares"},"change_message_id":"7d9c4a6b5419bddee5dffe697f8fe377807cefa1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"},{"line_number":38,"context_line":"  (possibly a few patches)"},{"line_number":39,"context_line":"* remove job binary internal from database"},{"line_number":40,"context_line":"* remove job binary internal from saharaclient"},{"line_number":41,"context_line":"* remove job binary internal option from Horizon"},{"line_number":42,"context_line":"  (sahara-dashboard)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5ff73747_39c2f634","line":39,"in_reply_to":"5ff73747_b9ba86db","updated":"2017-04-24 21:19:07.000000000","message":"Okay, I understand it now. Thank you, Telles.","commit_id":"d63b64eea39ebed022cd0808ed7e6940038447f1"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"045af9427d83d7e009db255dedcfafba4bc4f82d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"},{"line_number":38,"context_line":"  (possibly a few patches)"},{"line_number":39,"context_line":"* remove job binary internal from database"},{"line_number":40,"context_line":"* remove job binary internal from saharaclient"},{"line_number":41,"context_line":"* remove job binary internal option from Horizon"},{"line_number":42,"context_line":"  (sahara-dashboard)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff0f0b1f_317c5bb4","line":39,"in_reply_to":"ff0f0b1f_71c77347","updated":"2017-06-20 11:58:41.000000000","message":"I\u0027m not entirely sure that we should. In case someone is using internal binary feature, we don\u0027t want to break that.","commit_id":"d63b64eea39ebed022cd0808ed7e6940038447f1"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"ece64166bf18a71ff058231fc608556653afa8ca","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* remove job binary internal from APIv2"},{"line_number":37,"context_line":"* remove internal code that deals with job binary internal"},{"line_number":38,"context_line":"  (possibly a few patches)"},{"line_number":39,"context_line":"* remove job binary internal from database"},{"line_number":40,"context_line":"* remove job binary internal from saharaclient"},{"line_number":41,"context_line":"* remove job binary internal option from Horizon"},{"line_number":42,"context_line":"  (sahara-dashboard)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff0f0b1f_71c77347","line":39,"in_reply_to":"ff0f0b1f_bac4e660","updated":"2017-05-26 18:52:22.000000000","message":"Just for some further clarity here, we can\u0027t remove the API methods, but we can make them always do nothing, right?\n\nFor example:\nhttps://github.com/openstack/sahara/commit/f41c51ad033e3fbc1d7e6624a76a3ef77683ca51","commit_id":"d63b64eea39ebed022cd0808ed7e6940038447f1"}]}