)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7125,"name":"Alexander Ignatov","email":"aignatov@mirantis.com","username":"aignatov"},"change_message_id":"9bf6b16379d915e906e0835bebac0bec2eaec56e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Note, behavior of anti-affinity changed. Now Sahara will create one"},{"line_number":13,"context_line":"server group for cluster and will assign all affected instances to it."},{"line_number":14,"context_line":"So, if anti-affinity enabled for datanode (`dn`) and tasktracker (`tt`)"},{"line_number":15,"context_line":"Sahara will not assign node with `dn` and node with `tt` to the same"},{"line_number":16,"context_line":"compute."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Also note, that server group support will be added to heat only in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_df7ed61a","line":15,"updated":"2014-08-08 07:57:59.000000000","message":"Reading this note I\u0027m wondering how it will work for the case.\n\nAssuming I have 3 computes and the following JSON for cluster creation.\n\n\n{\n    \"name\": \"cluster\",\n    \"plugin_name\": \"vanilla\",\n    \"hadoop_version\": \"1.2.1\",\n\n    \"anti_affinity\": [\"datanode\", \"tasktracker\"],\n\n    \"node_groups\": [\n        {\n            \"name\": \"master\",\n            \"count\": 1,\n            \"node_processes\": [\"namenode\"],\n             ...skipped...\n        },\n        {\n            \"name\": \"worker\",\n            \"node_processes\": [\"datanode\", \"tasktracker\"],\n            \"count\": 3\n        }\n    ]\n}\n\nWhat will happen? Success or  Fail about insufficient number of computes?\n\n\nAnd what will happen for 3 computes and the following JSON:\n\n{\n    \"name\": \"cluster\",\n    \"plugin_name\": \"vanilla\",\n    \"hadoop_version\": \"1.2.1\",\n\n    \"anti_affinity\": [\"datanode\", \"tasktracker\"],\n\n    \"node_groups\": [\n        {\n            \"name\": \"master\",\n            \"count\": 1,\n            \"node_processes\": [\"namenode\"],\n             ...skipped...\n        },\n        {\n            \"name\": \"worker1\",\n            \"node_processes\": [\"datanode\"],\n            \"count\": 3\n        },\n        {\n            \"name\": \"worker2\",\n            \"node_processes\": [\"tasktracker\"],\n            \"count\": 3\n        }\n    ]\n}\n\nFail because changed behaviour you explained in Note?","commit_id":"229c95350af61451b79d68eaf90fc62feeeb2c13"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"e3ab75ea64324793194da194b6254d68ce493342","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Note, behavior of anti-affinity changed. Now Sahara will create one"},{"line_number":13,"context_line":"server group for cluster and will assign all affected instances to it."},{"line_number":14,"context_line":"So, if anti-affinity enabled for datanode (`dn`) and tasktracker (`tt`)"},{"line_number":15,"context_line":"Sahara will not assign node with `dn` and node with `tt` to the same"},{"line_number":16,"context_line":"compute."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Also note, that server group support will be added to heat only in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_3e7426cf","line":15,"in_reply_to":"baada198_df7ed61a","updated":"2014-08-08 14:55:24.000000000","message":"Success in the first case, fail in the second.","commit_id":"229c95350af61451b79d68eaf90fc62feeeb2c13"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"c5e68d1279724d3e6d7c041cc4442e3f320d8869","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixed anti-affinity for HEAT engine"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added support of anti-afinity using heat provisioning engine even"},{"line_number":10,"context_line":"when process spreaded across several noe groups."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Note, behavior of anti-affinity changed. Now Sahara will create one"},{"line_number":13,"context_line":"server group for cluster and will assign all affected instances to it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_ad70d241","line":10,"range":{"start_line":10,"start_character":37,"end_line":10,"end_character":40},"updated":"2014-08-11 15:37:06.000000000","message":"noDe groups","commit_id":"5666b22a4a168b1abcfc72f59b9932dbeba0eea9"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"48fe925fdcc5bb169e70fd519ae82b7aa6dc3b71","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixed anti-affinity for HEAT engine"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added support of anti-afinity using heat provisioning engine even"},{"line_number":10,"context_line":"when process spreaded across several noe groups."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Note, behavior of anti-affinity changed. Now Sahara will create one"},{"line_number":13,"context_line":"server group for cluster and will assign all affected instances to it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_26913f46","line":10,"range":{"start_line":10,"start_character":37,"end_line":10,"end_character":40},"in_reply_to":"baada198_ad70d241","updated":"2014-08-11 16:34:51.000000000","message":"Done","commit_id":"5666b22a4a168b1abcfc72f59b9932dbeba0eea9"}],"doc/source/userdoc/upgrade.guide.rst":[{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"2c620154e74781dd34ca96170790474f7c7b46af","unresolved":false,"context_lines":[{"line_number":39,"context_line":"++++++++++++++++++++++++++++++"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"If Heat provisioning engine is used (``infrastructure_engine\u003dheat``) it will"},{"line_number":42,"context_line":"be impossible to scale old clusters that have anti affinity feature enabled."},{"line_number":43,"context_line":"Format of heat template for anti affinity was changed in Juno and attempt to"},{"line_number":44,"context_line":"scale cluster created in Icehouse will lead to recreation of all instances"},{"line_number":45,"context_line":"involved into anti affinity."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7ac7a964_8ec73a12","line":42,"updated":"2014-08-14 10:49:04.000000000","message":"it will NOT be possible.","commit_id":"3dca4c1e96828e8a16ec33ff107b0a3915a88cc8"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"dae5892ded308bfe0bb2cdde0a2f367618441058","unresolved":false,"context_lines":[{"line_number":39,"context_line":"++++++++++++++++++++++++++++++"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"If Heat provisioning engine is used (``infrastructure_engine\u003dheat``) it will"},{"line_number":42,"context_line":"be impossible to scale old clusters that have anti affinity feature enabled."},{"line_number":43,"context_line":"Format of heat template for anti affinity was changed in Juno and attempt to"},{"line_number":44,"context_line":"scale cluster created in Icehouse will lead to recreation of all instances"},{"line_number":45,"context_line":"involved into anti affinity."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7ac7a964_e5d0ab55","line":42,"in_reply_to":"7ac7a964_8ec73a12","updated":"2014-08-15 00:03:23.000000000","message":"Done","commit_id":"3dca4c1e96828e8a16ec33ff107b0a3915a88cc8"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"b99685b6fc5fb7e51a8cb4d68d137fbb186734e3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"++++++++++++++++++++++++++++++"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"If Heat provisioning engine is used (``infrastructure_engine\u003dheat``) it will"},{"line_number":42,"context_line":"not be impossible to scale old clusters that have anti affinity feature"},{"line_number":43,"context_line":"enabled. Format of heat template for anti affinity was changed in Juno and"},{"line_number":44,"context_line":"attempt to scale cluster created in Icehouse will lead to recreation of all"},{"line_number":45,"context_line":"instances involved into anti affinity."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_6e1ae06f","line":42,"updated":"2014-08-18 11:23:24.000000000","message":"\"not be impossible\" sounds bad :-)","commit_id":"1cf9c8f4eaa74da29d1466147052fedf301073a6"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"92195331046493616bb7ef2184fc97c1a8726940","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"1) Server group object will be created if anti affinity feature is enabled"},{"line_number":46,"context_line":"2) New implementation doesn\u0027t allow several affected instances on the same"},{"line_number":47,"context_line":"   host even if they don\u0027t have common processes."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Note, new implementation will be applied for new clusters only. Old"},{"line_number":50,"context_line":"implementation will be applied if user scales cluster created in Icehouse."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1abeadc6_0fc4c63e","line":47,"updated":"2014-08-27 00:38:38.000000000","message":"not sure what this means, is there some way to clarify?","commit_id":"62ede59493f49cd2c4771a05ae53359c47421350"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"7c146ba521befeeb0e83decceccfe39b81541a50","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"1) Server group object will be created if anti affinity feature is enabled"},{"line_number":46,"context_line":"2) New implementation doesn\u0027t allow several affected instances on the same"},{"line_number":47,"context_line":"   host even if they don\u0027t have common processes."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Note, new implementation will be applied for new clusters only. Old"},{"line_number":50,"context_line":"implementation will be applied if user scales cluster created in Icehouse."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1abeadc6_3d1eef0c","line":47,"in_reply_to":"1abeadc6_0fc4c63e","updated":"2014-08-27 19:54:17.000000000","message":"Done","commit_id":"62ede59493f49cd2c4771a05ae53359c47421350"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"73daa552684c915fdfcfe1efae48c93124aa7c83","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   host even if they don\u0027t have common processes. So, if anti affinity enabled"},{"line_number":48,"context_line":"   for \u0027datanode\u0027 and \u0027tasktracker\u0027 processes, previous implementation allowed"},{"line_number":49,"context_line":"   to have instance with \u0027datanode\u0027 process and other instance with"},{"line_number":50,"context_line":"   \u0027tasktracker\u0027 process on one hot. New implementation guarantees that"},{"line_number":51,"context_line":"   instances will be on different hosts."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Note, new implementation will be applied for new clusters only. Old"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1abeadc6_3d526f67","line":50,"updated":"2014-08-27 20:07:33.000000000","message":"misspell on host as hot","commit_id":"d0e98bfd2a704e92c91e9895ef9ac500dc4e1b25"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"2c627f56721d9136dffbafdc8182068691749f33","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   host even if they don\u0027t have common processes. So, if anti affinity enabled"},{"line_number":48,"context_line":"   for \u0027datanode\u0027 and \u0027tasktracker\u0027 processes, previous implementation allowed"},{"line_number":49,"context_line":"   to have instance with \u0027datanode\u0027 process and other instance with"},{"line_number":50,"context_line":"   \u0027tasktracker\u0027 process on one hot. New implementation guarantees that"},{"line_number":51,"context_line":"   instances will be on different hosts."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Note, new implementation will be applied for new clusters only. Old"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1abeadc6_5da72b50","line":50,"in_reply_to":"1abeadc6_3d526f67","updated":"2014-08-27 20:10:44.000000000","message":"Done","commit_id":"d0e98bfd2a704e92c91e9895ef9ac500dc4e1b25"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"910626e106722d422d5066863b5a98da050422d7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   host even if they don\u0027t have common processes. So, if anti affinity enabled"},{"line_number":48,"context_line":"   for \u0027datanode\u0027 and \u0027tasktracker\u0027 processes, previous implementation allowed"},{"line_number":49,"context_line":"   to have instance with \u0027datanode\u0027 process and other instance with"},{"line_number":50,"context_line":"   \u0027tasktracker\u0027 process on one hots. New implementation guarantees that"},{"line_number":51,"context_line":"   instances will be on different hosts."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Note, new implementation will be applied for new clusters only. Old"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1abeadc6_641954d0","line":50,"updated":"2014-08-29 18:57:08.000000000","message":"Typo, \"hots\" should be \"host\"","commit_id":"74adac2246749cdb7e9693dc695c7cfeab2838cf"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"d48620be6b192eca7d9cd9faff9f45e653f3ce99","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   host even if they don\u0027t have common processes. So, if anti affinity enabled"},{"line_number":48,"context_line":"   for \u0027datanode\u0027 and \u0027tasktracker\u0027 processes, previous implementation allowed"},{"line_number":49,"context_line":"   to have instance with \u0027datanode\u0027 process and other instance with"},{"line_number":50,"context_line":"   \u0027tasktracker\u0027 process on one hots. New implementation guarantees that"},{"line_number":51,"context_line":"   instances will be on different hosts."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Note, new implementation will be applied for new clusters only. Old"}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa98f980_c8862165","line":50,"in_reply_to":"1abeadc6_641954d0","updated":"2014-09-02 18:43:53.000000000","message":"Done","commit_id":"74adac2246749cdb7e9693dc695c7cfeab2838cf"}],"sahara/tests/unit/service/test_instances.py":[{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"e7be45f16b3c8f5a066bdb9bf4ac6de18a643aea","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        userdata \u003d _generate_user_data_script(cluster)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        self.nova.servers.create.assert_has_calls("},{"line_number":161,"context_line":"            [mock.call(\u0027test_cluster-test_group_1-001\u0027,"},{"line_number":162,"context_line":"                       \"initial\","},{"line_number":163,"context_line":"                       \"test_flavor\","},{"line_number":164,"context_line":"                       scheduler_hints\u003d{\u0027group\u0027: \"123\"},"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa98f980_eb46ca22","line":161,"updated":"2014-09-01 14:07:21.000000000","message":"We\u0027re keeping the old code, so, let\u0027s keep the old tests too.","commit_id":"74adac2246749cdb7e9693dc695c7cfeab2838cf"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"d48620be6b192eca7d9cd9faff9f45e653f3ce99","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        userdata \u003d _generate_user_data_script(cluster)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        self.nova.servers.create.assert_has_calls("},{"line_number":161,"context_line":"            [mock.call(\u0027test_cluster-test_group_1-001\u0027,"},{"line_number":162,"context_line":"                       \"initial\","},{"line_number":163,"context_line":"                       \"test_flavor\","},{"line_number":164,"context_line":"                       scheduler_hints\u003d{\u0027group\u0027: \"123\"},"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa98f980_090e6b34","line":161,"in_reply_to":"fa98f980_eb46ca22","updated":"2014-09-02 18:43:53.000000000","message":"We are keeping old code for scaling only. It is hard to change test to have \"old\" create and \"new\" scaling. I think backward compatibility should be tested only manually.","commit_id":"74adac2246749cdb7e9693dc695c7cfeab2838cf"}],"sahara/tests/unit/utils/test_heat.py":[{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"e7be45f16b3c8f5a066bdb9bf4ac6de18a643aea","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        userdata \u003d \"line1\\nline2\""},{"line_number":46,"context_line":"        self.assertEqual(h._prepare_userdata(userdata), \u0027\"line1\",\\n\"line2\"\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_get_anti_affinity_scheduler_hints(self):"},{"line_number":49,"context_line":"        inst_names \u003d [\u0027i1\u0027, \u0027i2\u0027]"},{"line_number":50,"context_line":"        expected \u003d (\u0027\"scheduler_hints\" : {\"different_host\": \u0027"},{"line_number":51,"context_line":"                    \u0027[{\"Ref\": \"i1\"}, {\"Ref\": \"i2\"}]},\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa98f980_2b48d22c","side":"PARENT","line":48,"updated":"2014-09-01 14:07:21.000000000","message":"ditto","commit_id":"708cb8a2a78c7b01a858007d6a8f03c505b2c22b"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"d48620be6b192eca7d9cd9faff9f45e653f3ce99","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        userdata \u003d \"line1\\nline2\""},{"line_number":46,"context_line":"        self.assertEqual(h._prepare_userdata(userdata), \u0027\"line1\",\\n\"line2\"\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_get_anti_affinity_scheduler_hints(self):"},{"line_number":49,"context_line":"        inst_names \u003d [\u0027i1\u0027, \u0027i2\u0027]"},{"line_number":50,"context_line":"        expected \u003d (\u0027\"scheduler_hints\" : {\"different_host\": \u0027"},{"line_number":51,"context_line":"                    \u0027[{\"Ref\": \"i1\"}, {\"Ref\": \"i2\"}]},\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa98f980_28fa4dbd","side":"PARENT","line":48,"in_reply_to":"fa98f980_2b48d22c","updated":"2014-09-02 18:43:53.000000000","message":"We don\u0027t have old code for heat engine","commit_id":"708cb8a2a78c7b01a858007d6a8f03c505b2c22b"}],"sahara/utils/general.py":[{"author":{"_account_id":7125,"name":"Alexander Ignatov","email":"aignatov@mirantis.com","username":"aignatov"},"change_message_id":"9bf6b16379d915e906e0835bebac0bec2eaec56e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    return (\"%s-%s-%03d\" % (cluster_name, node_group_name, index)).lower()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"def generate_aa_group_name(cluster_name):"},{"line_number":130,"context_line":"    return (\"%s-aa-group\" % cluster_name).lower()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_5f680688","line":129,"updated":"2014-08-08 07:57:59.000000000","message":"As I see this method is used only for heat engine and only inside heat.py so consider to move it to heat.py","commit_id":"229c95350af61451b79d68eaf90fc62feeeb2c13"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"e3ab75ea64324793194da194b6254d68ce493342","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    return (\"%s-%s-%03d\" % (cluster_name, node_group_name, index)).lower()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"def generate_aa_group_name(cluster_name):"},{"line_number":130,"context_line":"    return (\"%s-aa-group\" % cluster_name).lower()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_9e4e128f","line":129,"in_reply_to":"baada198_5f680688","updated":"2014-08-08 14:55:24.000000000","message":"I think it is right make aa behavior same for heat and direct engines.  This is the first step.","commit_id":"229c95350af61451b79d68eaf90fc62feeeb2c13"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"b55ef03e0cb931f30dfcef050b95e977e395f5eb","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    return (\"%s-%s-%03d\" % (cluster_name, node_group_name, index)).lower()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"def generate_aa_group_name(cluster_name):"},{"line_number":130,"context_line":"    return (\"%s-aa-group\" % cluster_name).lower()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_4bf2ec05","line":129,"in_reply_to":"baada198_9e4e128f","updated":"2014-08-08 22:59:47.000000000","message":"Done","commit_id":"229c95350af61451b79d68eaf90fc62feeeb2c13"}],"sahara/utils/openstack/heat.py":[{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"c5e68d1279724d3e6d7c041cc4442e3f320d8869","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def _serialize_resources(self):"},{"line_number":151,"context_line":"        resources \u003d []"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if self.cluster.anti_affinity:"},{"line_number":154,"context_line":"            resources.extend(self._serialize_aa_server_group())"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        for ng in self.cluster.node_groups:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_4d0ad678","line":153,"updated":"2014-08-11 15:37:06.000000000","message":"Why do you make different checks for the same thing?\n\n *  if self.cluster.anti_affinity:\n *  if _need_aa_server_group(..):","commit_id":"5666b22a4a168b1abcfc72f59b9932dbeba0eea9"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"48fe925fdcc5bb169e70fd519ae82b7aa6dc3b71","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def _serialize_resources(self):"},{"line_number":151,"context_line":"        resources \u003d []"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if self.cluster.anti_affinity:"},{"line_number":154,"context_line":"            resources.extend(self._serialize_aa_server_group())"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        for ng in self.cluster.node_groups:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_668097f6","line":153,"in_reply_to":"baada198_4d0ad678","updated":"2014-08-11 16:34:51.000000000","message":"self.cluster.anti_affinity says that there is at least one aa instruction and we need to serialize group. _need_aa_server_group makes check for specific node group.","commit_id":"5666b22a4a168b1abcfc72f59b9932dbeba0eea9"}]}
