)]}'
{"sahara/plugins/storm/plugin.py":[{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"86372aa8ce9501a659977c69e0f1e4988140dd72","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                     sm_instance.hostname())"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def _start_slave_processes(self, sl_instances):"},{"line_number":146,"context_line":"        cpo.add_provisioning_step("},{"line_number":147,"context_line":"            g.get_cluster_id(sl_instances[0]),"},{"line_number":148,"context_line":"            utils.start_process_info(\"Slave\"), len(sl_instances))"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e352e5dc","line":146,"updated":"2015-02-04 21:15:30.000000000","message":"I think we shouldn\u0027t reference sl_instances[0] without testing for an empty list first, just on general principles.","commit_id":"37fd789c2737824384ce5b23b9508e5c126a4a99"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"86372aa8ce9501a659977c69e0f1e4988140dd72","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            run.start_storm_supervisor(r)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _start_zookeeper_processes(self, zk_instances):"},{"line_number":161,"context_line":"        cpo.add_provisioning_step("},{"line_number":162,"context_line":"            g.get_cluster_id(zk_instances[0]),"},{"line_number":163,"context_line":"            utils.start_process_info(\"Zookeeper\"), len(zk_instances))"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_23607da4","line":161,"updated":"2015-02-04 21:15:30.000000000","message":"ditto","commit_id":"37fd789c2737824384ce5b23b9508e5c126a4a99"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"1f493bff9da458f8c273885107dfbc27fb00f845","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _start_slave_processes(self, sl_instances):"},{"line_number":144,"context_line":"        if not sl_instances:"},{"line_number":145,"context_line":"            return"},{"line_number":146,"context_line":"        cpo.add_provisioning_step("},{"line_number":147,"context_line":"            g.get_cluster_id(sl_instances[0]),"},{"line_number":148,"context_line":"            utils.start_process_info(\"Slave\"), len(sl_instances))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_9de5b30c","line":145,"updated":"2015-02-06 18:45:42.000000000","message":"if the intent is to check for zero length lists then i think we should check like:\n\n    if len(sl_instances) is 0:\n\njust to ensure that if a None value gets through we catch the error","commit_id":"e29ef7265603359b68775810d72e124f38e2870a"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"9145e7773772e0456c83ad8301061b25a5310c7b","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _start_slave_processes(self, sl_instances):"},{"line_number":144,"context_line":"        if not sl_instances:"},{"line_number":145,"context_line":"            return"},{"line_number":146,"context_line":"        cpo.add_provisioning_step("},{"line_number":147,"context_line":"            g.get_cluster_id(sl_instances[0]),"},{"line_number":148,"context_line":"            utils.start_process_info(\"Slave\"), len(sl_instances))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_06e6cb44","line":145,"in_reply_to":"da86d52c_5d341b4a","updated":"2015-02-06 22:47:09.000000000","message":"i thought if sl_instances is None that would be an error and we would want to catch it. maybe i\u0027m mistaken, is it possible to get a valid None value for sl_instances?","commit_id":"e29ef7265603359b68775810d72e124f38e2870a"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"8be02a2999c24cd40ef5ac07cc2803ad56c8a0e4","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _start_slave_processes(self, sl_instances):"},{"line_number":144,"context_line":"        if not sl_instances:"},{"line_number":145,"context_line":"            return"},{"line_number":146,"context_line":"        cpo.add_provisioning_step("},{"line_number":147,"context_line":"            g.get_cluster_id(sl_instances[0]),"},{"line_number":148,"context_line":"            utils.start_process_info(\"Slave\"), len(sl_instances))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_5d341b4a","line":145,"in_reply_to":"da86d52c_9de5b30c","updated":"2015-02-06 18:53:37.000000000","message":"If sl_instances is None, we will call return as well. Or expected is exception?","commit_id":"e29ef7265603359b68775810d72e124f38e2870a"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"1f493bff9da458f8c273885107dfbc27fb00f845","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _start_zookeeper_processes(self, zk_instances):"},{"line_number":161,"context_line":"        if not zk_instances:"},{"line_number":162,"context_line":"            return"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        cpo.add_provisioning_step("},{"line_number":165,"context_line":"            g.get_cluster_id(zk_instances[0]),"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_fdeceff5","line":162,"updated":"2015-02-06 18:45:42.000000000","message":"similar as above","commit_id":"e29ef7265603359b68775810d72e124f38e2870a"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"8b203d6743f112f227b351c431adb4aa319a4c81","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                     sm_instance.hostname())"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def _start_slave_processes(self, sl_instances):"},{"line_number":145,"context_line":"        if len(sl_instances) is 0:"},{"line_number":146,"context_line":"            return"},{"line_number":147,"context_line":"        cpo.add_provisioning_step("},{"line_number":148,"context_line":"            g.get_cluster_id(sl_instances[0]),"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_3f7a6477","line":145,"range":{"start_line":145,"start_character":29,"end_line":145,"end_character":31},"updated":"2015-02-11 13:07:13.000000000","message":"should use \u003d\u003d instead \u0027is\u0027.","commit_id":"a06b43c75d994d0c1fc2b990f09f98a47d81c7ea"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"8b203d6743f112f227b351c431adb4aa319a4c81","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            run.start_storm_supervisor(r)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def _start_zookeeper_processes(self, zk_instances):"},{"line_number":162,"context_line":"        if len(zk_instances) is 0:"},{"line_number":163,"context_line":"            return"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        cpo.add_provisioning_step("}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_1ff040fd","line":162,"updated":"2015-02-11 13:07:13.000000000","message":"ditto","commit_id":"a06b43c75d994d0c1fc2b990f09f98a47d81c7ea"}]}
