)]}'
{"sahara/tests/integration/tests/check_services.py":[{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"ec57992910aa106f70fae83c521e4f1a2119f756","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                script_command \u003d (\u0027./script.sh %s\u0027 % (parameters))"},{"line_number":90,"context_line":"                self.execute_command(script_command)"},{"line_number":91,"context_line":"            else:"},{"line_number":92,"context_line":"                self.execute_command(\u0027./script.sh\u0027)"},{"line_number":93,"context_line":"        except Exception as e:"},{"line_number":94,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":95,"context_line":"                print(six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_59da4b79","line":92,"updated":"2015-02-20 18:35:51.000000000","message":"just an fyi, completely a matter of style but you can use a trick with \u0027\u0027 to combine this:\n\nscript_command \u003d \u0027.script.sh%s\u0027 % \u0027 \u0027.join([\u0027\u0027]+script_parameters)\n\nself.execute_comand(script_command)\n\nThe extra \u0027\u0027 in the list will cause it to add no extra spaces if script_parameters \u003d\u003d [] but another leading space if there is one parameter.\n\nToo subtle? :)\n\n(but it would fail if someone passed None for script_parameters. But they shouldn\u0027t :) )","commit_id":"6f26da14af1f1ff6e350118f9bd4b4fa25c83fa3"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"398cc8ec1d4286c50c405c6c83222ea858ea50b3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                script_command \u003d (\u0027./script.sh %s\u0027 % (parameters))"},{"line_number":90,"context_line":"                self.execute_command(script_command)"},{"line_number":91,"context_line":"            else:"},{"line_number":92,"context_line":"                self.execute_command(\u0027./script.sh\u0027)"},{"line_number":93,"context_line":"        except Exception as e:"},{"line_number":94,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":95,"context_line":"                print(six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_f9269f67","line":92,"in_reply_to":"ba7be1f8_59da4b79","updated":"2015-02-20 18:37:10.000000000","message":"\"if there is at least one\" I meant to say","commit_id":"6f26da14af1f1ff6e350118f9bd4b4fa25c83fa3"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"77ba81e7af271ea2d35fc30c5c30307d2c34b4b4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                for conf_file in conf_files:"},{"line_number":86,"context_line":"                    self.transfer_helper_conf_file_to_node(conf_file)"},{"line_number":87,"context_line":"            if script_parameters:"},{"line_number":88,"context_line":"                parameters \u003d \u0027  \u0027.join(script_parameters)"},{"line_number":89,"context_line":"                script_command \u003d (\u0027./script.sh %s\u0027 % (parameters))"},{"line_number":90,"context_line":"                self.execute_command(script_command)"},{"line_number":91,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_228e0dd1","line":88,"updated":"2015-03-02 05:50:35.000000000","message":"+1","commit_id":"e54986462e96acb8bff16a3a548c09086180171e"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"773f594566b96ec497433cb28bf3d1b4135a344e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                for conf_file in conf_files:"},{"line_number":86,"context_line":"                    self.transfer_helper_conf_file_to_node(conf_file)"},{"line_number":87,"context_line":"            if script_parameters:"},{"line_number":88,"context_line":"                parameters \u003d \u0027  \u0027.join(script_parameters)"},{"line_number":89,"context_line":"                script_command \u003d (\u0027./script.sh %s\u0027 % (parameters))"},{"line_number":90,"context_line":"                self.execute_command(script_command)"},{"line_number":91,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_bdaf7ee2","line":88,"updated":"2015-02-23 17:00:00.000000000","message":"should this be a single space in the string for the join?","commit_id":"e54986462e96acb8bff16a3a548c09086180171e"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"3a4fcc43fac3922f422ec88ce3b4c2d1c7c559a5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                for conf_file in conf_files:"},{"line_number":86,"context_line":"                    self.transfer_helper_conf_file_to_node(conf_file)"},{"line_number":87,"context_line":"            if script_parameters:"},{"line_number":88,"context_line":"                parameters \u003d \u0027  \u0027.join(script_parameters)"},{"line_number":89,"context_line":"                script_command \u003d (\u0027./script.sh %s\u0027 % (parameters))"},{"line_number":90,"context_line":"                self.execute_command(script_command)"},{"line_number":91,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_e97daee8","line":88,"in_reply_to":"ba7be1f8_00a3bab2","updated":"2015-02-23 23:22:55.000000000","message":"yea, shouldn\u0027t break anything. more a nit","commit_id":"e54986462e96acb8bff16a3a548c09086180171e"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"923a2fbcf3a0622425efb44dc9f33c9dcacfb689","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                for conf_file in conf_files:"},{"line_number":86,"context_line":"                    self.transfer_helper_conf_file_to_node(conf_file)"},{"line_number":87,"context_line":"            if script_parameters:"},{"line_number":88,"context_line":"                parameters \u003d \u0027  \u0027.join(script_parameters)"},{"line_number":89,"context_line":"                script_command \u003d (\u0027./script.sh %s\u0027 % (parameters))"},{"line_number":90,"context_line":"                self.execute_command(script_command)"},{"line_number":91,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_00a3bab2","line":88,"in_reply_to":"ba7be1f8_bdaf7ee2","updated":"2015-02-23 20:51:46.000000000","message":"good eyes, Mike :) I think you\u0027re right (although it shouldn\u0027t break)","commit_id":"e54986462e96acb8bff16a3a548c09086180171e"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"547dbfef8fe24decef981d231f8aac3d60495400","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                    self.transfer_helper_conf_file_to_node(conf_file)"},{"line_number":87,"context_line":"            if script_parameters:"},{"line_number":88,"context_line":"                parameters \u003d \u0027  \u0027.join(script_parameters)"},{"line_number":89,"context_line":"                script_command \u003d (\u0027./script.sh %s\u0027 % (parameters))"},{"line_number":90,"context_line":"                self.execute_command(script_command)"},{"line_number":91,"context_line":"            else:"},{"line_number":92,"context_line":"                self.execute_command(\u0027./script.sh\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_3d2652b8","line":89,"range":{"start_line":89,"start_character":65,"end_line":89,"end_character":66},"updated":"2015-02-21 10:01:22.000000000","message":"why brackets are required? why we can\u0027t write: \u0027./script.sh %s\u0027 % parameters ?","commit_id":"e54986462e96acb8bff16a3a548c09086180171e"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"9c654ce696de9974f7aaa12b79bb8a36422b9a69","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                    self.transfer_helper_conf_file_to_node(conf_file)"},{"line_number":87,"context_line":"            if script_parameters:"},{"line_number":88,"context_line":"                parameters \u003d \u0027  \u0027.join(script_parameters)"},{"line_number":89,"context_line":"                script_command \u003d (\u0027./script.sh %s\u0027 % (parameters))"},{"line_number":90,"context_line":"                self.execute_command(script_command)"},{"line_number":91,"context_line":"            else:"},{"line_number":92,"context_line":"                self.execute_command(\u0027./script.sh\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_c9cabc4e","line":89,"in_reply_to":"ba7be1f8_3d2652b8","updated":"2015-02-23 15:41:19.000000000","message":"+1, probably a cut and paste during coding, maybe from a line-too-long","commit_id":"e54986462e96acb8bff16a3a548c09086180171e"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"77ba81e7af271ea2d35fc30c5c30307d2c34b4b4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            if script_parameters:"},{"line_number":88,"context_line":"                parameters \u003d \u0027  \u0027.join(script_parameters)"},{"line_number":89,"context_line":"                script_command \u003d (\u0027./script.sh %s\u0027 % (parameters))"},{"line_number":90,"context_line":"                self.execute_command(script_command)"},{"line_number":91,"context_line":"            else:"},{"line_number":92,"context_line":"                self.execute_command(\u0027./script.sh\u0027)"},{"line_number":93,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_294438b6","line":90,"updated":"2015-03-02 05:50:35.000000000","message":"Seems this is designed to be a common function. What if there are several commands to be executed, like in check_hbase_availability? Does this helper function apply to that? I think it needs some change in this parameter.","commit_id":"e54986462e96acb8bff16a3a548c09086180171e"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"048a2242fc17d67f91a7b8db634d60b0260b6df1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            if script_parameters:"},{"line_number":88,"context_line":"                parameters \u003d \u0027  \u0027.join(script_parameters)"},{"line_number":89,"context_line":"                script_command \u003d (\u0027./script.sh %s\u0027 % (parameters))"},{"line_number":90,"context_line":"                self.execute_command(script_command)"},{"line_number":91,"context_line":"            else:"},{"line_number":92,"context_line":"                self.execute_command(\u0027./script.sh\u0027)"},{"line_number":93,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_e937274b","line":90,"in_reply_to":"ba7be1f8_294438b6","updated":"2015-03-03 16:36:47.000000000","message":"This was a simple refactor for a collection of common test functions that shared the same basic format.  It wasn\u0027t intended to handle the odd case where there are multiple commands.","commit_id":"e54986462e96acb8bff16a3a548c09086180171e"}],"sahara/tests/integration/tests/resources/solr_service_test.sh":[{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"c83111e4fca371fae58aaa7476a0dc3faeac0a33","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -x"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"check_solr_availability(){"},{"line_number":5,"context_line":"    solrctl instancedir --generate $HOME/solr_configs"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da86d52c_491c8b13","line":2,"updated":"2015-02-19 14:06:54.000000000","message":"please add \u0027set -e\u0027 for check error codes","commit_id":"1ad6f49cd5a696da6f53e6b6e711cb129a7b689a"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"c83111e4fca371fae58aaa7476a0dc3faeac0a33","unresolved":false,"context_lines":[{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"check_solr_availability"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"da86d52c_a9d42720","line":25,"updated":"2015-02-19 14:06:54.000000000","message":"need to remove empty line","commit_id":"1ad6f49cd5a696da6f53e6b6e711cb129a7b689a"}]}