)]}'
{"sahara/api/v10.py":[{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"e2d9d13658f35b43f0ed35c1ac92ed567236472d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"@acl.enforce(\"clusters:get\")"},{"line_number":62,"context_line":"@v.check_exists(api.get_cluster, \u0027cluster_id\u0027)"},{"line_number":63,"context_line":"def clusters_get(cluster_id):"},{"line_number":64,"context_line":"    data \u003d u.get_request_args()"},{"line_number":65,"context_line":"    if data.get(\u0027progress\u0027, False):"},{"line_number":66,"context_line":"        return u.render(api.get_cluster(cluster_id, True).to_wrapped_dict())"},{"line_number":67,"context_line":"    return u.render(api.get_cluster(cluster_id).to_wrapped_dict())"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_c9009104","line":64,"updated":"2015-02-25 16:30:19.000000000","message":"I think something is wrong with the endpoint description or processing here.\n\nIf the new endpoint is supposed to be /clusters/\u003ccluster_id\u003e/progress (as described in the spec) then it needs a new method with a new @rest.get() decorator\n@rest.get(\u0027/clusters/\u003ccluster_id\u003e/progress\u0027) otherwise the REST call won\u0027t map to this method.\n\nIf we are using u.get_request_args() here that suggests that we intend\n\n/clusters/\u003ccluster_id\u003e?progress\u003dtrue\n\nIn that case, note that the value returned from u.get_request_args() will have \"true\" as a string, not a boolean.  The test here will work if progress is anything that evaluates to True (non-empty string), even ?progress\u003dfalse I believe which would be strange :)\n\nI have a similar test in a WIP that uses data.get(\u0027key\u0027, False) in [\u0027true\u0027, \u0027True\u0027]  (maybe there is something better)","commit_id":"6561dfa1f7448e97cecd43e76a8cc64b6a8cf250"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"241d28b2cbe12a7a2cd012cdc4633e78a78309bd","unresolved":false,"context_lines":[{"line_number":61,"context_line":"@acl.enforce(\"clusters:get\")"},{"line_number":62,"context_line":"@v.check_exists(api.get_cluster, \u0027cluster_id\u0027)"},{"line_number":63,"context_line":"def clusters_get(cluster_id):"},{"line_number":64,"context_line":"    data \u003d u.get_request_args()"},{"line_number":65,"context_line":"    if data.get(\u0027progress\u0027, False):"},{"line_number":66,"context_line":"        return u.render(api.get_cluster(cluster_id, True).to_wrapped_dict())"},{"line_number":67,"context_line":"    return u.render(api.get_cluster(cluster_id).to_wrapped_dict())"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_b0055c12","line":64,"in_reply_to":"ba7be1f8_c9009104","updated":"2015-02-26 08:57:10.000000000","message":"Agreed with Trevor and Nikita","commit_id":"6561dfa1f7448e97cecd43e76a8cc64b6a8cf250"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"90858828753417bd518c5087786b2ebbdfc7707f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"@v.check_exists(api.get_cluster, \u0027cluster_id\u0027)"},{"line_number":63,"context_line":"def clusters_get(cluster_id):"},{"line_number":64,"context_line":"    data \u003d u.get_request_args()"},{"line_number":65,"context_line":"    if data.get(\u0027progress\u0027, False):"},{"line_number":66,"context_line":"        return u.render(api.get_cluster(cluster_id, True).to_wrapped_dict())"},{"line_number":67,"context_line":"    return u.render(api.get_cluster(cluster_id).to_wrapped_dict())"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_929de30c","line":65,"updated":"2015-02-25 15:24:36.000000000","message":"I\u0027d rather rename the parameter \u0027progress\u0027 -\u003e \u0027show_events\u0027\n\nThe code can be simplified:\nshow_events \u003d data.get(\u0027show_events\u0027, False)\nreturn u.render(api.get_cluster(cluster_id, show_events).to_wrapped_dict())","commit_id":"6561dfa1f7448e97cecd43e76a8cc64b6a8cf250"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"e6bdf59aea0c5364a4545180cbc4a10af57779a3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"@v.check_exists(api.get_cluster, \u0027cluster_id\u0027)"},{"line_number":63,"context_line":"def clusters_get(cluster_id):"},{"line_number":64,"context_line":"    data \u003d u.get_request_args()"},{"line_number":65,"context_line":"    if data.get(\u0027progress\u0027, False):"},{"line_number":66,"context_line":"        return u.render(api.get_cluster(cluster_id, True).to_wrapped_dict())"},{"line_number":67,"context_line":"    return u.render(api.get_cluster(cluster_id).to_wrapped_dict())"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_47572502","line":65,"in_reply_to":"ba7be1f8_929de30c","updated":"2015-02-25 17:43:44.000000000","message":"+1","commit_id":"6561dfa1f7448e97cecd43e76a8cc64b6a8cf250"}],"sahara/conductor/api.py":[{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"90858828753417bd518c5087786b2ebbdfc7707f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        return self._manager.cluster_get(context, _get_id(cluster))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @r.wrap(r.ClusterResource)"},{"line_number":70,"context_line":"    def cluster_get_with_events(self, context, cluster):"},{"line_number":71,"context_line":"        \"\"\"Return the cluster with events or None if it does not exist.\"\"\""},{"line_number":72,"context_line":"        return self._manager.cluster_get_with_events(context, cluster)"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_f2753fcb","line":70,"updated":"2015-02-25 15:24:36.000000000","message":"Why do you need a separate method for this, you can save the flag to the context.","commit_id":"6561dfa1f7448e97cecd43e76a8cc64b6a8cf250"}],"sahara/context.py":[{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"5f3088d5f05aa00850cc8cba0f4b3cbe6b26e28e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            self.auth_uri,"},{"line_number":92,"context_line":"            self.resource_uuid,"},{"line_number":93,"context_line":"            self.current_instance_info,"},{"line_number":94,"context_line":"            self.show_progress,"},{"line_number":95,"context_line":"            overwrite\u003dFalse)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def to_dict(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_144d2ec4","line":94,"updated":"2015-02-26 14:40:29.000000000","message":"I disagree with this.  Everything else I see here is general, across general\nrequests -- user, tenant, roles, auth_uri, is_admin, etc.\n\nShow progress is for one specific type of request on one specific object -- it\nis not general at all.  I think it sets a bad precedent, to handle individual\nrequests by injecting a flag into context to avoid passing parameters.","commit_id":"6aa1b82e742a5e6a883ea3a12c48346900a5c82e"}],"sahara/db/api.py":[{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"75f820236db801fbc4dcf43f40b5af6a96335415","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    cluster \u003d IMPL.cluster_get(context, cluster)"},{"line_number":114,"context_line":"    if cluster:"},{"line_number":115,"context_line":"        return cluster.to_dict(context.show_progress)"},{"line_number":116,"context_line":"    else:"},{"line_number":117,"context_line":"        return None"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_d48b96c0","line":116,"updated":"2015-02-26 14:41:53.000000000","message":"return None will be the default, so it\u0027s not needed at all, but being explicit\nis okay if you want to be.\n\nHowever, \"else\" should at least be removed even if return None is there,\nand remove indent","commit_id":"6aa1b82e742a5e6a883ea3a12c48346900a5c82e"}],"sahara/db/sqlalchemy/models.py":[{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"90858828753417bd518c5087786b2ebbdfc7707f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cluster_template \u003d relationship(\u0027ClusterTemplate\u0027,"},{"line_number":79,"context_line":"                                    backref\u003d\"clusters\", lazy\u003d\u0027joined\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def to_dict(self, push_events\u003dFalse):"},{"line_number":82,"context_line":"        d \u003d super(Cluster, self).to_dict()"},{"line_number":83,"context_line":"        d[\u0027node_groups\u0027] \u003d [ng.to_dict() for ng in self.node_groups]"},{"line_number":84,"context_line":"        d[\u0027provision_progress\u0027] \u003d [pp.to_dict(push_events) for pp in"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_f2237fba","line":81,"updated":"2015-02-25 15:24:36.000000000","message":"push_events -\u003e show_events","commit_id":"6561dfa1f7448e97cecd43e76a8cc64b6a8cf250"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"90858828753417bd518c5087786b2ebbdfc7707f","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        if push_events:"},{"line_number":427,"context_line":"            d[\u0027events\u0027] \u003d [event.to_dict() for event in self.events]"},{"line_number":428,"context_line":"        else:"},{"line_number":429,"context_line":"            d[\u0027events\u0027] \u003d []"},{"line_number":430,"context_line":"        return d"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_12049316","line":429,"updated":"2015-02-25 15:24:36.000000000","message":"In this case it\u0027s better not even add \u0027events\u0027 to the dict. The empty list looks confusing.","commit_id":"6561dfa1f7448e97cecd43e76a8cc64b6a8cf250"}],"sahara/service/api.py":[{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"90858828753417bd518c5087786b2ebbdfc7707f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    return conductor.cluster_get_all(context.ctx(), **kwargs)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def get_cluster(id, push_events\u003dFalse):"},{"line_number":53,"context_line":"    if push_events:"},{"line_number":54,"context_line":"        return conductor.cluster_get_with_events(context.ctx(), id)"},{"line_number":55,"context_line":"    return conductor.cluster_get(context.ctx(), id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_603dfac3","line":52,"updated":"2015-02-25 15:24:36.000000000","message":"Here is the place to save a flag to the context","commit_id":"6561dfa1f7448e97cecd43e76a8cc64b6a8cf250"}]}
