)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"8f2120741b32010b544b0c382b6bf0a30ebadc8e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed wrong value for total during step creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we attach volumes, it\u0027s also required mount it to instances."},{"line_number":10,"context_line":"Closes-bug: #1426450"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I311ad7bd6e6cfad46a95f4659103162880c9d74b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_c5454616","line":9,"updated":"2015-03-01 04:20:26.000000000","message":"required -\u003e required to","commit_id":"52455b2412c25702907e6243f6cad2fe97db35d7"}],"sahara/service/volumes.py":[{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"ec68d10025a255c740be21f012484245e2733a90","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    cpo.add_provisioning_step("},{"line_number":65,"context_line":"        instances[0].cluster_id, _(\"Attach and mount volumes to instances\"),"},{"line_number":66,"context_line":"        instances_to_attach + _count_volumes_to_mount(instances))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    with context.ThreadGroup() as tg:"},{"line_number":69,"context_line":"        for instance in instances:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_08b4d533","line":66,"updated":"2015-03-01 07:29:04.000000000","message":"looks wrong. example: 2 instances with 5 volumes. Metric looks like:\n    Attach and mount volumes to instances: 3 / 12\n\nWhat does 3 and 12?","commit_id":"52455b2412c25702907e6243f6cad2fe97db35d7"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"a0c4d43b881ef5740ec4b71f785dff224fe4a6f4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                    \u0027attach-volumes-for-instance-%s\u0027 % instance.instance_name,"},{"line_number":73,"context_line":"                    _attach_volumes_to_node, instance.node_group, instance)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    mount_to_instances(instances)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def _await_attach_volumes(instance, devices):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_63efcb87","line":75,"updated":"2015-03-03 19:24:19.000000000","message":"In case of direct engine you have added extra \"nova.client().volumes.get_server_volumes\" call for each instance. What was the reasoning for that?","commit_id":"16c8fda7f2446d6b7766e63facecd49d9f911b19"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"e51a2895e599b55813ef995069482290a9e0d8e5","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    _await_attach_volumes(instance, devices)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    for idx in range(0, instance.node_group.volumes_per_node):"},{"line_number":108,"context_line":"        LOG.debug(\"Mounting volume {volume} to instance {instance}\""},{"line_number":109,"context_line":"                  .format(volume\u003ddevice, instance\u003dinstance.instance_name))"},{"line_number":110,"context_line":"        mount_point \u003d instance.node_group.storage_paths()[idx]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_ce7d57b3","line":107,"updated":"2015-03-05 19:32:39.000000000","message":"a couple of questions, since I\u0027m not too familiar with the volume code.\n\n#1) Can the result of storage_paths() be cached once for the node_group? unless node_group.volumes_per_node or node_group.volume_mount_prefix is changing, it looks to me like it can be called just once.\n\n#2) storage_paths() loops over range(1, self.volumes_per_node + 1). but here we are looping over range(0, instance.node_group.volumes_per_node). Is that okay?  Looks like maybe naming of mount points is the reason in storage_paths() and it doesn\u0027t matter.","commit_id":"f8faf49c17a52a9b6422acef9d4d0dfc7e43350c"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"6a9817d4b7588e8ab2bc5ea43f32935d2b7a4505","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    _await_attach_volumes(instance, devices)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    for idx in range(0, instance.node_group.volumes_per_node):"},{"line_number":108,"context_line":"        LOG.debug(\"Mounting volume {volume} to instance {instance}\""},{"line_number":109,"context_line":"                  .format(volume\u003ddevice, instance\u003dinstance.instance_name))"},{"line_number":110,"context_line":"        mount_point \u003d instance.node_group.storage_paths()[idx]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_9147001d","line":107,"in_reply_to":"9a80dd14_ce7d57b3","updated":"2015-03-05 19:42:01.000000000","message":"Trevor, I\u0027ve just copied this part of code from _mount_volume_to_node. I\u0027ve also not too familiar with volume code. I would try to determine is it possible to call storage_paths() only once","commit_id":"f8faf49c17a52a9b6422acef9d4d0dfc7e43350c"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"11ef5edd48982e6535cef782ea2c644af60bca06","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    return result"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def _count_volumes_to_mount(instances):"},{"line_number":56,"context_line":"    return sum([inst.node_group.volumes_per_node for inst in instances])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_760bcb7c","line":55,"updated":"2015-03-10 11:41:27.000000000","message":"not sure it should be done in this patch. looks like a different thing.","commit_id":"318b4f263f2aa1c9ebaf680e4b2b9ca2c5a9dd83"}]}
