)]}'
{"sahara/plugins/hdp/configprovider.py":[{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"5ab3532b7ddc74bdef4c94428159adb8b132a250","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"WAIT_FOR_HOST_REGISTRATIONS_TIMEOUT \u003d p.Config("},{"line_number":22,"context_line":"    \u0027Wait for host registrations timeout\u0027, \u0027general\u0027,"},{"line_number":23,"context_line":"    \u0027cluster\u0027, config_type\u003d\u0027int\u0027, priority\u003d1,"},{"line_number":24,"context_line":"    default_value\u003d3600, is_optional\u003dTrue,"},{"line_number":25,"context_line":"    description\u003d\u0027Timeout for waiting for host registrations operation, in \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_c000b603","line":22,"updated":"2015-03-06 01:12:41.000000000","message":"this could be changed to\n\n    Host registrations timeout\n\nbut i think it would mean changing the variable name as well.","commit_id":"59ccad55a5d6dbed1aa10f73f01ee5d9ba38fbfe"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"d86792a7e05a1d7f4284c2c07aaf4d9b0b9f2e5c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"WAIT_FOR_HOST_REGISTRATIONS_TIMEOUT \u003d p.Config("},{"line_number":22,"context_line":"    \u0027Wait for host registrations timeout\u0027, \u0027general\u0027,"},{"line_number":23,"context_line":"    \u0027cluster\u0027, config_type\u003d\u0027int\u0027, priority\u003d1,"},{"line_number":24,"context_line":"    default_value\u003d3600, is_optional\u003dTrue,"},{"line_number":25,"context_line":"    description\u003d\u0027Timeout for waiting for host registrations operation, in \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_46676ce9","line":22,"in_reply_to":"9a80dd14_c000b603","updated":"2015-03-06 11:25:15.000000000","message":"+1 for that","commit_id":"59ccad55a5d6dbed1aa10f73f01ee5d9ba38fbfe"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"5ab3532b7ddc74bdef4c94428159adb8b132a250","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \u0027cluster\u0027, config_type\u003d\u0027int\u0027, priority\u003d1,"},{"line_number":24,"context_line":"    default_value\u003d3600, is_optional\u003dTrue,"},{"line_number":25,"context_line":"    description\u003d\u0027Timeout for waiting for host registrations operation, in \u0027"},{"line_number":26,"context_line":"                \u0027seconds\u0027)"},{"line_number":27,"context_line":"DECOMMISSIONING_TIMEOUT \u003d p.Config("},{"line_number":28,"context_line":"    \u0027Timeout for waiting for decommissioning nodes\u0027, \u0027general\u0027,"},{"line_number":29,"context_line":"    \u0027cluster\u0027, config_type\u003d\u0027int\u0027, priority\u003d1,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_7de6d1b5","line":26,"updated":"2015-03-06 01:12:41.000000000","message":"then this would be:\n\n    Timeout for host registrations in seconds","commit_id":"59ccad55a5d6dbed1aa10f73f01ee5d9ba38fbfe"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"5ab3532b7ddc74bdef4c94428159adb8b132a250","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    description\u003d\u0027Timeout for waiting for host registrations operation, in \u0027"},{"line_number":26,"context_line":"                \u0027seconds\u0027)"},{"line_number":27,"context_line":"DECOMMISSIONING_TIMEOUT \u003d p.Config("},{"line_number":28,"context_line":"    \u0027Timeout for waiting for decommissioning nodes\u0027, \u0027general\u0027,"},{"line_number":29,"context_line":"    \u0027cluster\u0027, config_type\u003d\u0027int\u0027, priority\u003d1,"},{"line_number":30,"context_line":"    default_value\u003d1000, is_optional\u003dTrue,"},{"line_number":31,"context_line":"    description\u003d\u0027Timeout for waiting for decommissioning nodes, in \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_fd3c81e4","line":28,"updated":"2015-03-06 01:12:41.000000000","message":"i think should be:\n\n    Timeout for decommissioning nodes\n\nthe variable name seems fine though","commit_id":"59ccad55a5d6dbed1aa10f73f01ee5d9ba38fbfe"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"5ab3532b7ddc74bdef4c94428159adb8b132a250","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \u0027cluster\u0027, config_type\u003d\u0027int\u0027, priority\u003d1,"},{"line_number":30,"context_line":"    default_value\u003d1000, is_optional\u003dTrue,"},{"line_number":31,"context_line":"    description\u003d\u0027Timeout for waiting for decommissioning nodes, in \u0027"},{"line_number":32,"context_line":"                \u0027seconds\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class ConfigurationProvider(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_1da4f555","line":32,"updated":"2015-03-06 01:12:41.000000000","message":"similar as above:\n\n    Timeout for decommissioning nodes in seconds","commit_id":"59ccad55a5d6dbed1aa10f73f01ee5d9ba38fbfe"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"d23316d15eca6cf76c6df66e73de9bb8f03c4c8d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                self.config_mapper[service_property[\u0027name\u0027]] \u003d ("},{"line_number":82,"context_line":"                    self._get_target("},{"line_number":83,"context_line":"                        service_property[\u0027applicable_target\u0027]))"},{"line_number":84,"context_line":"        setattr(HOST_REGISTRATIONS_TIMEOUT, \u0027tag\u0027, \u0027global\u0027)"},{"line_number":85,"context_line":"        self.config_items.append(HOST_REGISTRATIONS_TIMEOUT)"},{"line_number":86,"context_line":"        self.config_mapper[HOST_REGISTRATIONS_TIMEOUT.name] \u003d \u0027global\u0027"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_305b2023","line":84,"updated":"2015-03-16 12:55:47.000000000","message":"Changing global object is bad idea.","commit_id":"ddb79a69cd90fe919e3da75841b251f6fcd43a5d"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"d23316d15eca6cf76c6df66e73de9bb8f03c4c8d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.config_mapper[HOST_REGISTRATIONS_TIMEOUT.name] \u003d \u0027global\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        if self.hadoop_version \u003d\u003d \u00272.0.6\u0027:"},{"line_number":89,"context_line":"            setattr(DECOMMISSIONING_TIMEOUT, \u0027tag\u0027, \u0027global\u0027)"},{"line_number":90,"context_line":"            self.config_items.append(DECOMMISSIONING_TIMEOUT)"},{"line_number":91,"context_line":"            self.config_mapper[DECOMMISSIONING_TIMEOUT.name] \u003d \u0027global\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_30b24049","line":89,"updated":"2015-03-16 12:55:47.000000000","message":"ditto","commit_id":"ddb79a69cd90fe919e3da75841b251f6fcd43a5d"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"2b32a5d9129c55e5c1910e969ba065f20f5ea892","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        setattr(host_reg_timeout, \u0027tag\u0027, \u0027global\u0027)"},{"line_number":88,"context_line":"        self.config_items.append(host_reg_timeout)"},{"line_number":89,"context_line":"        self.config_mapper[host_reg_timeout.name] \u003d \u0027global\u0027"},{"line_number":90,"context_line":"        dec_timeout \u003d copy.copy(DECOMMISSIONING_TIMEOUT)"},{"line_number":91,"context_line":"        if self.hadoop_version \u003d\u003d \u00272.0.6\u0027:"},{"line_number":92,"context_line":"            setattr(dec_timeout, \u0027tag\u0027, \u0027global\u0027)"},{"line_number":93,"context_line":"            self.config_items.append(dec_timeout)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_e19337fe","line":90,"updated":"2015-03-17 16:37:11.000000000","message":"i think it should be move in \u0027if\u0027 section","commit_id":"92491809c7e6a8fba4419a517c5356f0d5700bf5"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"4d0f7612c28e2beeccb7a0e326520f2ebbc984b3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        setattr(host_reg_timeout, \u0027tag\u0027, \u0027global\u0027)"},{"line_number":88,"context_line":"        self.config_items.append(host_reg_timeout)"},{"line_number":89,"context_line":"        self.config_mapper[host_reg_timeout.name] \u003d \u0027global\u0027"},{"line_number":90,"context_line":"        dec_timeout \u003d copy.copy(DECOMMISSIONING_TIMEOUT)"},{"line_number":91,"context_line":"        if self.hadoop_version \u003d\u003d \u00272.0.6\u0027:"},{"line_number":92,"context_line":"            setattr(dec_timeout, \u0027tag\u0027, \u0027global\u0027)"},{"line_number":93,"context_line":"            self.config_items.append(dec_timeout)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_75525d36","line":90,"in_reply_to":"9a80dd14_e19337fe","updated":"2015-03-18 20:19:12.000000000","message":"Done","commit_id":"92491809c7e6a8fba4419a517c5356f0d5700bf5"}],"sahara/plugins/hdp/versions/version_1_3_2/versionhandler.py":[{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"72c081229723c52044cdacf4ceac7cc593a0323d","unresolved":false,"context_lines":[{"line_number":554,"context_line":"            result \u003d self._get(url, ambari_info)"},{"line_number":555,"context_line":"            json_result \u003d json.loads(result.text)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            LOG.debug((\u0027Registered Hosts: {current_number}s \u0027"},{"line_number":558,"context_line":"                      \u0027of %(final_number)s\u0027).format("},{"line_number":559,"context_line":"                      current_number\u003dlen(json_result[\u0027items\u0027]),"},{"line_number":560,"context_line":"                      final_number\u003dnum_hosts))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_53e95a19","line":557,"updated":"2015-03-04 15:38:50.000000000","message":"The last s is redundant","commit_id":"eb0d878fea682985716b1019b3630f2d2c8b3938"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"72c081229723c52044cdacf4ceac7cc593a0323d","unresolved":false,"context_lines":[{"line_number":555,"context_line":"            json_result \u003d json.loads(result.text)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            LOG.debug((\u0027Registered Hosts: {current_number}s \u0027"},{"line_number":558,"context_line":"                      \u0027of %(final_number)s\u0027).format("},{"line_number":559,"context_line":"                      current_number\u003dlen(json_result[\u0027items\u0027]),"},{"line_number":560,"context_line":"                      final_number\u003dnum_hosts))"},{"line_number":561,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_33bb0610","line":558,"updated":"2015-03-04 15:38:50.000000000","message":"%(final_number)s -\u003e {final_number}","commit_id":"eb0d878fea682985716b1019b3630f2d2c8b3938"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"d86792a7e05a1d7f4284c2c07aaf4d9b0b9f2e5c","unresolved":false,"context_lines":[{"line_number":556,"context_line":"            json_result \u003d json.loads(result.text)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"            LOG.debug(\u0027Registered Hosts: {current_number} \u0027"},{"line_number":559,"context_line":"                      \u0027of %(final_number)\u0027"},{"line_number":560,"context_line":"                      .format(current_number\u003dlen(json_result[\u0027items\u0027]),"},{"line_number":561,"context_line":"                              final_number\u003dnum_hosts))"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_eba90991","line":559,"updated":"2015-03-06 11:25:15.000000000","message":"%(final_number) -\u003e {final_number},or %(final_number)s","commit_id":"59ccad55a5d6dbed1aa10f73f01ee5d9ba38fbfe"}],"sahara/plugins/hdp/versions/version_2_0_6/versionhandler.py":[{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"72c081229723c52044cdacf4ceac7cc593a0323d","unresolved":false,"context_lines":[{"line_number":542,"context_line":"            json_result \u003d json.loads(result.text)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"            LOG.debug((\u0027Registered Hosts: {current_number}s \u0027"},{"line_number":545,"context_line":"                       \u0027of %(final_number)s\u0027).format("},{"line_number":546,"context_line":"                      current_number\u003dlen(json_result[\u0027items\u0027]),"},{"line_number":547,"context_line":"                      final_number\u003dnum_hosts))"},{"line_number":548,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_f347ae1b","line":545,"updated":"2015-03-04 15:38:50.000000000","message":"ditto","commit_id":"eb0d878fea682985716b1019b3630f2d2c8b3938"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"d86792a7e05a1d7f4284c2c07aaf4d9b0b9f2e5c","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            json_result \u003d json.loads(result.text)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"            LOG.debug(\u0027Registered Hosts: {current_number} \u0027"},{"line_number":546,"context_line":"                      \u0027of %(final_number)\u0027"},{"line_number":547,"context_line":"                      .format(current_number\u003dlen(json_result[\u0027items\u0027]),"},{"line_number":548,"context_line":"                              final_number\u003dnum_hosts))"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_6b743936","line":546,"updated":"2015-03-06 11:25:15.000000000","message":"ditto","commit_id":"59ccad55a5d6dbed1aa10f73f01ee5d9ba38fbfe"}],"sahara/plugins/vanilla/v1_2_1/config_helper.py":[{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"5ab3532b7ddc74bdef4c94428159adb8b132a250","unresolved":false,"context_lines":[{"line_number":101,"context_line":"DATANODES_STARTUP_TIMEOUT \u003d p.Config("},{"line_number":102,"context_line":"    \u0027Datanodes startup timeout\u0027, \u0027general\u0027, \u0027cluster\u0027, config_type\u003d\u0027int\u0027,"},{"line_number":103,"context_line":"    priority\u003d1, default_value\u003d10800, is_optional\u003dTrue,"},{"line_number":104,"context_line":"    description\u003d\u0027Timeout for waiting datanodes startup, in seconds\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"HIDDEN_CONFS \u003d [\u0027fs.default.name\u0027, \u0027dfs.name.dir\u0027, \u0027dfs.data.dir\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_7d4a51c6","line":104,"updated":"2015-03-06 01:12:41.000000000","message":"i think this might be clearer as:\n\n    Timeout for datanodes startup in seconds","commit_id":"59ccad55a5d6dbed1aa10f73f01ee5d9ba38fbfe"}],"sahara/plugins/vanilla/v1_2_1/versionhandler.py":[{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"e5673053bc7ba81d8d9f340266e4df6bcd0afd82","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        datanodes_count \u003d len(vu.get_datanodes(cluster))"},{"line_number":199,"context_line":"        if datanodes_count \u003c 1:"},{"line_number":200,"context_line":"            return"},{"line_number":201,"context_line":"        l_message \u003d _(\"Waiting %s datanodes to start up\") % datanodes_count"},{"line_number":202,"context_line":"        LOG.info(l_message)"},{"line_number":203,"context_line":"        with remote.get_remote(vu.get_namenode(cluster)) as r:"},{"line_number":204,"context_line":"            poll_utils.plugin_poll("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_9a7415d0","line":201,"updated":"2015-03-04 00:11:31.000000000","message":"this should read:\n\n    Waiting on %s datanodes to start up","commit_id":"658d11055b07566152c32dd1fa6669c5c29755a7"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"72c081229723c52044cdacf4ceac7cc593a0323d","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        LOG.info(_LI(\u0027Cluster %s has been started successfully\u0027), cluster.name)"},{"line_number":192,"context_line":"        self._set_cluster_info(cluster)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def is_decommissioned(self, cluster, remote, datanodes_count):"},{"line_number":195,"context_line":"        return run.check_datanodes_count(remote, datanodes_count)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def _await_datanodes(self, cluster):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_93b4b2f3","line":194,"updated":"2015-03-04 15:38:50.000000000","message":"Why param cluster? Seems it\u0027s unused.","commit_id":"eb0d878fea682985716b1019b3630f2d2c8b3938"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"d23316d15eca6cf76c6df66e73de9bb8f03c4c8d","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        datanodes_count \u003d len(vu.get_datanodes(cluster))"},{"line_number":212,"context_line":"        if datanodes_count \u003c 1:"},{"line_number":213,"context_line":"            return"},{"line_number":214,"context_line":"        l_message \u003d _(\"Waiting on %s datanodes to start up\") % datanodes_count"},{"line_number":215,"context_line":"        LOG.info(l_message)"},{"line_number":216,"context_line":"        with remote.get_remote(vu.get_namenode(cluster)) as r:"},{"line_number":217,"context_line":"            poll_utils.plugin_option_poll("}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_d073a47d","line":214,"range":{"start_line":214,"start_character":20,"end_line":214,"end_character":22},"updated":"2015-03-16 12:55:47.000000000","message":"_LI","commit_id":"ddb79a69cd90fe919e3da75841b251f6fcd43a5d"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"ddbeeb2f994dd43077ca0d204210ab7b2e8bd0fe","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        datanodes_count \u003d len(vu.get_datanodes(cluster))"},{"line_number":212,"context_line":"        if datanodes_count \u003c 1:"},{"line_number":213,"context_line":"            return"},{"line_number":214,"context_line":"        l_message \u003d _(\"Waiting on %s datanodes to start up\") % datanodes_count"},{"line_number":215,"context_line":"        LOG.info(l_message)"},{"line_number":216,"context_line":"        with remote.get_remote(vu.get_namenode(cluster)) as r:"},{"line_number":217,"context_line":"            poll_utils.plugin_option_poll("}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_10745c34","line":214,"range":{"start_line":214,"start_character":20,"end_line":214,"end_character":22},"in_reply_to":"9a80dd14_d073a47d","updated":"2015-03-16 12:58:31.000000000","message":"No","commit_id":"ddb79a69cd90fe919e3da75841b251f6fcd43a5d"}]}