)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"ee9cb1db72bac5f1fd245b6b181118acd721f4c6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add an is_default field to cluster templates and node group templates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027is_default\u0027 Boolan field (default False) will prevent update or"},{"line_number":10,"context_line":"deletion of cluster templates and node group templates. The field may"},{"line_number":11,"context_line":"be set by calls into the conductor layer or the db api layer, but it"},{"line_number":12,"context_line":"is not available through the REST API since validation will prevent it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_3c2cbbab","line":9,"updated":"2015-03-04 14:49:35.000000000","message":"-1 for this.\nThis field is special, for it won\u0027t be used when creating.  \n\nTypo:Boolan -\u003e Boolean.","commit_id":"1a4b55fae9072c1fab3b900ce299c5c2949ae8a2"},{"author":{"_account_id":12039,"name":"Andrey Pavlov","email":"apavlov@mirantis.com","username":"apavlov"},"change_message_id":"405de6679822717ee9562d46962167bd7e2b4339","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add an is_default field to cluster templates and node group templates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027is_default\u0027 Boolan field (default False) will prevent update or"},{"line_number":10,"context_line":"deletion of cluster templates and node group templates. The field may"},{"line_number":11,"context_line":"be set by calls into the conductor layer or the db api layer, but it"},{"line_number":12,"context_line":"is not available through the REST API since validation will prevent it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_9f6e79c8","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":44},"updated":"2015-03-04 14:23:48.000000000","message":"If so, should it be added to https://github.com/openstack/sahara/blob/master/sahara/conductor/manager.py#L25-L48 ?","commit_id":"1a4b55fae9072c1fab3b900ce299c5c2949ae8a2"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"a5b965930ca0c7ea5f8baf87c035f5c5467a6fbb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add an is_default field to cluster templates and node group templates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027is_default\u0027 Boolan field (default False) will prevent update or"},{"line_number":10,"context_line":"deletion of cluster templates and node group templates. The field may"},{"line_number":11,"context_line":"be set by calls into the conductor layer or the db api layer, but it"},{"line_number":12,"context_line":"is not available through the REST API since validation will prevent it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_583172eb","line":9,"in_reply_to":"9a80dd14_3c2cbbab","updated":"2015-03-04 16:41:48.000000000","message":"Done","commit_id":"1a4b55fae9072c1fab3b900ce299c5c2949ae8a2"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"a5b965930ca0c7ea5f8baf87c035f5c5467a6fbb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add an is_default field to cluster templates and node group templates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027is_default\u0027 Boolan field (default False) will prevent update or"},{"line_number":10,"context_line":"deletion of cluster templates and node group templates. The field may"},{"line_number":11,"context_line":"be set by calls into the conductor layer or the db api layer, but it"},{"line_number":12,"context_line":"is not available through the REST API since validation will prevent it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_982bea81","line":9,"in_reply_to":"9a80dd14_9f6e79c8","updated":"2015-03-04 16:41:48.000000000","message":"as Jacob noted, this field won\u0027t be used in typical creation.  It will be filled in by the default template CLI only.  And, it applies only to templates, not to cluster or node_group objects (or node_group descriptions embedded directly in a cluster template)","commit_id":"1a4b55fae9072c1fab3b900ce299c5c2949ae8a2"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"32f132784d0448e766ec81c6722b7cd23eff4a9c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add an is_default field to cluster templates and node group templates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027is_default\u0027 Boolean field (default False) will prevent update or"},{"line_number":10,"context_line":"deletion of cluster templates and node group templates. The field may"},{"line_number":11,"context_line":"be set by calls into the conductor layer or the db api layer, but it"},{"line_number":12,"context_line":"is not available through the REST API since validation will prevent it."},{"line_number":13,"context_line":"This is by design -- the CLI for managing default templates will set this"},{"line_number":14,"context_line":"field."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Additionally, add an \u0027ignore_default\u0027 Boolean switch (default False) on"},{"line_number":17,"context_line":"cluster template and node group template update and deletion operations"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_ed0858db","line":14,"range":{"start_line":10,"start_character":56,"end_line":14,"end_character":6},"updated":"2015-03-12 11:58:53.000000000","message":"this shouldn\u0027t be here. it will be hard to find this information in commit history. it\u0027s better to move it to bp, or directly mention this in the code.","commit_id":"70f52536516bc508cb8e867e9bcd6c24805100d1"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"32f132784d0448e766ec81c6722b7cd23eff4a9c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Additionally, add an \u0027ignore_default\u0027 Boolean switch (default False) on"},{"line_number":17,"context_line":"cluster template and node group template update and deletion operations"},{"line_number":18,"context_line":"from the conductor level down. This will allow special tools to modify"},{"line_number":19,"context_line":"or delete default templates, but this switch will not be available"},{"line_number":20,"context_line":"through REST operations."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Partial-implements: blueprint default-templates"},{"line_number":23,"context_line":"Change-Id: I973df823981ca1a92d0dd116e32e1eacd79c56a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_4d208449","line":20,"range":{"start_line":18,"start_character":31,"end_line":20,"end_character":24},"updated":"2015-03-12 11:58:53.000000000","message":"same here.","commit_id":"70f52536516bc508cb8e867e9bcd6c24805100d1"}],"sahara/db/sqlalchemy/api.py":[{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"ee9cb1db72bac5f1fd245b6b181118acd721f4c6","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            return []"},{"line_number":454,"context_line":"        raise e"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"def cluster_template_create(context, values):"},{"line_number":458,"context_line":"    values \u003d values.copy()"},{"line_number":459,"context_line":"    cluster_template \u003d m.ClusterTemplate()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_c281fa4b","line":456,"updated":"2015-03-04 14:49:35.000000000","message":"Eventually, we need call this to create a template with is_default\u003dtrue. So should this function be changed to support this?","commit_id":"1a4b55fae9072c1fab3b900ce299c5c2949ae8a2"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"a78c38e3d00267792a2de9ddcbb3354018975d61","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            return []"},{"line_number":454,"context_line":"        raise e"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"def cluster_template_create(context, values):"},{"line_number":458,"context_line":"    values \u003d values.copy()"},{"line_number":459,"context_line":"    cluster_template \u003d m.ClusterTemplate()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_332ce6ab","line":456,"in_reply_to":"9a80dd14_c281fa4b","updated":"2015-03-04 15:48:38.000000000","message":"It is supported through \"values\".\n\nThe key is that the default template CLI (in the works) will call into the db api level\nand supply \"is_default\" in values.  But, the REST validation will not allow is_default to be passed through REST, so we have not given the end user direct access to this flag.","commit_id":"1a4b55fae9072c1fab3b900ce299c5c2949ae8a2"}]}