)]}'
{"sahara/tests/integration/tests/check_services.py":[{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"77891d9e65f68e747db82cb39b8a147d41825852","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                         conf_files\u003d[])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _check_service_availability(self, cluster_info, helper_script,"},{"line_number":84,"context_line":"                                    script_parameters\u003d[], conf_files\u003d[]):"},{"line_number":85,"context_line":"        namenode_ip \u003d cluster_info[\u0027node_info\u0027][\u0027namenode_ip\u0027]"},{"line_number":86,"context_line":"        self.open_ssh_connection(namenode_ip)"},{"line_number":87,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a75e904_0fc7cd13","line":84,"updated":"2015-03-21 05:13:53.000000000","message":"Is it a good idea to use [] as default? Prefer None.","commit_id":"f6b7a2283ef2333a2f83a86fa144911cef6c226f"},{"author":{"_account_id":9740,"name":"lu huichun","email":"huichun.lu@intel.com","username":"luhuichun"},"change_message_id":"d819e6ae2e2edc7f6e5ecc41a21bc19bcb106935","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                         conf_files\u003d[])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _check_service_availability(self, cluster_info, helper_script,"},{"line_number":84,"context_line":"                                    script_parameters\u003d[], conf_files\u003d[]):"},{"line_number":85,"context_line":"        namenode_ip \u003d cluster_info[\u0027node_info\u0027][\u0027namenode_ip\u0027]"},{"line_number":86,"context_line":"        self.open_ssh_connection(namenode_ip)"},{"line_number":87,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_c0401f38","line":84,"in_reply_to":"7a75e904_0fc7cd13","updated":"2015-03-23 02:38:18.000000000","message":"I think we should make the code looks like one style\nhttps://github.com/openstack/sahara/blob/master/sahara/plugins/provisioning.py#L69","commit_id":"f6b7a2283ef2333a2f83a86fa144911cef6c226f"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"77891d9e65f68e747db82cb39b8a147d41825852","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if conf_files:"},{"line_number":90,"context_line":"                for conf_file in conf_files:"},{"line_number":91,"context_line":"                    self.transfer_helper_conf_file_to_node(conf_file)"},{"line_number":92,"context_line":"            if len(script_parameters) \u003e 0:"},{"line_number":93,"context_line":"                for parameter in script_parameters:"},{"line_number":94,"context_line":"                    script_command \u003d \u0027./script.sh %s\u0027 % parameter"},{"line_number":95,"context_line":"                    self.execute_command(script_command)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_ece3dfd5","line":92,"updated":"2015-03-21 05:13:53.000000000","message":"Use `if script_parameters` instead, for len(None) will raise exception, if Default is None.","commit_id":"f6b7a2283ef2333a2f83a86fa144911cef6c226f"},{"author":{"_account_id":9740,"name":"lu huichun","email":"huichun.lu@intel.com","username":"luhuichun"},"change_message_id":"d819e6ae2e2edc7f6e5ecc41a21bc19bcb106935","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if conf_files:"},{"line_number":90,"context_line":"                for conf_file in conf_files:"},{"line_number":91,"context_line":"                    self.transfer_helper_conf_file_to_node(conf_file)"},{"line_number":92,"context_line":"            if len(script_parameters) \u003e 0:"},{"line_number":93,"context_line":"                for parameter in script_parameters:"},{"line_number":94,"context_line":"                    script_command \u003d \u0027./script.sh %s\u0027 % parameter"},{"line_number":95,"context_line":"                    self.execute_command(script_command)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_2048135b","line":92,"in_reply_to":"9a80dd14_ece3dfd5","updated":"2015-03-23 02:38:18.000000000","message":"if we use script_parameters \u003d [], this would not happen","commit_id":"f6b7a2283ef2333a2f83a86fa144911cef6c226f"},{"author":{"_account_id":14967,"name":"Thiago Gomes","email":"fthiagogv@outlook.com","username":"fthiagogv"},"change_message_id":"02ac7f8f96def360348b192512cece71963eb8cf","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if conf_files:"},{"line_number":90,"context_line":"                for conf_file in conf_files:"},{"line_number":91,"context_line":"                    self.transfer_helper_conf_file_to_node(conf_file)"},{"line_number":92,"context_line":"            if len(script_parameters) \u003e 0:"},{"line_number":93,"context_line":"                for parameter in script_parameters:"},{"line_number":94,"context_line":"                    script_command \u003d \u0027./script.sh %s\u0027 % parameter"},{"line_number":95,"context_line":"                    self.execute_command(script_command)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_6467ed25","line":92,"updated":"2015-04-08 21:22:24.000000000","message":"Would not be better without \u0027len\u0027? \"if script_parameters:\". The performance could have a little improvement. Since that the default parameter is void \"line 84\". The reading is better, I think.","commit_id":"6cd2ea0c26d5779d5ca739248a8fe79e3b08ede5"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"eb87dd694606aa866aeb7828e2fb51ec45bbb0a4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if conf_files:"},{"line_number":90,"context_line":"                for conf_file in conf_files:"},{"line_number":91,"context_line":"                    self.transfer_helper_conf_file_to_node(conf_file)"},{"line_number":92,"context_line":"            if len(script_parameters) \u003e 0:"},{"line_number":93,"context_line":"                for parameter in script_parameters:"},{"line_number":94,"context_line":"                    script_command \u003d \u0027./script.sh %s\u0027 % parameter"},{"line_number":95,"context_line":"                    self.execute_command(script_command)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_5849e5cf","line":92,"in_reply_to":"9aa53dc9_6467ed25","updated":"2015-04-10 19:15:29.000000000","message":"+1, seems like an ok thing to do.  Not -1 worthy imho.","commit_id":"6cd2ea0c26d5779d5ca739248a8fe79e3b08ede5"}]}