)]}'
{"sahara/plugins/cdh/plugin_utils.py":[{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"f6c416ff6a573218e4e965a812e6042202d6fb00","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        cluster \u003d instance.cluster"},{"line_number":220,"context_line":"        swift_lib_remote_url \u003d self.c_helper.get_swift_lib_url(cluster)"},{"line_number":221,"context_line":"        with instance.remote() as r:"},{"line_number":222,"context_line":"            if cluster.hadoop_version \u003d\u003d \"5\":"},{"line_number":223,"context_line":"                if r.execute_command(\u0027ls %s/hadoop-openstack-5-0-0.jar\u0027 %"},{"line_number":224,"context_line":"                                     HADOOP_LIB_DIR,"},{"line_number":225,"context_line":"                                     raise_when_error\u003dFalse)[0] !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_56de1112","line":222,"range":{"start_line":222,"start_character":12,"end_line":222,"end_character":45},"updated":"2015-04-14 08:30:12.000000000","message":"Sorry, but I don\u0027t like this implementation, because this code depends on version of plugin. I would prefer to move code under \"if cluster.hadoop_version \u003d\u003d 5\" to plugin utils of 5 version of plugin, and same for \"5.3.0\".","commit_id":"4f98ebaa03f253c8d90978938e8ceda935118233"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"f94e0da6e8849d770295608e508ab4ab8f853bba","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        cluster \u003d instance.cluster"},{"line_number":220,"context_line":"        swift_lib_remote_url \u003d self.c_helper.get_swift_lib_url(cluster)"},{"line_number":221,"context_line":"        with instance.remote() as r:"},{"line_number":222,"context_line":"            if cluster.hadoop_version \u003d\u003d \"5\":"},{"line_number":223,"context_line":"                if r.execute_command(\u0027ls %s/hadoop-openstack-5-0-0.jar\u0027 %"},{"line_number":224,"context_line":"                                     HADOOP_LIB_DIR,"},{"line_number":225,"context_line":"                                     raise_when_error\u003dFalse)[0] !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_473bf99c","line":222,"range":{"start_line":222,"start_character":12,"end_line":222,"end_character":45},"in_reply_to":"7aaa499b_56de1112","updated":"2015-04-14 09:51:57.000000000","message":"@Vitaly is this right place for comment?","commit_id":"4f98ebaa03f253c8d90978938e8ceda935118233"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"ce0e0408e6cd445eeb6ec47e355dc6d52a047526","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        cluster \u003d instance.cluster"},{"line_number":220,"context_line":"        swift_lib_remote_url \u003d self.c_helper.get_swift_lib_url(cluster)"},{"line_number":221,"context_line":"        with instance.remote() as r:"},{"line_number":222,"context_line":"            if cluster.hadoop_version \u003d\u003d \"5\":"},{"line_number":223,"context_line":"                if r.execute_command(\u0027ls %s/hadoop-openstack-5-0-0.jar\u0027 %"},{"line_number":224,"context_line":"                                     HADOOP_LIB_DIR,"},{"line_number":225,"context_line":"                                     raise_when_error\u003dFalse)[0] !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_aa472176","line":222,"in_reply_to":"7aaa499b_56de1112","updated":"2015-04-14 11:44:03.000000000","message":"Agree with @Vitaly Gridnev","commit_id":"4f98ebaa03f253c8d90978938e8ceda935118233"},{"author":{"_account_id":14967,"name":"Thiago Gomes","email":"fthiagogv@outlook.com","username":"fthiagogv"},"change_message_id":"ad85b9f560b0cb54151f5906de2b5d1aff6e2e6b","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        swift_lib_remote_url \u003d self.c_helper.get_swift_lib_url(cluster)"},{"line_number":221,"context_line":"        with instance.remote() as r:"},{"line_number":222,"context_line":"            if cluster.hadoop_version \u003d\u003d \"5\":"},{"line_number":223,"context_line":"                if r.execute_command(\u0027ls %s/hadoop-openstack-5-0-0.jar\u0027 %"},{"line_number":224,"context_line":"                                     HADOOP_LIB_DIR,"},{"line_number":225,"context_line":"                                     raise_when_error\u003dFalse)[0] !\u003d 0:"},{"line_number":226,"context_line":"                    r.execute_command(\u0027sudo curl %s -o %s/hadoop-openstack.jar\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_3838d63c","line":223,"updated":"2015-04-15 15:41:56.000000000","message":"The same of L230","commit_id":"4f98ebaa03f253c8d90978938e8ceda935118233"},{"author":{"_account_id":14967,"name":"Thiago Gomes","email":"fthiagogv@outlook.com","username":"fthiagogv"},"change_message_id":"ad85b9f560b0cb54151f5906de2b5d1aff6e2e6b","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                if r.execute_command(\u0027ls %s/hadoop-openstack-5-0-0.jar\u0027 %"},{"line_number":224,"context_line":"                                     HADOOP_LIB_DIR,"},{"line_number":225,"context_line":"                                     raise_when_error\u003dFalse)[0] !\u003d 0:"},{"line_number":226,"context_line":"                    r.execute_command(\u0027sudo curl %s -o %s/hadoop-openstack.jar\u0027"},{"line_number":227,"context_line":"                                      % (swift_lib_remote_url, HADOOP_LIB_DIR))"},{"line_number":228,"context_line":"            else:"},{"line_number":229,"context_line":"                if r.execute_command(\u0027ls %s/hadoop-openstack-5-3-0.jar\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_380fb689","line":226,"updated":"2015-04-15 15:41:56.000000000","message":"Similar of L230","commit_id":"4f98ebaa03f253c8d90978938e8ceda935118233"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"f94e0da6e8849d770295608e508ab4ab8f853bba","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                      % (swift_lib_remote_url, HADOOP_LIB_DIR))"},{"line_number":228,"context_line":"            else:"},{"line_number":229,"context_line":"                if r.execute_command(\u0027ls %s/hadoop-openstack-5-3-0.jar\u0027 %"},{"line_number":230,"context_line":"                                       HADOOP_LIB_DIR,"},{"line_number":231,"context_line":"                                       raise_when_error\u003dFalse)[0] !\u003d 0:"},{"line_number":232,"context_line":"                    r.execute_command(\u0027sudo curl %s -o %s/hadoop-openstack.jar\u0027"},{"line_number":233,"context_line":"                                      % (swift_lib_remote_url, HADOOP_LIB_DIR))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_8768e188","line":230,"range":{"start_line":230,"start_character":37,"end_line":230,"end_character":39},"updated":"2015-04-14 09:51:57.000000000","message":"trailing whitespace","commit_id":"4f98ebaa03f253c8d90978938e8ceda935118233"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"f94e0da6e8849d770295608e508ab4ab8f853bba","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                    r.execute_command(\u0027sudo curl %s -o %s/hadoop-openstack.jar\u0027"},{"line_number":227,"context_line":"                                      % (swift_lib_remote_url, HADOOP_LIB_DIR))"},{"line_number":228,"context_line":"            else:"},{"line_number":229,"context_line":"                if r.execute_command(\u0027ls %s/hadoop-openstack-5-3-0.jar\u0027 %"},{"line_number":230,"context_line":"                                       HADOOP_LIB_DIR,"},{"line_number":231,"context_line":"                                       raise_when_error\u003dFalse)[0] !\u003d 0:"},{"line_number":232,"context_line":"                    r.execute_command(\u0027sudo curl %s -o %s/hadoop-openstack.jar\u0027"},{"line_number":233,"context_line":"                                      % (swift_lib_remote_url, HADOOP_LIB_DIR))"},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_c7cdc95e","line":231,"range":{"start_line":229,"start_character":16,"end_line":231,"end_character":71},"updated":"2015-04-14 09:51:57.000000000","message":"also, it\u0027s hard to understand what\u0027s happening here. try to reformat it.","commit_id":"4f98ebaa03f253c8d90978938e8ceda935118233"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"f94e0da6e8849d770295608e508ab4ab8f853bba","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            else:"},{"line_number":229,"context_line":"                if r.execute_command(\u0027ls %s/hadoop-openstack-5-3-0.jar\u0027 %"},{"line_number":230,"context_line":"                                       HADOOP_LIB_DIR,"},{"line_number":231,"context_line":"                                       raise_when_error\u003dFalse)[0] !\u003d 0:"},{"line_number":232,"context_line":"                    r.execute_command(\u0027sudo curl %s -o %s/hadoop-openstack.jar\u0027"},{"line_number":233,"context_line":"                                      % (swift_lib_remote_url, HADOOP_LIB_DIR))"},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_2710ed00","line":231,"range":{"start_line":231,"start_character":37,"end_line":231,"end_character":39},"updated":"2015-04-14 09:51:57.000000000","message":"ditto","commit_id":"4f98ebaa03f253c8d90978938e8ceda935118233"},{"author":{"_account_id":14967,"name":"Thiago Gomes","email":"fthiagogv@outlook.com","username":"fthiagogv"},"change_message_id":"ad85b9f560b0cb54151f5906de2b5d1aff6e2e6b","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                    r.execute_command(\u0027sudo curl %s -o %s/hadoop-openstack.jar\u0027"},{"line_number":227,"context_line":"                                      % (swift_lib_remote_url, HADOOP_LIB_DIR))"},{"line_number":228,"context_line":"            else:"},{"line_number":229,"context_line":"                if r.execute_command(\u0027ls %s/hadoop-openstack-5-3-0.jar\u0027 %"},{"line_number":230,"context_line":"                                       HADOOP_LIB_DIR,"},{"line_number":231,"context_line":"                                       raise_when_error\u003dFalse)[0] !\u003d 0:"},{"line_number":232,"context_line":"                    r.execute_command(\u0027sudo curl %s -o %s/hadoop-openstack.jar\u0027"},{"line_number":233,"context_line":"                                      % (swift_lib_remote_url, HADOOP_LIB_DIR))"},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_58fcc271","line":231,"range":{"start_line":229,"start_character":16,"end_line":231,"end_character":71},"in_reply_to":"7aaa499b_c7cdc95e","updated":"2015-04-15 15:41:56.000000000","message":"I think that this can be simplified with a dictionary or a list.\n\nhadoop_lib \u003d {}\n\nhadoop_lib[\u00275-0-0\u0027] \u003d \u0027ls %s/hadoop-openstack-5-0-0.jar\u0027 % HADOOP_LIB_DIR\n\nhadoop_lib[\u00275-3-0\u0027] \u003d \u0027ls %s/hadoop-openstack-5-3-0.jar\u0027 % HADOOP_LIB_DIR","commit_id":"4f98ebaa03f253c8d90978938e8ceda935118233"}]}
