)]}'
{"sahara/plugins/vanilla/hadoop2/config.py":[{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"f82806981a31c00f9a37fa278f681b006c8da3a4","unresolved":false,"context_lines":[{"line_number":352,"context_line":"                                         topology_data, run_as_root\u003dTrue)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"def get_open_ports(node_group):"},{"line_number":356,"context_line":"    port_map \u003d collections.OrderedDict()"},{"line_number":357,"context_line":"    port_map[\"namenode\"] \u003d [50070, 9000]"},{"line_number":358,"context_line":"    port_map[\"secondarynamenode\"] \u003d [50090]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_fda61652","line":355,"updated":"2015-09-28 13:44:28.000000000","message":"port_map can probably defined just once, outside of this method.","commit_id":"29f2a650f8ee59d0b8c47473f71d8f9eb366f0cf"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"bbc0722bfbe580612f1f52d216494aa7c956f22e","unresolved":false,"context_lines":[{"line_number":352,"context_line":"                                         topology_data, run_as_root\u003dTrue)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"def get_open_ports(node_group):"},{"line_number":356,"context_line":"    port_map \u003d collections.OrderedDict()"},{"line_number":357,"context_line":"    port_map[\"namenode\"] \u003d [50070, 9000]"},{"line_number":358,"context_line":"    port_map[\"secondarynamenode\"] \u003d [50090]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_2a915947","line":355,"in_reply_to":"9a1a9d01_fda61652","updated":"2015-09-29 22:14:40.000000000","message":"+1","commit_id":"29f2a650f8ee59d0b8c47473f71d8f9eb366f0cf"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"c693af2c7cc98faab9c7ef71c51be45d8d147a5f","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"def get_port_mapping():"},{"line_number":356,"context_line":"    port_map \u003d collections.OrderedDict()"},{"line_number":357,"context_line":"    port_map[\"namenode\"] \u003d [50070, 9000]"},{"line_number":358,"context_line":"    port_map[\"secondarynamenode\"] \u003d [50090]"},{"line_number":359,"context_line":"    port_map[\"resourcemanager\"] \u003d [8088, 8032]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_5a053643","line":356,"updated":"2015-10-01 10:18:54.000000000","message":"Why OrderedDict is used there? it looks like that simple dict is enough.","commit_id":"7dddf2a644149e9f14078d0485af30eec576dc50"},{"author":{"_account_id":15701,"name":"venkatesh","email":"p.venkatesh551@gmail.com","username":"venkatesh"},"change_message_id":"622a1ad22a019f398c8f0e9a0b183b043b152ba3","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"def get_port_mapping():"},{"line_number":356,"context_line":"    port_map \u003d collections.OrderedDict()"},{"line_number":357,"context_line":"    port_map[\"namenode\"] \u003d [50070, 9000]"},{"line_number":358,"context_line":"    port_map[\"secondarynamenode\"] \u003d [50090]"},{"line_number":359,"context_line":"    port_map[\"resourcemanager\"] \u003d [8088, 8032]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_70385bd3","line":356,"in_reply_to":"9a1a9d01_5a053643","updated":"2015-10-01 10:58:40.000000000","message":"ya, normal dict is enough In this case, Order of  port-values in the return value does not matter","commit_id":"7dddf2a644149e9f14078d0485af30eec576dc50"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"4299b41dcb4e5dbdde1ec70960ff1044ef8b941f","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        \"nodemanager\": [8042],"},{"line_number":361,"context_line":"        \"oozie\": [11000],"},{"line_number":362,"context_line":"        \"hiveserver\": [9999, 10000]"},{"line_number":363,"context_line":"    }"},{"line_number":364,"context_line":"    return port_map"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_60716877","line":363,"updated":"2015-10-01 12:58:04.000000000","message":"why not just make this structure a module global, do we need a function to recreate it every time?","commit_id":"cede9839992b61b7ae8b6cd776345680113ccd2a"},{"author":{"_account_id":15701,"name":"venkatesh","email":"p.venkatesh551@gmail.com","username":"venkatesh"},"change_message_id":"5e1ba0ebdf4e82b35d18ab833b2560694b191b07","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        \"nodemanager\": [8042],"},{"line_number":361,"context_line":"        \"oozie\": [11000],"},{"line_number":362,"context_line":"        \"hiveserver\": [9999, 10000]"},{"line_number":363,"context_line":"    }"},{"line_number":364,"context_line":"    return port_map"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_409b0473","line":363,"in_reply_to":"9a1a9d01_60716877","updated":"2015-10-01 13:01:54.000000000","message":"my first option is making a global variable, if it used only once method  is better.\nOther places, where these mapping is used, I am not aware of","commit_id":"cede9839992b61b7ae8b6cd776345680113ccd2a"}]}