)]}'
{"sahara/service/heat/templates.py":[{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"d4292456056d25d1c69735077bf6af03b57125bb","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    def _serialize_wait_condition_script(self):"},{"line_number":399,"context_line":"        etc_hosts \u003d cl.etc_hosts_entry_for_service(h.get_endpoint_name())"},{"line_number":400,"context_line":"        if etc_hosts:"},{"line_number":401,"context_line":"            etc_hosts \u003d \"echo \u0027%s\u0027 | sudo tee -a /etc/hosts\" % etc_hosts"},{"line_number":402,"context_line":"            return \"\\n\".join([etc_hosts, WAIT_CONDITION_SCRIPT_TEMPLATE])"},{"line_number":403,"context_line":"        return WAIT_CONDITION_SCRIPT_TEMPLATE"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b9f646d5","line":401,"updated":"2016-03-07 21:10:31.000000000","message":"just curious, why use tee here? Is it important that the etc_hosts entry ends up on standard out?","commit_id":"49366bdb129fd47dc852519f63f9df98437a974e"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"3ca2cf640f9e79e36f28cfbb8db0db2fec39cbc5","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    def _serialize_wait_condition_script(self):"},{"line_number":399,"context_line":"        etc_hosts \u003d cl.etc_hosts_entry_for_service(h.get_endpoint_name())"},{"line_number":400,"context_line":"        if etc_hosts:"},{"line_number":401,"context_line":"            etc_hosts \u003d \"echo \u0027%s\u0027 | sudo tee -a /etc/hosts\" % etc_hosts"},{"line_number":402,"context_line":"            return \"\\n\".join([etc_hosts, WAIT_CONDITION_SCRIPT_TEMPLATE])"},{"line_number":403,"context_line":"        return WAIT_CONDITION_SCRIPT_TEMPLATE"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_f44bb5ae","line":401,"in_reply_to":"5aef4532_995a6a82","updated":"2016-03-07 21:32:08.000000000","message":"ah, I see. It can be done I guess by launching a shell with sudo, but maybe not worth it. I was just curious. Use of tee seems to be a standard way to do it (as long as the standard out doesn\u0027t matter)\n\nsudo bash -c \u0027echo \"%s\" \u003e\u003e /etc/hosts\u0027","commit_id":"49366bdb129fd47dc852519f63f9df98437a974e"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"2c89b39424b224478dcd996529afef980df2ffa8","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    def _serialize_wait_condition_script(self):"},{"line_number":399,"context_line":"        etc_hosts \u003d cl.etc_hosts_entry_for_service(h.get_endpoint_name())"},{"line_number":400,"context_line":"        if etc_hosts:"},{"line_number":401,"context_line":"            etc_hosts \u003d \"echo \u0027%s\u0027 | sudo tee -a /etc/hosts\" % etc_hosts"},{"line_number":402,"context_line":"            return \"\\n\".join([etc_hosts, WAIT_CONDITION_SCRIPT_TEMPLATE])"},{"line_number":403,"context_line":"        return WAIT_CONDITION_SCRIPT_TEMPLATE"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_995a6a82","line":401,"in_reply_to":"5aef4532_b9f646d5","updated":"2016-03-07 21:17:09.000000000","message":"Is there another way to make echo \"data\" \u003e\u003e file with sudo permissions?","commit_id":"49366bdb129fd47dc852519f63f9df98437a974e"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"1e9ab6d579aadced88fca494684fbc96692e0da8","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    def _serialize_wait_condition_script(self):"},{"line_number":399,"context_line":"        etc_hosts \u003d cl.etc_hosts_entry_for_service(h.get_endpoint_name())"},{"line_number":400,"context_line":"        if etc_hosts:"},{"line_number":401,"context_line":"            cp_etc_hosts_data \u003d \"sudo cp /etc/hosts /tmp/hosts-data\""},{"line_number":402,"context_line":"            etc_hosts \u003d \"echo \u0027%s\u0027 | sudo tee -a /etc/hosts\" % etc_hosts"},{"line_number":403,"context_line":"            mv_after \u003d \"sudo mv /tmp/hosts-data /etc/hosts\""},{"line_number":404,"context_line":"            return \"\\n\".join(["},{"line_number":405,"context_line":"                cp_etc_hosts_data, etc_hosts, WAIT_CONDITION_SCRIPT_TEMPLATE,"},{"line_number":406,"context_line":"                mv_after])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_f74f7768","line":403,"range":{"start_line":401,"start_character":0,"end_line":403,"end_character":59},"updated":"2016-03-10 19:33:56.000000000","message":"We should resolve orchestration ip from VM.\nWriting entry in /etc/hosts looks like workaround for bad deployment of OpenStack.","commit_id":"0f67111cd0f72b7374d2bb9749d0c70d3d6c3746"}],"sahara/utils/cluster.py":[{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"01a55d652da131f1f45a7d6d63916d3a4a5b2152","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                     instance.hostname())"},{"line_number":153,"context_line":"    # add alias for keystone and swift"},{"line_number":154,"context_line":"    for service in [\"identity\", \"object-store\"]:"},{"line_number":155,"context_line":"        entry \u003d etc_hosts_entry_for_service(service)"},{"line_number":156,"context_line":"        if entry:"},{"line_number":157,"context_line":"            hosts +\u003d entry"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_76c9c8ab","line":155,"updated":"2016-03-10 11:25:07.000000000","message":"If ip address for service will be changed then we cannot connect for service via hostname.","commit_id":"15b69020cd9ffbc4f092be8eacf7bb527e726e5d"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"15cb91763b6e148874e266c904835e9e745d2ddc","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                     instance.hostname())"},{"line_number":153,"context_line":"    # add alias for keystone and swift"},{"line_number":154,"context_line":"    for service in [\"identity\", \"object-store\"]:"},{"line_number":155,"context_line":"        entry \u003d etc_hosts_entry_for_service(service)"},{"line_number":156,"context_line":"        if entry:"},{"line_number":157,"context_line":"            hosts +\u003d entry"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_96e5740a","line":155,"in_reply_to":"5aef4532_76c9c8ab","updated":"2016-03-10 11:28:15.000000000","message":"I agreed that it\u0027s problem, but in such way it\u0027s related to the current patch?","commit_id":"15b69020cd9ffbc4f092be8eacf7bb527e726e5d"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"0ca2e56febaadd3c335945a2d979e2bfa337acc7","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                     instance.hostname())"},{"line_number":153,"context_line":"    # add alias for keystone and swift"},{"line_number":154,"context_line":"    for service in [\"identity\", \"object-store\"]:"},{"line_number":155,"context_line":"        entry \u003d etc_hosts_entry_for_service(service)"},{"line_number":156,"context_line":"        if entry:"},{"line_number":157,"context_line":"            hosts +\u003d entry"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_7681c8fa","line":155,"in_reply_to":"5aef4532_96e5740a","updated":"2016-03-10 11:29:52.000000000","message":"In commit message:\n\n* added etc hosts entry for heat service, to allow curl command\nto be executed when heat deployed with hostname;","commit_id":"15b69020cd9ffbc4f092be8eacf7bb527e726e5d"}],"sahara/utils/openstack/heat.py":[{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"d4292456056d25d1c69735077bf6af03b57125bb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"               default\u003d\"internalURL\","},{"line_number":34,"context_line":"               help\u003d\"Endpoint type for heat client requests\"),"},{"line_number":35,"context_line":"    cfg.StrOpt(\"endpoint_name\", default\u003d\"orchestration\","},{"line_number":36,"context_line":"               help\u003d\"Name of the endpoint to Orchestration service\")"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"heat_group \u003d cfg.OptGroup(name\u003d\u0027heat\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_d9ceb282","line":36,"updated":"2016-03-07 21:10:31.000000000","message":"nit, \"to\" should be \"for\"","commit_id":"49366bdb129fd47dc852519f63f9df98437a974e"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"2c89b39424b224478dcd996529afef980df2ffa8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"               default\u003d\"internalURL\","},{"line_number":34,"context_line":"               help\u003d\"Endpoint type for heat client requests\"),"},{"line_number":35,"context_line":"    cfg.StrOpt(\"endpoint_name\", default\u003d\"orchestration\","},{"line_number":36,"context_line":"               help\u003d\"Name of the endpoint to Orchestration service\")"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"heat_group \u003d cfg.OptGroup(name\u003d\u0027heat\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b9d806f1","line":36,"in_reply_to":"5aef4532_d9ceb282","updated":"2016-03-07 21:17:09.000000000","message":"Done","commit_id":"49366bdb129fd47dc852519f63f9df98437a974e"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"1e9ab6d579aadced88fca494684fbc96692e0da8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONF.register_opts(opts, group\u003dheat_group)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def get_endpoint_name():"},{"line_number":48,"context_line":"    return CONF.heat.endpoint_name"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def client():"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_177023a3","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":34},"updated":"2016-03-10 19:33:56.000000000","message":"get method for config option? I think it\u0027s not needed.","commit_id":"0f67111cd0f72b7374d2bb9749d0c70d3d6c3746"}]}
