)]}'
{"sahara/tests/unit/utils/test_cinder.py":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"8d6295e51cdb14fc87f8f8fb247420c4c4ebb9bc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                      **kwargs):"},{"line_number":33,"context_line":"        self.override_config(\u0027os_region_name\u0027, \u0027RegionOne\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Fake service_catalog with both volume and volumev2 services available"},{"line_number":36,"context_line":"        service_catalog \u003d \u0027\u0027\u0027["},{"line_number":37,"context_line":"            { \"type\": \"volumev2\","},{"line_number":38,"context_line":"              \"endpoints\": [ { \"region\": \"RegionOne\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_f3bfb25e","line":35,"updated":"2017-05-22 12:52:52.000000000","message":"should fix this comment too","commit_id":"640ba3b94ba0b5447d53788c2b51d68b453703f8"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"d7adc947689ccb46c9ecdfc4bf87c611fc086bef","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                      **kwargs):"},{"line_number":33,"context_line":"        self.override_config(\u0027os_region_name\u0027, \u0027RegionOne\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Fake service_catalog with both volume and volumev2 services available"},{"line_number":36,"context_line":"        service_catalog \u003d \u0027\u0027\u0027["},{"line_number":37,"context_line":"            { \"type\": \"volumev2\","},{"line_number":38,"context_line":"              \"endpoints\": [ { \"region\": \"RegionOne\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_0fa419a5","line":35,"in_reply_to":"ff0f0b1f_f3bfb25e","updated":"2017-05-23 08:32:46.000000000","message":"Done","commit_id":"640ba3b94ba0b5447d53788c2b51d68b453703f8"}],"sahara/utils/openstack/cinder.py":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"8d6295e51cdb14fc87f8f8fb247420c4c4ebb9bc","unresolved":false,"context_lines":[{"line_number":56,"context_line":"def validate_config():"},{"line_number":57,"context_line":"    if CONF.cinder.api_version \u003d\u003d 2:"},{"line_number":58,"context_line":"        LOG.warning(\u0027The Cinder v2 API is deprecated. You should set \u0027"},{"line_number":59,"context_line":"                    \u0027cinder_api_version\u003d3 in your sahara.conf file.\u0027)"},{"line_number":60,"context_line":"    elif CONF.cinder.api_version !\u003d 3:"},{"line_number":61,"context_line":"        LOG.warning(\u0027Unsupported Cinder API version: {bad}. Please set a \u0027"},{"line_number":62,"context_line":"                    \u0027correct value for cinder.api_version in your \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_b3437a6c","line":59,"updated":"2017-05-22 12:52:52.000000000","message":"cinder.api_version, right? not cinder_api_version","commit_id":"640ba3b94ba0b5447d53788c2b51d68b453703f8"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"d7adc947689ccb46c9ecdfc4bf87c611fc086bef","unresolved":false,"context_lines":[{"line_number":56,"context_line":"def validate_config():"},{"line_number":57,"context_line":"    if CONF.cinder.api_version \u003d\u003d 2:"},{"line_number":58,"context_line":"        LOG.warning(\u0027The Cinder v2 API is deprecated. You should set \u0027"},{"line_number":59,"context_line":"                    \u0027cinder_api_version\u003d3 in your sahara.conf file.\u0027)"},{"line_number":60,"context_line":"    elif CONF.cinder.api_version !\u003d 3:"},{"line_number":61,"context_line":"        LOG.warning(\u0027Unsupported Cinder API version: {bad}. Please set a \u0027"},{"line_number":62,"context_line":"                    \u0027correct value for cinder.api_version in your \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_efa0c592","line":59,"in_reply_to":"ff0f0b1f_b3437a6c","updated":"2017-05-23 08:32:46.000000000","message":"Done","commit_id":"640ba3b94ba0b5447d53788c2b51d68b453703f8"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"8d6295e51cdb14fc87f8f8fb247420c4c4ebb9bc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    if CONF.cinder.api_version \u003d\u003d 2:"},{"line_number":88,"context_line":"        service_type \u003d \u0027volumev2\u0027"},{"line_number":89,"context_line":"    else:"},{"line_number":90,"context_line":"        service_type \u003d \u0027volumev3\u0027"},{"line_number":91,"context_line":"    try:"},{"line_number":92,"context_line":"        base.url_for(context.current().service_catalog, service_type,"},{"line_number":93,"context_line":"                     endpoint_type\u003dCONF.cinder.endpoint_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_732602d1","line":90,"updated":"2017-05-22 12:52:52.000000000","message":"service_type names are not guaranteed, see discussion at https://review.openstack.org/#/c/450566/","commit_id":"640ba3b94ba0b5447d53788c2b51d68b453703f8"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"d7adc947689ccb46c9ecdfc4bf87c611fc086bef","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    if CONF.cinder.api_version \u003d\u003d 2:"},{"line_number":88,"context_line":"        service_type \u003d \u0027volumev2\u0027"},{"line_number":89,"context_line":"    else:"},{"line_number":90,"context_line":"        service_type \u003d \u0027volumev3\u0027"},{"line_number":91,"context_line":"    try:"},{"line_number":92,"context_line":"        base.url_for(context.current().service_catalog, service_type,"},{"line_number":93,"context_line":"                     endpoint_type\u003dCONF.cinder.endpoint_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_efce8558","line":90,"in_reply_to":"ff0f0b1f_732602d1","updated":"2017-05-23 08:32:46.000000000","message":"I think \u0027volumev3\u0027 is correct service_type\nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/client.py#L60","commit_id":"640ba3b94ba0b5447d53788c2b51d68b453703f8"}]}