)]}'
{"etc/sahara/policy.json":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"95cc7a6d6d123866320937e5995ebccb50c346c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"context_is_admin\": \"role:admin\","},{"line_number":3,"context_line":"    \"default\": \"\","},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    \"data-processing:clusters:get_all\": \"\","}],"source_content_type":"application/json","patch_set":8,"id":"7f515b1d_aea334b1","side":"PARENT","line":2,"updated":"2017-10-05 15:45:35.000000000","message":"Looks like this could be removed now, too: \n\nhttps://github.com/openstack/sahara/blob/master/devstack/plugin.sh#L86-L88","commit_id":"ce53a6adf47af33402624cdd4f32d7a41de1a4a3"}],"releasenotes/notes/policy_in_code-5847902775ff9861.yaml":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"526b8440d382b2b40689470cc453a64ff3f30afd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - This feature allows the policy enforcement to be done in code thus"},{"line_number":4,"context_line":"    facilitating the maitainance of the policy file. In code the default"},{"line_number":5,"context_line":"    policies are set and the operator only needs to change his policys file"},{"line_number":6,"context_line":"    if any specific rule is needed in his cloud. Also, a complete policy file"},{"line_number":7,"context_line":"    can be gerenated using genconfig tool."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f4b6375_bcfe0703","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":32},"updated":"2017-10-18 16:40:02.000000000","message":"maintenance","commit_id":"237a63a77d701ae981d57dd76287b16c3da29fe7"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"526b8440d382b2b40689470cc453a64ff3f30afd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - This feature allows the policy enforcement to be done in code thus"},{"line_number":4,"context_line":"    facilitating the maitainance of the policy file. In code the default"},{"line_number":5,"context_line":"    policies are set and the operator only needs to change his policys file"},{"line_number":6,"context_line":"    if any specific rule is needed in his cloud. Also, a complete policy file"},{"line_number":7,"context_line":"    can be gerenated using genconfig tool."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f4b6375_3c3b37d2","line":5,"range":{"start_line":5,"start_character":52,"end_line":5,"end_character":75},"updated":"2017-10-18 16:40:02.000000000","message":"provide his own policy.json\n\n(ok, probably someone will tell me why \"his\" is not correct...)","commit_id":"237a63a77d701ae981d57dd76287b16c3da29fe7"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"526b8440d382b2b40689470cc453a64ff3f30afd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    facilitating the maitainance of the policy file. In code the default"},{"line_number":5,"context_line":"    policies are set and the operator only needs to change his policys file"},{"line_number":6,"context_line":"    if any specific rule is needed in his cloud. Also, a complete policy file"},{"line_number":7,"context_line":"    can be gerenated using genconfig tool."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f4b6375_dc18a376","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":20},"updated":"2017-10-18 16:40:02.000000000","message":"generated","commit_id":"237a63a77d701ae981d57dd76287b16c3da29fe7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"24c915c24a74c85e3f77c1e980725b4fe8591178","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - This feature allows the policy enforcement to be done in code thus"},{"line_number":4,"context_line":"    facilitating the maintenance of the policy file. In code the default"},{"line_number":5,"context_line":"    policies are set and the operator only needs to change the policy file"},{"line_number":6,"context_line":"    if any specific rule is needed for the cloud. Also, a complete policy file"},{"line_number":7,"context_line":"    can be generated using genconfig tool."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4b6375_c9cfa37d","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":32},"updated":"2017-10-19 19:07:58.000000000","message":"nit: better maintenance*","commit_id":"e758f8417c07f4f99c4c3497d6a6a0a1269e6c01"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"24c915c24a74c85e3f77c1e980725b4fe8591178","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - This feature allows the policy enforcement to be done in code thus"},{"line_number":4,"context_line":"    facilitating the maintenance of the policy file. In code the default"},{"line_number":5,"context_line":"    policies are set and the operator only needs to change the policy file"},{"line_number":6,"context_line":"    if any specific rule is needed for the cloud. Also, a complete policy file"},{"line_number":7,"context_line":"    can be generated using genconfig tool."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f4b6375_c97d631d","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":48},"updated":"2017-10-19 19:07:58.000000000","message":"nit: they wish to override the rule or role for a specific policy or operation.","commit_id":"e758f8417c07f4f99c4c3497d6a6a0a1269e6c01"}],"sahara/api/acl.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"24c915c24a74c85e3f77c1e980725b4fe8591178","unresolved":false,"context_lines":[{"line_number":27,"context_line":"ENFORCER \u003d None"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def setup_policy():"},{"line_number":31,"context_line":"    global ENFORCER"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    ENFORCER \u003d policy.Enforcer(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_09993b6d","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":16},"updated":"2017-10-19 19:07:58.000000000","message":"Just double checking here, but this is only ever called once, right?","commit_id":"e758f8417c07f4f99c4c3497d6a6a0a1269e6c01"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"1319d9de9ff4776ab376502f7179ba383208587b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"ENFORCER \u003d None"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def setup_policy():"},{"line_number":31,"context_line":"    global ENFORCER"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    ENFORCER \u003d policy.Enforcer(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_f4ba32dc","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":16},"in_reply_to":"3f4b6375_09993b6d","updated":"2017-10-19 19:19:17.000000000","message":"Yes, when starting the service","commit_id":"e758f8417c07f4f99c4c3497d6a6a0a1269e6c01"}],"sahara/common/policies/__init__.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"24c915c24a74c85e3f77c1e980725b4fe8591178","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from sahara.common.policies import job_binaries"},{"line_number":21,"context_line":"from sahara.common.policies import job_binary_internals"},{"line_number":22,"context_line":"from sahara.common.policies import job_executions"},{"line_number":23,"context_line":"from sahara.common.policies import job_templates"},{"line_number":24,"context_line":"from sahara.common.policies import job_types"},{"line_number":25,"context_line":"from sahara.common.policies import jobs"},{"line_number":26,"context_line":"from sahara.common.policies import node_group_templates"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_69d78fef","line":23,"range":{"start_line":23,"start_character":35,"end_line":23,"end_character":48},"updated":"2017-10-19 19:07:58.000000000","message":"Were these in the policy file somewhere?","commit_id":"e758f8417c07f4f99c4c3497d6a6a0a1269e6c01"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"1319d9de9ff4776ab376502f7179ba383208587b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from sahara.common.policies import job_binaries"},{"line_number":21,"context_line":"from sahara.common.policies import job_binary_internals"},{"line_number":22,"context_line":"from sahara.common.policies import job_executions"},{"line_number":23,"context_line":"from sahara.common.policies import job_templates"},{"line_number":24,"context_line":"from sahara.common.policies import job_types"},{"line_number":25,"context_line":"from sahara.common.policies import jobs"},{"line_number":26,"context_line":"from sahara.common.policies import node_group_templates"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_b4e39a05","line":23,"range":{"start_line":23,"start_character":35,"end_line":23,"end_character":48},"in_reply_to":"3f4b6375_69d78fef","updated":"2017-10-19 19:19:17.000000000","message":"Not yet, they are part of APIv2 which will be released at least as experimental in Queens, so I figured we should put it already there.","commit_id":"e758f8417c07f4f99c4c3497d6a6a0a1269e6c01"}],"sahara/common/policies/base.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"993aa4c16a39bbbb53625c216b58557e6523c0f5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"DATA_PROCESSING_PLUGINS \u003d DATA_PROCESSING % \u0027plugins:%s\u0027"},{"line_number":25,"context_line":"DATA_PROCESSING_NODE_GROUP_TEMPLATES \u003d ("},{"line_number":26,"context_line":"    DATA_PROCESSING % \u0027node-group-templates:%s\u0027)"},{"line_number":27,"context_line":"DATA_PROCESSING_JOB_BINARY_INTERNAL \u003d ("},{"line_number":28,"context_line":"    DATA_PROCESSING % \u0027job-binary-internal:%s\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"rules \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_610d753d","line":27,"updated":"2017-09-20 22:39:09.000000000","message":"The linter says:\n2017-09-20 18:51:31.497787 | sahara/common/policies/job_binary_internals.py:28: [E1101(no-member), ] Module \u0027sahara.common.policies.base\u0027 has no \u0027DATA_PROCESSING_JOB_BINARY_INTERNALS\u0027 member\n\nand here in fact it\u0027s DATA_PROCESSING_JOB_BINARY_INTERNAL\n\nNot sure why it does not trigger any error.","commit_id":"e17006a74435a259d1f82abd0cf45ae55d8f3827"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"24c915c24a74c85e3f77c1e980725b4fe8591178","unresolved":false,"context_lines":[{"line_number":19,"context_line":"DATA_PROCESSING_IMAGES \u003d DATA_PROCESSING % \u0027images:%s\u0027"},{"line_number":20,"context_line":"DATA_PROCESSING_JOB_BINARIES \u003d DATA_PROCESSING % \u0027job-binaries:%s\u0027"},{"line_number":21,"context_line":"DATA_PROCESSING_JOB_EXECUTIONS \u003d DATA_PROCESSING % \u0027job-executions:%s\u0027"},{"line_number":22,"context_line":"DATA_PROCESSING_JOB_TEMPLATES \u003d DATA_PROCESSING % \u0027job-templates:%s\u0027"},{"line_number":23,"context_line":"DATA_PROCESSING_JOB_TYPES \u003d DATA_PROCESSING % \u0027job-types:%s\u0027"},{"line_number":24,"context_line":"DATA_PROCESSING_JOBS \u003d DATA_PROCESSING % \u0027jobs:%s\u0027"},{"line_number":25,"context_line":"DATA_PROCESSING_PLUGINS \u003d DATA_PROCESSING % \u0027plugins:%s\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_a9f6a78e","line":22,"range":{"start_line":22,"start_character":51,"end_line":22,"end_character":64},"updated":"2017-10-19 19:07:58.000000000","message":"This doesn\u0027t appear to be in the policy file, is it documented somewhere?","commit_id":"e758f8417c07f4f99c4c3497d6a6a0a1269e6c01"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"1319d9de9ff4776ab376502f7179ba383208587b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"DATA_PROCESSING_IMAGES \u003d DATA_PROCESSING % \u0027images:%s\u0027"},{"line_number":20,"context_line":"DATA_PROCESSING_JOB_BINARIES \u003d DATA_PROCESSING % \u0027job-binaries:%s\u0027"},{"line_number":21,"context_line":"DATA_PROCESSING_JOB_EXECUTIONS \u003d DATA_PROCESSING % \u0027job-executions:%s\u0027"},{"line_number":22,"context_line":"DATA_PROCESSING_JOB_TEMPLATES \u003d DATA_PROCESSING % \u0027job-templates:%s\u0027"},{"line_number":23,"context_line":"DATA_PROCESSING_JOB_TYPES \u003d DATA_PROCESSING % \u0027job-types:%s\u0027"},{"line_number":24,"context_line":"DATA_PROCESSING_JOBS \u003d DATA_PROCESSING % \u0027jobs:%s\u0027"},{"line_number":25,"context_line":"DATA_PROCESSING_PLUGINS \u003d DATA_PROCESSING % \u0027plugins:%s\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_b4915a55","line":22,"range":{"start_line":22,"start_character":51,"end_line":22,"end_character":64},"in_reply_to":"3f4b6375_a9f6a78e","updated":"2017-10-19 19:19:17.000000000","message":"As I mentioned on other comment, this is part of APIv2.","commit_id":"e758f8417c07f4f99c4c3497d6a6a0a1269e6c01"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"24c915c24a74c85e3f77c1e980725b4fe8591178","unresolved":false,"context_lines":[{"line_number":32,"context_line":"rules \u003d ["},{"line_number":33,"context_line":"    policy.RuleDefault("},{"line_number":34,"context_line":"        name\u003d\u0027context_is_admin\u0027,"},{"line_number":35,"context_line":"        check_str\u003d\u0027role:admin\u0027),"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_29363705","line":35,"range":{"start_line":35,"start_character":18,"end_line":35,"end_character":30},"updated":"2017-10-19 19:07:58.000000000","message":"nit: We could pull this guy out into its own variable and reuse it for the data-processing:plugins:patch policy.","commit_id":"e758f8417c07f4f99c4c3497d6a6a0a1269e6c01"}],"sahara/common/policies/cluster_templates.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8c5444ccecf89138d4250dfee11aab565015f44f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"cluster_templates_policies \u003d ["},{"line_number":20,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":21,"context_line":"        name\u003dbase.DATA_PROCESSING_CLUSTER_TEMPLATES % \u0027create\u0027,"},{"line_number":22,"context_line":"        check_str\u003d\u0027\u0027,"},{"line_number":23,"context_line":"        description\u003d\u0027Create cluster template.\u0027,"},{"line_number":24,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/cluster-templates\u0027,"},{"line_number":25,"context_line":"                     \u0027method\u0027: \u0027POST\u0027}]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_986edec6","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":20},"updated":"2017-10-02 15:17:40.000000000","message":"It\u0027s possible to treat this just like a policy even though it is an empty string. This makes reading the policy easier for developers and ensure it\u0027s applied consistently everywhere. For example, you can do the following in sahara.common.policies.base:\n\n  UNPROTECTED \u003d \u0027\u0027\n\nAnd then here you can do:\n\n  policy.DocumentedRuleDefault(\n      name\u003dbase.DATA_PROCESSING_CLUSTER_TEMPLATES % \u0027create\u0027,\n      check_str\u003dbase.UNPROTECTED,\n      ...\n  )","commit_id":"4d84216184b96284d23bae80a580b5609a1d035d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0ead3d7f6a2d7236d17b861aaa3942ee8c66647c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from sahara.common.policies import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cluster_templates_policies \u003d ["},{"line_number":20,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":21,"context_line":"        name\u003dbase.DATA_PROCESSING_CLUSTER_TEMPLATES % \u0027create\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_62ec368f","line":18,"updated":"2017-10-05 13:25:08.000000000","message":"Looks like these can be removed now: \n\nhttps://github.com/openstack/sahara/blob/master/etc/sahara/policy.json#L12-L16","commit_id":"fdb8f143e285b1c4183c7e9e7130fd84d0ea23c7"},{"author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"change_message_id":"8d02c315f5c5ae58a24cd79bc83c448aa3637581","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        description\u003d\u0027Create cluster template.\u0027,"},{"line_number":24,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/cluster-templates\u0027,"},{"line_number":25,"context_line":"                     \u0027method\u0027: \u0027POST\u0027},"},{"line_number":26,"context_line":"                    {\u0027path\u0027: \u0027/v2/{project_id}/cluster-templates\u0027,"},{"line_number":27,"context_line":"                     \u0027method\u0027: \u0027POST\u0027}]),"},{"line_number":28,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":29,"context_line":"        name\u003dbase.DATA_PROCESSING_CLUSTER_TEMPLATES % \u0027delete\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f4b6375_ccc6aa17","line":26,"range":{"start_line":26,"start_character":33,"end_line":26,"end_character":46},"updated":"2017-10-19 02:03:19.000000000","message":"In API V2, we have been removed the {project_id} from URI, to be replaced by OpenStack-Project-ID header on all requests. so, the path should be \"/v2/cluster-templates\"","commit_id":"d471df877f0c60f5fd04a0d304fbe91bb4ef546b"}],"sahara/common/policies/clusters.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0ead3d7f6a2d7236d17b861aaa3942ee8c66647c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from sahara.common.policies import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"clusters_policies \u003d ["},{"line_number":20,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":21,"context_line":"        name\u003dbase.DATA_PROCESSING_CLUSTERS % \u0027scale\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_c262ca16","line":18,"updated":"2017-10-05 13:25:08.000000000","message":"These can be removed from the old .json file: \n\nhttps://github.com/openstack/sahara/blob/master/etc/sahara/policy.json#L5-L10\n\nThis comment can probably be applied throughout the rest of the patch (by just deleting the policy.json file) since it looks like you\u0027re addressing all policies at once.","commit_id":"fdb8f143e285b1c4183c7e9e7130fd84d0ea23c7"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"f6da8c9c78aa4ac4084aff0b997cee37a7f0ee9b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":45,"context_line":"        name\u003dbase.DATA_PROCESSING_CLUSTERS % \u0027get\u0027,"},{"line_number":46,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":47,"context_line":"        description\u003d\u0027Get a cluster.\u0027,"},{"line_number":48,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/clusters/{cluster_id}\u0027,"},{"line_number":49,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":50,"context_line":"                    {\u0027path\u0027: \u0027/v2/clusters/{cluster_id}\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_8fe64b44","line":47,"range":{"start_line":47,"start_character":21,"end_line":47,"end_character":35},"updated":"2017-10-19 20:05:36.000000000","message":"Sometimes you call the \u0027get\u0027 operation \"Get an X\" and sometimes you call it \"Show X details\". Not a big deal, but you could be more consistent","commit_id":"2b3e8d0fab0743ac023428b733d419a4f9d73455"}],"sahara/common/policies/images.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a46a60e5d1efae1e20ee3dce9bc949469d851332","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"images_policies \u003d ["},{"line_number":20,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":21,"context_line":"        name\u003dbase.DATA_PROCESSING_IMAGES % \u0027add_tags\u0027,"},{"line_number":22,"context_line":"        check_str\u003d\u0027\u0027,"},{"line_number":23,"context_line":"        description\u003d\u0027Add tags to image.\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_fe3225a7","line":20,"updated":"2017-09-20 20:18:50.000000000","message":"did set_tags disappear compared to the previous patch?","commit_id":"e17006a74435a259d1f82abd0cf45ae55d8f3827"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"f6da8c9c78aa4ac4084aff0b997cee37a7f0ee9b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":21,"context_line":"        name\u003dbase.DATA_PROCESSING_IMAGES % \u0027set_tags\u0027,"},{"line_number":22,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":23,"context_line":"        description\u003d\u0027Set tags to image.\u0027,"},{"line_number":24,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v2/images/{image_id}/tags\u0027,"},{"line_number":25,"context_line":"                     \u0027method\u0027: \u0027PUT\u0027}]),"},{"line_number":26,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_afc22784","line":23,"range":{"start_line":23,"start_character":21,"end_line":23,"end_character":24},"updated":"2017-10-19 20:05:36.000000000","message":"Set an image\u0027s tags? Set tags for image? Or maybe just Add tags to image...","commit_id":"2b3e8d0fab0743ac023428b733d419a4f9d73455"}],"sahara/common/policies/job_binary_internals.py":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"f6da8c9c78aa4ac4084aff0b997cee37a7f0ee9b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_BINARY_INTERNALS % \u0027create\u0027,"},{"line_number":35,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":36,"context_line":"        description\u003d\u0027Create job binary internals.\u0027,"},{"line_number":37,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/job-binary-internals/name\u0027,"},{"line_number":38,"context_line":"                     \u0027method\u0027: \u0027PUT\u0027}]),"},{"line_number":39,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":40,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_BINARY_INTERNALS % \u0027get_data\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_8fc9ab79","line":37,"range":{"start_line":37,"start_character":70,"end_line":37,"end_character":74},"updated":"2017-10-19 20:05:36.000000000","message":"should be {name}","commit_id":"2b3e8d0fab0743ac023428b733d419a4f9d73455"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"f6da8c9c78aa4ac4084aff0b997cee37a7f0ee9b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":57,"context_line":"        description\u003d\u0027Delete job binary internals.\u0027,"},{"line_number":58,"context_line":"        operations\u003d[{"},{"line_number":59,"context_line":"            \u0027path\u0027: \u0027/v1.1/{project_id}/job-binary-internals/{job_bin_int_id\u0027,"},{"line_number":60,"context_line":"            \u0027method\u0027: \u0027DELETE\u0027}]),"},{"line_number":61,"context_line":"]"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_cfcfa37d","line":59,"range":{"start_line":59,"start_character":61,"end_line":59,"end_character":76},"updated":"2017-10-19 20:05:36.000000000","message":"missing }","commit_id":"2b3e8d0fab0743ac023428b733d419a4f9d73455"}],"sahara/common/policies/job_executions.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"97b4f894a754f8a0b37d572b18e3e395eefd2706","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        operations\u003d[{"},{"line_number":55,"context_line":"            \u0027path\u0027:"},{"line_number":56,"context_line":"            \u0027/v1.1/{project_id}/job-executions/{job_exec_id}/refresh-status\u0027,"},{"line_number":57,"context_line":"            \u0027method\u0027: \u0027GET\u0027},"},{"line_number":58,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":59,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_EXECUTIONS % \u0027cancel\u0027,"},{"line_number":60,"context_line":"        check_str\u003dbase.UNPROTECTED,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_c5266d69","line":57,"updated":"2017-10-04 20:31:57.000000000","message":"Missing closing?","commit_id":"46274d5ce0bd0a6ada4ddfacdf3da42e1b470714"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"526b8440d382b2b40689470cc453a64ff3f30afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3f4b6375_7cb52fee","updated":"2017-10-18 16:40:02.000000000","message":"the whole jobs executions vs jobs in v1 and v2 is hard to keep track of in my brain, I will probably have to proofread it again","commit_id":"237a63a77d701ae981d57dd76287b16c3da29fe7"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"f210f2b34bd844292d33f04e8e0dbd16662e017c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3f4b6375_25cf9a80","in_reply_to":"3f4b6375_7cb52fee","updated":"2017-10-18 18:21:24.000000000","message":"I\u0027m sending a new patch that makes more sense.\n\nBasically what I did was:\n\nOn common/policies/cluster-templates.py it is what is jobs from api v1.1\n\nOn common/policies/jobs the v2 part is what it used to be job-executions on v1.1.\n\nIt is a little crossing info there, but hopefully, we will get rid of v1.1 soon enough","commit_id":"237a63a77d701ae981d57dd76287b16c3da29fe7"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"526b8440d382b2b40689470cc453a64ff3f30afd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_EXECUTIONS % \u0027cancel\u0027,"},{"line_number":60,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":61,"context_line":"        description\u003d\u0027Cancel job execution.\u0027,"},{"line_number":62,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/job-executions/{job_exec_id}\u0027,"},{"line_number":63,"context_line":"                     \u0027method\u0027: \u0027GET\u0027}]),"},{"line_number":64,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":65,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_EXECUTIONS % \u0027delete\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f4b6375_dc69c38b","line":62,"range":{"start_line":62,"start_character":63,"end_line":62,"end_character":77},"updated":"2017-10-18 16:40:02.000000000","message":"/{job_exec_id}/cancel if I remember our apiref correctly","commit_id":"237a63a77d701ae981d57dd76287b16c3da29fe7"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1213d6de580fb784b88862cd44da52b1e2255387","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_EXECUTIONS % \u0027cancel\u0027,"},{"line_number":48,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":49,"context_line":"        description\u003d\u0027Cancel job execution.\u0027,"},{"line_number":50,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/job-executions/{job_exec_id}\u0027,"},{"line_number":51,"context_line":"                     \u0027method\u0027: \u0027GET\u0027}]),"},{"line_number":52,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":53,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_EXECUTIONS % \u0027delete\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f4b6375_1392a1f7","line":50,"updated":"2017-10-18 22:38:20.000000000","message":"See the comment by Jeremy on the previous patch, this should end with /cancel according this:\n\nhttps://developer.openstack.org/api-ref/data-processing/#cancel-job-execution","commit_id":"d471df877f0c60f5fd04a0d304fbe91bb4ef546b"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"f6da8c9c78aa4ac4084aff0b997cee37a7f0ee9b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":21,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_EXECUTIONS % \u0027get\u0027,"},{"line_number":22,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":23,"context_line":"        description\u003d\u0027List job executions.\u0027,"},{"line_number":24,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/job-executions/{job_exec_id}\u0027,"},{"line_number":25,"context_line":"                     \u0027method\u0027: \u0027GET\u0027}]),"},{"line_number":26,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_4f8a931b","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":42},"updated":"2017-10-19 20:05:36.000000000","message":"shouldn\u0027t that be Show job execution ?","commit_id":"2b3e8d0fab0743ac023428b733d419a4f9d73455"}],"sahara/common/policies/job_templates.py":[{"author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"change_message_id":"533619470a09c26370183c23e906eb446f0eae41","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":27,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_TEMPLATES % \u0027create\u0027,"},{"line_number":28,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":29,"context_line":"        description\u003d\u0027Create job.\u0027,"},{"line_number":30,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v2/job-templates\u0027,"},{"line_number":31,"context_line":"                     \u0027method\u0027: \u0027POST\u0027}]),"},{"line_number":32,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_f56c6909","line":29,"range":{"start_line":29,"start_character":21,"end_line":29,"end_character":31},"updated":"2017-10-20 01:14:46.000000000","message":"should this be\" create job template\"?","commit_id":"e0c78cc6058b3c5299c6baff429c57deead03086"},{"author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"change_message_id":"533619470a09c26370183c23e906eb446f0eae41","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":33,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_TEMPLATES % \u0027get_all\u0027,"},{"line_number":34,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":35,"context_line":"        description\u003d\u0027List jobs.\u0027,"},{"line_number":36,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v2/job-templates\u0027,"},{"line_number":37,"context_line":"                     \u0027method\u0027: \u0027GET\u0027}]),"},{"line_number":38,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_3531e10c","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":30},"updated":"2017-10-20 01:14:46.000000000","message":"List job templates","commit_id":"e0c78cc6058b3c5299c6baff429c57deead03086"},{"author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"change_message_id":"533619470a09c26370183c23e906eb446f0eae41","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":39,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_TEMPLATES % \u0027modify\u0027,"},{"line_number":40,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":41,"context_line":"        description\u003d\u0027Update job object.\u0027,"},{"line_number":42,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v2/job-templates/{job_temp_id}\u0027,"},{"line_number":43,"context_line":"                     \u0027method\u0027: \u0027PATCH\u0027}]),"},{"line_number":44,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_1536e504","line":41,"range":{"start_line":41,"start_character":21,"end_line":41,"end_character":38},"updated":"2017-10-20 01:14:46.000000000","message":"Update job template","commit_id":"e0c78cc6058b3c5299c6baff429c57deead03086"},{"author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"change_message_id":"533619470a09c26370183c23e906eb446f0eae41","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":52,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_TEMPLATES % \u0027delete\u0027,"},{"line_number":53,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":54,"context_line":"        description\u003d\u0027Remove job.\u0027,"},{"line_number":55,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v2/job-templates/{job_temp_id}\u0027,"},{"line_number":56,"context_line":"                     \u0027method\u0027: \u0027DELETE\u0027}]),"},{"line_number":57,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_f53a29e5","line":54,"range":{"start_line":54,"start_character":21,"end_line":54,"end_character":32},"updated":"2017-10-20 01:14:46.000000000","message":"Remove Job Template","commit_id":"e0c78cc6058b3c5299c6baff429c57deead03086"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1f231c0aca2c18c9e95d1852dabe2cd781d6a78a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":39,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_TEMPLATES % \u0027modify\u0027,"},{"line_number":40,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":41,"context_line":"        description\u003d\u0027Update job tempĺate.\u0027,"},{"line_number":42,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v2/job-templates/{job_temp_id}\u0027,"},{"line_number":43,"context_line":"                     \u0027method\u0027: \u0027PATCH\u0027}]),"},{"line_number":44,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_fff65ff9","line":41,"updated":"2017-10-22 15:37:29.000000000","message":"recheck this line","commit_id":"06f200f9242cd5fd2d53ab90b89c68cdd2bdc664"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"dfcdc159fecfa4eb49af0a0955d72975023c57fe","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":39,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_TEMPLATES % \u0027modify\u0027,"},{"line_number":40,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":41,"context_line":"        description\u003d\u0027Update job tempĺate.\u0027,"},{"line_number":42,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v2/job-templates/{job_temp_id}\u0027,"},{"line_number":43,"context_line":"                     \u0027method\u0027: \u0027PATCH\u0027}]),"},{"line_number":44,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_4b649222","line":41,"in_reply_to":"3f4b6375_250f488a","updated":"2017-10-23 07:12:35.000000000","message":"I checked and the bogus character is definitely there between \"temp\" and \"ate.\".\nThe ĺ is not the normal l but U+013A (LATIN SMALL LETTER L WITH ACUTE), used in the Slovak alphabet. A typo for sure :)","commit_id":"06f200f9242cd5fd2d53ab90b89c68cdd2bdc664"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"08be5dbc29c32077927290fd1242772b9828e8a1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":39,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_TEMPLATES % \u0027modify\u0027,"},{"line_number":40,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":41,"context_line":"        description\u003d\u0027Update job tempĺate.\u0027,"},{"line_number":42,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v2/job-templates/{job_temp_id}\u0027,"},{"line_number":43,"context_line":"                     \u0027method\u0027: \u0027PATCH\u0027}]),"},{"line_number":44,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_9cdbe7eb","line":41,"in_reply_to":"3f4b6375_4b649222","updated":"2017-10-23 13:31:43.000000000","message":"Very weird, I can\u0027t see this character here","commit_id":"06f200f9242cd5fd2d53ab90b89c68cdd2bdc664"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"07202ec9119ac079c686da78b033fdb168d81149","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":39,"context_line":"        name\u003dbase.DATA_PROCESSING_JOB_TEMPLATES % \u0027modify\u0027,"},{"line_number":40,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":41,"context_line":"        description\u003d\u0027Update job tempĺate.\u0027,"},{"line_number":42,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v2/job-templates/{job_temp_id}\u0027,"},{"line_number":43,"context_line":"                     \u0027method\u0027: \u0027PATCH\u0027}]),"},{"line_number":44,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_250f488a","line":41,"in_reply_to":"3f4b6375_fff65ff9","updated":"2017-10-22 23:57:31.000000000","message":"um, maybe I did something wrong but I don\u0027t get that ascii error when I pull the code and look at it","commit_id":"06f200f9242cd5fd2d53ab90b89c68cdd2bdc664"}],"sahara/common/policies/jobs.py":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"526b8440d382b2b40689470cc453a64ff3f30afd","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":59,"context_line":"        name\u003dbase.DATA_PROCESSING_JOBS % \u0027get_config_hints\u0027,"},{"line_number":60,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":61,"context_line":"        description\u003d\u0027Get job config hints.\u0027,"},{"line_number":62,"context_line":"        operations\u003d[{\u0027path\u0027:"},{"line_number":63,"context_line":"                     \u0027/v1.1/{project_id}/jobs/get_config_hints/{job_type}\u0027,"},{"line_number":64,"context_line":"                     \u0027method\u0027: \u0027GET\u0027}]),"},{"line_number":65,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":66,"context_line":"        name\u003dbase.DATA_PROCESSING_JOBS % \u0027delete\u0027,"},{"line_number":67,"context_line":"        check_str\u003dbase.UNPROTECTED,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f4b6375_5caf1394","line":64,"range":{"start_line":61,"start_character":8,"end_line":64,"end_character":40},"updated":"2017-10-18 16:40:02.000000000","message":"does v2 not have the config hints?","commit_id":"237a63a77d701ae981d57dd76287b16c3da29fe7"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"f210f2b34bd844292d33f04e8e0dbd16662e017c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":59,"context_line":"        name\u003dbase.DATA_PROCESSING_JOBS % \u0027get_config_hints\u0027,"},{"line_number":60,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":61,"context_line":"        description\u003d\u0027Get job config hints.\u0027,"},{"line_number":62,"context_line":"        operations\u003d[{\u0027path\u0027:"},{"line_number":63,"context_line":"                     \u0027/v1.1/{project_id}/jobs/get_config_hints/{job_type}\u0027,"},{"line_number":64,"context_line":"                     \u0027method\u0027: \u0027GET\u0027}]),"},{"line_number":65,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":66,"context_line":"        name\u003dbase.DATA_PROCESSING_JOBS % \u0027delete\u0027,"},{"line_number":67,"context_line":"        check_str\u003dbase.UNPROTECTED,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f4b6375_4a74e599","line":64,"range":{"start_line":61,"start_character":8,"end_line":64,"end_character":40},"in_reply_to":"3f4b6375_5caf1394","updated":"2017-10-18 18:21:24.000000000","message":"Actually it was moved to cluster-templates, I will update it there","commit_id":"237a63a77d701ae981d57dd76287b16c3da29fe7"},{"author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"change_message_id":"533619470a09c26370183c23e906eb446f0eae41","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        name\u003dbase.DATA_PROCESSING_JOBS % \u0027get\u0027,"},{"line_number":30,"context_line":"        check_str\u003dbase.UNPROTECTED,"},{"line_number":31,"context_line":"        description\u003d\u0027Show job details.\u0027,"},{"line_number":32,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/jobs/{job_id}\u0027,"},{"line_number":33,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":34,"context_line":"                    {\u0027path\u0027: \u0027/v2/jobs/{job_id}\u0027,"},{"line_number":35,"context_line":"                     \u0027method\u0027: \u0027GET\u0027}]),"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_f056b706","line":32,"range":{"start_line":32,"start_character":30,"end_line":32,"end_character":62},"updated":"2017-10-20 01:14:46.000000000","message":"One of problem in API v1 is inaccurate name for method endpoints, for example \"jobs\" instead of \"job-templates\". \nHere, this URI means show job template detail other than show job details.","commit_id":"e0c78cc6058b3c5299c6baff429c57deead03086"},{"author":{"_account_id":22689,"name":"Shu Yingya","email":"yingya.shu@easystack.cn","username":"ShuYingya"},"change_message_id":"4924b2074a521256a28c0fec06a7ac5e6309e9dd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        description\u003d\u0027Show job details.\u0027,"},{"line_number":32,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/jobs/{job_id}\u0027,"},{"line_number":33,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":34,"context_line":"                    {\u0027path\u0027: \u0027/v2/jobs/{job_id}\u0027,"},{"line_number":35,"context_line":"                     \u0027method\u0027: \u0027GET\u0027}]),"},{"line_number":36,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":37,"context_line":"        name\u003dbase.DATA_PROCESSING_JOBS % \u0027create\u0027,"},{"line_number":38,"context_line":"        check_str\u003dbase.UNPROTECTED,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_b04a7f24","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":40},"updated":"2017-10-20 01:26:16.000000000","message":"Maybe we can split the policy rules in  this file (jobs.py) by v1 or v2. And describe them separately.","commit_id":"e0c78cc6058b3c5299c6baff429c57deead03086"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"5f65272a8a40ca9ff1da5e68bacc7992df6c4b2d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        description\u003d\u0027Show job details.\u0027,"},{"line_number":32,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/jobs/{job_id}\u0027,"},{"line_number":33,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":34,"context_line":"                    {\u0027path\u0027: \u0027/v2/jobs/{job_id}\u0027,"},{"line_number":35,"context_line":"                     \u0027method\u0027: \u0027GET\u0027}]),"},{"line_number":36,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":37,"context_line":"        name\u003dbase.DATA_PROCESSING_JOBS % \u0027create\u0027,"},{"line_number":38,"context_line":"        check_str\u003dbase.UNPROTECTED,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_72d3d639","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":40},"in_reply_to":"3f4b6375_b04a7f24","updated":"2017-10-20 19:27:04.000000000","message":"I think that since the name is the same, we can keep like it is right now and remove the v1.1 once we deprecate it.","commit_id":"e0c78cc6058b3c5299c6baff429c57deead03086"}],"sahara/common/policies/plugins.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0ead3d7f6a2d7236d17b861aaa3942ee8c66647c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        operations\u003d[{"},{"line_number":51,"context_line":"            \u0027path\u0027:"},{"line_number":52,"context_line":"            plugins_v11 % \u0027/{plugin_name}/{version}/convert-config/{name}\u0027,"},{"line_number":53,"context_line":"            \u0027method\u0027: \u0027POST_FILE\u0027}]),"},{"line_number":54,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":55,"context_line":"        name\u003dbase.DATA_PROCESSING_PLUGINS % \u0027patch\u0027,"},{"line_number":56,"context_line":"        check_str\u003d\u0027role:admin\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_42249ac6","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":32},"updated":"2017-10-05 13:25:08.000000000","message":"Is this just a POST?","commit_id":"fdb8f143e285b1c4183c7e9e7130fd84d0ea23c7"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"526b8440d382b2b40689470cc453a64ff3f30afd","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from sahara.common.policies import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"plugins_v11 \u003d \u0027/v1.1/{project_id}/plugins%s\u0027"},{"line_number":19,"context_line":"plugins_v2 \u003d \u0027/v2/{project_id}/plugins%s\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"plugins_policies \u003d ["},{"line_number":22,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":15,"id":"3f4b6375_1c7abb23","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":41},"updated":"2017-10-18 16:40:02.000000000","message":"a little strange that you only used these sometimes.","commit_id":"237a63a77d701ae981d57dd76287b16c3da29fe7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"24c915c24a74c85e3f77c1e980725b4fe8591178","unresolved":false,"context_lines":[{"line_number":52,"context_line":"             \u0027method\u0027: \u0027POST\u0027}]),"},{"line_number":53,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":54,"context_line":"        name\u003dbase.DATA_PROCESSING_PLUGINS % \u0027patch\u0027,"},{"line_number":55,"context_line":"        check_str\u003d\u0027role:admin\u0027,"},{"line_number":56,"context_line":"        description\u003d\u0027Update plugin details.\u0027,"},{"line_number":57,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v1.1/{project_id}/plugins/{plugin_name}\u0027,"},{"line_number":58,"context_line":"                     \u0027method\u0027: \u0027PATCH\u0027},"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_a9aea72b","line":55,"range":{"start_line":55,"start_character":18,"end_line":55,"end_character":30},"updated":"2017-10-19 19:07:58.000000000","message":"nit: this could be shared with base, too\n\n  check_str\u003dbase.ROLE_ADMIN,","commit_id":"e758f8417c07f4f99c4c3497d6a6a0a1269e6c01"}],"sahara/service/ops.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a46a60e5d1efae1e20ee3dce9bc949469d851332","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        plugin.decommission_nodes(cluster, instances_to_delete)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    # Scaling infrastructure"},{"line_number":337,"context_line":"    # LOOK HERE"},{"line_number":338,"context_line":"    cluster \u003d c_u.change_cluster_status("},{"line_number":339,"context_line":"        cluster, c_u.CLUSTER_STATUS_SCALING)"},{"line_number":340,"context_line":"    context.set_step_type(_(\"Engine: scale cluster\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_1ed3b93a","line":337,"updated":"2017-09-20 20:18:50.000000000","message":"ehm? :)","commit_id":"e17006a74435a259d1f82abd0cf45ae55d8f3827"}],"setup.cfg":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"c92b3fa4685e64c24fdcf11c75baa29e69df1461","unresolved":false,"context_lines":[{"line_number":28,"context_line":"data_files \u003d"},{"line_number":29,"context_line":"    etc/sahara \u003d"},{"line_number":30,"context_line":"        etc/sahara/api-paste.ini"},{"line_number":31,"context_line":"        etc/sahara/policy.json"},{"line_number":32,"context_line":"        etc/sahara/rootwrap.conf"},{"line_number":33,"context_line":"    etc/sahara/rootwrap.d \u003d etc/sahara/rootwrap.d/*"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":21,"id":"3f4b6375_8c3cd6c8","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":30},"updated":"2017-10-23 14:33:41.000000000","message":"remove this, no?","commit_id":"4e5c7cb1403847c60b7e75544e2982c0027aa1c7"}],"tox.ini":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0ead3d7f6a2d7236d17b861aaa3942ee8c66647c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    bandit -c bandit.yaml -r sahara -n5 -p sahara_default -x tests"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:genpolicy]"},{"line_number":40,"context_line":"commands \u003d oslopolicy-sample-generator --config-file tools/config/sahara-policy-generator.conf"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[testenv:venv]"},{"line_number":43,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":7,"id":"7f515b1d_fd344be0","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":8},"updated":"2017-10-05 13:25:08.000000000","message":"A subsequent patch can make sure this is being used to generate sample policy files in sahara\u0027s documentation. Kind of like what we did here: \n\nhttps://github.com/openstack/keystone/blob/244bfb6d90fe470b7a42afc2e97ea3c49ce039a9/doc/source/configuration/policy.rst\n\nWhich renders:\n\nhttps://docs.openstack.org/keystone/latest/configuration/policy.html","commit_id":"fdb8f143e285b1c4183c7e9e7130fd84d0ea23c7"}]}
