)]}'
{"sahara/plugins/mapr/resources/images/centos/install_scala":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"581913d720c1c0eb60e4e5b6f5cdc3c9d71fe0cb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"       VERSION\u003d\"$(curl -s --fail http://www.scala-lang.org| tr -d \u0027\\n\u0027 | sed \u0027s/^.*\u003cdiv[^\u003c]\\+scala-version\"\u003e[^0-9]\\+\\([0-9\\.\\?]\\+\\)\u003c.\\+$/\\1/\u0027)\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"       if [ $? !\u003d 0 -o -z \"${VERSION}\" ]; then"},{"line_number":20,"context_line":"           echo \"Installing default version 2.11.6\""},{"line_number":21,"context_line":"           VERSION\u003d\"2.11.6\""},{"line_number":22,"context_line":"       fi"},{"line_number":23,"context_line":"   fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf659307_e9abd084","line":20,"updated":"2018-04-13 13:51:58.000000000","message":"As the value is used twice, I would use a variable.","commit_id":"c58075f8d8c498db0b0ed3d75fde0ad6024a664e"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"ebe383d6c2d05a759e88081c06d023d021588df8","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"echo \"START: installing Scala\""},{"line_number":4,"context_line":"sudo yum -y update"},{"line_number":5,"context_line":"DEF_VERSION\u003d\"2.11.6\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ $test_only -eq 0 ]; then"},{"line_number":8,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9f6a8fd7_2135c4f7","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":11},"updated":"2018-04-19 16:26:14.000000000","message":"not a huge fan of the abbreviation\n\nDEFAULT_VERSION would be nicer","commit_id":"2a1d92c89c99acf3f017060df8e669ba41a0f971"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"9949ea84ec12dc0433da1cf7e1b894050fadf1f0","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"echo \"START: installing Scala\""},{"line_number":4,"context_line":"sudo yum -y update"},{"line_number":5,"context_line":"DEF_VERSION\u003d\"2.11.6\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ $test_only -eq 0 ]; then"},{"line_number":8,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9f6a8fd7_1c8ee32d","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":11},"in_reply_to":"9f6a8fd7_2135c4f7","updated":"2018-04-19 16:32:11.000000000","message":"As historical reference, I suspect it\u0027s just the name used in the dib element used as starting point:\nhttps://git.openstack.org/cgit/openstack/sahara-image-elements/tree/elements/hadoop-mapr/install.d/41-scala?h\u003dstable%2Fqueens#n12","commit_id":"2a1d92c89c99acf3f017060df8e669ba41a0f971"}],"sahara/plugins/mapr/resources/images/image.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"581913d720c1c0eb60e4e5b6f5cdc3c9d71fe0cb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    required: False"},{"line_number":13,"context_line":"  scala_version:"},{"line_number":14,"context_line":"    default: 1"},{"line_number":15,"context_line":"    description: The version of scala to install. Defaults to 1."},{"line_number":16,"context_line":"    hidden: True"},{"line_number":17,"context_line":"    required: False"},{"line_number":18,"context_line":"  hdfs_lib_dir:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_6997c046","line":15,"updated":"2018-04-13 13:51:58.000000000","message":"I would describe what \"1\" means (fallback to autodetection or good-known value, depending on the distribution)","commit_id":"c58075f8d8c498db0b0ed3d75fde0ad6024a664e"}],"sahara/plugins/mapr/resources/images/ubuntu/install_scala":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"581913d720c1c0eb60e4e5b6f5cdc3c9d71fe0cb","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"   if [ \"${scala_version}\" !\u003d \"1\" ]; then"},{"line_number":15,"context_line":"       VERSION\u003d$scala_version"},{"line_number":16,"context_line":"   else"},{"line_number":17,"context_line":"       VERSION\u003d\"$(curl -s --fail http://www.scala-lang.org| tr -d \u0027\\n\u0027 | sed \u0027s/^.*\u003cdiv[^\u003c]\\+scala-version\"\u003e[^0-9]\\+\\([0-9\\.\\?]\\+\\)\u003c.\\+$/\\1/\u0027)\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"       if [ $? !\u003d 0 -o -z \"${VERSION}\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf659307_a9ccf888","line":16,"updated":"2018-04-13 13:51:58.000000000","message":"In this case, the fallback should kick in before checking the version on the website, at least for trusty. As long as only MapR 5.x is supported, this means that the curl... part will never be triggered. Up to you if you want to remove it for now or keep it so that\u0027s not forgotten.\n\n(what is the cleanest way to check the version of ubuntu used?)","commit_id":"c58075f8d8c498db0b0ed3d75fde0ad6024a664e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"581913d720c1c0eb60e4e5b6f5cdc3c9d71fe0cb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"       VERSION\u003d\"$(curl -s --fail http://www.scala-lang.org| tr -d \u0027\\n\u0027 | sed \u0027s/^.*\u003cdiv[^\u003c]\\+scala-version\"\u003e[^0-9]\\+\\([0-9\\.\\?]\\+\\)\u003c.\\+$/\\1/\u0027)\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"       if [ $? !\u003d 0 -o -z \"${VERSION}\" ]; then"},{"line_number":20,"context_line":"           echo \"Installing default version 2.11.6\""},{"line_number":21,"context_line":"           VERSION\u003d\"2.11.6\""},{"line_number":22,"context_line":"       fi"},{"line_number":23,"context_line":"   fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf659307_09a3a4b3","line":20,"updated":"2018-04-13 13:51:58.000000000","message":"As the value is used twice, I would use a variable (see the other file)","commit_id":"c58075f8d8c498db0b0ed3d75fde0ad6024a664e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1c3ac987634042960d6cbe2d011c54a1f2ea6346","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        echo \"http://www.scala-lang.org is unreachable\" \u0026\u0026 exit 1"},{"line_number":10,"context_line":"    fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    if [ $(lsb_release -a | grep \"trusty\" | wc -l) \u003d\u003d 0 ]; then"},{"line_number":13,"context_line":"        VERSION\u003d${DEF_VERSION}"},{"line_number":14,"context_line":"    else"},{"line_number":15,"context_line":"        if [ \"${scala_version}\" !\u003d \"1\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_94320cf1","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":49},"updated":"2018-04-17 14:37:58.000000000","message":"$(lsb_release -c -s) seems to return exactly trusty","commit_id":"24de59209d4e90b5ee85a5c9900640990f72e013"}]}