)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7125,"name":"Alexander Ignatov","email":"aignatov@mirantis.com","username":"aignatov"},"change_message_id":"24e2b0763d44d9f780f94f351468a4099811d60e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"should handle processes names."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially implements: blueprint edp-plugin-communication"},{"line_number":13,"context_line":"Closes-Bug: #1251750"},{"line_number":14,"context_line":"Partial-Bug: #1279360"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If1f84ce7672763034aadc28871b77fa0ba419adc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"AAAAXH%2F%2FRbE%3D","line":13,"updated":"2014-04-22 20:40:50.000000000","message":"The current state of patch doesn\u0027t fix bug #1251750 completely. Only part of it, since you are moved only vanilla plugin related utils.","commit_id":"f34bf94e203ebd92cadb664ec62ed09dc5aba2b0"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"856bd1b0a98f7e8f504016db33ac2ab87d94d468","unresolved":false,"context_lines":[{"line_number":10,"context_line":"should handle processes names."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially implements: blueprint edp-plugin-communication"},{"line_number":13,"context_line":"Closes-Bug: #1251750"},{"line_number":14,"context_line":"Partial-Bug: #1279360"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If1f84ce7672763034aadc28871b77fa0ba419adc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"AAAAXH%2F%2FQSE%3D","line":13,"in_reply_to":"AAAAXH%2F%2FRbE%3D","updated":"2014-04-23 00:19:26.000000000","message":"HDP doesn\u0027t use general units. IDH was removed. So, only vanilla need to be changed.","commit_id":"f34bf94e203ebd92cadb664ec62ed09dc5aba2b0"},{"author":{"_account_id":7125,"name":"Alexander Ignatov","email":"aignatov@mirantis.com","username":"aignatov"},"change_message_id":"24e2b0763d44d9f780f94f351468a4099811d60e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially implements: blueprint edp-plugin-communication"},{"line_number":13,"context_line":"Closes-Bug: #1251750"},{"line_number":14,"context_line":"Partial-Bug: #1279360"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If1f84ce7672763034aadc28871b77fa0ba419adc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"AAAAXH%2F%2FRa8%3D","line":14,"updated":"2014-04-22 20:40:50.000000000","message":"Could you please give some info how this bug can fix Hive related bug?","commit_id":"f34bf94e203ebd92cadb664ec62ed09dc5aba2b0"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"856bd1b0a98f7e8f504016db33ac2ab87d94d468","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially implements: blueprint edp-plugin-communication"},{"line_number":13,"context_line":"Closes-Bug: #1251750"},{"line_number":14,"context_line":"Partial-Bug: #1279360"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If1f84ce7672763034aadc28871b77fa0ba419adc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"AAAAXH%2F%2FQSU%3D","line":14,"in_reply_to":"AAAAXH%2F%2FRa8%3D","updated":"2014-04-23 00:19:26.000000000","message":"It was before when EDP communicated with plugins via general units. Removed line.","commit_id":"f34bf94e203ebd92cadb664ec62ed09dc5aba2b0"}],"savanna/plugins/hdp/ambariplugin.py":[{"author":{"_account_id":7737,"name":"Jonathan Maron","email":"jmaron@hortonworks.com","username":"jmaron"},"change_message_id":"6ffe2fd53bda240b7d2a844a5cabe4aea99b134c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def get_resource_manager(self, cluster):"},{"line_number":146,"context_line":"        return u.get_instance(cluster, \"jobtracker\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def get_hive_server(self, cluster):"},{"line_number":149,"context_line":"        return u.get_instance(cluster, \"hiveserver\")"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def update_infra(self, cluster):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FBsk%3D","line":148,"updated":"2014-02-17 15:20:30.000000000","message":"\"hiveserver\" won\u0027t work for HDP.  The component is referenced by \"hive_server\"","commit_id":"4a5741cb4c2157ef13a657fa0d95625bb2cf84de"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"389eec6e9a4b0cafac51d916b27411e4d8738c9c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def get_resource_manager(self, cluster):"},{"line_number":146,"context_line":"        return u.get_instance(cluster, \"jobtracker\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def get_hive_server(self, cluster):"},{"line_number":149,"context_line":"        return u.get_instance(cluster, \"hiveserver\")"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def update_infra(self, cluster):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2B%2FJQ%3D","line":148,"in_reply_to":"AAAAUX%2F%2FBsk%3D","updated":"2014-02-17 19:53:21.000000000","message":"This is different CR: see https://review.openstack.org/#/c/73881/ . This one for refactoring only.","commit_id":"4a5741cb4c2157ef13a657fa0d95625bb2cf84de"},{"author":{"_account_id":8304,"name":"John Speidel","email":"jspeidel@hortonworks.com","username":"jspeidel"},"change_message_id":"dea662b6471fb2cbe0591e2048d47afe8ccd2143","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return instance"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def get_hive_server(self, cluster):"},{"line_number":158,"context_line":"        return u.get_instance(cluster, \"hiveserver\")"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def update_infra(self, cluster):"},{"line_number":161,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BVoM%3D","line":158,"updated":"2014-02-21 19:28:47.000000000","message":"should be hive_server","commit_id":"407c7a78bd8c7f7b69f725c599c8543f90a4a550"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"5c45b0202ef961be961732030d5414f810554211","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return instance"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def get_hive_server(self, cluster):"},{"line_number":158,"context_line":"        return u.get_instance(cluster, \"hiveserver\")"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def update_infra(self, cluster):"},{"line_number":161,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FwWo%3D","line":158,"in_reply_to":"AAAAUX%2F%2BVoM%3D","updated":"2014-02-24 23:13:23.000000000","message":"Done","commit_id":"407c7a78bd8c7f7b69f725c599c8543f90a4a550"}],"savanna/service/edp/workflow_creator/workflow_factory.py":[{"author":{"_account_id":7737,"name":"Jonathan Maron","email":"jmaron@hortonworks.com","username":"jmaron"},"change_message_id":"6ffe2fd53bda240b7d2a844a5cabe4aea99b134c","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def configure_workflow_if_needed(self, cluster, wf_dir):"},{"line_number":147,"context_line":"        plugin \u003d plugin_base.PLUGINS.get_plugin(cluster.plugin_name)"},{"line_number":148,"context_line":"        h_s \u003d plugin.get_hiveserver(cluster)"},{"line_number":149,"context_line":"        hdfs_user \u003d plugin.get_hdfs_user()"},{"line_number":150,"context_line":"        h.copy_from_local(remote.get_remote(h_s),"},{"line_number":151,"context_line":"                          plugin.get_hive_config_path(), wf_dir, hdfs_user)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FBp8%3D","line":148,"updated":"2014-02-17 15:20:30.000000000","message":"I believe the method is actually plugin.get_hive_server(), not plugin.get_hiveserver()","commit_id":"4a5741cb4c2157ef13a657fa0d95625bb2cf84de"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"389eec6e9a4b0cafac51d916b27411e4d8738c9c","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def configure_workflow_if_needed(self, cluster, wf_dir):"},{"line_number":147,"context_line":"        plugin \u003d plugin_base.PLUGINS.get_plugin(cluster.plugin_name)"},{"line_number":148,"context_line":"        h_s \u003d plugin.get_hiveserver(cluster)"},{"line_number":149,"context_line":"        hdfs_user \u003d plugin.get_hdfs_user()"},{"line_number":150,"context_line":"        h.copy_from_local(remote.get_remote(h_s),"},{"line_number":151,"context_line":"                          plugin.get_hive_config_path(), wf_dir, hdfs_user)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2B%2FIU%3D","line":148,"in_reply_to":"AAAAUX%2F%2FBp8%3D","updated":"2014-02-17 19:53:21.000000000","message":"Indeed. Wonder how unit and integration tests passed. Do we use this method?","commit_id":"4a5741cb4c2157ef13a657fa0d95625bb2cf84de"},{"author":{"_account_id":8304,"name":"John Speidel","email":"jspeidel@hortonworks.com","username":"jspeidel"},"change_message_id":"dea662b6471fb2cbe0591e2048d47afe8ccd2143","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def configure_workflow_if_needed(self, cluster, wf_dir):"},{"line_number":147,"context_line":"        plugin \u003d plugin_base.PLUGINS.get_plugin(cluster.plugin_name)"},{"line_number":148,"context_line":"        h_s \u003d plugin.get_hive_server(cluster)"},{"line_number":149,"context_line":"        hdfs_user \u003d plugin.get_hdfs_user()"},{"line_number":150,"context_line":"        h.copy_from_local(remote.get_remote(h_s),"},{"line_number":151,"context_line":"                          plugin.get_hive_config_path(), wf_dir, hdfs_user)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BVi4%3D","line":148,"updated":"2014-02-21 19:28:47.000000000","message":"really minor comment.\nI think this is a terrible variable name as it is not descriptive at all.","commit_id":"407c7a78bd8c7f7b69f725c599c8543f90a4a550"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"5c45b0202ef961be961732030d5414f810554211","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def configure_workflow_if_needed(self, cluster, wf_dir):"},{"line_number":147,"context_line":"        plugin \u003d plugin_base.PLUGINS.get_plugin(cluster.plugin_name)"},{"line_number":148,"context_line":"        h_s \u003d plugin.get_hive_server(cluster)"},{"line_number":149,"context_line":"        hdfs_user \u003d plugin.get_hdfs_user()"},{"line_number":150,"context_line":"        h.copy_from_local(remote.get_remote(h_s),"},{"line_number":151,"context_line":"                          plugin.get_hive_config_path(), wf_dir, hdfs_user)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FwVw%3D","line":148,"in_reply_to":"AAAAUX%2F%2BUUY%3D","updated":"2014-02-24 23:13:23.000000000","message":"Done","commit_id":"407c7a78bd8c7f7b69f725c599c8543f90a4a550"},{"author":{"_account_id":8304,"name":"John Speidel","email":"jspeidel@hortonworks.com","username":"jspeidel"},"change_message_id":"4d33b1e0961fa2291e289f74b9a3dade39088b3e","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def configure_workflow_if_needed(self, cluster, wf_dir):"},{"line_number":147,"context_line":"        plugin \u003d plugin_base.PLUGINS.get_plugin(cluster.plugin_name)"},{"line_number":148,"context_line":"        h_s \u003d plugin.get_hive_server(cluster)"},{"line_number":149,"context_line":"        hdfs_user \u003d plugin.get_hdfs_user()"},{"line_number":150,"context_line":"        h.copy_from_local(remote.get_remote(h_s),"},{"line_number":151,"context_line":"                          plugin.get_hive_config_path(), wf_dir, hdfs_user)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BUUY%3D","line":148,"in_reply_to":"AAAAUX%2F%2BVas%3D","updated":"2014-02-21 22:26:55.000000000","message":"yeah, should have mentioned that it had already existed with this name.","commit_id":"407c7a78bd8c7f7b69f725c599c8543f90a4a550"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"9f41d0c29ea8a20b20b2bde7a797426c46dd9ccb","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def configure_workflow_if_needed(self, cluster, wf_dir):"},{"line_number":147,"context_line":"        plugin \u003d plugin_base.PLUGINS.get_plugin(cluster.plugin_name)"},{"line_number":148,"context_line":"        h_s \u003d plugin.get_hive_server(cluster)"},{"line_number":149,"context_line":"        hdfs_user \u003d plugin.get_hdfs_user()"},{"line_number":150,"context_line":"        h.copy_from_local(remote.get_remote(h_s),"},{"line_number":151,"context_line":"                          plugin.get_hive_config_path(), wf_dir, hdfs_user)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BVas%3D","line":148,"in_reply_to":"AAAAUX%2F%2BVi4%3D","updated":"2014-02-21 19:41:28.000000000","message":"It was here before. But anyway, it is better to change it. Thanks.","commit_id":"407c7a78bd8c7f7b69f725c599c8543f90a4a550"},{"author":{"_account_id":9499,"name":"Robert Nettleton","email":"rnettleton@hortonworks.com","username":"rnettleton"},"change_message_id":"49aab85000f7d57f32b19fe74a232a3de36109d2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        plugin \u003d plugin_base.PLUGINS.get_plugin(cluster.plugin_name)"},{"line_number":148,"context_line":"        hive_server \u003d plugin.get_hive_server(cluster)"},{"line_number":149,"context_line":"        h.copy_from_local(remote.get_remote(hive_server),"},{"line_number":150,"context_line":"                          plugin.get_hive_config_path(), wf_dir,"},{"line_number":151,"context_line":"                          plugin.get_hdfs_user())"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2F4WI%3D","line":150,"updated":"2014-03-03 16:59:37.000000000","message":"Would it be possible to modify the get_hive_config_path() method to take a cluster instance as an argument?  \n\nAt HWX, we\u0027ve been working on a change that is similar to this patch, but we should be able to abandon our patch provided that the HDP plugin can be passed a cluster instance during get_hive_config_path(). The HDP plugin utilizes the cluster instance to determine the location for the hive configuration file, rather than use a hard-coded location.  \n\nWe could then build a subsequent patch to the HDP plugin that returns the correct configuration path for HDP.","commit_id":"8577dc6b9fc0ab4360efba47b0a3a43f4fa62497"}]}