)]}'
{"id":"openstack%2Fsahara~737513","triplet_id":"openstack%2Fsahara~master~Ic0d8c9e1025cd05f4042f1c5ba440cc03a0b5834","project":"openstack/sahara","branch":"master","hashtags":[],"change_id":"Ic0d8c9e1025cd05f4042f1c5ba440cc03a0b5834","subject":"Switch from unittest2 compat methods to Python 3.x methods","status":"MERGED","created":"2020-06-23 12:19:52.000000000","updated":"2020-06-24 17:17:06.000000000","submitted":"2020-06-24 17:14:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"737513-1593018896185-91b529dc","meta_rev_id":"70c570a8d3849c8e0385d0c64b6f2ef71810269e","_number":737513,"virtual_id_number":737513,"owner":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-24 17:14:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"all":[{"value":2,"date":"2020-06-24 16:10:43.000000000","_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},{"value":2,"date":"2020-06-23 23:32:52.000000000","_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"all":[{"value":1,"date":"2020-06-24 16:10:43.000000000","_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-23 23:32:52.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"},{"updated":"2020-06-24 16:10:43.000000000","updated_by":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"reviewer":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"state":"REVIEWER"},{"updated":"2020-06-24 17:14:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"34fe6ee71b045bcf4fc126d0d4cc13b62c582516","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2020-06-23 12:19:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c1829c5ce61b42466c215bc2737aa84227df885a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 14:32:05.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d3de28099877420a9bf0f516e9252089 : SUCCESS in 9m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e8f527eb88ca4651b57c842b17b33a25 : POST_FAILURE in 7m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/57ea11a0191b44dfb0880a643a67a4f7 : SUCCESS in 8m 23s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9de99fe08610466880f5b861b701b0c6 : SUCCESS in 7m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a57ba48854cf483cab78ec757e02412b : SUCCESS in 6m 11s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/87eeac34c90e41b8917cb03088b09d1c : SUCCESS in 5m 41s (non-voting)\n- sahara-tests-scenario https://zuul.opendev.org/t/openstack/build/8511217f553b402fbe2d8e20d10c352b : POST_FAILURE in 25m 36s\n- sahara-tests-scenario-v2 https://zuul.opendev.org/t/openstack/build/a760203d3a664b6e99bb02c9e52ef438 : POST_FAILURE in 41m 22s\n- sahara-tests-tempest https://zuul.opendev.org/t/openstack/build/883d5a3941d14f88bcba7831234e2b46 : TIMED_OUT in 2h 08m 46s\n- sahara-tests-tempest-v2 https://zuul.opendev.org/t/openstack/build/5c363c6cd9e2498bb42ef528bc476b7e : SUCCESS in 50m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2e8e21693e774a618dc6819f08986a45 : SUCCESS in 13m 29s (non-voting)\n- sahara-openstack-ansible-functional https://zuul.opendev.org/t/openstack/build/0793477621a54cb198e35dc5264b6b30 : POST_FAILURE in 1h 00m 42s\n\nWarning:\n  Comments left for invalid file devstack/upgrade/from-mitaka/upgrade-sahara\n  Comments left for invalid file devstack/upgrade/resources.sh\n  Comments left for invalid file devstack/settings\n  Comments left for invalid file devstack/plugin.sh","accounts_in_message":[],"_revision_number":1},{"id":"6fb307e4b49eaa6b70e1941860c7030d6fa5d64f","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-06-23 21:52:55.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"5114326bdf7a4ad246410a1cf3dd44f67ace82f3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 22:52:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/83268bc49fad480ab91c755b1a171fc7 : SUCCESS in 8m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c86622641eed4c069cc02ca453d1adf3 : SUCCESS in 7m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/487b6a2f81ad4413ac26d0d9e7974512 : SUCCESS in 6m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/532e7243cee640579a3059edc5ec3e7f : SUCCESS in 7m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/539b8ddab8464ad2a5f36dfdb1bbb01d : SUCCESS in 6m 29s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/1ec84f56a1834bccb5151e55580545eb : SUCCESS in 5m 17s (non-voting)\n- sahara-tests-scenario https://zuul.opendev.org/t/openstack/build/a78173c965424f2ba1379fff57e3934f : SUCCESS in 52m 10s\n- sahara-tests-scenario-v2 https://zuul.opendev.org/t/openstack/build/32e9e2f7cfef45fdb1b7ed94939f3709 : SUCCESS in 31m 32s\n- sahara-tests-tempest https://zuul.opendev.org/t/openstack/build/48ff7c62186f47e7aab08c9a06992a37 : SUCCESS in 43m 13s\n- sahara-tests-tempest-v2 https://zuul.opendev.org/t/openstack/build/4aecbc67d43f4f7c86292c9c48c6cb8e : SUCCESS in 45m 00s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/37ae4ff5141e44e5a4190114949ac880 : FAILURE in 7m 56s (non-voting)\n- sahara-openstack-ansible-functional https://zuul.opendev.org/t/openstack/build/39d4046d0ca14cfd92894a58eea9c7c9 : SUCCESS in 42m 09s\n\nWarning:\n  Comments left for invalid file devstack/plugin.sh\n  Comments left for invalid file devstack/settings\n  Comments left for invalid file devstack/upgrade/resources.sh\n  Comments left for invalid file devstack/upgrade/from-mitaka/upgrade-sahara","accounts_in_message":[],"_revision_number":1},{"id":"08dd3c805b11671083c74caf8a04d6d6abe9fcff","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-06-23 23:32:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cb6e20dba494fbb18cc5d6b5b9e17de6c2dd196f","author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"date":"2020-06-24 16:10:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0990bd49e154b1e157735fc5cbdfd42817a61531","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 16:10:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4f8d54013c023f750cf7ec19f66f043cc2a98d2a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 17:14:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5fb5f0e2e80e4451a4e61f483651d92e : SUCCESS in 12m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dce00055257f4ce080403892728e99a5 : SUCCESS in 11m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fc31d26a0c3b4dedadc4fe4a3d0c7036 : SUCCESS in 12m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/299d144aa3704b919b8a66fd52b595f6 : SUCCESS in 9m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a251844880e148bca835e719e2d9418d : SUCCESS in 8m 22s\n- sahara-tests-scenario https://zuul.opendev.org/t/openstack/build/a9b4c3447e3b41ae9fdda7c299e71612 : SUCCESS in 47m 52s\n- sahara-tests-scenario-v2 https://zuul.opendev.org/t/openstack/build/61148c3ab7e3403ea926c2a2756bafcb : SUCCESS in 39m 51s\n- sahara-tests-tempest https://zuul.opendev.org/t/openstack/build/a6740edf995d4fbc8b9127a89beb774f : SUCCESS in 59m 12s\n- sahara-tests-tempest-v2 https://zuul.opendev.org/t/openstack/build/fe886c0d720846728f18a9c6786b724b : SUCCESS in 38m 53s\n- sahara-openstack-ansible-functional https://zuul.opendev.org/t/openstack/build/ac05519b37774cf3a71539bc1cd4c0a9 : SUCCESS in 45m 52s\n\nWarning:\n  Comments left for invalid file devstack/plugin.sh\n  Comments left for invalid file devstack/settings\n  Comments left for invalid file devstack/upgrade/resources.sh\n  Comments left for invalid file devstack/upgrade/from-mitaka/upgrade-sahara","accounts_in_message":[],"_revision_number":1},{"id":"eca90d6bff5e1af8834b101e58bfd77d370d9570","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 17:14:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"70c570a8d3849c8e0385d0c64b6f2ef71810269e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 17:17:06.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/11b51ca5fc4b441b8ce5407e150c0935 : SUCCESS in 1m 31s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3f004e6a9fd52fb2aa0b34946a4c1b4aabb71570","revisions":{"3f004e6a9fd52fb2aa0b34946a4c1b4aabb71570":{"kind":"REWORK","_number":1,"created":"2020-06-23 12:19:52.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/13/737513/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/sahara","ref":"refs/changes/13/737513/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/sahara refs/changes/13/737513/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/sahara refs/changes/13/737513/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/sahara refs/changes/13/737513/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/sahara refs/changes/13/737513/1"}}},"commit":{"parents":[{"commit":"81bae85a9a5457a2c74a528d9501f998013d0197","subject":"Stop to use the __future__ module.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sahara/commit/81bae85a9a5457a2c74a528d9501f998013d0197"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2020-06-23 12:19:29.000000000","tz":120},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2020-06-23 12:19:43.000000000","tz":120},"subject":"Switch from unittest2 compat methods to Python 3.x methods","message":"Switch from unittest2 compat methods to Python 3.x methods\n\nWith the removal of Python 2.x we can remove the unittest2 compat\nwrappers and switch to assertCountEqual instead of assertItemsEqual\n\nWe have been able to use them since then, because\ntesttools required unittest2, which still included it. With testtools\nremoving Python 2.7 support [3][4], we will lose support for\nassertItemsEqual, so we should switch to use assertCountEqual.\n\n[1] - https://bugs.python.org/issue17866\n[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd\n[3] - testing-cabal/testtools#286\n[4] - testing-cabal/testtools#277\n\nChange-Id: Ic0d8c9e1025cd05f4042f1c5ba440cc03a0b5834\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sahara/commit/3f004e6a9fd52fb2aa0b34946a4c1b4aabb71570"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sahara/commit/3f004e6a9fd52fb2aa0b34946a4c1b4aabb71570"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}