)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"375c95e70f836c987a4d799f0b7e79e6d3e9681e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"689179fc_70ada0b2","updated":"2022-04-15 19:30:53.000000000","message":"Hi Stephen, I\u0027m a bit puzzled. I thought I\u0027ve followed the examples and when running locally (on Fedora 35) the tests pass for all 3 environments (py36, py38, py39). What am I missing?","commit_id":"58813ab0865f8c1d367c60dbef853ea18cd80d65"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1fe8174321c0a8484d160f53d083ab33f0140d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"87728512_561eb065","in_reply_to":"689179fc_70ada0b2","updated":"2022-04-19 11:14:53.000000000","message":"Weird. I wonder if you\u0027re actually running what you think you\u0027re running? This failed locally for me with:\n\n  $ tox -e py38 -- -n sahara/tests/unit/db/migration/test_migrations.py\n\nSuggestion inline to resolve this in any case.","commit_id":"58813ab0865f8c1d367c60dbef853ea18cd80d65"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a09c08538e6bbbc2c30e27dc0ebe6070f841d440","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f635f39c_9d8b48e2","in_reply_to":"87728512_561eb065","updated":"2022-04-19 12:08:13.000000000","message":"Uhm, I was sure I\u0027ve tested the change with the patches. I\u0027ve rechecked my environment and it matches what I remembered. Not sure what\u0027s happened :/","commit_id":"58813ab0865f8c1d367c60dbef853ea18cd80d65"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a09c08538e6bbbc2c30e27dc0ebe6070f841d440","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8262e830_8456704d","updated":"2022-04-19 12:08:13.000000000","message":"+1 for now as I\u0027ve co-written it, but I will bump if the oslo.db removal needs to proceed","commit_id":"2627d3433b61d78c46ecd812739fab7534c73ea5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"671d23bee62d4c886896489d5078e162f11dbc31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6cf25d9a_751a9096","updated":"2022-04-19 11:17:53.000000000","message":"Fixed the issue. This looks sensible to me now","commit_id":"2627d3433b61d78c46ecd812739fab7534c73ea5"}],"sahara/tests/unit/db/migration/test_migrations.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1fe8174321c0a8484d160f53d083ab33f0140d2","unresolved":true,"context_lines":[{"line_number":649,"context_line":"                          base.TestModelsMigrationsSync,"},{"line_number":650,"context_line":"                          test_fixtures.OpportunisticDBTestMixin,"},{"line_number":651,"context_line":"                          test_base.BaseTestCase):"},{"line_number":652,"context_line":"    FIXTURE \u003d test_fixtures.MySQLOpportunisticFixture"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"class TestMigrationsPostgresql(SaharaMigrationsCheckers,"}],"source_content_type":"text/x-python","patch_set":2,"id":"cdd9b245_507c336f","line":652,"updated":"2022-04-19 11:14:53.000000000","message":"You need to define the \u0027self.engine\u0027 attribute here or in \u0027SaharaMigrationsCheckers\u0027\n\n  self.engine \u003d enginefacade.writer.get_engine()\n\nshould do the trick. This is what nova does (nova/tests/unit/db/main/test_migrations.py) and what\u0027s proposed for murano [1]\n\n[1] https://review.opendev.org/c/openstack/murano/+/838412/1/murano/tests/unit/db/migration/test_migrations.py#47","commit_id":"58813ab0865f8c1d367c60dbef853ea18cd80d65"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a09c08538e6bbbc2c30e27dc0ebe6070f841d440","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                          base.TestModelsMigrationsSync,"},{"line_number":650,"context_line":"                          test_fixtures.OpportunisticDBTestMixin,"},{"line_number":651,"context_line":"                          test_base.BaseTestCase):"},{"line_number":652,"context_line":"    FIXTURE \u003d test_fixtures.MySQLOpportunisticFixture"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"class TestMigrationsPostgresql(SaharaMigrationsCheckers,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e8661be1_65196652","line":652,"in_reply_to":"36b53902_a3b77a04","updated":"2022-04-19 12:08:13.000000000","message":"Thanks, I thought that was part of the other fix related to facede. But I was probably partially on vacation that day and I misread that.\n\nThanks again for the fix, much appreciated!","commit_id":"58813ab0865f8c1d367c60dbef853ea18cd80d65"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08a68fe846f23397cf4ee057a2fcd4c3cc69a889","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                          base.TestModelsMigrationsSync,"},{"line_number":650,"context_line":"                          test_fixtures.OpportunisticDBTestMixin,"},{"line_number":651,"context_line":"                          test_base.BaseTestCase):"},{"line_number":652,"context_line":"    FIXTURE \u003d test_fixtures.MySQLOpportunisticFixture"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"class TestMigrationsPostgresql(SaharaMigrationsCheckers,"}],"source_content_type":"text/x-python","patch_set":2,"id":"36b53902_a3b77a04","line":652,"in_reply_to":"cdd9b245_507c336f","updated":"2022-04-19 11:15:47.000000000","message":"Done","commit_id":"58813ab0865f8c1d367c60dbef853ea18cd80d65"}]}