)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"7a45ef138b2b275d79796a329b57248e9d517d14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"80ade152_4b1967bb","updated":"2022-08-02 17:37:37.000000000","message":"There\u0027s one remaining failure here and it is documented in the story. I doubt I will have time to get to fixing it, unfortunately.","commit_id":"b4ea6ad2465ebd15b0aa4716b83ff749486d142f"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1016f67bd0629510ecf4a02a1f1a537cbd199d65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a18f5235_4afc5b53","in_reply_to":"80ade152_4b1967bb","updated":"2022-09-05 22:36:57.000000000","message":"Thanks for all the effort. I think I may have fixed the remaining issue, what do you think? (apart maybe requirements)","commit_id":"b4ea6ad2465ebd15b0aa4716b83ff749486d142f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"445fb4e89c53e51d05b37004ddf9ac324544cbfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"25c32550_d4db3a3e","updated":"2022-11-16 13:29:40.000000000","message":"As of today Sahara is broken for Zed and Master.","commit_id":"c8599461fc77a32116e1ce33be97c771705ad5f0"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"536c324fc944fad962cc13e7f5bc95245bbd7ce6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f56fbcd3_a7cb6479","updated":"2022-11-16 13:38:47.000000000","message":"The problem is that sahara is broke with too many things at this point, we would need to disable some tests if we want to avoid squashing too many patches together.","commit_id":"c8599461fc77a32116e1ce33be97c771705ad5f0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7768183abf7e01d69545eff70d9c08b6d1e4415c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"31902b49_b9657930","in_reply_to":"94d16a52_96922ee3","updated":"2022-11-24 17:28:24.000000000","message":"I don\u0027t think it\u0027s too broken though. For example - for my simmilar patch it\u0027s broken only related to the patch itself - single unit test has failed:\nhttps://736242ba87fe1f7043c5-30e72828a36544d0c7466f2989d78bfe.ssl.cf2.rackcdn.com/864728/2/check/openstack-tox-py39/30746c1/testr_results.html","commit_id":"c8599461fc77a32116e1ce33be97c771705ad5f0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"37ed646c34ca5fcf3023e3cc0ae9b3442d1d195d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"94d16a52_96922ee3","in_reply_to":"f56fbcd3_a7cb6479","updated":"2022-11-24 17:04:37.000000000","message":"It totally does make sense to me to go this way.","commit_id":"c8599461fc77a32116e1ce33be97c771705ad5f0"}],"sahara/utils/api_validator.py":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0d5eb99e94fd61cb6d12e50bce6b23e9b9b762a3","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    return uuidutils.is_uuid_like(entry)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"@jsonschema.FormatChecker.cls_checks(\u0027posix_path\u0027)"},{"line_number":91,"context_line":"def validate_posix_path(entry):"},{"line_number":92,"context_line":"    if not isinstance(entry, six.string_types):"},{"line_number":93,"context_line":"        # should fail type validation"}],"source_content_type":"text/x-python","patch_set":4,"id":"0bf4cff6_5aeb6444","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":36},"updated":"2022-11-16 13:02:38.000000000","message":"this must also be handled somehow, as decorator has been deprecated since 4.14.0:\nhttps://python-jsonschema.readthedocs.io/en/latest/validate/#jsonschema.FormatChecker.cls_checks","commit_id":"c8599461fc77a32116e1ce33be97c771705ad5f0"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"31a8be3012ea0c3e40cd49b0988f1415e9a88073","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    return res is not None"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def config_type(checker, instance):"},{"line_number":101,"context_line":"    # configs should be dict"},{"line_number":102,"context_line":"    if not isinstance(instance, dict):"},{"line_number":103,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"9271ebb0_a000f862","line":100,"updated":"2022-09-06 01:47:37.000000000","message":"The reason for this part modification？The unittest problem caused by this code? Is the deatailed reason for this change?","commit_id":"c8599461fc77a32116e1ce33be97c771705ad5f0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"87914ba5edda5713b6b72960def1d7d86a027171","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    return res is not None"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def config_type(checker, instance):"},{"line_number":101,"context_line":"    # configs should be dict"},{"line_number":102,"context_line":"    if not isinstance(instance, dict):"},{"line_number":103,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"438a8d00_c9a26393","line":100,"in_reply_to":"9271ebb0_a000f862","updated":"2022-11-16 13:01:21.000000000","message":"Well, yes, if you check jsonschema code it uses simple functions everywhere:\n\nhttps://github.com/python-jsonschema/jsonschema/blob/v4.14.0/jsonschema/_types.py#L26-L61\n\nSo this simply does not work with current code.","commit_id":"c8599461fc77a32116e1ce33be97c771705ad5f0"}]}
