)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"a32e24ff31ec6e5afcc9fc7a08753f2ccb78e8db","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove usage of remote from HDP Instance object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The usage causes problem in distributed mode (see bug description)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0d09c7a19e4df7fce948994fb21028fe147d2782"},{"line_number":12,"context_line":"Closes-bug: #1325989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_30abbb8a","line":9,"updated":"2014-06-09 16:46:20.000000000","message":"I would say about problem here. It can be described in one line. No need to reference to bug description.","commit_id":"508adabed6b7e4d033d1150cd017dfd4e22cc03e"},{"author":{"_account_id":7555,"name":"Matthew Farrellee","email":"matt@redhat.com","username":"farrellee"},"change_message_id":"51d6537b3166731b02b4b1a8b0a020e5965a33c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove usage of remote from HDP Instance object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The usage causes problem in distributed mode (see bug description)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0d09c7a19e4df7fce948994fb21028fe147d2782"},{"line_number":12,"context_line":"Closes-bug: #1325989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_a3490cb9","line":9,"in_reply_to":"1ae5cdf2_30abbb8a","updated":"2014-06-10 21:18:33.000000000","message":"+1","commit_id":"508adabed6b7e4d033d1150cd017dfd4e22cc03e"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"fb748fc1f42fcc7390767fc212ae4ecd83ff8f64","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove usage of remote from HDP Instance object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The usage causes problem in distributed mode (see bug description)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0d09c7a19e4df7fce948994fb21028fe147d2782"},{"line_number":12,"context_line":"Closes-bug: #1325989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_9fea930d","line":9,"in_reply_to":"1ae5cdf2_a3490cb9","updated":"2014-06-11 07:03:16.000000000","message":"Don\u0027t know how to describe it in one line, but added a description as short as I can make it :-)","commit_id":"508adabed6b7e4d033d1150cd017dfd4e22cc03e"}],"sahara/plugins/hdp/clusterspec.py":[{"author":{"_account_id":7555,"name":"Matthew Farrellee","email":"matt@redhat.com","username":"farrellee"},"change_message_id":"51d6537b3166731b02b4b1a8b0a020e5965a33c7","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        return self.inst_fqdn"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def remote(self):"},{"line_number":259,"context_line":"        return self.sahara_instance.remote()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def __hash__(self):"},{"line_number":262,"context_line":"        return hash(self.fqdn())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_83e5f0a9","line":259,"updated":"2014-06-10 21:18:33.000000000","message":"what guarantees that remote() will work at this point while it fails to work during initialization?","commit_id":"508adabed6b7e4d033d1150cd017dfd4e22cc03e"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"0384be47bb7cac5510816501b3029e3d58ccdfbc","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        return self.inst_fqdn"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def remote(self):"},{"line_number":259,"context_line":"        return self.sahara_instance.remote()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def __hash__(self):"},{"line_number":262,"context_line":"        return hash(self.fqdn())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_70fa3fbe","line":259,"in_reply_to":"1ae5cdf2_14266ace","updated":"2014-06-11 19:18:04.000000000","message":"Hmm, do you think we want to add a debug level log message here that says something like \"You probably called this from the wrong Sahara context\" on an AttributeError so that a dev might be given a clue what went wrong?","commit_id":"508adabed6b7e4d033d1150cd017dfd4e22cc03e"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"fb748fc1f42fcc7390767fc212ae4ecd83ff8f64","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        return self.inst_fqdn"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def remote(self):"},{"line_number":259,"context_line":"        return self.sahara_instance.remote()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def __hash__(self):"},{"line_number":262,"context_line":"        return hash(self.fqdn())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_14266ace","line":259,"in_reply_to":"1ae5cdf2_83e5f0a9","updated":"2014-06-11 07:03:16.000000000","message":"At this moment - nothing. We assume that remote() will be called only within sahara-engine context. We need to remove the call from the constructor because Instance itself is used in sahara-api.\n\nLater we will need to work on plugins to decouple them into two parts: one for sahara-api with calls like get_configs(...), validate(...), etc. Another part - for sahara-engine with calls like update_infra(...), configure_cluster(...), etc. The decoupling should help to avoid using remote calls in sahara-api context.","commit_id":"508adabed6b7e4d033d1150cd017dfd4e22cc03e"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"d71e90e5ad9935fb511a2fd40acf4040e70667ed","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        return self.inst_fqdn"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def remote(self):"},{"line_number":259,"context_line":"        return self.sahara_instance.remote()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def __hash__(self):"},{"line_number":262,"context_line":"        return hash(self.fqdn())"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_b01767ed","line":259,"updated":"2014-06-11 19:18:28.000000000","message":"Ditto note on patch 1, do we want to catch an AttibuteError here and add a debug log message to give guidance on sahara-api vs sahara-engine context?","commit_id":"049e64a4408d6ff6ef0d3e8d10f8433e8271e991"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"a57723a1c525e7e0b502dce2c999ae373ca16f3c","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        return self.inst_fqdn"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def remote(self):"},{"line_number":259,"context_line":"        return self.sahara_instance.remote()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def __hash__(self):"},{"line_number":262,"context_line":"        return hash(self.fqdn())"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_936cc7d2","line":259,"in_reply_to":"1ae5cdf2_b01767ed","updated":"2014-06-16 08:34:21.000000000","message":"Sounds like a good idea. There are other places where the same thing is needed. So I\u0027ve made a check at the remote, as it is the source of the exception: https://review.openstack.org/#/c/100184","commit_id":"049e64a4408d6ff6ef0d3e8d10f8433e8271e991"}]}
