)]}'
{"searchlight_ui/static/searchlight-ui/searchlight-ui.scss":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"502baecfcabdc16394b33c8eaa54e127d803dca1","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// work around bootstrap bug https://github.com/twbs/bootstrap/issues/11728"},{"line_number":11,"context_line":"table.table-searchlight-search-results tr.warning td {"},{"line_number":12,"context_line":"  background-color: gold !important;"},{"line_number":13,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":3,"id":"bab6814e_60a32950","line":10,"range":{"start_line":10,"start_character":48,"end_line":10,"end_character":52},"updated":"2016-05-19 20:45:46.000000000","message":"This issue looks like it was fixed at least a year ago and possibly in 2014 - is it still present in whatever version horizon\u0027s using in mitaka/newton? I have been lectured on the inadvisability of using !important before..","commit_id":"5c620759d8874627d575c20cdf2367adfd3b90f5"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"bbb96af022e72834a762f93115413c8a74b0bf4b","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// work around bootstrap bug https://github.com/twbs/bootstrap/issues/11728"},{"line_number":11,"context_line":"table.table-searchlight-search-results tr.warning td {"},{"line_number":12,"context_line":"  background-color: gold !important;"},{"line_number":13,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":4,"id":"bab6814e_5a025e0a","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":24},"updated":"2016-05-25 13:57:37.000000000","message":"$brand-warning should be used here instead of \u0027gold.\u0027  This will then use the theme-relevant color.","commit_id":"569ec636e5a1d3ef2ffc01e6429e716905e9cfb9"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"93b13d370d46d96487c4e664ef03157964a28d5d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"// TODO (tyr) - unclear why contextual classes still not working, 11728 was fixed"},{"line_number":12,"context_line":"table.table-rsp.table-detail.table-striped.table-searchlight-search-results tr.warning td {"},{"line_number":13,"context_line":"  background-color: $brand-warning"},{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-scss","patch_set":11,"id":"7aa08908_d56067d1","line":14,"updated":"2016-06-14 19:24:37.000000000","message":"I notice (at least with recent changes in Horizon) that this only works on \u0027grey\u0027 rows...the white ones don\u0027t get shading.  The following seems to work, if clunky:\n\ntable.table-rsp.table-detail.table-striped.table-searchlight-search-results tbody tr.warning {\n  background-color: $brand-warning;\n  td {\n    background-color: $brand-warning;\n  }\n}","commit_id":"106f5d3444b38d8e8068ddae8e6125e2a586bafb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// work around bootstrap bug https://github.com/twbs/bootstrap/issues/11728"},{"line_number":11,"context_line":"// TODO (tyr) - unclear why contextual classes still not working, 11728 was fixed"},{"line_number":12,"context_line":"table.table-rsp.table-detail.table-striped.table-searchlight-search-results tbody tr.warning {"},{"line_number":13,"context_line":"  background-color: $brand-warning;"},{"line_number":14,"context_line":"  td {"},{"line_number":15,"context_line":"    background-color: $brand-warning;"}],"source_content_type":"text/x-scss","patch_set":12,"id":"7aa08908_a0ad179d","line":12,"updated":"2016-06-16 23:41:52.000000000","message":"Why are we using \"warning\" and not info or success?  It seems like if an action failed we would want to use warning danger.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"7ff49794ab839f00c828875663787bf6b57bf2a2","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// work around bootstrap bug https://github.com/twbs/bootstrap/issues/11728"},{"line_number":11,"context_line":"// TODO (tyr) - unclear why contextual classes still not working, 11728 was fixed"},{"line_number":12,"context_line":"table.table-rsp.table-detail.table-striped.table-searchlight-search-results tbody tr.warning {"},{"line_number":13,"context_line":"  background-color: $brand-warning;"},{"line_number":14,"context_line":"  td {"},{"line_number":15,"context_line":"    background-color: $brand-warning;"}],"source_content_type":"text/x-scss","patch_set":12,"id":"3aaa91ec_5162ebd8","line":12,"in_reply_to":"3aaa91ec_d8b99aee","updated":"2016-06-24 18:35:25.000000000","message":"FWIW I think \"warning\" is the right thing here, and this is actually different from the barber-pole.  They signify two different things.  \"warning\" is saying \"you just changed something and although you already changed it...it hasn\u0027t updated yet\" which is different from the barber-pole: \"Someone initiated something that puts it in an explicit transitional state, so we\u0027re indicating it\u0027s in a transitional state.\"  So I think this implementation is right, and the barber-pole is different, having to do with transitional states.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// work around bootstrap bug https://github.com/twbs/bootstrap/issues/11728"},{"line_number":11,"context_line":"// TODO (tyr) - unclear why contextual classes still not working, 11728 was fixed"},{"line_number":12,"context_line":"table.table-rsp.table-detail.table-striped.table-searchlight-search-results tbody tr.warning {"},{"line_number":13,"context_line":"  background-color: $brand-warning;"},{"line_number":14,"context_line":"  td {"},{"line_number":15,"context_line":"    background-color: $brand-warning;"}],"source_content_type":"text/x-scss","patch_set":12,"id":"5a9d85d2_bf81f54c","line":12,"in_reply_to":"5a9d85d2_b0892dcd","updated":"2016-06-20 18:24:03.000000000","message":"Fair point regarding instances, although it doesn\u0027t seem too hard to use correct contextual classes from the start and be a bit better than instances.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2a7db5822891adb35d7e568056b7af916eded2bb","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// work around bootstrap bug https://github.com/twbs/bootstrap/issues/11728"},{"line_number":11,"context_line":"// TODO (tyr) - unclear why contextual classes still not working, 11728 was fixed"},{"line_number":12,"context_line":"table.table-rsp.table-detail.table-striped.table-searchlight-search-results tbody tr.warning {"},{"line_number":13,"context_line":"  background-color: $brand-warning;"},{"line_number":14,"context_line":"  td {"},{"line_number":15,"context_line":"    background-color: $brand-warning;"}],"source_content_type":"text/x-scss","patch_set":12,"id":"3aaa91ec_d8b99aee","line":12,"in_reply_to":"5a9d85d2_bf81f54c","updated":"2016-06-21 20:25:43.000000000","message":"As we just discussed, this can make sense in a follow on patch.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"// work around bootstrap bug https://github.com/twbs/bootstrap/issues/11728"},{"line_number":11,"context_line":"// TODO (tyr) - unclear why contextual classes still not working, 11728 was fixed"},{"line_number":12,"context_line":"table.table-rsp.table-detail.table-striped.table-searchlight-search-results tbody tr.warning {"},{"line_number":13,"context_line":"  background-color: $brand-warning;"},{"line_number":14,"context_line":"  td {"},{"line_number":15,"context_line":"    background-color: $brand-warning;"}],"source_content_type":"text/x-scss","patch_set":12,"id":"5a9d85d2_b0892dcd","line":12,"in_reply_to":"7aa08908_a0ad179d","updated":"2016-06-20 16:32:53.000000000","message":"it is arbitrary at this point. Long-term we will use some kind of \"in-progress\" indicator. For now, warning is similar to the behavior of an in-progress instance.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"}],"searchlight_ui/static/searchlight-ui/settings/search-settings.service.js":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"4d609ab51dcb11d28e798372f2ff5ffa56b8c03c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          policy: { rules: [[\"search\", \"search:user_polling:allow\"]] }"},{"line_number":89,"context_line":"        },"},{"line_number":90,"context_line":"        cache: {"},{"line_number":91,"context_line":"          clearInterval: 30 * 1000"},{"line_number":92,"context_line":"        }"},{"line_number":93,"context_line":"      }"},{"line_number":94,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":9,"id":"7aa08908_c9e987b9","line":91,"range":{"start_line":91,"start_character":30,"end_line":91,"end_character":34},"updated":"2016-06-10 16:01:10.000000000","message":"This is milliseconds, presumably. Any reason for this being 30 or any benefit to being configurable?","commit_id":"6822167ba09bbfb7e49230a333cb25470c7a25af"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"c8f56e0f4bd70ccc7409018fc1e2c2eb625fa39c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          policy: { rules: [[\"search\", \"search:user_polling:allow\"]] }"},{"line_number":89,"context_line":"        },"},{"line_number":90,"context_line":"        cache: {"},{"line_number":91,"context_line":"          clearInterval: 30 * 1000"},{"line_number":92,"context_line":"        }"},{"line_number":93,"context_line":"      }"},{"line_number":94,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":9,"id":"7aa08908_d07ec317","line":91,"range":{"start_line":91,"start_character":30,"end_line":91,"end_character":34},"in_reply_to":"7aa08908_c9e987b9","updated":"2016-06-14 16:23:35.000000000","message":"Yes. 30,000 ms. Used with Date.now()  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/now\n\n30s is just a number that seems \"long enough\" to allow an action to have time to occur and notify SL.\n\nThis is a good spot for \"settings\", but no particular benefit to making it user configurable as long as it is relatively easy to developer adjust.","commit_id":"6822167ba09bbfb7e49230a333cb25470c7a25af"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":80,"context_line":"          }"},{"line_number":81,"context_line":"        },"},{"line_number":82,"context_line":"        polling: {"},{"line_number":83,"context_line":"          enabled: true,"},{"line_number":84,"context_line":"          interval: 10, //seconds"},{"line_number":85,"context_line":"          getIntervalInMs: getIntervalInMs,"},{"line_number":86,"context_line":"          interval_min: 1,"}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_00d18bfb","line":83,"updated":"2016-06-16 23:41:52.000000000","message":"This is now enabled regardless of the policy (line 88). We need to resolve that. I also had disabled by default because on a large scale system the polling may just cause lots of changes to flow all the time making the page unusable.\n\nWe could consider removing the policy all together, but one reason I had added the policy was a way to completely prevent some kind of DOS from happening.  It would be very easy to hack the javascript and have the js poll every single millisecond. The policy can prevent that completely.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5a8f70505afc2e9ece6478b75b3139bfc14134e7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"          }"},{"line_number":81,"context_line":"        },"},{"line_number":82,"context_line":"        polling: {"},{"line_number":83,"context_line":"          enabled: true,"},{"line_number":84,"context_line":"          interval: 10, //seconds"},{"line_number":85,"context_line":"          getIntervalInMs: getIntervalInMs,"},{"line_number":86,"context_line":"          interval_min: 1,"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_8e639741","line":83,"in_reply_to":"3aaa91ec_817da51e","updated":"2016-06-24 17:53:35.000000000","message":"Sounds good.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":80,"context_line":"          }"},{"line_number":81,"context_line":"        },"},{"line_number":82,"context_line":"        polling: {"},{"line_number":83,"context_line":"          enabled: true,"},{"line_number":84,"context_line":"          interval: 10, //seconds"},{"line_number":85,"context_line":"          getIntervalInMs: getIntervalInMs,"},{"line_number":86,"context_line":"          interval_min: 1,"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_817da51e","line":83,"in_reply_to":"5a9d85d2_9f6fda91","updated":"2016-06-22 23:21:44.000000000","message":"ok, removed the search polling policy since it would dramatically affect our UX if turned off by a deployer.\n\nAbsolutely agree about the need to disable polling and that there is a UX question.  I like Matt\u0027s opinion that default polling and action result handing is a great experience for small deployments and it is worth moving forward while we continue to experiment with good UX to avoid \"wack-a-mole\" behavior in the search table.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":80,"context_line":"          }"},{"line_number":81,"context_line":"        },"},{"line_number":82,"context_line":"        polling: {"},{"line_number":83,"context_line":"          enabled: true,"},{"line_number":84,"context_line":"          interval: 10, //seconds"},{"line_number":85,"context_line":"          getIntervalInMs: getIntervalInMs,"},{"line_number":86,"context_line":"          interval_min: 1,"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_9f6fda91","line":83,"in_reply_to":"5a9d85d2_f0aa9518","updated":"2016-06-20 18:24:03.000000000","message":"Note, meant to say that policy \"can\u0027t\" protect that completely. So agreeing with you that it can be hacked.\n\nThat said, this needs to be resolved, because this basically now is coded to ignore policy in several places that this setting now completely ignores.\n\nAlso, there is another UX discussion with this right now.  If I choose to disable polling as a user (something I am certain is still highly desirable), the dirty rows never get updated.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":80,"context_line":"          }"},{"line_number":81,"context_line":"        },"},{"line_number":82,"context_line":"        polling: {"},{"line_number":83,"context_line":"          enabled: true,"},{"line_number":84,"context_line":"          interval: 10, //seconds"},{"line_number":85,"context_line":"          getIntervalInMs: getIntervalInMs,"},{"line_number":86,"context_line":"          interval_min: 1,"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_f0aa9518","line":83,"in_reply_to":"7aa08908_00d18bfb","updated":"2016-06-20 16:32:53.000000000","message":"If you hack the javascript, then client-side policy doesn\u0027t protect you either.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"375993b075a5226e656026a53b43f36029f9f6cb","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        },"},{"line_number":89,"context_line":"        cache: {"},{"line_number":90,"context_line":"          // big \"enough\" to hold items modified by user before actions complete notify SL"},{"line_number":91,"context_line":"          capacity: 100"},{"line_number":92,"context_line":"        }"},{"line_number":93,"context_line":"      }"},{"line_number":94,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":21,"id":"1aa78d24_e4cce96b","line":91,"updated":"2016-07-13 06:48:45.000000000","message":"There is a limit to the number of items per query, this probably should be set to be equal. I guess okay for now.","commit_id":"19086ab8f870d30b2e95ab92c468a60317b00a40"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"02a2b29d58dfdd16dc8e4a25665403f8e46834af","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        },"},{"line_number":89,"context_line":"        cache: {"},{"line_number":90,"context_line":"          // big \"enough\" to hold items modified by user before actions complete notify SL"},{"line_number":91,"context_line":"          capacity: 100"},{"line_number":92,"context_line":"        }"},{"line_number":93,"context_line":"      }"},{"line_number":94,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":21,"id":"1aa78d24_e59fb1b1","line":91,"in_reply_to":"1aa78d24_e4cce96b","updated":"2016-07-13 13:36:09.000000000","message":"This is related to how many items can the user modify before those modifications complete.  My guess is that it will be very hard for the user to make update/delete actions on 100 items before any of them provide notfication updates to searchlight.  The max number of items per query isn\u0027t related.","commit_id":"19086ab8f870d30b2e95ab92c468a60317b00a40"}],"searchlight_ui/static/searchlight-ui/table/search-table.controller.js":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"502baecfcabdc16394b33c8eaa54e127d803dca1","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    function onSearchResult(response) {"},{"line_number":209,"context_line":"      // Clean cached items that aren\u0027t in current search anymore, or have been deleted. This simply"},{"line_number":210,"context_line":"      // assumes that any actions have long since notified and updated the searchlight index."},{"line_number":211,"context_line":"      // TODO - clear violation of Law of Demeter (https://en.wikipedia.org/wiki/Law_of_Demeter)"},{"line_number":212,"context_line":"      cacheService.clean(ctrl.searchSettings.settings.cache.clearInterval);"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"      // Filter the search results against the cache to make sure we show the user their most"}],"source_content_type":"text/javascript","patch_set":3,"id":"bab6814e_803c4de3","line":211,"range":{"start_line":211,"start_character":16,"end_line":211,"end_character":21},"updated":"2016-05-19 20:45:46.000000000","message":"Should use TODO (irc name)\nIs there a straightforward solution for this? If not, is it odorous enough that we\u0027d try to address it?","commit_id":"5c620759d8874627d575c20cdf2367adfd3b90f5"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"bbb96af022e72834a762f93115413c8a74b0bf4b","unresolved":false,"context_lines":[{"line_number":231,"context_line":"     * @returns {boolean} - True if item contains \u0027deleted\u0027 attribute"},{"line_number":232,"context_line":"     */"},{"line_number":233,"context_line":"    function removeDeletedItems(searchlightItem) {"},{"line_number":234,"context_line":"      if ( searchlightItem.deleted ) {"},{"line_number":235,"context_line":"        return false;"},{"line_number":236,"context_line":"      } else {"},{"line_number":237,"context_line":"        return true;"},{"line_number":238,"context_line":"      }"},{"line_number":239,"context_line":"    }"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    /**"}],"source_content_type":"text/javascript","patch_set":4,"id":"bab6814e_3f94ace0","line":238,"range":{"start_line":234,"start_character":0,"end_line":238,"end_character":7},"updated":"2016-05-25 13:57:37.000000000","message":"I\u0027d really like it to be simple:\n\nreturn !searchlightItem.deleted;\n\nThe truthiness is evaluated all the same via the ! operator.\n\nMight want to also call it something more like \u0027is/has\u0027; \u0027removeX\u0027 sounds like it performs a removal.","commit_id":"569ec636e5a1d3ef2ffc01e6429e716905e9cfb9"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"bbb96af022e72834a762f93115413c8a74b0bf4b","unresolved":false,"context_lines":[{"line_number":282,"context_line":"      var deletedIds, updatedIds, createdIds, failedIds;"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"      if ( result ) {"},{"line_number":285,"context_line":"        deletedIds \u003d getIdsOfType(result.deleted, undefined);"},{"line_number":286,"context_line":"        updatedIds \u003d getIdsOfType(result.updated, undefined);"},{"line_number":287,"context_line":"        createdIds \u003d getIdsOfType(result.created, undefined);"},{"line_number":288,"context_line":"        failedIds \u003d getIdsOfType(result.failed, undefined);"}],"source_content_type":"text/javascript","patch_set":4,"id":"bab6814e_ff77c4d1","line":285,"range":{"start_line":285,"start_character":21,"end_line":285,"end_character":33},"updated":"2016-05-25 13:57:37.000000000","message":"See note below about a service function that does this.","commit_id":"569ec636e5a1d3ef2ffc01e6429e716905e9cfb9"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"bbb96af022e72834a762f93115413c8a74b0bf4b","unresolved":false,"context_lines":[{"line_number":358,"context_line":"      // Action has failed. Do nothing."},{"line_number":359,"context_line":"    }"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    /**"},{"line_number":362,"context_line":"     * Returns an array of ids that match the given resource type (e.g. \"OS::Glance::Image\")"},{"line_number":363,"context_line":"     *"},{"line_number":364,"context_line":"     * @param items - items to filter"},{"line_number":365,"context_line":"     * @param type - type to filter in, or \u0027undefined\u0027 to match all types)"},{"line_number":366,"context_line":"     * @returns {*}"},{"line_number":367,"context_line":"     */"},{"line_number":368,"context_line":"    function getIdsOfType(items, type) {"},{"line_number":369,"context_line":"      var result;"},{"line_number":370,"context_line":"      function typeIdReduce(accumulator, item) {"},{"line_number":371,"context_line":"        if (type \u003d\u003d\u003d undefined || item.type \u003d\u003d\u003d type) {"},{"line_number":372,"context_line":"          accumulator.push(item.id);"},{"line_number":373,"context_line":"        }"},{"line_number":374,"context_line":"        return accumulator;"},{"line_number":375,"context_line":"      }"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"      if ( items ) {"},{"line_number":378,"context_line":"        result \u003d items.reduce(typeIdReduce, []);"},{"line_number":379,"context_line":"      } else {"},{"line_number":380,"context_line":"        result \u003d [];"},{"line_number":381,"context_line":"      }"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"      return result;"},{"line_number":384,"context_line":"    }"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"  }"},{"line_number":387,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"bab6814e_ffb0648d","line":384,"range":{"start_line":361,"start_character":0,"end_line":384,"end_character":5},"updated":"2016-05-25 13:57:37.000000000","message":"This can go away as the action result service has merged:\nhttps://github.com/openstack/horizon/blob/master/horizon/static/framework/util/actions/action-result.service.js#L88","commit_id":"569ec636e5a1d3ef2ffc01e6429e716905e9cfb9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"4d609ab51dcb11d28e798372f2ff5ffa56b8c03c","unresolved":false,"context_lines":[{"line_number":237,"context_line":"     *"},{"line_number":238,"context_line":"     * @param searchlightItem"},{"line_number":239,"context_line":"     * @returns {string} - the searchlight service timestamp which indicates the time when"},{"line_number":240,"context_line":"     * the item was last updated in the searchlight index"},{"line_number":241,"context_line":"     */"},{"line_number":242,"context_line":"    function getSearchlightTimestamp(searchlightItem) {"},{"line_number":243,"context_line":"      var timestamp \u003d \u0027\u0027;"}],"source_content_type":"text/javascript","patch_set":9,"id":"bab6814e_fe4131aa","line":240,"range":{"start_line":240,"start_character":25,"end_line":240,"end_character":32},"updated":"2016-06-10 16:01:10.000000000","message":"This isn\u0027t quite accurate. The dates (and versions) are the times on the service things came from (so, neutron or nova). Searchlight currently doesn\u0027t record a timestamp though we could do so.","commit_id":"6822167ba09bbfb7e49230a333cb25470c7a25af"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"c8f56e0f4bd70ccc7409018fc1e2c2eb625fa39c","unresolved":false,"context_lines":[{"line_number":237,"context_line":"     *"},{"line_number":238,"context_line":"     * @param searchlightItem"},{"line_number":239,"context_line":"     * @returns {string} - the searchlight service timestamp which indicates the time when"},{"line_number":240,"context_line":"     * the item was last updated in the searchlight index"},{"line_number":241,"context_line":"     */"},{"line_number":242,"context_line":"    function getSearchlightTimestamp(searchlightItem) {"},{"line_number":243,"context_line":"      var timestamp \u003d \u0027\u0027;"}],"source_content_type":"text/javascript","patch_set":9,"id":"7aa08908_b0f5f783","line":240,"range":{"start_line":240,"start_character":25,"end_line":240,"end_character":32},"in_reply_to":"bab6814e_fe4131aa","updated":"2016-06-14 16:23:35.000000000","message":"The ideal here is to use a searchlight updated timestamp. This is the hope for _version, but perhaps there is a different field that should be used?","commit_id":"6822167ba09bbfb7e49230a333cb25470c7a25af"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"370e25b5c77151f72de1e5b34ffc99b4e8a6e50e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"      var deletedIds, updatedIds, createdIds, failedIds;"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"      if ( result ) {"},{"line_number":280,"context_line":"        deletedIds \u003d getIdsOfType(result.deleted, undefined);"},{"line_number":281,"context_line":"        updatedIds \u003d getIdsOfType(result.updated, undefined);"},{"line_number":282,"context_line":"        createdIds \u003d getIdsOfType(result.created, undefined);"},{"line_number":283,"context_line":"        failedIds \u003d getIdsOfType(result.failed, undefined);"}],"source_content_type":"text/javascript","patch_set":9,"id":"9abb7d3a_6d6c1009","line":280,"range":{"start_line":280,"start_character":21,"end_line":280,"end_character":33},"updated":"2016-06-02 19:52:03.000000000","message":"You can use the service from Horizon, as described below.","commit_id":"6822167ba09bbfb7e49230a333cb25470c7a25af"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"c8f56e0f4bd70ccc7409018fc1e2c2eb625fa39c","unresolved":false,"context_lines":[{"line_number":277,"context_line":"      var deletedIds, updatedIds, createdIds, failedIds;"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"      if ( result ) {"},{"line_number":280,"context_line":"        deletedIds \u003d getIdsOfType(result.deleted, undefined);"},{"line_number":281,"context_line":"        updatedIds \u003d getIdsOfType(result.updated, undefined);"},{"line_number":282,"context_line":"        createdIds \u003d getIdsOfType(result.created, undefined);"},{"line_number":283,"context_line":"        failedIds \u003d getIdsOfType(result.failed, undefined);"}],"source_content_type":"text/javascript","patch_set":9,"id":"7aa08908_9ab1f949","line":280,"range":{"start_line":280,"start_character":21,"end_line":280,"end_character":33},"in_reply_to":"7aa08908_64c98a78","updated":"2016-06-14 16:23:35.000000000","message":"Done","commit_id":"6822167ba09bbfb7e49230a333cb25470c7a25af"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"90c165515ccd96fa850eb8f5b9833f492b42a22f","unresolved":false,"context_lines":[{"line_number":277,"context_line":"      var deletedIds, updatedIds, createdIds, failedIds;"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"      if ( result ) {"},{"line_number":280,"context_line":"        deletedIds \u003d getIdsOfType(result.deleted, undefined);"},{"line_number":281,"context_line":"        updatedIds \u003d getIdsOfType(result.updated, undefined);"},{"line_number":282,"context_line":"        createdIds \u003d getIdsOfType(result.created, undefined);"},{"line_number":283,"context_line":"        failedIds \u003d getIdsOfType(result.failed, undefined);"}],"source_content_type":"text/javascript","patch_set":9,"id":"7aa08908_64c98a78","line":280,"range":{"start_line":280,"start_character":21,"end_line":280,"end_character":33},"in_reply_to":"9abb7d3a_6d6c1009","updated":"2016-06-10 20:54:30.000000000","message":"This is now truly available/merged in horizon, with the latest features from https://review.openstack.org/#/c/321207/","commit_id":"6822167ba09bbfb7e49230a333cb25470c7a25af"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"370e25b5c77151f72de1e5b34ffc99b4e8a6e50e","unresolved":false,"context_lines":[{"line_number":361,"context_line":"     * @returns {*}"},{"line_number":362,"context_line":"     */"},{"line_number":363,"context_line":"    // TODO (tyr) use https://review.openstack.org/#/c/321207/ when it merges"},{"line_number":364,"context_line":"    function getIdsOfType(items, type) {"},{"line_number":365,"context_line":"      var result;"},{"line_number":366,"context_line":"      function typeIdReduce(accumulator, item) {"},{"line_number":367,"context_line":"        if (type \u003d\u003d\u003d undefined || item.type \u003d\u003d\u003d type) {"}],"source_content_type":"text/javascript","patch_set":9,"id":"9abb7d3a_adaf182a","line":364,"range":{"start_line":364,"start_character":13,"end_line":364,"end_character":40},"updated":"2016-06-02 19:52:03.000000000","message":"You can now use that service:\n\nhorizon.framework.util.actions.action-result.service\n\nfrom: https://github.com/openstack/horizon/blob/c0eb28f71844c50505d829c4783b1918c6db8c5d/horizon/static/framework/util/actions/action-result.service.js","commit_id":"6822167ba09bbfb7e49230a333cb25470c7a25af"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":205,"context_line":"      ctrl.queryResponse \u003d response;"},{"line_number":206,"context_line":"    }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    function actionResultHandler(result) {"},{"line_number":209,"context_line":"      result.then(repeatUntilChangedResults);"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"      function repeatUntilChangedResults() {"}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_f639a9d9","side":"PARENT","line":208,"updated":"2016-06-16 23:41:52.000000000","message":"The ability to toggle polling is still use capable via the setting dialog. I still think we need to give users the ability to turn it off, even if it is on by default.  When it is turned off, the dirty row gets stuck until you change your search. This would ensure that polling always happened for a period of time regardless of active polling.  I\u0027m not sure of the best answer right now, but need to point this out and we can talk.","commit_id":"4c004f6d86f19f963efb706d7e3d45b6bb69d26c"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"cc3aa3432e00bda153fceddbd09353da6e2387b3","unresolved":false,"context_lines":[{"line_number":205,"context_line":"      ctrl.queryResponse \u003d response;"},{"line_number":206,"context_line":"    }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    function actionResultHandler(result) {"},{"line_number":209,"context_line":"      result.then(repeatUntilChangedResults);"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"      function repeatUntilChangedResults() {"}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_96b2e5e3","side":"PARENT","line":208,"in_reply_to":"7aa08908_f639a9d9","updated":"2016-06-16 23:45:15.000000000","message":"One other thing, this also increases poll time for the case of creates. So, if you launch an instance from an image, it is quite likely that it will show up sooner than the next poll interval of (that could be ten seconds away).","commit_id":"4c004f6d86f19f963efb706d7e3d45b6bb69d26c"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":218,"context_line":"      ctrl.queryResponse \u003d response;"},{"line_number":219,"context_line":"    }"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    function syncWithCache(searchlightItem) {"},{"line_number":222,"context_line":"      return cacheService.sync("},{"line_number":223,"context_line":"        searchlightItem,"},{"line_number":224,"context_line":"        searchlightItem._id,"}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_1bfe20ae","line":221,"updated":"2016-06-16 23:41:52.000000000","message":"This is getting called on every single item in the response even when the cache is empty. It really should be smarter and not call this code if the cache is empty.  This is one potential reason to use the angular cache because you can get the size from it.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":218,"context_line":"      ctrl.queryResponse \u003d response;"},{"line_number":219,"context_line":"    }"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    function syncWithCache(searchlightItem) {"},{"line_number":222,"context_line":"      return cacheService.sync("},{"line_number":223,"context_line":"        searchlightItem,"},{"line_number":224,"context_line":"        searchlightItem._id,"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_7dc48e5e","line":221,"in_reply_to":"5a9d85d2_7f314da2","updated":"2016-06-22 23:21:44.000000000","message":"Done. Using angular cache and checking cache size before syncing results.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":218,"context_line":"      ctrl.queryResponse \u003d response;"},{"line_number":219,"context_line":"    }"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    function syncWithCache(searchlightItem) {"},{"line_number":222,"context_line":"      return cacheService.sync("},{"line_number":223,"context_line":"        searchlightItem,"},{"line_number":224,"context_line":"        searchlightItem._id,"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_7f314da2","line":221,"in_reply_to":"5a9d85d2_b00c8d43","updated":"2016-06-20 18:24:03.000000000","message":"1000 search results will result in 1000 unnecessary dictionary lookups. Seems like a simple check could handle this, so why not add that protection?","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":218,"context_line":"      ctrl.queryResponse \u003d response;"},{"line_number":219,"context_line":"    }"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    function syncWithCache(searchlightItem) {"},{"line_number":222,"context_line":"      return cacheService.sync("},{"line_number":223,"context_line":"        searchlightItem,"},{"line_number":224,"context_line":"        searchlightItem._id,"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_b00c8d43","line":221,"in_reply_to":"7aa08908_1bfe20ae","updated":"2016-06-20 16:32:53.000000000","message":"True. However for every item in hit result we do O(1) dictionary lookup. I\u0027m not particularly worried about perf impact of this.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":241,"context_line":"     * @returns {string} - the searchlight service timestamp which indicates the time when"},{"line_number":242,"context_line":"     * the item was last updated in the searchlight index"},{"line_number":243,"context_line":"     */"},{"line_number":244,"context_line":"    function getSearchlightTimestamp(searchlightItem) {"},{"line_number":245,"context_line":"      var timestamp \u003d \u0027\u0027;"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"      if (searchlightItem._source.updated_at) {"}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_d60d8d36","line":244,"updated":"2016-06-16 23:41:52.000000000","message":"now that we support version, it should be easy to take advantage of.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":241,"context_line":"     * @returns {string} - the searchlight service timestamp which indicates the time when"},{"line_number":242,"context_line":"     * the item was last updated in the searchlight index"},{"line_number":243,"context_line":"     */"},{"line_number":244,"context_line":"    function getSearchlightTimestamp(searchlightItem) {"},{"line_number":245,"context_line":"      var timestamp \u003d \u0027\u0027;"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"      if (searchlightItem._source.updated_at) {"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_bda436b9","line":244,"in_reply_to":"5a9d85d2_93acfbee","updated":"2016-06-22 23:21:44.000000000","message":"Done","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":241,"context_line":"     * @returns {string} - the searchlight service timestamp which indicates the time when"},{"line_number":242,"context_line":"     * the item was last updated in the searchlight index"},{"line_number":243,"context_line":"     */"},{"line_number":244,"context_line":"    function getSearchlightTimestamp(searchlightItem) {"},{"line_number":245,"context_line":"      var timestamp \u003d \u0027\u0027;"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"      if (searchlightItem._source.updated_at) {"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_e25802fd","line":244,"in_reply_to":"5a9d85d2_93acfbee","updated":"2016-06-20 18:24:03.000000000","message":"update_at and created_at quite possibly are just wrong to use right now.\n\nThose fields often do not give the level of precision needed to properly detect changes.  Many of these timestamp fields only give second level precision.  Sometimes we can see events emitted faster than 1 second. On SL side, we do some extra activities to ensure version is always updated including using notification timestamps that higher level of precision.\n\nIn the way this is being used in searchlight UI in this patch, maybe this doesn\u0027t manifest itself?  But still not seeing why not add using version as first option and falling back to these when it doesn\u0027t exist. If you want to put in a follow up patch showing the use of version, then I guess we could push this through and changing to version in follow on, but then I\u0027m not sure why not just use version in this patch.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":241,"context_line":"     * @returns {string} - the searchlight service timestamp which indicates the time when"},{"line_number":242,"context_line":"     * the item was last updated in the searchlight index"},{"line_number":243,"context_line":"     */"},{"line_number":244,"context_line":"    function getSearchlightTimestamp(searchlightItem) {"},{"line_number":245,"context_line":"      var timestamp \u003d \u0027\u0027;"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"      if (searchlightItem._source.updated_at) {"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_1dac6a9f","line":244,"in_reply_to":"5a9d85d2_e25802fd","updated":"2016-06-22 23:21:44.000000000","message":"Done","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":241,"context_line":"     * @returns {string} - the searchlight service timestamp which indicates the time when"},{"line_number":242,"context_line":"     * the item was last updated in the searchlight index"},{"line_number":243,"context_line":"     */"},{"line_number":244,"context_line":"    function getSearchlightTimestamp(searchlightItem) {"},{"line_number":245,"context_line":"      var timestamp \u003d \u0027\u0027;"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"      if (searchlightItem._source.updated_at) {"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_93acfbee","line":244,"in_reply_to":"7aa08908_d60d8d36","updated":"2016-06-20 16:32:53.000000000","message":"yep. follow-on.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        // Handle failed images"},{"line_number":293,"context_line":"        if ( failedIds ) {"},{"line_number":294,"context_line":"          // Do nothing for now"},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_1ba8e076","line":294,"updated":"2016-06-16 23:41:52.000000000","message":"if we didn\u0027t use the warning color for highlighting we could use that here.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5a8f70505afc2e9ece6478b75b3139bfc14134e7","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        // Handle failed images"},{"line_number":293,"context_line":"        if ( failedIds ) {"},{"line_number":294,"context_line":"          // Do nothing for now"},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_8908b1db","line":294,"in_reply_to":"3aaa91ec_ddb662db","updated":"2016-06-24 17:53:35.000000000","message":"i\u0027m okay with that.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        // Handle failed images"},{"line_number":293,"context_line":"        if ( failedIds ) {"},{"line_number":294,"context_line":"          // Do nothing for now"},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_bf3a9534","line":294,"in_reply_to":"5a9d85d2_13d80b53","updated":"2016-06-20 18:24:03.000000000","message":"well, for example, when we have batch actions like in ng images, we don\u0027t check the allowed function until performing the action. I just hit this several times last week working on that patch where I get a toast failed for several that I didn\u0027t have rights to and it was annoying to have a toast that I then had to look at the message a try to correlate that rows in my table. Would have been much nicer to see them highlighted in warning or danger when they failed.\n\nShouldn\u0027t row clear after cache expiration?  Or maybe you need some kind of a failed expiration?\n\nJust totally not getting why we have knowledge of success and failed and we only do something with success by marking those rows as \"warning\".","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        // Handle failed images"},{"line_number":293,"context_line":"        if ( failedIds ) {"},{"line_number":294,"context_line":"          // Do nothing for now"},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_ddb662db","line":294,"in_reply_to":"5a9d85d2_bf3a9534","updated":"2016-06-22 23:21:44.000000000","message":"Good ideas for failed items. I think this needs some experimenting to find the right UX. Since that might be a bit complicated, I\u0027d prefer the failed action use case be its own patch.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        // Handle failed images"},{"line_number":293,"context_line":"        if ( failedIds ) {"},{"line_number":294,"context_line":"          // Do nothing for now"},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_13d80b53","line":294,"in_reply_to":"7aa08908_1ba8e076","updated":"2016-06-20 16:32:53.000000000","message":"not clear what UX you are suggesting. If we highlight a row where the action failed due to network interrupt, how does the row clear?","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":309,"context_line":"     * @param ids - id of an item that has been modified"},{"line_number":310,"context_line":"     * @param deleted - set to true if the item has been deleted"},{"line_number":311,"context_line":"     */"},{"line_number":312,"context_line":"    function addItemsToCache(ids, deleted) {"},{"line_number":313,"context_line":"      var index, searchlightItem;"},{"line_number":314,"context_line":"      ids.forEach(function addToCache(id) {"},{"line_number":315,"context_line":"        // Find the index of the item if it is currently displayed in the search results"}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_5b06e885","line":312,"updated":"2016-06-16 23:41:52.000000000","message":"this function feels like it could be moved into the cache service if it took hitsSrc (in a generalized form as an argument).","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":309,"context_line":"     * @param ids - id of an item that has been modified"},{"line_number":310,"context_line":"     * @param deleted - set to true if the item has been deleted"},{"line_number":311,"context_line":"     */"},{"line_number":312,"context_line":"    function addItemsToCache(ids, deleted) {"},{"line_number":313,"context_line":"      var index, searchlightItem;"},{"line_number":314,"context_line":"      ids.forEach(function addToCache(id) {"},{"line_number":315,"context_line":"        // Find the index of the item if it is currently displayed in the search results"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_a2827a50","line":312,"in_reply_to":"5a9d85d2_73e7cfe4","updated":"2016-06-20 18:24:03.000000000","message":"Yeah, i do see some of the point there. I just ideally want to avoid adding things to the controller. Controllers should be as light as they possible can.  If this is all truly specific to this view and won\u0027t be needed elsewhere, then fine. Also can be considered for future refactor.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":309,"context_line":"     * @param ids - id of an item that has been modified"},{"line_number":310,"context_line":"     * @param deleted - set to true if the item has been deleted"},{"line_number":311,"context_line":"     */"},{"line_number":312,"context_line":"    function addItemsToCache(ids, deleted) {"},{"line_number":313,"context_line":"      var index, searchlightItem;"},{"line_number":314,"context_line":"      ids.forEach(function addToCache(id) {"},{"line_number":315,"context_line":"        // Find the index of the item if it is currently displayed in the search results"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_7de12e9a","line":312,"in_reply_to":"5a9d85d2_a2827a50","updated":"2016-06-22 23:21:44.000000000","message":"The logic here is view specific.\n\nThis view controller has knowledge about the data being rendered, and is responsible for splicing out any deleted items. Also, it knows the particular data attributes to set on the items to cause them to render as \"dirty\" or \"deleted\".","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":309,"context_line":"     * @param ids - id of an item that has been modified"},{"line_number":310,"context_line":"     * @param deleted - set to true if the item has been deleted"},{"line_number":311,"context_line":"     */"},{"line_number":312,"context_line":"    function addItemsToCache(ids, deleted) {"},{"line_number":313,"context_line":"      var index, searchlightItem;"},{"line_number":314,"context_line":"      ids.forEach(function addToCache(id) {"},{"line_number":315,"context_line":"        // Find the index of the item if it is currently displayed in the search results"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_73e7cfe4","line":312,"in_reply_to":"7aa08908_5b06e885","updated":"2016-06-20 16:32:53.000000000","message":"possibly, not convinced that it is the cache\u0027s responsibility. In this case, the controller has the knowledge of why we are caching and which items should be inserted.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":333,"context_line":"          if ( searchlightItem ) {"},{"line_number":334,"context_line":"            // Annotate the item as dirty, and possibly deleted, then place it in the cache"},{"line_number":335,"context_line":"            // with the current searchlight timestamp (not local time). If this item is displayed"},{"line_number":336,"context_line":"            // is the search results, the cached item will be used until the searchlight timestamp"},{"line_number":337,"context_line":"            // in the search results has been updated. For deleted items, since they will be removed"},{"line_number":338,"context_line":"            // from the searchlight server search results, they will be removed from the cache after"},{"line_number":339,"context_line":"            // the cache clearing interval."}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_fb94f444","line":336,"range":{"start_line":336,"start_character":15,"end_line":336,"end_character":17},"updated":"2016-06-16 23:41:52.000000000","message":"is \u003d in","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":333,"context_line":"          if ( searchlightItem ) {"},{"line_number":334,"context_line":"            // Annotate the item as dirty, and possibly deleted, then place it in the cache"},{"line_number":335,"context_line":"            // with the current searchlight timestamp (not local time). If this item is displayed"},{"line_number":336,"context_line":"            // is the search results, the cached item will be used until the searchlight timestamp"},{"line_number":337,"context_line":"            // in the search results has been updated. For deleted items, since they will be removed"},{"line_number":338,"context_line":"            // from the searchlight server search results, they will be removed from the cache after"},{"line_number":339,"context_line":"            // the cache clearing interval."}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_5d8a72c0","line":336,"range":{"start_line":336,"start_character":15,"end_line":336,"end_character":17},"in_reply_to":"7aa08908_fb94f444","updated":"2016-06-22 23:21:44.000000000","message":"Done","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            // Annotate the item as dirty, and possibly deleted, then place it in the cache"},{"line_number":335,"context_line":"            // with the current searchlight timestamp (not local time). If this item is displayed"},{"line_number":336,"context_line":"            // is the search results, the cached item will be used until the searchlight timestamp"},{"line_number":337,"context_line":"            // in the search results has been updated. For deleted items, since they will be removed"},{"line_number":338,"context_line":"            // from the searchlight server search results, they will be removed from the cache after"},{"line_number":339,"context_line":"            // the cache clearing interval."},{"line_number":340,"context_line":"            searchlightItem.dirty \u003d true;"}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_5b8a681b","line":337,"range":{"start_line":337,"start_character":37,"end_line":337,"end_character":40},"updated":"2016-06-16 23:41:52.000000000","message":"have","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            // Annotate the item as dirty, and possibly deleted, then place it in the cache"},{"line_number":335,"context_line":"            // with the current searchlight timestamp (not local time). If this item is displayed"},{"line_number":336,"context_line":"            // is the search results, the cached item will be used until the searchlight timestamp"},{"line_number":337,"context_line":"            // in the search results has been updated. For deleted items, since they will be removed"},{"line_number":338,"context_line":"            // from the searchlight server search results, they will be removed from the cache after"},{"line_number":339,"context_line":"            // the cache clearing interval."},{"line_number":340,"context_line":"            searchlightItem.dirty \u003d true;"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_3d85e6ac","line":337,"range":{"start_line":337,"start_character":37,"end_line":337,"end_character":40},"in_reply_to":"7aa08908_5b8a681b","updated":"2016-06-22 23:21:44.000000000","message":"Done","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            cacheService.add("},{"line_number":343,"context_line":"              searchlightItem,"},{"line_number":344,"context_line":"              searchlightItem._id,"},{"line_number":345,"context_line":"              getSearchlightTimestamp(searchlightItem)"},{"line_number":346,"context_line":"            );"},{"line_number":347,"context_line":"          }"},{"line_number":348,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_56eb5d12","line":345,"updated":"2016-06-16 23:41:52.000000000","message":"with the version on there, i\u0027m not sure I see a reason to take all three of these as input. you can just pass in a searchlight item and use the fields internally.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5a8f70505afc2e9ece6478b75b3139bfc14134e7","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            cacheService.add("},{"line_number":343,"context_line":"              searchlightItem,"},{"line_number":344,"context_line":"              searchlightItem._id,"},{"line_number":345,"context_line":"              getSearchlightTimestamp(searchlightItem)"},{"line_number":346,"context_line":"            );"},{"line_number":347,"context_line":"          }"},{"line_number":348,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_c9af597b","line":345,"in_reply_to":"3aaa91ec_9dab3a1d","updated":"2016-06-24 17:53:35.000000000","message":"There is certainly some added coupling, but also potential for simplification in usage with less redundancy when you have a cache that is specific to caching searchlight results. I\u0027m not sold that this cache is useful outside of the searchlight UI context, yet or that it needs to stay general purpose for other unknown views.  That is my opinion, but not worth arguing too much over.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            cacheService.add("},{"line_number":343,"context_line":"              searchlightItem,"},{"line_number":344,"context_line":"              searchlightItem._id,"},{"line_number":345,"context_line":"              getSearchlightTimestamp(searchlightItem)"},{"line_number":346,"context_line":"            );"},{"line_number":347,"context_line":"          }"},{"line_number":348,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_7f1dcd72","line":345,"in_reply_to":"5a9d85d2_13300b56","updated":"2016-06-20 18:24:03.000000000","message":"Since this is for Searchlight UI and in the Searchlight UI plugin, it would be helpful to me to understand the bigger picture goal here? Are you thinking of putting the cache in horizon master where it would be very useful in the rest of horizon?  If there is something that we think it should be general purpose horizon, then we should move it there.  Otherwise, why burden ourselves with trying to create some general purpose caching mechanism that gets hard for us to adopt for our specific needs and uses and also gets easier for others to break SL UI on accident.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            cacheService.add("},{"line_number":343,"context_line":"              searchlightItem,"},{"line_number":344,"context_line":"              searchlightItem._id,"},{"line_number":345,"context_line":"              getSearchlightTimestamp(searchlightItem)"},{"line_number":346,"context_line":"            );"},{"line_number":347,"context_line":"          }"},{"line_number":348,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_9dab3a1d","line":345,"in_reply_to":"5a9d85d2_7f1dcd72","updated":"2016-06-22 23:21:44.000000000","message":"What I meant was that the cache isn\u0027t limited to this view.  Unless there is a compelling reason, I\u0027d prefer that the modified item cache be usable by other controllers and views to cache data objects that may have different id or timestamp fields.\n\nGranted, the cache currently is a singleton, but I think keeping a generic interface will aid its maintainability.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            cacheService.add("},{"line_number":343,"context_line":"              searchlightItem,"},{"line_number":344,"context_line":"              searchlightItem._id,"},{"line_number":345,"context_line":"              getSearchlightTimestamp(searchlightItem)"},{"line_number":346,"context_line":"            );"},{"line_number":347,"context_line":"          }"},{"line_number":348,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_13300b56","line":345,"in_reply_to":"7aa08908_56eb5d12","updated":"2016-06-20 16:32:53.000000000","message":"cache isn\u0027t intended to be searchlight specific. I prefer that it doesn\u0027t know the structure of the objects it is storing.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    }"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    function actionErrorHandler(reason) { // eslint-disable-line no-unused-vars"},{"line_number":353,"context_line":"      // Action has failed. Do nothing."},{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_3b767c3e","line":353,"updated":"2016-06-16 23:41:52.000000000","message":"actually, i think we could mark the item as error and highlight in the danger or warning color until it is cleared from the cache.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    }"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    function actionErrorHandler(reason) { // eslint-disable-line no-unused-vars"},{"line_number":353,"context_line":"      // Action has failed. Do nothing."},{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_5d5f1241","line":353,"in_reply_to":"5a9d85d2_459da064","updated":"2016-06-22 23:21:44.000000000","message":"yes, possibly. As above, I\u0027d like to explore failed item UX in a patch dedicated to that use case.  This patch didn\u0027t consider that part of the action response, and is focused on the 80% use case of items successfully deleted or modified.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    }"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    function actionErrorHandler(reason) { // eslint-disable-line no-unused-vars"},{"line_number":353,"context_line":"      // Action has failed. Do nothing."},{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_459da064","line":353,"in_reply_to":"5a9d85d2_73834fcd","updated":"2016-06-20 18:24:03.000000000","message":"Perhaps errors need an error timeout for cleaning them.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    }"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    function actionErrorHandler(reason) { // eslint-disable-line no-unused-vars"},{"line_number":353,"context_line":"      // Action has failed. Do nothing."},{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_73834fcd","line":353,"in_reply_to":"7aa08908_3b767c3e","updated":"2016-06-20 16:32:53.000000000","message":"As above, I don\u0027t think this is a good UX. Action errors may be transitory and do not necessarily mean we shouldn\u0027t try again...and item in SL cache may never change, meaning we won\u0027t mark it as clean.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"}],"searchlight_ui/static/searchlight-ui/table/search-table.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      \u003c/tr\u003e"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"7aa08908_5b65481b","line":69,"updated":"2016-06-16 23:41:52.000000000","message":"Maybe we should just add it to the searchresult when it comes in?\n\nhttps://github.com/openstack/searchlight-ui/blob/master/searchlight_ui/static/searchlight-ui/util/searchlight-search-helper.service.js#L117-L130","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"6db81a8b718f809621860d3008e7a98f2b4cd1b3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      \u003c/tr\u003e"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"1aa78d24_7132a25f","line":69,"in_reply_to":"3aaa91ec_49aa491a","updated":"2016-07-12 13:17:28.000000000","message":"I double checked. This is only called on data load when Angular is deciding if a row needs to be re-rendered. It is not called every digest cycle otherwise (e.g. when a row action is invoked).","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5a8f70505afc2e9ece6478b75b3139bfc14134e7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      \u003c/tr\u003e"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"3aaa91ec_49aa491a","line":69,"in_reply_to":"3aaa91ec_7d02ce0c","updated":"2016-06-24 17:53:35.000000000","message":"we\u0027d have to test it with some profiling, but i think this may get hit by the digest cycle more often than just doing it once each time the data is loaded. Good thing to check out.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      \u003c/tr\u003e"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"3aaa91ec_7d02ce0c","line":69,"in_reply_to":"5a9d85d2_42ef56e8","updated":"2016-06-22 23:21:44.000000000","message":"Since I have a controller convenience method to get the \"key\" for a hit that is used multiple times in the controller, using it in the view is simple to understand and doesn\u0027t require additional synthetic data attributes.\n\nIs there some kind of performance benefit to one approach versus the other?","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      \u003c/tr\u003e"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"5a9d85d2_42ef56e8","line":69,"in_reply_to":"5a9d85d2_b3dbf7ec","updated":"2016-06-20 18:24:03.000000000","message":"I think it is a good pattern. This kind of thing is what just got added into the images update to use the resource-table directive.  Matt also added a trackBy property to each result.\n\nSee line 161:\n\nhttps://review.openstack.org/#/c/309561/44/openstack_dashboard/static/app/core/images/images.module.js\n\nAnd here:\n\nhttps://review.openstack.org/#/c/309561/44/horizon/static/framework/widgets/table/hz-resource-table.controller.js","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      \u003c/tr\u003e"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"5a9d85d2_b3dbf7ec","line":69,"in_reply_to":"7aa08908_5b65481b","updated":"2016-06-20 16:32:53.000000000","message":"That is possible. Interesting suggestion.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"},{"line_number":73,"context_line":"          \u003ci class\u003d\"fa fa-chevron-right\""}],"source_content_type":"text/html","patch_set":12,"id":"7aa08908_fbafd428","line":70,"updated":"2016-06-16 23:41:52.000000000","message":"why not use success for changes and warning or danger for failed?","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5a8f70505afc2e9ece6478b75b3139bfc14134e7","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"},{"line_number":73,"context_line":"          \u003ci class\u003d\"fa fa-chevron-right\""}],"source_content_type":"text/html","patch_set":12,"id":"3aaa91ec_29a53d46","line":70,"in_reply_to":"3aaa91ec_a01ecd60","updated":"2016-06-24 17:53:35.000000000","message":"i\u0027m okay with that.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"},{"line_number":73,"context_line":"          \u003ci class\u003d\"fa fa-chevron-right\""}],"source_content_type":"text/html","patch_set":12,"id":"5a9d85d2_e2abe287","line":70,"in_reply_to":"5a9d85d2_9374fbcf","updated":"2016-06-20 18:24:03.000000000","message":"So, with this patch, it knows something is dirty, I understand that, but why do action results have \"failed\" then?","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"},{"line_number":73,"context_line":"          \u003ci class\u003d\"fa fa-chevron-right\""}],"source_content_type":"text/html","patch_set":12,"id":"3aaa91ec_a01ecd60","line":70,"in_reply_to":"5a9d85d2_e2abe287","updated":"2016-06-22 23:21:44.000000000","message":"If possible, let\u0027s dedicate a later patch to the addressing the failed action use case.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      \u003ctr ng-if\u003d\u0027!table.queryError\u0027"},{"line_number":69,"context_line":"          ng-repeat-start\u003d\"hit in table.hits track by table.getSearchlightKey(hit)\""},{"line_number":70,"context_line":"          ng-class\u003d\"{warning: hit.dirty}\"\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"},{"line_number":73,"context_line":"          \u003ci class\u003d\"fa fa-chevron-right\""}],"source_content_type":"text/html","patch_set":12,"id":"5a9d85d2_9374fbcf","line":70,"in_reply_to":"7aa08908_fbafd428","updated":"2016-06-20 16:32:53.000000000","message":"The \"UX\" for failed items is not clear. All SL-UI knows is item is \"in-transition\"","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"375993b075a5226e656026a53b43f36029f9f6cb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"          \u003c/actions\u003e"},{"line_number":145,"context_line":"          \u003cspan"},{"line_number":146,"context_line":"            ng-show\u003d\"hit.dirty\""},{"line_number":147,"context_line":"            class\u003d\"fa fa-spinner fa-spin fa-lg\"\u003e"},{"line_number":148,"context_line":"          \u003c/span\u003e"},{"line_number":149,"context_line":"        \u003c/td\u003e"},{"line_number":150,"context_line":""}],"source_content_type":"text/html","patch_set":21,"id":"1aa78d24_a4fca172","line":147,"updated":"2016-07-13 06:48:45.000000000","message":"I like this a lot better than the row highlighting that was ambiguous. However, this is still ambiguous because we don\u0027t know end states (see diatribes on patch set 12)\n\nhttps://review.openstack.org/#/c/317106/12..21/searchlight_ui/static/searchlight-ui/table/search-table.html","commit_id":"19086ab8f870d30b2e95ab92c468a60317b00a40"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"02a2b29d58dfdd16dc8e4a25665403f8e46834af","unresolved":false,"context_lines":[{"line_number":144,"context_line":"          \u003c/actions\u003e"},{"line_number":145,"context_line":"          \u003cspan"},{"line_number":146,"context_line":"            ng-show\u003d\"hit.dirty\""},{"line_number":147,"context_line":"            class\u003d\"fa fa-spinner fa-spin fa-lg\"\u003e"},{"line_number":148,"context_line":"          \u003c/span\u003e"},{"line_number":149,"context_line":"        \u003c/td\u003e"},{"line_number":150,"context_line":""}],"source_content_type":"text/html","patch_set":21,"id":"1aa78d24_e9bb0be3","line":147,"in_reply_to":"1aa78d24_a4fca172","updated":"2016-07-13 13:36:09.000000000","message":"Thanks.\n\nI don\u0027t think I understand what you mean by \"end states\". If you are thinking that sl-ui should have some idea of a status value or other attribute on the data to examine to determine when the change has occurred, I don\u0027t think that will be very easy to apply generally to all resources.\n\nI agree there are UX corner cases we need to work out with refreshing the data...but I think that simple strategy is easier to apply to an arbitrary resource, and will better reflect the true state of the system, with far less complex knowledge in the UI.","commit_id":"19086ab8f870d30b2e95ab92c468a60317b00a40"}],"searchlight_ui/static/searchlight-ui/util/cache.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d8f11b4b32db97abd7340940512d4192aa6d3b27","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      };"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    var cache \u003d {};"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    var service \u003d {"},{"line_number":62,"context_line":"      add: add,"}],"source_content_type":"text/javascript","patch_set":12,"id":"7aa08908_20012707","line":59,"updated":"2016-06-16 23:41:52.000000000","message":"Is there any value to potentially using the angular cache factory and also using LRU with it? You\u0027d also have size (from info). I realize your custom methods would all still need to be used.... just mentioning it. Maybe you could extend from the cache coming out of it.\n\nhttps://docs.angularjs.org/api/ng/service/$cacheFactory","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      };"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    var cache \u003d {};"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    var service \u003d {"},{"line_number":62,"context_line":"      add: add,"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_c029598b","line":59,"in_reply_to":"5a9d85d2_3331c70c","updated":"2016-06-22 23:21:44.000000000","message":"Done","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9719a159fa7ce3d664d5cf1ea5585ea70a3690da","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      };"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    var cache \u003d {};"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    var service \u003d {"},{"line_number":62,"context_line":"      add: add,"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_3331c70c","line":59,"in_reply_to":"7aa08908_20012707","updated":"2016-06-20 16:32:53.000000000","message":"Probably a good improvement.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a48e804cb2bf2458ef08b6c6a7e2d6de77c84dd4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    /**"},{"line_number":82,"context_line":"     * If the item is newer than cached item clear the cached version"},{"line_number":83,"context_line":"     */"},{"line_number":84,"context_line":"    function sync(item, id, timestamp) {"},{"line_number":85,"context_line":"      var syncedItem \u003d item;"},{"line_number":86,"context_line":"      var cachedItem;"},{"line_number":87,"context_line":"      if (cache.hasOwnProperty(id)) {"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a9d85d2_c2406659","line":84,"updated":"2016-06-20 18:24:03.000000000","message":"There is something about all of this that is in the back of my mind and II didn\u0027t re-test this morning and look through the code deeply enough to decipher. So please bear with me as I explain it in order to get your thoughts.\n\nSo, an instance that is suspending, pausing, etc, will actually emit multiple updates that searchlight picks up during the process and the timestamps and versions will update even if the item is still in transition. For example, pressing the suspend button actually results in going from 1) below to 3). \n\n 1) Status: Active -\u003e Task State: None \n 2) Status: Active -\u003e Task State: Suspending\n 3) Status: Suspended -\u003e Task State: None\n\n2 and 3 are both points in time where the instance will get new timestamps and versions (which SL is notified of).  The time may be nearly instant or may take some awhile. 2 How long will the item be dirty?  Does it have a minimum amount of time that it stays dirty?","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"6db81a8b718f809621860d3008e7a98f2b4cd1b3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    /**"},{"line_number":82,"context_line":"     * If the item is newer than cached item clear the cached version"},{"line_number":83,"context_line":"     */"},{"line_number":84,"context_line":"    function sync(item, id, timestamp) {"},{"line_number":85,"context_line":"      var syncedItem \u003d item;"},{"line_number":86,"context_line":"      var cachedItem;"},{"line_number":87,"context_line":"      if (cache.hasOwnProperty(id)) {"}],"source_content_type":"text/javascript","patch_set":12,"id":"1aa78d24_7138e2ee","line":84,"in_reply_to":"3aaa91ec_1b452445","updated":"2016-07-12 13:17:28.000000000","message":"IMHO, if the visible data matches the change you just made I don\u0027t think it is necessary to highlight the row you just successfully clicked. I think of the dirty indicator as a \"spinner\" that is active until we have confirmation of action completion.\n\nGranted, it isn\u0027t a spinner today...I can look into that a little bit now, but otherwise, that might be best addressed at the same time as we deal with failed actions.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5a8f70505afc2e9ece6478b75b3139bfc14134e7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    /**"},{"line_number":82,"context_line":"     * If the item is newer than cached item clear the cached version"},{"line_number":83,"context_line":"     */"},{"line_number":84,"context_line":"    function sync(item, id, timestamp) {"},{"line_number":85,"context_line":"      var syncedItem \u003d item;"},{"line_number":86,"context_line":"      var cachedItem;"},{"line_number":87,"context_line":"      if (cache.hasOwnProperty(id)) {"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_1b452445","line":84,"in_reply_to":"3aaa91ec_a0bfedf9","updated":"2016-06-24 17:53:35.000000000","message":"Won\u0027t the UX be confusing if sometimes things glow or change colors and sometimes they don\u0027t?","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"fd087a0433d620d375864d6a8c9fe2c72b6a5e57","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    /**"},{"line_number":82,"context_line":"     * If the item is newer than cached item clear the cached version"},{"line_number":83,"context_line":"     */"},{"line_number":84,"context_line":"    function sync(item, id, timestamp) {"},{"line_number":85,"context_line":"      var syncedItem \u003d item;"},{"line_number":86,"context_line":"      var cachedItem;"},{"line_number":87,"context_line":"      if (cache.hasOwnProperty(id)) {"}],"source_content_type":"text/javascript","patch_set":12,"id":"3aaa91ec_a0bfedf9","line":84,"in_reply_to":"5a9d85d2_c2406659","updated":"2016-06-22 23:21:44.000000000","message":"Great observation. Depending on the timing of the poll, from a user\u0027s perspective a dirty flag may be cleared the instant it is set.\n\nSome kind of auto-fade comes to mind, similar to toast messages.\n\nOn the other hand, I think the core concern is that the item contains the modification you expect so you don\u0027t feel like the action didn\u0027t \"stick\".\n\nFor example, if you change the name of an instance, when you submit the action you expect to either see the new name in the search results...or some indication that the item is \"in-transition\".\n\nIf the item is not visibly \"dirty\", but the name is what you just set...then I think there is no frustration.  Therefore, I think dirty is only necessary while the state of the item is identical to its pre-action state.  Once that item has updated...I don\u0027t think a user will expect a row they just operated on to have a \"freshly-modified glow\".  It might look cool...but I suspect it won\u0027t cause confusion if omitted.","commit_id":"ede421befe0b5bad9cbb86d40cb04518f9e7f5ba"}],"searchlight_ui/static/searchlight-ui/util/searchlight-query-generator.service.js":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"502baecfcabdc16394b33c8eaa54e127d803dca1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"      function addVersionToQuery() {"},{"line_number":98,"context_line":"        searchlightQuery.version \u003d true;"},{"line_number":99,"context_line":"      }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      function addDefaultQuery() {"}],"source_content_type":"text/javascript","patch_set":3,"id":"bab6814e_b397298f","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":40},"updated":"2016-05-19 20:45:46.000000000","message":"It\u0027s not clear what this is used for","commit_id":"5c620759d8874627d575c20cdf2367adfd3b90f5"}]}
