)]}'
{"searchlight_ui/karma.conf.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"fd81295f18b53e5accb2547c8a134d14f5733368","unresolved":false,"context_lines":[{"line_number":87,"context_line":"      xstaticPath + \u0027rickshaw/data/rickshaw.js\u0027,"},{"line_number":88,"context_line":"      xstaticPath + \u0027angular_smart_table/data/smart-table.js\u0027,"},{"line_number":89,"context_line":"      xstaticPath + \u0027angular_lrdragndrop/data/lrdragndrop.js\u0027,"},{"line_number":90,"context_line":"      xstaticPath + \u0027angular_fileupload/data/ng-file-upload-all.js\u0027,"},{"line_number":91,"context_line":"      xstaticPath + \u0027spin/data/spin.js\u0027,"},{"line_number":92,"context_line":"      xstaticPath + \u0027spin/data/spin.jquery.js\u0027,"},{"line_number":93,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_d77f2415","line":90,"range":{"start_line":90,"start_character":6,"end_line":90,"end_character":68},"updated":"2016-06-29 17:01:57.000000000","message":"dependency failure on master","commit_id":"2ae1169af8fc1422a3a565706a57e30dff1539d3"}],"searchlight_ui/static/searchlight-ui/table/search-table.controller.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5971788cf68ef7e123d3444eba0d55b6b01303cf","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    function getSummaryTemplateUrl(type) {"},{"line_number":221,"context_line":"      return registry.getResourceType(type).summaryTemplateUrl ||"},{"line_number":222,"context_line":"        registry.getDefaultSummaryTemplateUrl();"},{"line_number":223,"context_line":"    }"},{"line_number":224,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_ecf56eed","line":221,"updated":"2016-06-28 20:14:53.000000000","message":"getting resource type","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5971788cf68ef7e123d3444eba0d55b6b01303cf","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        registry.getDefaultSummaryTemplateUrl();"},{"line_number":223,"context_line":"    }"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    function getDetailsUrl(hit) {"},{"line_number":226,"context_line":"      var type \u003d registry.getResourceType(hit._type);"},{"line_number":227,"context_line":"      return type.detailsViews.length \u003e 0 ?"},{"line_number":228,"context_line":"        \u0027project/ngdetails/\u0027 + hit._type + \u0027/\u0027 + type.pathGenerator(hit._source.id) :"}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_8c55cac7","line":225,"updated":"2016-06-28 20:14:53.000000000","message":"I\u0027m just noticing that we have to lookup the resourceType object a lot.  This is a hash lookup, so it should be fast, but I\u0027m still wondering if we should be looking it up once and storing on each hit. in the onSearchResult function above (line 206).\n\nI\u0027m not blocking on this, just posing a question for discussion.","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bcbd40c7fc6e1e9dfcb67551ce193afb6e42364c","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        registry.getDefaultSummaryTemplateUrl();"},{"line_number":223,"context_line":"    }"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    function getDetailsUrl(hit) {"},{"line_number":226,"context_line":"      var type \u003d registry.getResourceType(hit._type);"},{"line_number":227,"context_line":"      return type.detailsViews.length \u003e 0 ?"},{"line_number":228,"context_line":"        \u0027project/ngdetails/\u0027 + hit._type + \u0027/\u0027 + type.pathGenerator(hit._source.id) :"}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_8bddad16","line":225,"in_reply_to":"3aaa91ec_6866872a","updated":"2016-06-28 21:17:48.000000000","message":"Yeah, i\u0027m okay with keeping it this way. Thanks for discussing it.","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"88d5dacc0e0fabdab37fb27020122829b267528c","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        registry.getDefaultSummaryTemplateUrl();"},{"line_number":223,"context_line":"    }"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    function getDetailsUrl(hit) {"},{"line_number":226,"context_line":"      var type \u003d registry.getResourceType(hit._type);"},{"line_number":227,"context_line":"      return type.detailsViews.length \u003e 0 ?"},{"line_number":228,"context_line":"        \u0027project/ngdetails/\u0027 + hit._type + \u0027/\u0027 + type.pathGenerator(hit._source.id) :"}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_6866872a","line":225,"in_reply_to":"3aaa91ec_8c55cac7","updated":"2016-06-28 21:02:16.000000000","message":"I thought about this, and actually I think it\u0027s not a problem; the registry is a single reference, and so you\u0027re right, it\u0027s a hash lookup.  I\u0027d rather do the honest thing and look it up every time, than somehow cache it, which frankly would fall back on the exact same behavior (caching using a lookup). :)","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5971788cf68ef7e123d3444eba0d55b6b01303cf","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    function getDetailsUrl(hit) {"},{"line_number":226,"context_line":"      var type \u003d registry.getResourceType(hit._type);"},{"line_number":227,"context_line":"      return type.detailsViews.length \u003e 0 ?"},{"line_number":228,"context_line":"        \u0027project/ngdetails/\u0027 + hit._type + \u0027/\u0027 + type.pathGenerator(hit._source.id) :"},{"line_number":229,"context_line":"        resourceLocator.getResourceUrl(hit);"},{"line_number":230,"context_line":"    }"},{"line_number":231,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_6ca85e78","line":228,"range":{"start_line":228,"start_character":8,"end_line":228,"end_character":83},"updated":"2016-06-28 20:14:53.000000000","message":"This whole concatenation seems like it should be a common function somewhere in horizon master.  It seems a little brittle to me. I\u0027d probably make it a function on core alongside the route definition [0].\n\nAlso, it is missing webroot.\n\n[0] https://github.com/openstack/horizon/blob/5d618bf4902b96c06d52e804c403355e2b8b1cfd/openstack_dashboard/static/app/core/core.module.js#L54","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"88d5dacc0e0fabdab37fb27020122829b267528c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    function getDetailsUrl(hit) {"},{"line_number":226,"context_line":"      var type \u003d registry.getResourceType(hit._type);"},{"line_number":227,"context_line":"      return type.detailsViews.length \u003e 0 ?"},{"line_number":228,"context_line":"        \u0027project/ngdetails/\u0027 + hit._type + \u0027/\u0027 + type.pathGenerator(hit._source.id) :"},{"line_number":229,"context_line":"        resourceLocator.getResourceUrl(hit);"},{"line_number":230,"context_line":"    }"},{"line_number":231,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_cb57b500","line":228,"range":{"start_line":228,"start_character":8,"end_line":228,"end_character":83},"in_reply_to":"3aaa91ec_6ca85e78","updated":"2016-06-28 21:02:16.000000000","message":"It\u0027s *NOT* missing webroot!  This is very important to understand.  Since this is a relative link, it is using the base path, which incorporates webroot.  That\u0027s part of the value of how this is setup; secondly, it doesn\u0027t matter because it\u0027s Angular routed (as a relative path), and the Angular route excludes the base properly (just as when evaluating paths for routing).\n\nYou are completely right about the fragility of the route; we should have a route service in Horizon.","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bcbd40c7fc6e1e9dfcb67551ce193afb6e42364c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    function getDetailsUrl(hit) {"},{"line_number":226,"context_line":"      var type \u003d registry.getResourceType(hit._type);"},{"line_number":227,"context_line":"      return type.detailsViews.length \u003e 0 ?"},{"line_number":228,"context_line":"        \u0027project/ngdetails/\u0027 + hit._type + \u0027/\u0027 + type.pathGenerator(hit._source.id) :"},{"line_number":229,"context_line":"        resourceLocator.getResourceUrl(hit);"},{"line_number":230,"context_line":"    }"},{"line_number":231,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"3aaa91ec_0bcb7d54","line":228,"range":{"start_line":228,"start_character":8,"end_line":228,"end_character":83},"in_reply_to":"3aaa91ec_cb57b500","updated":"2016-06-28 21:17:48.000000000","message":"oops, forgot to remove the line about webroot.  I picked up on the lack of a forward / after testing (had posted this comment before actually testing and debugging).","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"}],"searchlight_ui/static/searchlight-ui/table/search-table.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5971788cf68ef7e123d3444eba0d55b6b01303cf","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \u003c/td\u003e"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \u003ctd ng-cloak class\u003d\"rsp-p1\"\u003e"},{"line_number":98,"context_line":"          \u003ca href\u003d\"{$ table.getDetailsUrl(hit) $}\"\u003e"},{"line_number":99,"context_line":"            \u003csl-search-highlighter hit\u003d\"hit\""},{"line_number":100,"context_line":"                                   field\u003d\"\u0027name\u0027\""},{"line_number":101,"context_line":"                                   default-value\u003d\"hit._source.name || hit._source.id | noValue\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"3aaa91ec_c204b9c7","line":98,"updated":"2016-06-28 20:14:53.000000000","message":"Rather than put this into the controller, I always intended that the resource locator would either go completely away in favor of a horizon hosted service or the resource locator would just encapsulate the logic to use the registry so fallback would all be centralized in one location (the resource locator service).\n\nhttps://github.com/openstack/searchlight-ui/blob/master/searchlight_ui/static/searchlight-ui/util/resource-locator.service.js#L60-L62\n\nWith that, we can continue use of the filter. If the filter isn\u0027t really desirable, then the slResourceUrl filter should be deleted. However, the table should just inject the locator service and use it rather than code additional logic on top of it.","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bcbd40c7fc6e1e9dfcb67551ce193afb6e42364c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \u003c/td\u003e"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \u003ctd ng-cloak class\u003d\"rsp-p1\"\u003e"},{"line_number":98,"context_line":"          \u003ca href\u003d\"{$ table.getDetailsUrl(hit) $}\"\u003e"},{"line_number":99,"context_line":"            \u003csl-search-highlighter hit\u003d\"hit\""},{"line_number":100,"context_line":"                                   field\u003d\"\u0027name\u0027\""},{"line_number":101,"context_line":"                                   default-value\u003d\"hit._source.name || hit._source.id | noValue\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"3aaa91ec_ebf3919d","line":98,"in_reply_to":"3aaa91ec_ab7189aa","updated":"2016-06-28 21:17:48.000000000","message":"On a related, but also tangent topic, I think we need to start registering more stuff on horizon master soon, including the path generator functions. Even if we don\u0027t have the panels enabled, getting the properties and paths in place would be good (NOT FOR THIS PATCH).","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"88d5dacc0e0fabdab37fb27020122829b267528c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \u003c/td\u003e"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \u003ctd ng-cloak class\u003d\"rsp-p1\"\u003e"},{"line_number":98,"context_line":"          \u003ca href\u003d\"{$ table.getDetailsUrl(hit) $}\"\u003e"},{"line_number":99,"context_line":"            \u003csl-search-highlighter hit\u003d\"hit\""},{"line_number":100,"context_line":"                                   field\u003d\"\u0027name\u0027\""},{"line_number":101,"context_line":"                                   default-value\u003d\"hit._source.name || hit._source.id | noValue\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"3aaa91ec_ab7189aa","line":98,"in_reply_to":"3aaa91ec_c204b9c7","updated":"2016-06-28 21:02:16.000000000","message":"Ah, I see what you\u0027re saying...put the logic into the resource locator.  Works for me!","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5971788cf68ef7e123d3444eba0d55b6b01303cf","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        \u003ctd class\u003d\"actions_column\"\u003e"},{"line_number":137,"context_line":"          \u003cactions"},{"line_number":138,"context_line":"                  allowed\u003d\"table.registry.getResourceType(hit._type).itemActions\""},{"line_number":139,"context_line":"                  type\u003d\"row\""},{"line_number":140,"context_line":"                  item\u003d\"hit._source\""},{"line_number":141,"context_line":"                  result-handler\u003d\"table.actionResultHandler\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"3aaa91ec_ec7e0e69","line":138,"updated":"2016-06-28 20:14:53.000000000","message":"Getting resourceType","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"88d5dacc0e0fabdab37fb27020122829b267528c","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        \u003ctd class\u003d\"actions_column\"\u003e"},{"line_number":137,"context_line":"          \u003cactions"},{"line_number":138,"context_line":"                  allowed\u003d\"table.registry.getResourceType(hit._type).itemActions\""},{"line_number":139,"context_line":"                  type\u003d\"row\""},{"line_number":140,"context_line":"                  item\u003d\"hit._source\""},{"line_number":141,"context_line":"                  result-handler\u003d\"table.actionResultHandler\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"3aaa91ec_8b9bedc8","line":138,"in_reply_to":"3aaa91ec_ec7e0e69","updated":"2016-06-28 21:02:16.000000000","message":"Yep!  I think that is just fine.","commit_id":"b58f9f35174e8d8fc46cbb4afddb0d8ca1ae17f3"}],"searchlight_ui/static/searchlight-ui/util/resource-locator.service.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8ceacc203163f7de58e8154f6445bbc7eb2214cf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"     * @returns {function} This service."},{"line_number":55,"context_line":"    */"},{"line_number":56,"context_line":"    function getResourceUrl(hit) {"},{"line_number":57,"context_line":"      var basePath \u003d $window.WEBROOT;"},{"line_number":58,"context_line":"      var idPattern \u003d \u0027resourceId\u0027;"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      // TODO pull this resource type registry"}],"source_content_type":"text/javascript","patch_set":3,"id":"3aaa91ec_36f4b859","side":"PARENT","line":57,"range":{"start_line":57,"start_character":21,"end_line":57,"end_character":36},"updated":"2016-06-29 13:53:17.000000000","message":"This is not needed; BASE is set on all Angular pages.  Use relative links and all will work well. :)","commit_id":"12d05f31695d94f780a561708b088e053a551f4f"}],"searchlight_ui/static/searchlight-ui/widgets/sl-drawer.directive.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"fd81295f18b53e5accb2547c8a134d14f5733368","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  slDrawer.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027searchlight-ui.basePath\u0027,"},{"line_number":25,"context_line":"    \u0027$window\u0027"},{"line_number":26,"context_line":"  ];"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  /**"}],"source_content_type":"text/javascript","patch_set":6,"id":"3aaa91ec_1797ec48","side":"PARENT","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":13},"updated":"2016-06-29 17:01:57.000000000","message":"linting error on master","commit_id":"12d05f31695d94f780a561708b088e053a551f4f"}]}
