)]}'
{"searchlight_ui/static/searchlight-ui/searchlight-ui.scss":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"dc0c6ad39fd6421232262068c11057669aedaa7e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  height: 50px;"},{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".row .no-padding {"},{"line_number":18,"context_line":"  padding: 0;"},{"line_number":19,"context_line":"  margin: 0;"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-scss","patch_set":7,"id":"3ac371cc_afdc1d13","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":1},"updated":"2016-08-15 23:12:20.000000000","message":"Don\u0027t do this:\n\nDo this:\n\n\n hz-magic-search-context {\n  .searchlight-table-preamble {\n    display: flex;\n\n    .hz-magic-search-bar {\n      flex-grow: 1;\n      flex-shrink: 1;\n      padding-right: $padding-small-vertical;\n\n      .magic-search {\n        border-bottom-right-radius: 0;\n        border-top-right-radius: 0;\n      }\n    }\n\n    .searchlight-play-pause {\n      flex-grow: 0;\n      flex-shrink: 0;\n      max-width: 10%;\n      padding-right: $padding-large-vertical;\n    }\n\n    .searchlight-table-actions {\n      flex-grow: 0;\n      flex-shrink: 0;\n      max-width: 100%;\n\n    }\n  }\n }","commit_id":"151ea57eca97a5c45823173d78153ea155a049f8"}],"searchlight_ui/static/searchlight-ui/table/search-table.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"993362e9de770c9dc42ee522db84f18b9815aa5d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      \u003cdiv class\u003d\"col-sm-10\"\u003e"},{"line_number":15,"context_line":"        \u003cdiv class\u003d\"row\"\u003e"},{"line_number":16,"context_line":"          \u003chz-magic-search-bar class\u003d\"col-sm-11 no-padding\"\u003e\u003c/hz-magic-search-bar\u003e"},{"line_number":17,"context_line":"          \u003cbutton"},{"line_number":18,"context_line":"              class\u003d\"btn btn-default\""},{"line_number":19,"context_line":"              ng-click\u003d\"table.toggleLiveSearch()\"\u003e"},{"line_number":20,"context_line":"            \u003ci"}],"source_content_type":"text/html","patch_set":3,"id":"9ad45d7e_422bd330","line":17,"updated":"2016-08-08 22:53:30.000000000","message":"I think we need a tooltip or a popover here explaining what this is doing. Probably give it 500 or 1000 ms delay.\n\nUse the syntax like in line 102 for proper formatting.","commit_id":"c99e32a816326c3f6a581fae04ef172e41ec0d74"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"cd4262049ab51886053316f9b73de61b550900a1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      \u003cdiv class\u003d\"col-sm-10\"\u003e"},{"line_number":15,"context_line":"        \u003cdiv class\u003d\"row\"\u003e"},{"line_number":16,"context_line":"          \u003chz-magic-search-bar class\u003d\"col-sm-11 no-padding\"\u003e\u003c/hz-magic-search-bar\u003e"},{"line_number":17,"context_line":"          \u003cbutton"},{"line_number":18,"context_line":"              class\u003d\"btn btn-default\""},{"line_number":19,"context_line":"              ng-click\u003d\"table.toggleLiveSearch()\"\u003e"},{"line_number":20,"context_line":"            \u003ci"}],"source_content_type":"text/html","patch_set":3,"id":"9ad45d7e_1bee6222","line":17,"in_reply_to":"9ad45d7e_422bd330","updated":"2016-08-09 00:17:33.000000000","message":"Good idea. I\u0027ll include in next revision.","commit_id":"c99e32a816326c3f6a581fae04ef172e41ec0d74"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"993362e9de770c9dc42ee522db84f18b9815aa5d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"          \u003c/actions\u003e"},{"line_number":157,"context_line":"          \u003cspan"},{"line_number":158,"context_line":"            ng-show\u003d\"hit.dirty\""},{"line_number":159,"context_line":"            class\u003d\"fa fa-refresh fa-lg\"\u003e"},{"line_number":160,"context_line":"          \u003c/span\u003e"},{"line_number":161,"context_line":"        \u003c/td\u003e"},{"line_number":162,"context_line":""}],"source_content_type":"text/html","patch_set":3,"id":"9ad45d7e_e2ada789","line":159,"updated":"2016-08-08 22:53:30.000000000","message":"no spin?  you could use ng-class and do a conditional here if the polling is enabled.\n\nThe refresh icon also could use a tooltip to explain why you see it.","commit_id":"c99e32a816326c3f6a581fae04ef172e41ec0d74"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"47be11e669e5a995b163768e40a0fcfaa3e3069f","unresolved":false,"context_lines":[{"line_number":156,"context_line":"          \u003c/actions\u003e"},{"line_number":157,"context_line":"          \u003cspan"},{"line_number":158,"context_line":"            ng-show\u003d\"hit.dirty\""},{"line_number":159,"context_line":"            class\u003d\"fa fa-refresh fa-lg\"\u003e"},{"line_number":160,"context_line":"          \u003c/span\u003e"},{"line_number":161,"context_line":"        \u003c/td\u003e"},{"line_number":162,"context_line":""}],"source_content_type":"text/html","patch_set":3,"id":"9ad45d7e_dbaa0a70","line":159,"in_reply_to":"9ad45d7e_bb4bd62a","updated":"2016-08-09 00:21:17.000000000","message":"Sounds good.","commit_id":"c99e32a816326c3f6a581fae04ef172e41ec0d74"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"cd4262049ab51886053316f9b73de61b550900a1","unresolved":false,"context_lines":[{"line_number":156,"context_line":"          \u003c/actions\u003e"},{"line_number":157,"context_line":"          \u003cspan"},{"line_number":158,"context_line":"            ng-show\u003d\"hit.dirty\""},{"line_number":159,"context_line":"            class\u003d\"fa fa-refresh fa-lg\"\u003e"},{"line_number":160,"context_line":"          \u003c/span\u003e"},{"line_number":161,"context_line":"        \u003c/td\u003e"},{"line_number":162,"context_line":""}],"source_content_type":"text/html","patch_set":3,"id":"9ad45d7e_bb4bd62a","line":159,"in_reply_to":"9ad45d7e_e2ada789","updated":"2016-08-09 00:17:33.000000000","message":"Good point. With follow-on \"poll dirty\" patch, this icon will always be \"live\" if shown...how about I just replace this one with the normal animated spinner as part of that follow-on?","commit_id":"c99e32a816326c3f6a581fae04ef172e41ec0d74"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"dc0c6ad39fd6421232262068c11057669aedaa7e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"              tooltip-placement\u003d\"top\""},{"line_number":22,"context_line":"              tooltip-popup-delay\u003d\"500\""},{"line_number":23,"context_line":"              tooltip-trigger\u003d\"mouseenter\"\u003e"},{"line_number":24,"context_line":"            \u003ci"},{"line_number":25,"context_line":"                class\u003d\"fa\""},{"line_number":26,"context_line":"                ng-class\u003d\"table.isLiveSearch() ? \u0027fa-pause\u0027 : \u0027fa-play\u0027\"\u003e"},{"line_number":27,"context_line":"            \u003c/i\u003e"},{"line_number":28,"context_line":"          \u003c/button\u003e"},{"line_number":29,"context_line":"        \u003c/div\u003e"},{"line_number":30,"context_line":"      \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"3ac371cc_2691799a","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":16},"updated":"2016-08-15 23:12:20.000000000","message":"Just noticed this.  We shouldn\u0027t use \u003ci\u003e  this should be span:\n\n              \u003cspan class\u003d\"fa\"\n                    ng-class\u003d\"table.isLiveSearch() ? \u0027fa-pause\u0027 : \u0027fa-play\u0027\"\u003e\n              \u003c/span\u003e","commit_id":"151ea57eca97a5c45823173d78153ea155a049f8"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"dc0c6ad39fd6421232262068c11057669aedaa7e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u003cactions class\u003d\"pull-right\" allowed\u003d\"table.globalActions\" type\u003d\"row\"\u003e"},{"line_number":33,"context_line":"        \u003c/actions\u003e"},{"line_number":34,"context_line":"      \u003c/div\u003e"},{"line_number":35,"context_line":"    \u003c/div\u003e"},{"line_number":36,"context_line":"    \u003ctable"},{"line_number":37,"context_line":"            hz-table ng-cloak"},{"line_number":38,"context_line":"            st-magic-search"}],"source_content_type":"text/html","patch_set":7,"id":"3ac371cc_6fd22502","line":35,"updated":"2016-08-15 23:12:20.000000000","message":"The layout here is all wonky. Line 13 to 35 should be replaced with this and then see my comments on the scss file.\n\n    \u003cdiv class\u003d\"row\"\u003e\n      \u003cdiv class\u003d\"searchlight-table-preamble col-xs-12\"\u003e\n        \u003chz-magic-search-bar class\u003d\"hz-magic-search-bar\"\u003e\u003c/hz-magic-search-bar\u003e\n        \u003cdiv class\u003d\"searchlight-play-pause\"\u003e\n          \u003cbutton\n                  class\u003d\"btn btn-default\"\n                  ng-click\u003d\"table.toggleLiveSearch()\"\n                  tooltip\u003d\"{$ table.playPauseTooltip() $}\"\n                  tooltip-placement\u003d\"top\"\n                  tooltip-popup-delay\u003d\"500\"\n                  tooltip-trigger\u003d\"mouseenter\"\u003e\n              \u003cspan class\u003d\"fa\"\n                    ng-class\u003d\"table.isLiveSearch() ? \u0027fa-pause\u0027 : \u0027fa-play\u0027\"\u003e\n              \u003c/span\u003e\n          \u003c/button\u003e\n        \u003c/div\u003e\n        \u003cactions class\u003d\"searchlight-table-actions\"\n                 allowed\u003d\"table.globalActions\"\n                 type\u003d\"row\"\u003e\n        \u003c/actions\u003e\n      \u003c/div\u003e\n    \u003c/div\u003e","commit_id":"151ea57eca97a5c45823173d78153ea155a049f8"}],"searchlight_ui/static/searchlight-ui/util/searchlight-search-helper.service.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"33fd685583b4e192428d2a11d4ac9a9246284ef9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    function cancelRepeatSearch() {"},{"line_number":83,"context_line":"      if (settingsPollster !\u003d\u003d null) {"},{"line_number":84,"context_line":"        // We just always will reset the next poll interval to"},{"line_number":85,"context_line":"        // come after the latest search no matter what the"},{"line_number":86,"context_line":"        // cause of the current search was."}],"source_content_type":"text/javascript","patch_set":5,"id":"9ad45d7e_fa7351e5","line":83,"range":{"start_line":83,"start_character":10,"end_line":83,"end_character":35},"updated":"2016-08-09 21:05:33.000000000","message":"In general I\u0027d prefer a slightly different approach as !\u003d\u003d null is kind of Java-esque, and doesn\u0027t handle the \u0027undefined\u0027 situation.  I know, it is set it to null above, but in general I see less of the use of null in this way in JS because of the potential for confusion; and if it is used it\u0027s usually checked for using more inclusive means than !\u003d\u003d null.","commit_id":"c28e4bcbfcab65166bf1889fb3b134cb8808a989"}]}
