)]}'
{"searchlight_ui/static/searchlight-ui/util/searchlight-search-helper.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e6bf9fe8d593635762f2deecd4d6b076311423d6","unresolved":false,"context_lines":[{"line_number":133,"context_line":"          // isn\u0027t exposed by the API, this ID is intentionally not the same to prevent its"},{"line_number":134,"context_line":"          // accidental use in calls back to the searchlight API. All uses of .id should"},{"line_number":135,"context_line":"          // treat it as an opaque, unique identifier of 1 item in the searchlight index."},{"line_number":136,"context_line":"          hit.id \u003d hit._type + hit._id;"},{"line_number":137,"context_line":"        });"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        queryOptions.onSearchSuccess(response);"}],"source_content_type":"text/javascript","patch_set":4,"id":"3ac371cc_f572697b","line":136,"updated":"2016-08-15 20:32:57.000000000","message":".id worries me a little a bit, because it might be interpreted as coming from SL, but I don\u0027t have a dramatically better name (maybe slui_id). It does get a little confusing when I look at add items to cache in search-table.controller.js it uses item.id, but it isn\u0027t this id, but is little confusing at first since \"id\" is used everywhere.","commit_id":"86a1949a65756ae0c125d2331b09f956feb7cec0"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"7161fd86a89878daf8a9679bcaa117ab1019d5e9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"          // isn\u0027t exposed by the API, this ID is intentionally not the same to prevent its"},{"line_number":134,"context_line":"          // accidental use in calls back to the searchlight API. All uses of .id should"},{"line_number":135,"context_line":"          // treat it as an opaque, unique identifier of 1 item in the searchlight index."},{"line_number":136,"context_line":"          hit.id \u003d hit._type + hit._id;"},{"line_number":137,"context_line":"        });"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        queryOptions.onSearchSuccess(response);"}],"source_content_type":"text/javascript","patch_set":4,"id":"3ac371cc_4b644b48","line":136,"in_reply_to":"3ac371cc_f572697b","updated":"2016-08-16 18:00:04.000000000","message":"Yes. I know what you mean. Here is how I justified it to myself.\n\n1) Hit wraps the _source, so any attributes on hit directly are searchlight related rather than resource related.\n2) Searchlight appears to add attributes with \"_\" (_type, _id, etc)\n3) hit.id therefore is related to the searchlight hit...but not provided by the searchlight service itself.\n\nThat\u0027s a little shaky, but I\u0027m open to suggestions. Other names that make sense in this service started to get confusing when code actually uses them to do stuff :(","commit_id":"86a1949a65756ae0c125d2331b09f956feb7cec0"}]}
