)]}'
{"README.rst":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"805b54131bc27a743f329f705fb98254c76e2687","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    pip install dist/searchlight-ui-0.0.0.tar.gz (use appropriate version)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Running npm Features"},{"line_number":110,"context_line":"--------------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"To perform various testing of the JavaScript features in a development"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_43c63268","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":20},"updated":"2016-08-15 16:58:09.000000000","message":"Im not sure how npm is related to python-dev and tox. Arent the two independent?","commit_id":"faade4ba9d0b7d69abec4abefe2b8a434d89a93a"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"2f87b3cd10327a319ac0c227d8f902c360a80bb7","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    pip install dist/searchlight-ui-0.0.0.tar.gz (use appropriate version)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Running npm Features"},{"line_number":110,"context_line":"--------------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"To perform various testing of the JavaScript features in a development"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_6ea6b5c2","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":20},"in_reply_to":"3ac371cc_43c63268","updated":"2016-08-15 17:15:14.000000000","message":"If you look at:\n\nhttps://github.com/openstack/searchlight-ui/blob/master/package.json#L23\n\nYou will see the relationship.  It has to largely do with the acquisition of dependencies like XStatic packages.","commit_id":"faade4ba9d0b7d69abec4abefe2b8a434d89a93a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"0dccdfc463ddad718eaec7ee732c445eaec0218b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"environment, you will want to run commands like `npm run lint` and"},{"line_number":114,"context_line":"`npm run test`.  To do this, you must:"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"1. Install appropriate development packages for tox to run.  In Ubuntu this"},{"line_number":117,"context_line":"   may include, for example, \u0027python-dev\u0027."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"2. Run `npm install` to install the npm packages."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_b52c0303","line":116,"range":{"start_line":116,"start_character":11,"end_line":116,"end_character":43},"updated":"2016-08-17 15:23:01.000000000","message":"Can you narrow this down a bit?  Perhaps just \"Run \u0027tox\u0027...depending on the environment, tox may fail to create the venv and give a message with the required dependencies. \u0027source .tox/venv/bin/activate\u0027 to activate the tox venv, then use pip to manually install the required dependencies\"\n\nIf there *are* dependencies missing...can they just be added to test-requirements.txt instead?","commit_id":"faade4ba9d0b7d69abec4abefe2b8a434d89a93a"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"ad2cd0588c5f2a80ecf042265b372336c23d31c9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"environment, you will want to run commands like `npm run lint` and"},{"line_number":114,"context_line":"`npm run test`.  To do this, you must:"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"1. Install appropriate development packages for tox to run.  In Ubuntu this"},{"line_number":117,"context_line":"   may include, for example, \u0027python-dev\u0027."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"2. Run `npm install` to install the npm packages."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_e5efdb1b","line":116,"range":{"start_line":116,"start_character":11,"end_line":116,"end_character":43},"in_reply_to":"3ac371cc_b52c0303","updated":"2016-08-17 20:25:12.000000000","message":"Yeah, the main problem is that it doesn\u0027t complain about the needed dependencies at a certain level, like if the python-dev libraries are missing.  You\u0027ll just get a nebulous error about Python.h not being present.  That said, you\u0027re generally expected to load them in as described in this quickstart document.\n\nhttp://docs.openstack.org/developer/horizon/quickstart.html\n\nThe reason I ran into it was actually because we didn\u0027t limit the version originally, so I had the 2.7 dev libs but not 3.x, which it wanted to use.  So this is less of an issue, but a good reminder.","commit_id":"faade4ba9d0b7d69abec4abefe2b8a434d89a93a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"0dccdfc463ddad718eaec7ee732c445eaec0218b","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"2. Run `npm install` to install the npm packages."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"3. Run `tox` to ensure that you can successfully create the environments"},{"line_number":122,"context_line":"   needed."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"If those are successful, you should now be able to run `npm run lint` and"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_35ddb3e0","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":11},"updated":"2016-08-17 15:23:01.000000000","message":"This isn\u0027t really necessary since the first step of \u0027npm run test\u0027 is \u0027tox -evenv\u0027\n\nI think the instructions boil down to:\n\n1) install npm using the package manager for your operating system (for example apt-get install nodejs)\n\n2) run \u0027npm install\u0027 to install required npm dependencies\n\n3) run \u0027npm run test\u0027 to run the tests, and \u0027npm run lint\u0027 for the linter.\n \n  i) On some systems \u0027python-dev\u0027 may need to be installed for \u0027tox\u0027 to be successful","commit_id":"faade4ba9d0b7d69abec4abefe2b8a434d89a93a"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"2. This will create a python egg in the dist folder, which can be used to"},{"line_number":104,"context_line":"   install on the horizon machine or within horizon\u0027s python virtual"},{"line_number":105,"context_line":"   environment (prepend wih ``./tools/with_venv.sh``)::"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    pip install dist/searchlight-ui-0.0.0.tar.gz (use appropriate version)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_49c3f28a","line":105,"range":{"start_line":105,"start_character":24,"end_line":105,"end_character":27},"updated":"2016-08-31 04:06:27.000000000","message":"While we are making changes in this file, can we fix this typo?","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    pip install dist/searchlight-ui-0.0.0.tar.gz (use appropriate version)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Running npm Features"},{"line_number":110,"context_line":"--------------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"To perform various testing of the JavaScript features in a development"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_491f7209","line":109,"updated":"2016-08-31 04:06:27.000000000","message":"I would be more explicit with the header. Not everyone will know what npm is used for, so they may just skip over this part. I would use something more descriptive and attention-grabbing:\n\n    Verifying JavaScript features.","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"To perform various testing of the JavaScript features in a development"},{"line_number":113,"context_line":"environment, you will want to run commands like `npm run lint` and"},{"line_number":114,"context_line":"`npm run test`.  To do this, you must:"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"1. Install appropriate development packages for tox to run.  In Ubuntu this"},{"line_number":117,"context_line":"   may include, for example, \u0027python-dev\u0027."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_691c3614","line":114,"updated":"2016-08-31 04:06:27.000000000","message":"I\u0027m not sure who is the audience of this part of the README, but if they include folks who are newish to searchlight-ui/JS development, I would be more explicit in this description.\n\nIt may be nice to include all of the relevant commands. Also, when specifying commands in an *.rst file, we need to use double quotes ``.\n\nMaybe something like this:\n\n    The Node.js package manager `npm` can be used to verify\n    JavaScript features in a development environment. The\n    commands to do this include ``npm run lint`` and ``npm\n    run test``.","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":114,"context_line":"`npm run test`.  To do this, you must:"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"1. Install appropriate development packages for tox to run.  In Ubuntu this"},{"line_number":117,"context_line":"   may include, for example, \u0027python-dev\u0027."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"2. Run `npm install` to install the npm packages."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_09aaca85","line":117,"updated":"2016-08-31 04:06:27.000000000","message":"Can we add a link to the instructions for this:\n\nhttp://docs.openstack.org/developer/horizon/quickstart.html\n\nOtherwise this may turn into an exercise in frustration for a lot of folks.","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":116,"context_line":"1. Install appropriate development packages for tox to run.  In Ubuntu this"},{"line_number":117,"context_line":"   may include, for example, \u0027python-dev\u0027."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"2. Run `npm install` to install the npm packages."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"If those are successful, you should now be able to run `npm run lint` and"},{"line_number":122,"context_line":"`npm run test`."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_29394e42","line":119,"updated":"2016-08-31 04:06:27.000000000","message":"We need double quotes here:\n\n    ``npm install``","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"2. Run `npm install` to install the npm packages."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"If those are successful, you should now be able to run `npm run lint` and"},{"line_number":122,"context_line":"`npm run test`."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When running the tests, if it appears to be using a non-current version of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_693b5639","line":121,"range":{"start_line":121,"start_character":55,"end_line":121,"end_character":69},"updated":"2016-08-31 04:06:27.000000000","message":"``npm run lint``","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":119,"context_line":"2. Run `npm install` to install the npm packages."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"If those are successful, you should now be able to run `npm run lint` and"},{"line_number":122,"context_line":"`npm run test`."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When running the tests, if it appears to be using a non-current version of"},{"line_number":125,"context_line":"Horizon, you may want to clear your pip cache and clear .tox/venv.  The"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_a9455eb4","line":122,"range":{"start_line":122,"start_character":0,"end_line":122,"end_character":14},"updated":"2016-08-31 04:06:27.000000000","message":"``npm run test``","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":121,"context_line":"If those are successful, you should now be able to run `npm run lint` and"},{"line_number":122,"context_line":"`npm run test`."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When running the tests, if it appears to be using a non-current version of"},{"line_number":125,"context_line":"Horizon, you may want to clear your pip cache and clear .tox/venv.  The"},{"line_number":126,"context_line":"pip cache is found at:"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_a94abeaa","line":124,"range":{"start_line":124,"start_character":24,"end_line":124,"end_character":37},"updated":"2016-08-31 04:06:27.000000000","message":"Can we be more explicit in how this will appear? I\u0027m assuming this means it will fail. Can we show the failing messages or the kind of failing messages to look for?","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":122,"context_line":"`npm run test`."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When running the tests, if it appears to be using a non-current version of"},{"line_number":125,"context_line":"Horizon, you may want to clear your pip cache and clear .tox/venv.  The"},{"line_number":126,"context_line":"pip cache is found at:"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Linux and Unix: ``~/.cache/pip``  # respects the XDG_CACHE_HOME directory."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_69c6f64a","line":125,"range":{"start_line":125,"start_character":50,"end_line":125,"end_character":65},"updated":"2016-08-31 04:06:27.000000000","message":"What does this mean? Does it mean \"rm -rf .tox\"? In which case, do we also need to remind the reader to rebuild the virtual environment (e.g. \"tox -evenv --notest\") for further development.","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When running the tests, if it appears to be using a non-current version of"},{"line_number":125,"context_line":"Horizon, you may want to clear your pip cache and clear .tox/venv.  The"},{"line_number":126,"context_line":"pip cache is found at:"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Linux and Unix: ``~/.cache/pip``  # respects the XDG_CACHE_HOME directory."},{"line_number":129,"context_line":"OS X: ``~/Library/Caches/pip``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_e9e046cf","line":126,"updated":"2016-08-31 04:06:27.000000000","message":"Same thing here. What does clear mean? Does it mean:\n\n    % rm -rf ~/.cache/pip\n\nor:\n\n    % rm -rf ~/.cache/pip/*\n\nor clearing out some files under ~/.cache/pip?","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"6c7ac336fa77509f3ee882105a46d1987069ae66","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Horizon, you may want to clear your pip cache and clear .tox/venv.  The"},{"line_number":126,"context_line":"pip cache is found at:"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Linux and Unix: ``~/.cache/pip``  # respects the XDG_CACHE_HOME directory."},{"line_number":129,"context_line":"OS X: ``~/Library/Caches/pip``"},{"line_number":130,"context_line":"Windows: ``\u003cCSIDL_LOCAL_APPDATA\u003e\\pip\\Cache``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_6c3d24bb","line":128,"range":{"start_line":128,"start_character":49,"end_line":128,"end_character":63},"updated":"2016-08-31 04:06:27.000000000","message":"I\u0027m assuming this is ok. If someone doesn\u0027t find ~/.cache/pip, this comment should be enough for them to go looking for the setting of XDG_CACHE_HOME. And then append \"/pip\" to it (and not \"/.cache/pip\")","commit_id":"9be71a9b3d644c0780b1e80a4f2fe5973f0f43db"}]}