)]}'
{"searchlight_ui/static/searchlight-ui/table/search-table.html":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"d3b2692a0d3d130107d16c013894864dbb29506a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            \u003csl-search-highlighter hit\u003d\"hit\""},{"line_number":110,"context_line":"                                   field\u003d\"\u0027name\u0027\""},{"line_number":111,"context_line":"                                   default-value\u003d\"hit._source.name || hit._source.id | noValue\"\u003e"},{"line_number":112,"context_line":"            \u003c/sl-search-highlighter\u003e"},{"line_number":113,"context_line":"          \u003c/a\u003e"},{"line_number":114,"context_line":"        \u003c/td\u003e"},{"line_number":115,"context_line":""}],"source_content_type":"text/html","patch_set":2,"id":"1ac06dbe_d24de3c5","line":112,"updated":"2016-08-24 18:48:58.000000000","message":"Does this block need to be protected by a ng-if\u003d\"table.searchSettings.settings.highlighting.enable\" check? The block in \"util/sl-search-highlighter.html\" will display a highlighted field. Actually it seems that the protection should be placed in the file util/sl-search-highlighter.html. That way if we uncomment line 143, it will still work as expected.","commit_id":"65b1ffd33ec76f3112ae1c154e50042c51efdbd7"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"442ce1f06ecdd38698d3633f8287d347980c7dec","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            \u003csl-search-highlighter hit\u003d\"hit\""},{"line_number":110,"context_line":"                                   field\u003d\"\u0027name\u0027\""},{"line_number":111,"context_line":"                                   default-value\u003d\"hit._source.name || hit._source.id | noValue\"\u003e"},{"line_number":112,"context_line":"            \u003c/sl-search-highlighter\u003e"},{"line_number":113,"context_line":"          \u003c/a\u003e"},{"line_number":114,"context_line":"        \u003c/td\u003e"},{"line_number":115,"context_line":""}],"source_content_type":"text/html","patch_set":2,"id":"1ac06dbe_9c8255c7","line":112,"in_reply_to":"1ac06dbe_d24de3c5","updated":"2016-08-24 21:48:36.000000000","message":"Good idea on the consolidation, but it actually gets messy in a hurry and I don\u0027t think it\u0027d save us anything.\n\nThe directive uses isolate scope.  The enabled setting comes in via the controller, which is per table instance.  I don\u0027t want to inject the settings service because then it is possible you are going around the controller\u0027s version of the settings.  So, I\u0027d have to add an \"enabled\" input to the directive which would be the same thing as I\u0027d put in ng-if.  I\u0027d then have to put an additional ng-if check inside of that HTML to see if it is enabled. So, I\u0027d be passing into enabled a reference to what I\u0027d put on ng-if anyway. The ng-if inside of it actually is already just checking to see if highlighting exists. which is roughly equivalent to what it is already doing, because that field is removed if highlighting is not enabled:\n\nhttps://github.com/openstack/searchlight-ui/blob/master/searchlight_ui/static/searchlight-ui/util/searchlight-query-utils.service.js#L210-L213\n\nThat said, I did see a tweak I can do in the html.","commit_id":"65b1ffd33ec76f3112ae1c154e50042c51efdbd7"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"d3b2692a0d3d130107d16c013894864dbb29506a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \u003c/td\u003e"},{"line_number":131,"context_line":"        \u003ctd ng-if\u003d\"table.searchSettings.settings.highlighting.enabled\""},{"line_number":132,"context_line":"            class\u003d\"rsp-p2\"\u003e"},{"line_number":133,"context_line":"          \u003cul ng-if\u003d\"hit.highlight\""},{"line_number":134,"context_line":"              class\u003d\"list-unstyled\""},{"line_number":135,"context_line":"              ng-repeat\u003d\"(field, value) in hit.highlight\"\u003e"},{"line_number":136,"context_line":"            \u003cli ng-if\u003d\"!field.endsWith(\u0027.raw\u0027)\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"1ac06dbe_92dc0b76","line":133,"updated":"2016-08-24 18:48:58.000000000","message":"I\u0027m assuming it is ok to have an empty \u003cUL\u003e\u003c/UL\u003e block. Which can happen if highlighting is enabled and all of the \"ng-if\" checks on line 136 fails. The HTML Is still valid.","commit_id":"65b1ffd33ec76f3112ae1c154e50042c51efdbd7"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"442ce1f06ecdd38698d3633f8287d347980c7dec","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \u003c/td\u003e"},{"line_number":131,"context_line":"        \u003ctd ng-if\u003d\"table.searchSettings.settings.highlighting.enabled\""},{"line_number":132,"context_line":"            class\u003d\"rsp-p2\"\u003e"},{"line_number":133,"context_line":"          \u003cul ng-if\u003d\"hit.highlight\""},{"line_number":134,"context_line":"              class\u003d\"list-unstyled\""},{"line_number":135,"context_line":"              ng-repeat\u003d\"(field, value) in hit.highlight\"\u003e"},{"line_number":136,"context_line":"            \u003cli ng-if\u003d\"!field.endsWith(\u0027.raw\u0027)\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"1ac06dbe_fc4a69ab","line":133,"in_reply_to":"1ac06dbe_92dc0b76","updated":"2016-08-24 21:48:36.000000000","message":"It is okay.","commit_id":"65b1ffd33ec76f3112ae1c154e50042c51efdbd7"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"d3b2692a0d3d130107d16c013894864dbb29506a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"              {$ hit._type | slResourceLabeler: field $}"},{"line_number":138,"context_line":"            \u003c/li\u003e"},{"line_number":139,"context_line":"          \u003c/ul\u003e"},{"line_number":140,"context_line":"          \u003cdiv ng-show\u003d\"!hit.highlight\" translate\u003e-\u003c/div\u003e"},{"line_number":141,"context_line":"        \u003c/td\u003e"},{"line_number":142,"context_line":"        \u003c!-- td class\u003d\"rsp-p3 truncate\"\u003e"},{"line_number":143,"context_line":"          \u003csl-search-highlighter hit\u003d\"hit\""}],"source_content_type":"text/html","patch_set":2,"id":"1ac06dbe_f29e1fb7","line":140,"updated":"2016-08-24 18:48:58.000000000","message":"Is there a reason we are using \"ng-show\" instead of \"ng-if\" here? Do we always want the DIV tag defined (but hidden). Is it referenced somewhere else? Otherwise it seems better to remove it from the DOM using \"ng-if\".","commit_id":"65b1ffd33ec76f3112ae1c154e50042c51efdbd7"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"442ce1f06ecdd38698d3633f8287d347980c7dec","unresolved":false,"context_lines":[{"line_number":137,"context_line":"              {$ hit._type | slResourceLabeler: field $}"},{"line_number":138,"context_line":"            \u003c/li\u003e"},{"line_number":139,"context_line":"          \u003c/ul\u003e"},{"line_number":140,"context_line":"          \u003cdiv ng-show\u003d\"!hit.highlight\" translate\u003e-\u003c/div\u003e"},{"line_number":141,"context_line":"        \u003c/td\u003e"},{"line_number":142,"context_line":"        \u003c!-- td class\u003d\"rsp-p3 truncate\"\u003e"},{"line_number":143,"context_line":"          \u003csl-search-highlighter hit\u003d\"hit\""}],"source_content_type":"text/html","patch_set":2,"id":"1ac06dbe_bcd751be","line":140,"in_reply_to":"1ac06dbe_f29e1fb7","updated":"2016-08-24 21:48:36.000000000","message":"no, fine to change to ng-if","commit_id":"65b1ffd33ec76f3112ae1c154e50042c51efdbd7"}]}