)]}'
{"searchlight/cmd/manage.py":[{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"50077ac7ff2c07dca6fd57599e14744638da8511","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        namespace \u003d \u0027searchlight.index_backend\u0027"},{"line_number":40,"context_line":"        ext_manager \u003d stevedore.extension.ExtensionManager("},{"line_number":41,"context_line":"            namespace, invoke_on_load\u003dTrue)"},{"line_number":42,"context_line":"        for ext in ext_manager.extensions:"},{"line_number":43,"context_line":"            try:"},{"line_number":44,"context_line":"                ext.obj.setup()"},{"line_number":45,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_5578638f","line":42,"updated":"2015-06-30 13:30:09.000000000","message":"The following code should reuse existing get_search_plugins method located in the searchlight.common.utils if we want for now to index all available resources.","commit_id":"54740ba85a82e21c9b5debbceae6a4b5b82b2025"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"6a1a8b2e43f712afa86bf95d8864abc6d53f5d92","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        namespace \u003d \u0027searchlight.index_backend\u0027"},{"line_number":40,"context_line":"        ext_manager \u003d stevedore.extension.ExtensionManager("},{"line_number":41,"context_line":"            namespace, invoke_on_load\u003dTrue)"},{"line_number":42,"context_line":"        for ext in ext_manager.extensions:"},{"line_number":43,"context_line":"            try:"},{"line_number":44,"context_line":"                ext.obj.setup()"},{"line_number":45,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_15bc2d04","line":42,"updated":"2015-06-30 04:41:57.000000000","message":"We should allow for syncing a specific resource type. So, this is fine if a specific resource type isn\u0027t passed in, but if a specific one (or list of them) is/are passed in then it should only do that one.  I\u0027m sure there are other options and we should really think through the possibilities, so I\u0027d be easily convinced that should be deferred to a follow on patch as well.","commit_id":"54740ba85a82e21c9b5debbceae6a4b5b82b2025"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"5244c736c972c0214a0545fdaa71e338986389df","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        namespace \u003d \u0027searchlight.index_backend\u0027"},{"line_number":40,"context_line":"        ext_manager \u003d stevedore.extension.ExtensionManager("},{"line_number":41,"context_line":"            namespace, invoke_on_load\u003dTrue)"},{"line_number":42,"context_line":"        for ext in ext_manager.extensions:"},{"line_number":43,"context_line":"            try:"},{"line_number":44,"context_line":"                ext.obj.setup()"},{"line_number":45,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_65af797d","line":42,"in_reply_to":"ba3cc151_5578638f","updated":"2015-07-02 15:26:22.000000000","message":"Yeah.. i don\u0027t want to go too crazy on this patch. We can make additions later. Agree it should use get_search_plugins, will do","commit_id":"54740ba85a82e21c9b5debbceae6a4b5b82b2025"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"50077ac7ff2c07dca6fd57599e14744638da8511","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                                   \u0027e\u0027: e})"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def add_command_parsers(subparsers):"},{"line_number":52,"context_line":"    \"\"\"Adds any commands and subparsers for their actions. This code\u0027s"},{"line_number":53,"context_line":"    from the Glance equivalent."},{"line_number":54,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_a202d709","line":51,"updated":"2015-06-30 13:30:09.000000000","message":"It would be better if we store available commands in some dict. It will provide easy way for adding new commands without modifying this method. Similar approach to the nova \u0026 cinder which stores commands in the CATEGORIES dict.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/cmd/manage.py#L483\n\nhttps://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1303","commit_id":"54740ba85a82e21c9b5debbceae6a4b5b82b2025"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"50077ac7ff2c07dca6fd57599e14744638da8511","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        parser \u003d category_subparsers.add_parser(action)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        action_kwargs \u003d []"},{"line_number":66,"context_line":"        for args, kwargs in getattr(action_fn, \u0027args\u0027, []):"},{"line_number":67,"context_line":"            kwargs.setdefault(\u0027dest\u0027, args[0][2:])"},{"line_number":68,"context_line":"            if kwargs[\u0027dest\u0027].startswith(\u0027action_kwarg_\u0027):"},{"line_number":69,"context_line":"                action_kwargs.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_35deff11","line":66,"updated":"2015-06-30 13:30:09.000000000","message":"Do we need the code within L67-L73? In nova it has been introduced due to historical reason, because they support both `flavor` and `instance_type` as the same command. I do not see any point in maintaining it in our codebase.\n\n\nhttps://review.openstack.org/#/c/19896/2","commit_id":"54740ba85a82e21c9b5debbceae6a4b5b82b2025"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"5244c736c972c0214a0545fdaa71e338986389df","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        parser \u003d category_subparsers.add_parser(action)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        action_kwargs \u003d []"},{"line_number":66,"context_line":"        for args, kwargs in getattr(action_fn, \u0027args\u0027, []):"},{"line_number":67,"context_line":"            kwargs.setdefault(\u0027dest\u0027, args[0][2:])"},{"line_number":68,"context_line":"            if kwargs[\u0027dest\u0027].startswith(\u0027action_kwarg_\u0027):"},{"line_number":69,"context_line":"                action_kwargs.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_a58b411e","line":66,"in_reply_to":"ba3cc151_35deff11","updated":"2015-07-02 15:26:22.000000000","message":"No, probably not. I wasn\u0027t sure of the history behind this in nova and glance","commit_id":"54740ba85a82e21c9b5debbceae6a4b5b82b2025"}],"setup.cfg":[{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"33696a6302393bac5ba99860b527ee94c2466739","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    searchlight-manage \u003d searchlight.cmd.manage:main"},{"line_number":26,"context_line":"oslo.config.opts \u003d"},{"line_number":27,"context_line":"    searchlight.api \u003d searchlight.opts:list_api_opts"},{"line_number":28,"context_line":"searchlight.index_backend \u003d"},{"line_number":29,"context_line":"    image \u003d searchlight.elasticsearch.plugins.glance.images:ImageIndex"},{"line_number":30,"context_line":"    metadef \u003d searchlight.elasticsearch.plugins.glance.metadefs:MetadefIndex"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ba3cc151_48c937ab","line":28,"updated":"2015-07-02 12:48:56.000000000","message":"I think searchlight.index_backend could also be renamed to something that means a plugin like may be searchlight.es_plugin","commit_id":"54740ba85a82e21c9b5debbceae6a4b5b82b2025"}]}