)]}'
{"doc/source/plugins/nova.rst":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"7f3e66b21766ac5eab14a0de1877a7d76e4c3dc2","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Turn on Notifications::"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Open nova-api.conf and make the following changes::"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    notification_driver \u003d messaging"},{"line_number":28,"context_line":"    notification_topics \u003d searchlight_indexer"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a4dcd0f_a9c5e60a","line":25,"updated":"2015-08-14 17:18:41.000000000","message":"should be nova.conf","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"0615c256ee122215b5e462ded058de1f0cd5d3d0","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Turn on Notifications::"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Open nova-api.conf and make the following changes::"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    notification_driver \u003d messaging"},{"line_number":28,"context_line":"    notification_topics \u003d searchlight_indexer"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa1b9901_30d89553","line":25,"in_reply_to":"1a4dcd0f_a9c5e60a","updated":"2015-08-17 15:28:07.000000000","message":"Done","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bb0dd73d7e8931f1be7e925f2142b51fb64c8bc5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    notification_topics \u003d searchlight_indexer"},{"line_number":29,"context_line":"    rpc_backend \u003d \u0027rabbit\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Restart nova API and nova scheduler."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a4dcd0f_bfdaeae7","line":31,"updated":"2015-08-14 22:46:28.000000000","message":"The notification handle is also looking for neutron events.  We need to doc that.","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"0615c256ee122215b5e462ded058de1f0cd5d3d0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    notification_topics \u003d searchlight_indexer"},{"line_number":29,"context_line":"    rpc_backend \u003d \u0027rabbit\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Restart nova API and nova scheduler."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa1b9901_10d3113a","line":31,"in_reply_to":"1a4dcd0f_bfdaeae7","updated":"2015-08-17 15:28:07.000000000","message":"Done","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"0bea89af90cee91a9cedaf6baa00afc6f4cc06bf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    notification_topics \u003d searchlight_indexer"},{"line_number":29,"context_line":"    rpc_backend \u003d \u0027rabbit\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Restart nova API and nova scheduler."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Neutron Configuration"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"fa1b9901_1e2bd195","line":31,"updated":"2015-08-25 00:56:28.000000000","message":"You put the devstack service in parenthesis for neutron.  Probably should do the same here for nova.","commit_id":"e538b39db4e75e66d9b9501756692e79f104a594"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"b40f8d036b0cd683ec62790145caff445248e89b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    notification_topics \u003d searchlight_indexer"},{"line_number":29,"context_line":"    rpc_backend \u003d \u0027rabbit\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Restart nova API and nova scheduler."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Neutron Configuration"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"fa1b9901_dfb1af90","line":31,"in_reply_to":"fa1b9901_1e2bd195","updated":"2015-08-25 20:04:35.000000000","message":"Done","commit_id":"e538b39db4e75e66d9b9501756692e79f104a594"}],"searchlight/elasticsearch/plugins/nova/__init__.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"INDEX_FLAVORS \u003d True"},{"line_number":29,"context_line":"INDEX_IMAGES \u003d True"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def serialize_nova_server(server):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_7c46f922","line":29,"updated":"2015-07-30 00:04:58.000000000","message":"Yikes, we need per plugin config.","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"43fd2a726acef1b5b9318cf431e889fbb6fd4b90","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"INDEX_FLAVORS \u003d True"},{"line_number":29,"context_line":"INDEX_IMAGES \u003d True"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def serialize_nova_server(server):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_1e8a8e1b","line":29,"in_reply_to":"3a50d1a3_7c46f922","updated":"2015-08-06 23:14:14.000000000","message":"Agreed :)","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        server \u003d nc_client.servers.get(server)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    LOG.debug(\"Serializing server %s for tenant %s\","},{"line_number":38,"context_line":"              server.id, server.tenant_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    if INDEX_FLAVORS:"},{"line_number":41,"context_line":"        # TODO(sjmc7): cache this"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_dc34edad","line":38,"updated":"2015-07-30 00:04:58.000000000","message":"Logs maybe should say \"project\" just to use current day terminology.","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"43fd2a726acef1b5b9318cf431e889fbb6fd4b90","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        server \u003d nc_client.servers.get(server)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    LOG.debug(\"Serializing server %s for tenant %s\","},{"line_number":38,"context_line":"              server.id, server.tenant_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    if INDEX_FLAVORS:"},{"line_number":41,"context_line":"        # TODO(sjmc7): cache this"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_de96663d","line":38,"in_reply_to":"3a50d1a3_dc34edad","updated":"2015-08-06 23:14:14.000000000","message":"Done","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        image \u003d gc.images.get(server.image[\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    networks \u003d []"},{"line_number":49,"context_line":"    for net_name, ports in six.iteritems(server.addresses):"},{"line_number":50,"context_line":"        for port in ports:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            LOG.debug(\"## port %s ##\", port)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_256054cf","line":49,"updated":"2015-07-30 00:04:58.000000000","message":"Ian made a comment in another review that shouldn\u0027t be used?","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"43fd2a726acef1b5b9318cf431e889fbb6fd4b90","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        image \u003d gc.images.get(server.image[\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    networks \u003d []"},{"line_number":49,"context_line":"    for net_name, ports in six.iteritems(server.addresses):"},{"line_number":50,"context_line":"        for port in ports:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            LOG.debug(\"## port %s ##\", port)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_5ec25635","line":49,"in_reply_to":"3a50d1a3_256054cf","updated":"2015-08-06 23:14:14.000000000","message":"Not in this patch - what are you referring to?","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    for net_name, ports in six.iteritems(server.addresses):"},{"line_number":50,"context_line":"        for port in ports:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            LOG.debug(\"## port %s ##\", port)"},{"line_number":53,"context_line":"            addr \u003d {\"name\": net_name}"},{"line_number":54,"context_line":"            port_address \u003d port.pop(\u0027addr\u0027)"},{"line_number":55,"context_line":"            if port[\u0027version\u0027] \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_1c01f5af","line":52,"updated":"2015-07-30 00:04:58.000000000","message":"Adding server and net_name to this debug message would likely be helpufl","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"43fd2a726acef1b5b9318cf431e889fbb6fd4b90","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    for net_name, ports in six.iteritems(server.addresses):"},{"line_number":50,"context_line":"        for port in ports:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            LOG.debug(\"## port %s ##\", port)"},{"line_number":53,"context_line":"            addr \u003d {\"name\": net_name}"},{"line_number":54,"context_line":"            port_address \u003d port.pop(\u0027addr\u0027)"},{"line_number":55,"context_line":"            if port[\u0027version\u0027] \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_1e2daefd","line":52,"in_reply_to":"3a50d1a3_1c01f5af","updated":"2015-08-06 23:14:14.000000000","message":"Done","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                port[\u0027ipv6_addr\u0027] \u003d port_address"},{"line_number":59,"context_line":"            addr.update(port)"},{"line_number":60,"context_line":"            networks.append(addr)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    serialized \u003d dict("},{"line_number":63,"context_line":"        id\u003dserver.id,"},{"line_number":64,"context_line":"        instance_id\u003dserver.id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_7fd6ebc4","line":61,"updated":"2015-07-30 00:04:58.000000000","message":"The below is like a combo of goodness (image name, flavor name in single query) and badness (firewall to the original API data that also forces people  / clients to know both the searchlight version of data and the original API data). Here\u0027s some comparison (note the surrounding body stuff is of course different with ES envelope).  But look at the actual data:\n\nHere\u0027s the original Nova API Data:  http://paste.openstack.org/show/406327/\n\nHere\u0027s the Searchlight Data: http://paste.openstack.org/show/406328/\n\nNetworks has all the same data, but a totally different format.\n\nI feel like we should be able to show the original data and augment it here and there for searchability, etc, but to always provide raw data.\n\nTBH, I\u0027d actually really like to see the plugin config be able to define fields to include / exclude (whitelist / blacklist).  This could be an object that even provides the mapping for the field and any query filter to add, since for example some of the fields here should only be shown if an admin is making the request. Since plugin config isn\u0027t in yet, I guess we have to go that far, yet.","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"43fd2a726acef1b5b9318cf431e889fbb6fd4b90","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                port[\u0027ipv6_addr\u0027] \u003d port_address"},{"line_number":59,"context_line":"            addr.update(port)"},{"line_number":60,"context_line":"            networks.append(addr)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    serialized \u003d dict("},{"line_number":63,"context_line":"        id\u003dserver.id,"},{"line_number":64,"context_line":"        instance_id\u003dserver.id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_99b1d849","line":61,"in_reply_to":"3a50d1a3_7fd6ebc4","updated":"2015-08-06 23:14:14.000000000","message":"Whitelisting/blacklisting i think is a future thing since it will apply to all plugins, though i agree in principle.\n\nRegarding augmentation, I can see the argument to keep the original format and potentially add to it but, for instance, indexing \"flavor\" as is from nova i don\u0027t think is useful. Fields like OS-EXT-AZ:availability_zone I could see both ways; i think as a user i don\u0027t really care that it\u0027s called that but i can see how someone might. I\u0027m ok changing the attributes back to match the extension:attribute format.\n\nI do feel quite strongly that from a search perspective it\u0027s essential that things like flavor names, image names, power states are stringified; retaining OS-EXT-STS:power_state might be dubiously useful for a client that understands what those numbers mean but it\u0027s useless for raw searching.\n\nDecided to keep networking as-is as well as transforming.","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            \u0027id\u0027: server.flavor[\u0027id\u0027]"},{"line_number":80,"context_line":"        }"},{"line_number":81,"context_line":"    )"},{"line_number":82,"context_line":"    # TODO(sjmc7): turn these into useful strings?"},{"line_number":83,"context_line":"    for att in (\u0027OS-EXT-STS:power_state\u0027, \u0027OS-EXT-STS:task_state\u0027):"},{"line_number":84,"context_line":"        attr_value \u003d getattr(server, att, None)"},{"line_number":85,"context_line":"        if attr_value:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_9fe5f7a5","line":82,"updated":"2015-07-30 00:04:58.000000000","message":"No, I think that is the job of the client of the API.","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"43fd2a726acef1b5b9318cf431e889fbb6fd4b90","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            \u0027id\u0027: server.flavor[\u0027id\u0027]"},{"line_number":80,"context_line":"        }"},{"line_number":81,"context_line":"    )"},{"line_number":82,"context_line":"    # TODO(sjmc7): turn these into useful strings?"},{"line_number":83,"context_line":"    for att in (\u0027OS-EXT-STS:power_state\u0027, \u0027OS-EXT-STS:task_state\u0027):"},{"line_number":84,"context_line":"        attr_value \u003d getattr(server, att, None)"},{"line_number":85,"context_line":"        if attr_value:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_d979a083","line":82,"in_reply_to":"3a50d1a3_9fe5f7a5","updated":"2015-08-06 23:14:14.000000000","message":"I don\u0027t, but i think that can be a future discussion :)","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bb0dd73d7e8931f1be7e925f2142b51fb64c8bc5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        id\u003dserver.id,"},{"line_number":43,"context_line":"        server_id\u003dserver.id,"},{"line_number":44,"context_line":"        name\u003dserver.name,"},{"line_number":45,"context_line":"        status\u003dserver.status.lower(),"},{"line_number":46,"context_line":"        owner\u003dserver.tenant_id,"},{"line_number":47,"context_line":"        tenant_id\u003dserver.tenant_id,"},{"line_number":48,"context_line":"        user_id\u003dserver.user_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a4dcd0f_c82063fb","line":45,"updated":"2015-08-14 22:46:28.000000000","message":"Why moving to lower case?  Native API has it all uppercase.  I don\u0027t think we should lower() it.","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"0615c256ee122215b5e462ded058de1f0cd5d3d0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        id\u003dserver.id,"},{"line_number":43,"context_line":"        server_id\u003dserver.id,"},{"line_number":44,"context_line":"        name\u003dserver.name,"},{"line_number":45,"context_line":"        status\u003dserver.status.lower(),"},{"line_number":46,"context_line":"        owner\u003dserver.tenant_id,"},{"line_number":47,"context_line":"        tenant_id\u003dserver.tenant_id,"},{"line_number":48,"context_line":"        user_id\u003dserver.user_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_90e72112","line":45,"in_reply_to":"1a4dcd0f_c82063fb","updated":"2015-08-17 15:28:07.000000000","message":"Done","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bb0dd73d7e8931f1be7e925f2142b51fb64c8bc5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if attr_value:"},{"line_number":66,"context_line":"            serialized[att] \u003d attr_value"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    return serialized"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def _denormalize(server, serialized):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a4dcd0f_9f660eba","line":68,"updated":"2015-08-14 22:46:28.000000000","message":"Comparing\n\nNova API response: http://paste.openstack.org/show/415028/\n\nTo ES response (native, nonfiltered): http://paste.openstack.org/show/415029/\n\nWe are missing some things. I\u0027m still thinking we should index almost everything (stripping links is fine).   If Nova has data that we can rely on, then it would be bad to force them to make a call to nova api to get that data.The caveat being that we have to be able to have a list of fields that are excluded unless admin is searching.  Initially, we could just not index that, but have a follow on patch that adds that.  We have discussed doing that, and I\u0027m still okay with that, but we can\u0027t lose that work, so would like to see a BP to track it.  See: https://blueprints.launchpad.net/searchlight/+spec/nova-instance-full-data\n\nThat said, below are all the items I found in native API response not in ES response.  Out of these, there are a few that I think need to be added: security_groups, volumes attached, accessIPv4/6, config_drive.\n\nIt really also occurs to me that when we do that the nova plugin should support having separate extension files for all these extension fields.  The extensions enabled would all be invoked during serialize function and also would be called to add to the mapping. This way deployers could add their extension without modifying source just like they do for nova.  BP needed.\n\n    {\n      \"hostId\": \"f57bcb1e1ba43de39322dc473d69e180f9b5a554aa0892c7a34a11e3\",\n      \"OS-EXT-STS:task_state\": null,\n      \"OS-EXT-STS:vm_state\": \"active\",\n      \"OS-EXT-SRV-ATTR:instance_name\": \"instance-00000001\",\n      \"OS-SRV-USG:launched_at\": \"2015-08-12T23:49:55.000000\",\n      \"OS-EXT-SRV-ATTR:hypervisor_hostname\": \"ubuntu\",\n      \"security_groups\": [\n        {\n          \"name\": \"foo sg\"\n        },\n        {\n          \"name\": \"a sg\"\n        },\n        {\n          \"name\": \"lolz sg\"\n        }\n      ],\n      \"OS-DCF:diskConfig\": \"AUTO\",\n      \"os-extended-volumes:volumes_attached\": [],\n      \"accessIPv4\": \"\",\n      \"accessIPv6\": \"\",\n      \"progress\": 0,\n      \"config_drive\": \"True\",\n    }","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"0615c256ee122215b5e462ded058de1f0cd5d3d0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if attr_value:"},{"line_number":66,"context_line":"            serialized[att] \u003d attr_value"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    return serialized"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def _denormalize(server, serialized):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_c6dcff48","line":68,"in_reply_to":"1a4dcd0f_9f660eba","updated":"2015-08-17 15:28:07.000000000","message":"Regarding indexing everything, there are two risks. The first is that you\u0027re blacklisting versus whitelisting, which is fine unless there are often extension fields that are admin-only. The second is that without explicit mappings we\u0027ll be at elasticsearch\u0027s mercy. In the case above, a search for \"instance-00001\" as a single term would result in no matches because it\u0027d get tokenized. In the \u0027addresses\u0027 case searching becomes quite difficult because the \u0027addresses\u0027 keys are network names.\n\nBoth of those are ok, and we could also do the same for images (i.e. have almost no explicit mapping and take everything we get). I\u0027m not sure i agree philosophically about whether we should be encouraging a 1-1 mapping with the service APIs, but i\u0027m also ok losing that argument. \n\nIf we DO go down that route, for the sake of consistency we will solve the \u0027to normalize or not denormalize\u0027 argument; it will also make plugins easier for the most part (they\u0027ll be a short list of \u0027no not index\u0027 fields, a short list of \u0027protected\u0027 fields and possibly a very small list of \u0027transform\u0027 fields and functions).","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ee2f60b596f5d4289c717aae70c7b566260f63bb","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# All \u0027links\u0027 will also be removed"},{"line_number":30,"context_line":"BLACKLISTED_FIELDS \u003d set((u\u0027progress\u0027, u\u0027links\u0027))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def serialize_nova_server(server):"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_ec016107","line":30,"updated":"2015-08-19 22:52:34.000000000","message":"Future per plugin config item (no change needed in this patch. leaving comment for reminder).","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ee2f60b596f5d4289c717aae70c7b566260f63bb","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Some enhancements"},{"line_number":45,"context_line":"    serialized[u\u0027owner\u0027] \u003d server.tenant_id"},{"line_number":46,"context_line":"    serialized[u\u0027server_id\u0027] \u003d server.id"},{"line_number":47,"context_line":"    serialized[u\u0027image\u0027].pop(u\u0027links\u0027, None)"},{"line_number":48,"context_line":"    serialized[u\u0027flavor\u0027].pop(u\u0027links\u0027, None)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_0c613505","line":46,"updated":"2015-08-19 22:52:34.000000000","message":"Why?  There is already an ID field.","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d59e1b5a591fcd05f6e9e3aaae58a3f5af657835","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Some enhancements"},{"line_number":45,"context_line":"    serialized[u\u0027owner\u0027] \u003d server.tenant_id"},{"line_number":46,"context_line":"    serialized[u\u0027server_id\u0027] \u003d server.id"},{"line_number":47,"context_line":"    serialized[u\u0027image\u0027].pop(u\u0027links\u0027, None)"},{"line_number":48,"context_line":"    serialized[u\u0027flavor\u0027].pop(u\u0027links\u0027, None)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_8032aca5","line":46,"in_reply_to":"fa1b9901_0c613505","updated":"2015-08-25 20:04:48.000000000","message":"Done","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"6a37c4436ed1f102942711943eb8cf28aaeffbfa","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Some enhancements"},{"line_number":45,"context_line":"    serialized[u\u0027owner\u0027] \u003d server.tenant_id"},{"line_number":46,"context_line":"    serialized[u\u0027server_id\u0027] \u003d server.id"},{"line_number":47,"context_line":"    serialized[u\u0027image\u0027].pop(u\u0027links\u0027, None)"},{"line_number":48,"context_line":"    serialized[u\u0027flavor\u0027].pop(u\u0027links\u0027, None)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_1e02f10b","line":46,"in_reply_to":"fa1b9901_0c613505","updated":"2015-08-25 00:13:41.000000000","message":"Done by Steve in patchset 15","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"}],"searchlight/elasticsearch/plugins/nova/instances.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return \u0027nova\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_document_type(self):"},{"line_number":35,"context_line":"        return \u0027instance\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_mapping(self):"},{"line_number":38,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_42a55645","line":35,"updated":"2015-07-30 00:04:58.000000000","message":"Nova calls them servers, so I\u0027m thinking we should also go with servers here.","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"43fd2a726acef1b5b9318cf431e889fbb6fd4b90","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return \u0027nova\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_document_type(self):"},{"line_number":35,"context_line":"        return \u0027instance\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_mapping(self):"},{"line_number":38,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_9998f8c1","line":35,"in_reply_to":"3a50d1a3_42a55645","updated":"2015-08-06 23:14:14.000000000","message":"Done","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \u0027properties\u0027: {"},{"line_number":78,"context_line":"                        \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":79,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":80,"context_line":"                    }"},{"line_number":81,"context_line":"                },"},{"line_number":82,"context_line":"                \u0027availability_zone\u0027: {"},{"line_number":83,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_3c9ab16f","line":80,"updated":"2015-07-30 00:04:58.000000000","message":"What do you think about using the images extension / plugin to get the mapping? In setup, we could just pass all the extensions in as an argument to each extension (unless there is a better way).","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            },"},{"line_number":89,"context_line":"        }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_rbac_filter(self, request_context):"},{"line_number":92,"context_line":"        return ["},{"line_number":93,"context_line":"            {"},{"line_number":94,"context_line":"                \"and\": ["}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_82903e50","line":91,"updated":"2015-07-30 00:04:58.000000000","message":"We need to add source exclude filtering for some fields if the user is not an admin.  For example, the host, hypervisor, etc.","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def get_notification_topic_exchanges():"},{"line_number":143,"context_line":"        return ("},{"line_number":144,"context_line":"            (\u0027notifications\u0027, \u0027nova\u0027),"},{"line_number":145,"context_line":"            (\u0027notifications\u0027, \u0027neutron\u0027)"},{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def get_notification_supported_events(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_028bce1f","line":145,"updated":"2015-07-30 00:04:58.000000000","message":"This will have the same competition with ceilometer problem. Probably should just go ahead and change to searchlight_indexer.  Also, we need a nova.rst plugin doc.","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"43fd2a726acef1b5b9318cf431e889fbb6fd4b90","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def get_notification_topic_exchanges():"},{"line_number":143,"context_line":"        return ("},{"line_number":144,"context_line":"            (\u0027notifications\u0027, \u0027nova\u0027),"},{"line_number":145,"context_line":"            (\u0027notifications\u0027, \u0027neutron\u0027)"},{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def get_notification_supported_events(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_84c39a37","line":145,"in_reply_to":"3a50d1a3_028bce1f","updated":"2015-08-06 23:14:14.000000000","message":"Done","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20a668a375fb953ad91868ef7ad0295fa7086fe2","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            (\u0027notifications\u0027, \u0027neutron\u0027)"},{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def get_notification_supported_events(self):"},{"line_number":149,"context_line":"        # TODO(sjmc7): DRY"},{"line_number":150,"context_line":"        # Most events are duplicated by instance.update"},{"line_number":151,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_e201026f","line":148,"updated":"2015-07-30 00:04:58.000000000","message":"This isn\u0027t listening to image update events, meaning that the image can get out of date in the indexed data.  So either should solve for that and just go ahead and remove image name from indexed data.  Same for flavor.","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"43fd2a726acef1b5b9318cf431e889fbb6fd4b90","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            (\u0027notifications\u0027, \u0027neutron\u0027)"},{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def get_notification_supported_events(self):"},{"line_number":149,"context_line":"        # TODO(sjmc7): DRY"},{"line_number":150,"context_line":"        # Most events are duplicated by instance.update"},{"line_number":151,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_e4c85e57","line":148,"in_reply_to":"3a50d1a3_e201026f","updated":"2015-08-06 23:14:14.000000000","message":"After weekly meeting, we won\u0027t do the denormalization so we\u0027re ok not listening to glance notifications","commit_id":"bfc0dd9d6801f00412a856d42ce5d2227a7c4fdc"}],"searchlight/elasticsearch/plugins/nova/servers.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bb0dd73d7e8931f1be7e925f2142b51fb64c8bc5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                        }"},{"line_number":107,"context_line":"                    }"},{"line_number":108,"context_line":"                ]"},{"line_number":109,"context_line":"            }"},{"line_number":110,"context_line":"        ]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def get_objects(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a4dcd0f_bf1f4a08","line":109,"updated":"2015-08-14 22:46:28.000000000","message":"We need to add source exclude filtering for some fields if the user is not an admin. For example, the host, hypervisor, etc.  We can choose to not index that in this patch and then have a follow-on patch that adds source field filtering later.  Is that what you are thinking?  See comments on init file.","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"0615c256ee122215b5e462ded058de1f0cd5d3d0","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                        }"},{"line_number":107,"context_line":"                    }"},{"line_number":108,"context_line":"                ]"},{"line_number":109,"context_line":"            }"},{"line_number":110,"context_line":"        ]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def get_objects(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_1088f121","line":109,"in_reply_to":"1a4dcd0f_bf1f4a08","updated":"2015-08-17 15:28:07.000000000","message":"Yes, that\u0027d be my choice for now. I\u0027ll remove hypervisor fields for now.","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bb0dd73d7e8931f1be7e925f2142b51fb64c8bc5","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def get_notification_topic_exchanges():"},{"line_number":146,"context_line":"        return ("},{"line_number":147,"context_line":"            (\u0027searchlight_indexer\u0027, \u0027nova\u0027),"},{"line_number":148,"context_line":"            (\u0027searchlight_indexer\u0027, \u0027neutron\u0027)"},{"line_number":149,"context_line":"        )"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_notification_supported_events(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a4dcd0f_5f916645","line":148,"updated":"2015-08-14 22:46:28.000000000","message":"The nova RST file doesn\u0027t mention anything about adding that notification topic to neutron. Please add that.","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"0615c256ee122215b5e462ded058de1f0cd5d3d0","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def get_notification_topic_exchanges():"},{"line_number":146,"context_line":"        return ("},{"line_number":147,"context_line":"            (\u0027searchlight_indexer\u0027, \u0027nova\u0027),"},{"line_number":148,"context_line":"            (\u0027searchlight_indexer\u0027, \u0027neutron\u0027)"},{"line_number":149,"context_line":"        )"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_notification_supported_events(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_b0cb4572","line":148,"in_reply_to":"1a4dcd0f_5f916645","updated":"2015-08-17 15:28:07.000000000","message":"Done","commit_id":"0d2afada2d5f446d881942fa2515106300567910"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"fcf67c0a3caa433b20031240d02afd7510a81635","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class ServerIndex(base.IndexBase):"},{"line_number":28,"context_line":"    # Properties restricted to admins only"},{"line_number":29,"context_line":"    ADMIN_ONLY_PROPERTIES \u003d (u\u0027OS-EXT-SRV-ATTR:host\u0027,"},{"line_number":30,"context_line":"                             u\u0027OS-EXT-SRV-ATTR:hypervisor_hostname\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self):"},{"line_number":33,"context_line":"        super(ServerIndex, self).__init__()"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_4c8b9f68","line":30,"updated":"2015-08-20 05:42:16.000000000","message":"Also, need to verify that there aren\u0027t more properties that are admin only.","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"6a37c4436ed1f102942711943eb8cf28aaeffbfa","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class ServerIndex(base.IndexBase):"},{"line_number":28,"context_line":"    # Properties restricted to admins only"},{"line_number":29,"context_line":"    ADMIN_ONLY_PROPERTIES \u003d (u\u0027OS-EXT-SRV-ATTR:host\u0027,"},{"line_number":30,"context_line":"                             u\u0027OS-EXT-SRV-ATTR:hypervisor_hostname\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self):"},{"line_number":33,"context_line":"        super(ServerIndex, self).__init__()"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_e102fc08","line":30,"in_reply_to":"fa1b9901_4c8b9f68","updated":"2015-08-25 00:13:41.000000000","message":"Done by Steve in patchset 15.\n\nAgreed that per extension filtering will be done in follow-on patch and it is better to filter all of them until then (for security reasons)","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d59e1b5a591fcd05f6e9e3aaae58a3f5af657835","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class ServerIndex(base.IndexBase):"},{"line_number":28,"context_line":"    # Properties restricted to admins only"},{"line_number":29,"context_line":"    ADMIN_ONLY_PROPERTIES \u003d (u\u0027OS-EXT-SRV-ATTR:host\u0027,"},{"line_number":30,"context_line":"                             u\u0027OS-EXT-SRV-ATTR:hypervisor_hostname\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self):"},{"line_number":33,"context_line":"        super(ServerIndex, self).__init__()"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_200e40e5","line":30,"in_reply_to":"fa1b9901_4c8b9f68","updated":"2015-08-25 20:04:48.000000000","message":"hostId, i think. Also as discussed in the meeting earlier we may want to whitelist allowed extension fields rather than include everything since it\u0027s hard to come up with a proper blacklist","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ee2f60b596f5d4289c717aae70c7b566260f63bb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            \u0027dynamic\u0027: True,"},{"line_number":44,"context_line":"            \u0027properties\u0027: {"},{"line_number":45,"context_line":"                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":46,"context_line":"                \u0027server_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":47,"context_line":"                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":48,"context_line":"                \u0027flavor\u0027: {"},{"line_number":49,"context_line":"                    \u0027type\u0027: \u0027nested\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_ed463b4e","line":46,"updated":"2015-08-19 22:52:34.000000000","message":"Aren\u0027t the above two the same thing?  id and server_id?","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"6a37c4436ed1f102942711943eb8cf28aaeffbfa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            \u0027dynamic\u0027: True,"},{"line_number":44,"context_line":"            \u0027properties\u0027: {"},{"line_number":45,"context_line":"                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":46,"context_line":"                \u0027server_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":47,"context_line":"                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":48,"context_line":"                \u0027flavor\u0027: {"},{"line_number":49,"context_line":"                    \u0027type\u0027: \u0027nested\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_a10c043c","line":46,"in_reply_to":"fa1b9901_ed463b4e","updated":"2015-08-25 00:13:41.000000000","message":"Done by Steve in patchset 15","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ee2f60b596f5d4289c717aae70c7b566260f63bb","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                    for key in list(hit[\u0027_source\u0027].keys()):"},{"line_number":126,"context_line":"                        if key in self.ADMIN_ONLY_PROPERTIES:"},{"line_number":127,"context_line":"                            del hit[\u0027_source\u0027][key]"},{"line_number":128,"context_line":"        return result"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def get_objects(self):"},{"line_number":131,"context_line":"        \"\"\"Generator that lists all nova servers owned by all tenants.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_e7e2da2e","line":128,"updated":"2015-08-19 22:52:34.000000000","message":"Functional, but I was hoping we could do this with the following in RBAC filtering. Please note, I\u0027m commenting on this patch now for quicker collaboration and haven\u0027t yet gone through the parent patch.\n\nhttps://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-source-filtering.html\n\nor \n\nhttps://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-source-filtering.html","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d59e1b5a591fcd05f6e9e3aaae58a3f5af657835","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                    for key in list(hit[\u0027_source\u0027].keys()):"},{"line_number":126,"context_line":"                        if key in self.ADMIN_ONLY_PROPERTIES:"},{"line_number":127,"context_line":"                            del hit[\u0027_source\u0027][key]"},{"line_number":128,"context_line":"        return result"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def get_objects(self):"},{"line_number":131,"context_line":"        \"\"\"Generator that lists all nova servers owned by all tenants.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_e04e083a","line":128,"in_reply_to":"fa1b9901_e7e2da2e","updated":"2015-08-25 20:04:48.000000000","message":"That might be a better way to do it, although it\u0027s tough to e.g. exclude hostId for nova servers but not for some other thing. Perhaps a future optimization?","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"6c89a813d77fc313af64fdd1faa2372636002c99","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(ServerIndex, self).__init__()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_index_name(self):"},{"line_number":38,"context_line":"        return \u0027nova\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_document_type(self):"},{"line_number":41,"context_line":"        return \u0027server\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa1b9901_24ad3e84","line":38,"updated":"2015-08-25 15:20:35.000000000","message":"Should be searchlight.\n\nThis merged:\n\nhttps://review.openstack.org/207672","commit_id":"e538b39db4e75e66d9b9501756692e79f104a594"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"b40f8d036b0cd683ec62790145caff445248e89b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(ServerIndex, self).__init__()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_index_name(self):"},{"line_number":38,"context_line":"        return \u0027nova\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_document_type(self):"},{"line_number":41,"context_line":"        return \u0027server\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa1b9901_71d1b756","line":38,"in_reply_to":"fa1b9901_24ad3e84","updated":"2015-08-25 20:04:35.000000000","message":"Done","commit_id":"e538b39db4e75e66d9b9501756692e79f104a594"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"6c89a813d77fc313af64fdd1faa2372636002c99","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return \u0027nova\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_document_type(self):"},{"line_number":41,"context_line":"        return \u0027server\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get_mapping(self):"},{"line_number":44,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa1b9901_84952a34","line":41,"updated":"2015-08-25 15:20:35.000000000","message":"Should now be OS::Nova::Server\n\nThis merged:\n\nhttps://review.openstack.org/207672","commit_id":"e538b39db4e75e66d9b9501756692e79f104a594"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"b40f8d036b0cd683ec62790145caff445248e89b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return \u0027nova\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_document_type(self):"},{"line_number":41,"context_line":"        return \u0027server\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get_mapping(self):"},{"line_number":44,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa1b9901_91d6cb4d","line":41,"in_reply_to":"fa1b9901_84952a34","updated":"2015-08-25 20:04:35.000000000","message":"Done","commit_id":"e538b39db4e75e66d9b9501756692e79f104a594"}],"searchlight/elasticsearch/plugins/nova/servers_notification_handler.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5833ad8422944bfc95638188cccbf59203fe7ddf","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                \u0027compute.instance.create.end\u0027: self.create_or_update,"},{"line_number":50,"context_line":"                \u0027compute.instance.power_on.end\u0027: self.create_or_update,"},{"line_number":51,"context_line":"                \u0027compute.instance.power_off.end\u0027: self.create_or_update,"},{"line_number":52,"context_line":"                \u0027compute.instance.delete.end\u0027: self.delete,"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"                # Neutron events"},{"line_number":55,"context_line":"                \u0027port.create.end\u0027: self.update_from_neutron,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_2230bde7","line":52,"updated":"2015-08-20 00:26:23.000000000","message":"This is a comment for consideration once the performance tests are ready in a future patch, but in watching the number of events that pass through on an instance launch, i\u0027m thinking we\u0027ll need to investigate if we can optimize some of them and not have to make calls back to nova for all of them.","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5833ad8422944bfc95638188cccbf59203fe7ddf","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            payload \u003d serialize_nova_server(instance_id)"},{"line_number":81,"context_line":"        except novaclient.exceptions.NotFound:"},{"line_number":82,"context_line":"            # Todo: delete? probably"},{"line_number":83,"context_line":"            LOG.warning(_LW(\"Instance id %s not found\") % instance_id)"},{"line_number":84,"context_line":"            return"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_ed8e3bcf","line":83,"updated":"2015-08-20 00:26:23.000000000","message":"YES. I believe this should be changed to call delete when not found.  If Nova can not find it, it is entirely possible that notification processing is just a bit behind reality and there is no reason it should still be in our \"cache\". I\u0027m in favor of ejecting from the cache as soon as it is detected.\n\nIn running this through debugger, which of course is a slower than reality, it hit this statement every single time I deleted the instance (because nova sends some status update notifications prior to actual deletion).","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d59e1b5a591fcd05f6e9e3aaae58a3f5af657835","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            payload \u003d serialize_nova_server(instance_id)"},{"line_number":81,"context_line":"        except novaclient.exceptions.NotFound:"},{"line_number":82,"context_line":"            # Todo: delete? probably"},{"line_number":83,"context_line":"            LOG.warning(_LW(\"Instance id %s not found\") % instance_id)"},{"line_number":84,"context_line":"            return"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_001f7c08","line":83,"in_reply_to":"fa1b9901_ed8e3bcf","updated":"2015-08-25 20:04:48.000000000","message":"Done","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"6a37c4436ed1f102942711943eb8cf28aaeffbfa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            payload \u003d serialize_nova_server(instance_id)"},{"line_number":81,"context_line":"        except novaclient.exceptions.NotFound:"},{"line_number":82,"context_line":"            # Todo: delete? probably"},{"line_number":83,"context_line":"            LOG.warning(_LW(\"Instance id %s not found\") % instance_id)"},{"line_number":84,"context_line":"            return"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_014cd06e","line":83,"in_reply_to":"fa1b9901_ed8e3bcf","updated":"2015-08-25 00:13:41.000000000","message":"Done by Steve in patchset 15","commit_id":"47bd4a4581030339ee62462c66ca3bf14d8cfa1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"8e2ff96453adf5448c4137ad49a6800701efc002","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        body \u003d {"},{"line_number":96,"context_line":"            \u0027doc\u0027: payload,"},{"line_number":97,"context_line":"            \u0027doc_as_upsert\u0027: True,"},{"line_number":98,"context_line":"        },"},{"line_number":99,"context_line":"        self.engine.update("},{"line_number":100,"context_line":"            index\u003dself.index_name,"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa1b9901_b95c1b1a","line":97,"updated":"2015-08-25 15:00:20.000000000","message":"Removed properties don\u0027t seem to get removed with this option.","commit_id":"e538b39db4e75e66d9b9501756692e79f104a594"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"b40f8d036b0cd683ec62790145caff445248e89b","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        body \u003d {"},{"line_number":96,"context_line":"            \u0027doc\u0027: payload,"},{"line_number":97,"context_line":"            \u0027doc_as_upsert\u0027: True,"},{"line_number":98,"context_line":"        },"},{"line_number":99,"context_line":"        self.engine.update("},{"line_number":100,"context_line":"            index\u003dself.index_name,"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa1b9901_f1de276c","line":97,"in_reply_to":"fa1b9901_7f9bc318","updated":"2015-08-25 20:04:35.000000000","message":"Changed to use engine.index without upsert, same as for glance.","commit_id":"e538b39db4e75e66d9b9501756692e79f104a594"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"903298cd81860adf68db5dc090978192ee8876f1","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        body \u003d {"},{"line_number":96,"context_line":"            \u0027doc\u0027: payload,"},{"line_number":97,"context_line":"            \u0027doc_as_upsert\u0027: True,"},{"line_number":98,"context_line":"        },"},{"line_number":99,"context_line":"        self.engine.update("},{"line_number":100,"context_line":"            index\u003dself.index_name,"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa1b9901_7f9bc318","line":97,"in_reply_to":"fa1b9901_b95c1b1a","updated":"2015-08-25 15:36:20.000000000","message":"Please also see this bug.\n\nhttps://bugs.launchpad.net/searchlight/+bug/1486781","commit_id":"e538b39db4e75e66d9b9501756692e79f104a594"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"cf29a6a204a95066476caf20db62b2527947f1ff","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            actions[event_type](payload)"},{"line_number":61,"context_line":"            return oslo_messaging.NotificationResult.HANDLED"},{"line_number":62,"context_line":"        except Exception as e:"},{"line_number":63,"context_line":"            LOG.error(utils.exception_to_str(e))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def create_or_update(self, payload):"},{"line_number":66,"context_line":"        instance_id \u003d payload[\u0027instance_id\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_f374d9fe","line":63,"updated":"2015-08-25 23:46:07.000000000","message":"This should be:\n     LOG.error(encodeutils.exception_to_unicode(e))\n\nSee: https://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/glance/images_notification_handler.py#L44\n\nOtherwise, I was getting this error:\n\n 2015-08-25 16:30:43.568 ERROR oslo_messaging.notify.dispatcher [-] Exception during message handling\n 2015-08-25 16:30:43.568 TRACE oslo_messaging.notify.dispatcher Traceback (most recent call last):\n 2015-08-25 16:30:43.568 TRACE oslo_messaging.notify.dispatcher   File \"/usr/local/lib/python2.7/dist-packages/oslo_messaging/notify/dispatcher.py\", line 92, in _dispatch_and_handle_error\n 2015-08-25 16:30:43.568 TRACE oslo_messaging.notify.dispatcher     executor_callback)\n 2015-08-25 16:30:43.568 TRACE oslo_messaging.notify.dispatcher   File \"/usr/local/lib/python2.7/dist-packages/oslo_messaging/notify/dispatcher.py\", line 135, in _dispatch\n 2015-08-25 16:30:43.568 TRACE oslo_messaging.notify.dispatcher     metadata)\n 2015-08-25 16:30:43.568 TRACE oslo_messaging.notify.dispatcher   File \"/opt/stack/searchlight/searchlight/listener.py\", line 67, in info\n 2015-08-25 16:30:43.568 TRACE oslo_messaging.notify.dispatcher     metadata)\n 2015-08-25 16:30:43.568 TRACE oslo_messaging.notify.dispatcher   File \"/opt/stack/searchlight/searchlight/elasticsearch/plugins/nova/servers_notification_handler.py\", line 63, in process\n 2015-08-25 16:30:43.568 TRACE oslo_messaging.notify.dispatcher     LOG.error(utils.exception_to_str(e))\n 2015-08-25 16:30:43.568 TRACE oslo_messaging.notify.dispatcher AttributeError: \u0027module\u0027 object has no attribute \u0027exception_to_str\u0027\n\nWhen I changed to the above, my output was this:\n\n2015-08-25 17:29:46.737 ERROR searchlight.elasticsearch.plugins.nova.servers_notification_handler [-] TransportError(400, u\u0027MapperParsingException[Malformed content, must start with an object]\u0027)\n\nI didn\u0027t have time to debug further on root cause of error today.  Will look tomorrow. Probably my fault.","commit_id":"dc82295855f6623f7c002449e3dc757c4696a8d3"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"e585ea52ce8e1ec701cda8757bceafc343ddf8aa","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            actions[event_type](payload)"},{"line_number":61,"context_line":"            return oslo_messaging.NotificationResult.HANDLED"},{"line_number":62,"context_line":"        except Exception as e:"},{"line_number":63,"context_line":"            LOG.error(utils.exception_to_str(e))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def create_or_update(self, payload):"},{"line_number":66,"context_line":"        instance_id \u003d payload[\u0027instance_id\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_95be7e63","line":63,"in_reply_to":"fa1b9901_f374d9fe","updated":"2015-08-26 15:24:08.000000000","message":"Thanks for spotting this, missed it during the rebases.","commit_id":"dc82295855f6623f7c002449e3dc757c4696a8d3"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"efc9407a0c5d847a420f075a94b196028caa80d7","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_instance(self, instance_id):"},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            payload \u003d serialize_nova_server(instance_id)"},{"line_number":81,"context_line":"        except novaclient.exceptions.NotFound:"},{"line_number":82,"context_line":"            LOG.warning(_LW(\"Instance %s not found; deleting\") % instance_id)"},{"line_number":83,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_4cf63f5e","line":80,"updated":"2015-08-26 03:45:20.000000000","message":"Hi, I have a question, every time a nova notification comes, why serialization needs to call nova api to get info of a instance? I saw glance plugin just serialize notification content into elasticsearch document, does nova notification lacks some important attributes?","commit_id":"dc82295855f6623f7c002449e3dc757c4696a8d3"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"3cd4e7ac2aa795fbc841017038e8dec538854ed7","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_instance(self, instance_id):"},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            payload \u003d serialize_nova_server(instance_id)"},{"line_number":81,"context_line":"        except novaclient.exceptions.NotFound:"},{"line_number":82,"context_line":"            LOG.warning(_LW(\"Instance %s not found; deleting\") % instance_id)"},{"line_number":83,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_5b58178a","line":80,"in_reply_to":"fa1b9901_3524520b","updated":"2015-08-26 15:34:55.000000000","message":"Lei,\n\nAlso, there is a maintenance problem. One of our goals is to make it that searchlight can provide you with the same information you\u0027d get from the API.  Notifications typically don\u0027t keep up with the format of the API, so for now it is unfortunately required to go back to the API.  Ideally, the few hits searchlight puts on the API will offload many, many other subsequent search requests from the API (as they go through searchlight).\n\nTravis","commit_id":"dc82295855f6623f7c002449e3dc757c4696a8d3"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"e585ea52ce8e1ec701cda8757bceafc343ddf8aa","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_instance(self, instance_id):"},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            payload \u003d serialize_nova_server(instance_id)"},{"line_number":81,"context_line":"        except novaclient.exceptions.NotFound:"},{"line_number":82,"context_line":"            LOG.warning(_LW(\"Instance %s not found; deleting\") % instance_id)"},{"line_number":83,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_3524520b","line":80,"in_reply_to":"fa1b9901_4cf63f5e","updated":"2015-08-26 15:24:08.000000000","message":"Hi Lei - yes, the notifications are missing some attributes and are formatted differently. We intend to talk to the service teams about standardizing them but we want to get to a point where searchlight is reliable and demonstrates value before asking for those kinds of changes.","commit_id":"dc82295855f6623f7c002449e3dc757c4696a8d3"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"91ab9695e7472fe907591f89824cebb962322bcd","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        body \u003d {"},{"line_number":96,"context_line":"            \u0027doc\u0027: payload"},{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":"        self.engine.index("},{"line_number":99,"context_line":"            index\u003dself.index_name,"},{"line_number":100,"context_line":"            doc_type\u003dself.document_type,"}],"source_content_type":"text/x-python","patch_set":18,"id":"da20952f_fcebcfae","line":97,"updated":"2015-08-27 00:49:30.000000000","message":"In my env, this has the same effect as the glance notification indexing that I reported in the following bug.\n\nhttps://bugs.launchpad.net/searchlight/+bug/1486781\n\nHowever, Lakshmi and I did a hangout yesterday and he couldn\u0027t replicate that bug in his environment.  So, we were thinking it might be an issue with my environment. I think further investigation into this should be done, but I\u0027m okay with that being treated as a follow on bug. I don\u0027t think it is necessary to block this entire patch yet another time to determine if there is a better function to call on the ES client. If there is, we should do it at the same time as a change to the glance plugin.","commit_id":"13b9e1d17281600ea00e9f17d3238531f9f3cf73"}]}
