)]}'
{"searchlight/api/v1/search.py":[{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"135c74ac4c9894c4fd22843c201bb590b20fc266","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.plugin_lookup \u003d {"},{"line_number":50,"context_line":"            plugin.obj.get_document_type(): plugin.obj"},{"line_number":51,"context_line":"            for plugin in self.plugins.values()"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def search(self, req, query, index\u003dNone, doc_type\u003dNone,"},{"line_number":55,"context_line":"               fields\u003dNone, offset\u003d0, limit\u003d10):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a1a9d01_5a0c5142","line":52,"updated":"2015-09-24 14:14:48.000000000","message":"The type should be same in self.plugin. I dont think you need this logic.","commit_id":"44a5e8f2adf8348496dd685d8b756096bcb5a54a"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"cfb6e913114988766691fb39a98d9e37b122a49c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.plugin_lookup \u003d {"},{"line_number":50,"context_line":"            plugin.obj.get_document_type(): plugin.obj"},{"line_number":51,"context_line":"            for plugin in self.plugins.values()"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def search(self, req, query, index\u003dNone, doc_type\u003dNone,"},{"line_number":55,"context_line":"               fields\u003dNone, offset\u003d0, limit\u003d10):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a1a9d01_40e224a1","line":52,"in_reply_to":"9a1a9d01_5a0c5142","updated":"2015-09-24 14:41:17.000000000","message":"Yeah, i think that\u0027s reasonable. No need to add unnecessary complexity before it\u0027s required.","commit_id":"44a5e8f2adf8348496dd685d8b756096bcb5a54a"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"135c74ac4c9894c4fd22843c201bb590b20fc266","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            hits \u003d result.get(\u0027hits\u0027, {}).get(\u0027hits\u0027, [])"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                for hit in hits:"},{"line_number":72,"context_line":"                    plugin \u003d self.plugin_lookup[hit[\u0027_type\u0027]]"},{"line_number":73,"context_line":"                    plugin.filter_result(hit, req.context)"},{"line_number":74,"context_line":"            except KeyError as e:"},{"line_number":75,"context_line":"                raise Exception(\"No registered plugin for type %s\" % e.message)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a1a9d01_1d1d7366","line":72,"updated":"2015-09-24 14:14:48.000000000","message":"You could instead do \nplugin \u003d self.plugins[hit[\u0027_type\u0027]]\nplugin.obj.filter_result(hit, req.context)","commit_id":"44a5e8f2adf8348496dd685d8b756096bcb5a54a"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"cfb6e913114988766691fb39a98d9e37b122a49c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            hits \u003d result.get(\u0027hits\u0027, {}).get(\u0027hits\u0027, [])"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                for hit in hits:"},{"line_number":72,"context_line":"                    plugin \u003d self.plugin_lookup[hit[\u0027_type\u0027]]"},{"line_number":73,"context_line":"                    plugin.filter_result(hit, req.context)"},{"line_number":74,"context_line":"            except KeyError as e:"},{"line_number":75,"context_line":"                raise Exception(\"No registered plugin for type %s\" % e.message)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a1a9d01_00f3cc74","line":72,"in_reply_to":"9a1a9d01_1d1d7366","updated":"2015-09-24 14:41:17.000000000","message":"Done","commit_id":"44a5e8f2adf8348496dd685d8b756096bcb5a54a"}]}