)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"be8d543a3ff314e7fffa4345915e15507c2edf59","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        setup_colorized_logging_searchlight $SEARCHLIGHT_CONF DEFAULT \"tenant\" \"user\""},{"line_number":130,"context_line":"    fi"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Plugin config - disable designate by default since it\u0027s not typically installed"},{"line_number":133,"context_line":"    iniset $SEARCHLIGHT_CONF resource_plugin:os_designate_zone enabled False"},{"line_number":134,"context_line":"    iniset $SEARCHLIGHT_CONF resource_plugin:os_designate_recordset enabled False"},{"line_number":135,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":9,"id":"9a1a9d01_a7ed3627","line":132,"updated":"2015-10-02 04:11:24.000000000","message":"This almost makes me thing things should be disabled by default all the time and that they have to be enabled.  However, I could go either way and won\u0027t block on this point.","commit_id":"ae9c962ff2bf14e99b7ba98092542272ccb1436f"}],"doc/source/indexingservice.rst":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"be8d543a3ff314e7fffa4345915e15507c2edf59","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    metadef \u003d searchlight.elasticsearch.plugins.glance.metadefs:MetadefIndex"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Each plugin installed is enabled by default, but can be disabled in the"},{"line_number":37,"context_line":"Searchlight configuration file."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Information about each of the plugins may be found here:"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_c7bdca03","line":37,"updated":"2015-10-02 04:11:24.000000000","message":"\"See each plugin for specific information.\"","commit_id":"ae9c962ff2bf14e99b7ba98092542272ccb1436f"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"538d43918099e40548bcad481f133eb2213ed0b1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"``[entry_points]`` named ``searchlight.index_backend``"},{"line_number":30,"context_line":"should list the available indexable types. For example the entries to index"},{"line_number":31,"context_line":"glance images and glance metadefs are::"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    image \u003d searchlight.elasticsearch.plugins.glance.images:ImageIndex"},{"line_number":34,"context_line":"    metadef \u003d searchlight.elasticsearch.plugins.glance.metadefs:MetadefIndex"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_de632cdc","line":32,"updated":"2015-10-02 20:57:13.000000000","message":"The above is now kind of confusing because we have two locations.\n\nThe search service determines the types of information that is searchable\nvia a plugin mechanism.  All plugins must be registered within ``setup.cfg`` under the  \n``[entry_points]`` and ``searchlight.index_backend`` groups. To install a new plugin or completely remove a plugin it should be added or removed from this file.  Any change to this file will typically required re-running `python setup.py install`.","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"4284580529a2b7aacc0f9ed9576325ae21493e3a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"``[entry_points]`` named ``searchlight.index_backend``"},{"line_number":30,"context_line":"should list the available indexable types. For example the entries to index"},{"line_number":31,"context_line":"glance images and glance metadefs are::"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    image \u003d searchlight.elasticsearch.plugins.glance.images:ImageIndex"},{"line_number":34,"context_line":"    metadef \u003d searchlight.elasticsearch.plugins.glance.metadefs:MetadefIndex"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_7e58e056","line":32,"in_reply_to":"9a1a9d01_de632cdc","updated":"2015-10-02 21:15:41.000000000","message":"Done","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"538d43918099e40548bcad481f133eb2213ed0b1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"glance images and glance metadefs are::"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    image \u003d searchlight.elasticsearch.plugins.glance.images:ImageIndex"},{"line_number":34,"context_line":"    metadef \u003d searchlight.elasticsearch.plugins.glance.metadefs:MetadefIndex"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Each plugin installed is enabled by default, but can be disabled in the"},{"line_number":37,"context_line":"Searchlight configuration file."}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_9e67f4b6","line":34,"updated":"2015-10-02 20:57:13.000000000","message":"Let\u0027s just get rid of the examples above.","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"4284580529a2b7aacc0f9ed9576325ae21493e3a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"glance images and glance metadefs are::"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    image \u003d searchlight.elasticsearch.plugins.glance.images:ImageIndex"},{"line_number":34,"context_line":"    metadef \u003d searchlight.elasticsearch.plugins.glance.metadefs:MetadefIndex"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Each plugin installed is enabled by default, but can be disabled in the"},{"line_number":37,"context_line":"Searchlight configuration file."}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_be5e7843","line":34,"in_reply_to":"9a1a9d01_9e67f4b6","updated":"2015-10-02 21:15:41.000000000","message":"Done","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"538d43918099e40548bcad481f133eb2213ed0b1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    metadef \u003d searchlight.elasticsearch.plugins.glance.metadefs:MetadefIndex"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Each plugin installed is enabled by default, but can be disabled in the"},{"line_number":37,"context_line":"Searchlight configuration file."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"See each plugin below for detailed information:"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_4b1200b6","line":37,"updated":"2015-10-02 20:57:13.000000000","message":"We need to specify which searchlight configuration file and provide some information on defaults.  Please reword to say:\n\nEach plugin registered in ``setup.cfg`` is enabled by default. Typically, you should not need to change ``setup.cfg`` unless adding new plugins for the first time.  After that they can be disabled, enabled, or have additional configuration set within the searchlight-api.conf file.\n\n.. warning::\n\n    You must always restart all API and listener processes for changes to ``searchlight-api.conf`` to take effect.\n    If changing the `enabled` or `index_name` setting, you will also need to reindex the changed resources.\n\nDefault configuration values may be set for all plugins using the following::\n\n [resource_plugin:default]\n index_name \u003d searchlight","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"4284580529a2b7aacc0f9ed9576325ae21493e3a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    metadef \u003d searchlight.elasticsearch.plugins.glance.metadefs:MetadefIndex"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Each plugin installed is enabled by default, but can be disabled in the"},{"line_number":37,"context_line":"Searchlight configuration file."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"See each plugin below for detailed information:"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_de59ec5c","line":37,"in_reply_to":"9a1a9d01_4b1200b6","updated":"2015-10-02 21:15:41.000000000","message":"Done","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"}],"doc/source/plugins/designate.rst":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"be8d543a3ff314e7fffa4345915e15507c2edf59","unresolved":false,"context_lines":[{"line_number":31,"context_line":"you should be good to go!"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Searchlight configuration"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":"Designate-specific plugin configuration options (and defaults) are:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    [resource_plugin:os_designate_zone]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_4740da07","line":34,"updated":"2015-10-02 04:11:24.000000000","message":"Add a whitespace here.\n\nI think (and defaults) is slightly confusing as well.\n\nShould be double :: at end of this line.\n\n Designate-specific plugin configuration options are shown below with their deaults values. You only need to specify the below configuration options if you decide to change it to a non-default value. ::","commit_id":"ae9c962ff2bf14e99b7ba98092542272ccb1436f"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"be8d543a3ff314e7fffa4345915e15507c2edf59","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Searchlight configuration"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":"Designate-specific plugin configuration options (and defaults) are:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    [resource_plugin:os_designate_zone]"},{"line_number":38,"context_line":"    enabled \u003d true"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_27d846ef","line":35,"updated":"2015-10-02 04:11:24.000000000","message":"Designate fails anytime I specify ANY value for index_name.  e.g.\n\n [resource_plugin:os_designate_zone]\n enabled \u003d True\n index_name \u003d designate\n\n [resource_plugin:os_designate_recordset]\n enabled \u003d True\n index_name \u003d designate\n\nCreates the following error:\n\nhttp://paste.openstack.org/show/475134/","commit_id":"ae9c962ff2bf14e99b7ba98092542272ccb1436f"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"be8d543a3ff314e7fffa4345915e15507c2edf59","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Searchlight configuration"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":"Designate-specific plugin configuration options (and defaults) are:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    [resource_plugin:os_designate_zone]"},{"line_number":38,"context_line":"    enabled \u003d true"},{"line_number":39,"context_line":"    index_name \u003d searchlight"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_07d182fb","line":36,"updated":"2015-10-02 04:11:24.000000000","message":"We need to add to the docs that both must be enabled or disabled because of the close relationship.  When I tried enabling ONLY zone, it created an error, because the way the plugin is written when a domain is created it also attempts to index the recordsets.\n\n2015-10-01 17:54:21.917 ERROR searchlight.elasticsearch.plugins.designate.notification_handlers [-] TransportError(400, u\"ElasticsearchIllegalArgumentException[Can\u0027t specify parent if no parent field has been configured]\")\n2015-10-01 17:54:21.917 TRACE \n\nTraceback (most recent call last):\n2015-10-01 17:54:21.917 TRACE searchlight.elasticsearch.plugins.designate.notification_handlers   File \"/opt/stack/searchlight/searchlight/elasticsearch/plugins/designate/notification_handlers.py\", line 75, in process","commit_id":"ae9c962ff2bf14e99b7ba98092542272ccb1436f"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"18ea7d9fe596280a1bff2ee8817ede121b25fdbb","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    [resource_plugin:os_designate_zone]"},{"line_number":41,"context_line":"    enabled \u003d true"},{"line_number":42,"context_line":"    index_name \u003d designate"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    [resource_plugin:os_designate_recordsets]"},{"line_number":45,"context_line":"    enabled \u003d true"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a1a9d01_f16bd583","line":42,"updated":"2015-10-02 14:11:53.000000000","message":"I don\u0027t want to put this in here. The default should be \u0027searchlight\u0027","commit_id":"7caebd89212ec11b44fc10d313cb66cf551de47a"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"538d43918099e40548bcad481f133eb2213ed0b1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    enabled \u003d false"},{"line_number":47,"context_line":"    index_name \u003d searchlight"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. note::"},{"line_number":50,"context_line":"    "},{"line_number":51,"context_line":"    You need to have both *os_designate_zone* and *os_designate_recordset*"},{"line_number":52,"context_line":"    enabled at this moment because of a relationship between them, and they"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_6bf1046a","line":49,"updated":"2015-10-02 20:57:13.000000000","message":"Perhaps this should be warning instead of note.","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"4284580529a2b7aacc0f9ed9576325ae21493e3a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    enabled \u003d false"},{"line_number":47,"context_line":"    index_name \u003d searchlight"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. note::"},{"line_number":50,"context_line":"    "},{"line_number":51,"context_line":"    You need to have both *os_designate_zone* and *os_designate_recordset*"},{"line_number":52,"context_line":"    enabled at this moment because of a relationship between them, and they"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_5e34fcf9","line":49,"in_reply_to":"9a1a9d01_6bf1046a","updated":"2015-10-02 21:15:41.000000000","message":"Done","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"538d43918099e40548bcad481f133eb2213ed0b1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    index_name \u003d searchlight"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. note::"},{"line_number":50,"context_line":"    "},{"line_number":51,"context_line":"    You need to have both *os_designate_zone* and *os_designate_recordset*"},{"line_number":52,"context_line":"    enabled at this moment because of a relationship between them, and they"},{"line_number":53,"context_line":"    must have the same index_name."}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_e2fd406f","line":50,"updated":"2015-10-02 20:57:13.000000000","message":"Remove whitespace above.","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"4284580529a2b7aacc0f9ed9576325ae21493e3a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    index_name \u003d searchlight"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. note::"},{"line_number":50,"context_line":"    "},{"line_number":51,"context_line":"    You need to have both *os_designate_zone* and *os_designate_recordset*"},{"line_number":52,"context_line":"    enabled at this moment because of a relationship between them, and they"},{"line_number":53,"context_line":"    must have the same index_name."}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_fe3ab0e6","line":50,"in_reply_to":"9a1a9d01_e2fd406f","updated":"2015-10-02 21:15:41.000000000","message":"Done","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"}],"doc/source/plugins/glance.rst":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"be8d543a3ff314e7fffa4345915e15507c2edf59","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Suggested changes::"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    property_protection_file \u003d ~/openstack/searchlight/etc/property-protections-roles.conf"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Glance-specific plugin configuration options (and defaults) are:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    [resource_plugin:os_glance_image]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_c76b8a84","line":53,"updated":"2015-10-02 04:11:24.000000000","message":"Similar comments here as designate.rst","commit_id":"ae9c962ff2bf14e99b7ba98092542272ccb1436f"}],"doc/source/plugins/nova.rst":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"be8d543a3ff314e7fffa4345915e15507c2edf59","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Restart neutron service (q-svc)."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Plugin configuration"},{"line_number":50,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":51,"context_line":"Nova-specific plugin configuration options (and defaults) are:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    [resource_plugin:os_nova_server]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_e7680e8a","line":50,"updated":"2015-10-02 04:11:24.000000000","message":"Similar comments to designate.rst.","commit_id":"ae9c962ff2bf14e99b7ba98092542272ccb1436f"}],"searchlight/elasticsearch/plugins/base.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"9036cb7f3b54a841dfdc86296a74bc01a33f2556","unresolved":false,"context_lines":[{"line_number":26,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":27,"context_line":"class IndexBase(plugin.Plugin):"},{"line_number":28,"context_line":"    __plugin_ns__ \u003d \u0027searchlight.index_backend\u0027"},{"line_number":29,"context_line":"    __plugin_type__ \u003d \u0027indexer\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    chunk_size \u003d 200"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_8ec80124","line":29,"updated":"2015-09-16 01:34:16.000000000","message":"I can\u0027t decide if i like \u0027indexer\u0027. I can\u0027t think what other \u0027types\u0027 we might have; if it were something like a auth plugins i could maybe see it, in which case it might be better to use \u0027resource\u0027 as the type here.","commit_id":"db8142f37924024dbfc3a202dd4c6ed76103112b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"119d3e3850d6c874db6e129370525f6c5d3fb9c6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            opts.append(cfg.MultiOpt("},{"line_number":52,"context_line":"                \u0027exchange_topics\u0027,"},{"line_number":53,"context_line":"                item_type\u003dtypes.MultiString(),"},{"line_number":54,"context_line":"                default\u003d[\u0027searchlight-indexer,glance\u0027]))"},{"line_number":55,"context_line":"        return opts"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_21ed1fef","line":54,"updated":"2015-09-16 18:55:06.000000000","message":"This is more what i meant, although the defaults (topics at least) need to come from the plugin.\n\nI think searchlight_indexer (underscore, not dash) is the current default","commit_id":"e979fd3b99d2c1f2ce37df749b24259b5826ca3a"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"119d3e3850d6c874db6e129370525f6c5d3fb9c6","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def get_index_name(self):"},{"line_number":164,"context_line":"        return self.options.index_name"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @classmethod"},{"line_number":167,"context_line":"    def get_document_type(cls):"},{"line_number":168,"context_line":"        \"\"\"Get name of the document type."},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_41a613af","line":166,"updated":"2015-09-16 18:55:06.000000000","message":"I\u0027m not crazy about proliferating classmethods. I\u0027ll see if i can think of an alternative, otherwise i can live with it","commit_id":"e979fd3b99d2c1f2ce37df749b24259b5826ca3a"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"119d3e3850d6c874db6e129370525f6c5d3fb9c6","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        return []"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @classmethod"},{"line_number":199,"context_line":"    def get_topioc_exchanges(cls):"},{"line_number":200,"context_line":"        return []"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def get_notification_topics_exchanges(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_219bdf73","line":199,"updated":"2015-09-16 18:55:06.000000000","message":"Typo in topic. Since it seems like the default topic is largely (always?) going to be searchlight_indexer, can we put that in here and have the plugin return the topics (nova, glance, neutron)?","commit_id":"e979fd3b99d2c1f2ce37df749b24259b5826ca3a"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"242fe1f888906375bc0481cff93baad72edb69e3","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":34,"context_line":"class IndexBase(plugin.Plugin):"},{"line_number":35,"context_line":"    __plugin_ns__ \u003d \u0027searchlight.index_backend\u0027"},{"line_number":36,"context_line":"    __plugin_type__ \u003d \u0027index\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_478ed12e","line":34,"updated":"2015-09-18 12:35:19.000000000","message":"Why do we need another base class for plugin. IndexBase is the plugin class which all plugins implement. We could simplify a lot of method interactions by adding the methods from plugin.Plugin class to this class unless there is a specific reason to have another base class(In addition to IndexBase) which will extend from plugin.Plugin.","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"04169b33d8ccbe4de820996b3e828a20e44e9c61","unresolved":false,"context_lines":[{"line_number":33,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":34,"context_line":"class IndexBase(plugin.Plugin):"},{"line_number":35,"context_line":"    __plugin_ns__ \u003d \u0027searchlight.index_backend\u0027"},{"line_number":36,"context_line":"    __plugin_type__ \u003d \u0027index\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    chunk_size \u003d 200"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_d6238a54","line":36,"updated":"2015-09-17 20:57:25.000000000","message":"Why \u0027index\u0027 here and \u0027indexer\u0027 for the default?","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"04169b33d8ccbe4de820996b3e828a20e44e9c61","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        opts \u003d ["},{"line_number":53,"context_line":"            cfg.StrOpt(\"index_name\")"},{"line_number":54,"context_line":"        ]"},{"line_number":55,"context_line":"        exchange_topics \u003d [\"searchlight_indexer,%s\" % i for i in"},{"line_number":56,"context_line":"                           cls.get_topic_exchanges()]"},{"line_number":57,"context_line":"        if exchange_topics:"},{"line_number":58,"context_line":"            opts.append(cfg.MultiOpt("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_f6cc8e8a","line":55,"updated":"2015-09-17 20:57:25.000000000","message":"We will need to revisit this to figure out how people configure notifications. If the \u0027exchanges\u0027 are always named \u0027nova\u0027, \u0027glance\u0027 then only the topics need configuring, and in any case, the topic for the nova exchange will always be the same. A configuration mapping of .e.g nova -\u003e (searchlight_indexer, nova) makes more sense. But i think this is ok for now.","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"242fe1f888906375bc0481cff93baad72edb69e3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            cfg.StrOpt(\"index_name\")"},{"line_number":54,"context_line":"        ]"},{"line_number":55,"context_line":"        exchange_topics \u003d [\"searchlight_indexer,%s\" % i for i in"},{"line_number":56,"context_line":"                           cls.get_topic_exchanges()]"},{"line_number":57,"context_line":"        if exchange_topics:"},{"line_number":58,"context_line":"            opts.append(cfg.MultiOpt("},{"line_number":59,"context_line":"                \u0027exchange_topics\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_49334af6","line":56,"updated":"2015-09-18 12:35:19.000000000","message":"since the topic name is only specified here it would be good to get the name \"searchlight_indexer\" configurable from searchlight-api.conf","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"04169b33d8ccbe4de820996b3e828a20e44e9c61","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        return []"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    @classmethod"},{"line_number":209,"context_line":"    def get_topic_exchanges(cls):"},{"line_number":210,"context_line":"        return []"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def get_notification_topics_exchanges(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_76187ed3","line":209,"updated":"2015-09-17 20:57:25.000000000","message":"Let\u0027s make this an attribute of the class and indicate that it\u0027s defining the defaults.","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"242fe1f888906375bc0481cff93baad72edb69e3","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        \"\"\"\""},{"line_number":214,"context_line":"        Get the set of topics and exchanges. This is to retain the old"},{"line_number":215,"context_line":"        pattern without changing too much for now."},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":"        return [i.split(\u0027,\u0027) for i in self.options.exchange_topics]"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_0cbfa061","line":216,"updated":"2015-09-18 12:35:19.000000000","message":"This is not necessarily a big change.  listener.py is the only user of this method which could be modified to get the topic name from config file(see above comment) and exchanges from get_topic_exchanges()","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"}],"searchlight/elasticsearch/plugins/designate/notification_handlers.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"538d43918099e40548bcad481f133eb2213ed0b1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            }"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # TODO(ekarlso): Make this part (doc_type/index) configurable."},{"line_number":104,"context_line":"        documents \u003d helpers.scan("},{"line_number":105,"context_line":"            client\u003dself.engine,"},{"line_number":106,"context_line":"            index\u003dself.index_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a1a9d01_42150c99","line":103,"updated":"2015-10-02 20:57:13.000000000","message":"This TODO can go away, right?","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"4284580529a2b7aacc0f9ed9576325ae21493e3a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            }"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # TODO(ekarlso): Make this part (doc_type/index) configurable."},{"line_number":104,"context_line":"        documents \u003d helpers.scan("},{"line_number":105,"context_line":"            client\u003dself.engine,"},{"line_number":106,"context_line":"            index\u003dself.index_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a1a9d01_1e152448","line":103,"in_reply_to":"9a1a9d01_42150c99","updated":"2015-10-02 21:15:41.000000000","message":"Done","commit_id":"baa2fc1980db9c6cf8735a4a173c5533c23803d9"}],"searchlight/elasticsearch/plugins/glance/images.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"9036cb7f3b54a841dfdc86296a74bc01a33f2556","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            cfg.MultiOpt("},{"line_number":49,"context_line":"                \u0027exchange_topics\u0027,"},{"line_number":50,"context_line":"                item_type\u003dtypes.MultiString(),"},{"line_number":51,"context_line":"                default\u003d[\u0027searchlight-indexer,glance\u0027])"},{"line_number":52,"context_line":"        ])"},{"line_number":53,"context_line":"        return [(group, opts)]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_37f58482","line":51,"updated":"2015-09-16 01:34:16.000000000","message":"Since the only thing that changes from plugin to plugin is the defaults, perhaps best to abstract this out? Have the defaults as an attribute of the class and not make every plugin implement this function.","commit_id":"db8142f37924024dbfc3a202dd4c6ed76103112b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"04169b33d8ccbe4de820996b3e828a20e44e9c61","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def serialize(self, obj):"},{"line_number":121,"context_line":"        return serialize_glance_image(obj)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @classmethod"},{"line_number":124,"context_line":"    def get_exchanges(cls):"},{"line_number":125,"context_line":"        return [\u0027glance\u0027]"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_5150e40a","line":123,"updated":"2015-09-17 20:57:25.000000000","message":"Is this used?","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"}],"searchlight/elasticsearch/plugins/glance/metadefs.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"119d3e3850d6c874db6e129370525f6c5d3fb9c6","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class MetadefIndex(base.IndexBase):"},{"line_number":24,"context_line":"    __plugin_name__ \u003d \u0027metadef\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self):"},{"line_number":27,"context_line":"        super(MetadefIndex, self).__init__()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_61ca3750","line":24,"updated":"2015-09-16 18:55:06.000000000","message":"No longer needed","commit_id":"e979fd3b99d2c1f2ce37df749b24259b5826ca3a"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"04169b33d8ccbe4de820996b3e828a20e44e9c61","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def serialize(self, metadef_obj):"},{"line_number":131,"context_line":"        return serialize_glance_metadef_ns(metadef_obj)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @classmethod"},{"line_number":134,"context_line":"    def get_exchanges(cls):"},{"line_number":135,"context_line":"        return [\u0027glance\u0027]"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_1156ec05","line":133,"updated":"2015-09-17 20:57:25.000000000","message":"Is this used?","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"}],"searchlight/elasticsearch/plugins/nova/servers.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"9036cb7f3b54a841dfdc86296a74bc01a33f2556","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class ServerIndex(base.IndexBase):"},{"line_number":33,"context_line":"    __plugin_name__ \u003d \u0027servers\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # Properties restricted to admins only. hostId seems not to be"},{"line_number":36,"context_line":"    # considered sensitive because it doesn\u0027t directly identify hosts,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_0efab175","line":33,"updated":"2015-09-16 01:34:16.000000000","message":"Need to be a bit careful with using unqualified names; there could easily be an ironic plugin that has a \u0027servers\u0027 types as well. The full resource type name would be better; if the colons are a problem, we could replace those characters","commit_id":"db8142f37924024dbfc3a202dd4c6ed76103112b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"9036cb7f3b54a841dfdc86296a74bc01a33f2556","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            cfg.MultiOpt("},{"line_number":51,"context_line":"                \u0027exchange_topics\u0027,"},{"line_number":52,"context_line":"                item_type\u003dtypes.MultiString(),"},{"line_number":53,"context_line":"                default\u003d[\u0027searchlight-indexer,neutron\u0027,"},{"line_number":54,"context_line":"                         \u0027searchlight-indexer,nova\u0027]),"},{"line_number":55,"context_line":"        ])"},{"line_number":56,"context_line":"        return [(group, opts)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_4e366953","line":53,"updated":"2015-09-16 01:34:16.000000000","message":"searchlight_indexer (underscore) is the current default. Not necessarily opposed to changing it, but not as part of this patch","commit_id":"db8142f37924024dbfc3a202dd4c6ed76103112b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"119d3e3850d6c874db6e129370525f6c5d3fb9c6","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ServerIndex(base.IndexBase):"},{"line_number":30,"context_line":"    __plugin_name__ \u003d \u0027servers\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # Properties restricted to admins only. hostId seems not to be"},{"line_number":33,"context_line":"    # considered sensitive because it doesn\u0027t directly identify hosts,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_c1df830b","line":30,"updated":"2015-09-16 18:55:06.000000000","message":"No longer needed","commit_id":"e979fd3b99d2c1f2ce37df749b24259b5826ca3a"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"04169b33d8ccbe4de820996b3e828a20e44e9c61","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    def serialize(self, server):"},{"line_number":153,"context_line":"        return serialize_nova_server(server)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @classmethod"},{"line_number":156,"context_line":"    def get_exchanges(cls):"},{"line_number":157,"context_line":"        return [\u0027server\u0027]"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_3159b035","line":155,"updated":"2015-09-17 20:57:25.000000000","message":"Is this used?","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"}],"searchlight/plugin.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"9036cb7f3b54a841dfdc86296a74bc01a33f2556","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"import abc"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_eea97d7c","line":13,"updated":"2015-09-16 01:34:16.000000000","message":"Maybe a note where this came from for future reference?","commit_id":"db8142f37924024dbfc3a202dd4c6ed76103112b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"04169b33d8ccbe4de820996b3e828a20e44e9c61","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        LOG.debug(\"Loaded plugin %s\" % self.name)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def get_canonical_name(cls):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        Return the plugin name"},{"line_number":41,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_d1b2b44b","line":38,"updated":"2015-09-17 20:57:25.000000000","message":"Not sure what this is used for. If it\u0027s future proofing for more plugin types, i\u0027d rather add that when it\u0027s needed","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"242fe1f888906375bc0481cff93baad72edb69e3","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def register_cfg_opts(cls, namespace):"},{"line_number":76,"context_line":"        mgr \u003d extension.ExtensionManager(namespace)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        for e in mgr:"},{"line_number":79,"context_line":"            for group, opts in e.plugin.get_cfg_opts():"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_4c6b5885","line":76,"updated":"2015-09-18 12:35:19.000000000","message":"Use common.utils.get_search_plugins() to retrieve plugins from stevedore to be consistent","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"242fe1f888906375bc0481cff93baad72edb69e3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    @classmethod"},{"line_number":87,"context_line":"    def register_extra_cfg_opts(cls, namespace):"},{"line_number":88,"context_line":"        mgr \u003d extension.ExtensionManager(namespace)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        for e in mgr:"},{"line_number":91,"context_line":"            for group, opts in e.plugin.get_extra_cfg_opts():"},{"line_number":92,"context_line":"                if isinstance(group, six.string_types):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_0c0800d9","line":89,"updated":"2015-09-18 12:35:19.000000000","message":"Use common.utils.get_search_plugins() to retrieve plugins from stevedore to be consistent","commit_id":"f4481101dc715eb753dbf9480738a829ad18de2b"}]}
