)]}'
{"searchlight/elasticsearch/plugins/designate/recordsets.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"64e7c06ecb1105b88e8baea14a1dd86cbaf031b5","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def facets_with_options(self):"},{"line_number":68,"context_line":"        return (\u0027status\u0027, \u0027type\u0027, \u0027action\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":71,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_139d2459","line":68,"updated":"2015-09-25 23:04:06.000000000","message":"Test case.","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"434a3a95083cc3d06546416ff5a492c4a728cdfd","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def facets_with_options(self):"},{"line_number":68,"context_line":"        return (\u0027status\u0027, \u0027type\u0027, \u0027action\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":71,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_2f13e667","line":68,"in_reply_to":"9a1a9d01_139d2459","updated":"2015-09-28 21:14:41.000000000","message":"Adding a new test case is beyond what i\u0027ve got time for; perhaps safe to remove this for now.","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"}],"searchlight/elasticsearch/plugins/designate/zones.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"64e7c06ecb1105b88e8baea14a1dd86cbaf031b5","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def facets_with_options(self):"},{"line_number":68,"context_line":"        return (\u0027status\u0027, \u0027type\u0027, \u0027action\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":71,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_53939c4f","line":68,"updated":"2015-09-25 23:04:06.000000000","message":"Test case?","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"434a3a95083cc3d06546416ff5a492c4a728cdfd","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def facets_with_options(self):"},{"line_number":68,"context_line":"        return (\u0027status\u0027, \u0027type\u0027, \u0027action\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":71,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_2f3c46e1","line":68,"in_reply_to":"9a1a9d01_53939c4f","updated":"2015-09-28 21:14:41.000000000","message":"Adding a test case for this, although there is no existing test case for designate.","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"}],"searchlight/elasticsearch/plugins/glance/images.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"64e7c06ecb1105b88e8baea14a1dd86cbaf031b5","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @property"},{"line_number":69,"context_line":"    def facets_with_options(self):"},{"line_number":70,"context_line":"        return (\u0027disk_format\u0027, \u0027container_format\u0027, \u0027tags\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":73,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_73c90078","line":70,"updated":"2015-09-25 23:04:06.000000000","message":"Looking at the data, couple more fields to add:\n\n  \"visibility\": \"public\",\n  \"protected\": false,\n  \"status\": \"active\",","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"434a3a95083cc3d06546416ff5a492c4a728cdfd","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @property"},{"line_number":69,"context_line":"    def facets_with_options(self):"},{"line_number":70,"context_line":"        return (\u0027disk_format\u0027, \u0027container_format\u0027, \u0027tags\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":73,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_0fce225a","line":70,"in_reply_to":"9a1a9d01_73c90078","updated":"2015-09-28 21:14:41.000000000","message":"Done","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"64e7c06ecb1105b88e8baea14a1dd86cbaf031b5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    @property"},{"line_number":69,"context_line":"    def facets_with_options(self):"},{"line_number":70,"context_line":"        return (\u0027disk_format\u0027, \u0027container_format\u0027, \u0027tags\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":73,"context_line":"        return ["},{"line_number":74,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_b37d581e","line":71,"updated":"2015-09-25 23:04:06.000000000","message":"Glance facets are also returning all the properties object properties. This could be treated as separate bug so we can get this other facets added sooner than later if needed.\n\nThis is due to how glance does things.  So we\u0027re getting double mapping:\n\n    {\n      \"type\": \"string\",\n      \"name\": \"objects.description\"\n    },\n    {\n      \"type\": \"string\",\n      \"name\": \"objects.properties.description\"\n    },\n    {\n      \"type\": \"string\",\n      \"name\": \"objects.properties.type\"\n    },\n    {\n      \"type\": \"string\",\n      \"name\": \"objects.properties.name\"\n    },\n    {\n      \"type\": \"string\",\n      \"name\": \"objects.properties.title\"\n\n    {\n      \"type\": \"string\",\n      \"name\": \"objects.name\"\n    },\n    {\n      \"type\": \"string\",\n      \"name\": \"display_name\"\n    },\n    {\n      \"type\": \"string\",\n      \"name\": \"description\"\n    },","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"434a3a95083cc3d06546416ff5a492c4a728cdfd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    @property"},{"line_number":69,"context_line":"    def facets_with_options(self):"},{"line_number":70,"context_line":"        return (\u0027disk_format\u0027, \u0027container_format\u0027, \u0027tags\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":73,"context_line":"        return ["},{"line_number":74,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_ef408ea7","line":71,"in_reply_to":"9a1a9d01_b37d581e","updated":"2015-09-28 21:14:41.000000000","message":"It doesn\u0027t recurse more than one nesting level; I\u0027ll see how tough a fix that is.","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"}],"searchlight/elasticsearch/plugins/nova/servers.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"64e7c06ecb1105b88e8baea14a1dd86cbaf031b5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":92,"context_line":"                    \u0027index\u0027: \u0027not_analyzed\u0027"},{"line_number":93,"context_line":"                },"},{"line_number":94,"context_line":"                \u0027security_groups\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":95,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":96,"context_line":"            },"},{"line_number":97,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_d3ab2cd5","line":94,"updated":"2015-09-25 23:04:06.000000000","message":"Security groups is an array of objects.\n\n 1) The aggregation doesn\u0027t seem to be returning them correctly:\n 2) Maybe we shouldn\u0027t do this one?? There could be lots of security groups?\n\nExample data:\n\n          \"security_groups\": [\n            {\n              \"name\": \"default\"\n            }\n          ],\n\nResulting facet:\n\n    {\n      \"type\": \"string\",\n      \"name\": \"security_groups\",\n      \"options\": []\n    },","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"434a3a95083cc3d06546416ff5a492c4a728cdfd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":92,"context_line":"                    \u0027index\u0027: \u0027not_analyzed\u0027"},{"line_number":93,"context_line":"                },"},{"line_number":94,"context_line":"                \u0027security_groups\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":95,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":96,"context_line":"            },"},{"line_number":97,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_8f3552f8","line":94,"in_reply_to":"9a1a9d01_d3ab2cd5","updated":"2015-09-28 21:14:41.000000000","message":"This was a bug in how we\u0027re mapping it; nova returns a list of objects. Changed the mapping and facet field name.","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"64e7c06ecb1105b88e8baea14a1dd86cbaf031b5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        return (\u0027OS-EXT-AZ:availability_zone\u0027, \u0027OS-EXT-SRV-ATTR:host\u0027,"},{"line_number":102,"context_line":"                \u0027status\u0027, \u0027image.id\u0027, \u0027flavor.id\u0027, \u0027networks.name\u0027,"},{"line_number":103,"context_line":"                \u0027security_groups\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @property"},{"line_number":106,"context_line":"    def facets_excluded(self):"},{"line_number":107,"context_line":"        \"\"\"A map of {name: allow_admin} that indicate which"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_93685489","line":104,"updated":"2015-09-25 23:04:06.000000000","message":"Looking at the data there are a few other fields that are candidates for nova servers, because the choices will be limited.  Here are a few examples:\n\nNetworks subfields:\n  \"OS-EXT-IPS:type\": \"fixed\"\n  \"version\": 4,\n\nOther:\n  \"OS-DCF:diskConfig\": \"AUTO\",\n   \"config_drive\": \"True\",\n   \"hostId\"\n   \"OS-EXT-STS:vm_state\": \"stopped\",\n\nWhat is the performance impact of adding more?  Should we be careful about that?","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"434a3a95083cc3d06546416ff5a492c4a728cdfd","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        return (\u0027OS-EXT-AZ:availability_zone\u0027, \u0027OS-EXT-SRV-ATTR:host\u0027,"},{"line_number":102,"context_line":"                \u0027status\u0027, \u0027image.id\u0027, \u0027flavor.id\u0027, \u0027networks.name\u0027,"},{"line_number":103,"context_line":"                \u0027security_groups\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @property"},{"line_number":106,"context_line":"    def facets_excluded(self):"},{"line_number":107,"context_line":"        \"\"\"A map of {name: allow_admin} that indicate which"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_ef6e4e2e","line":104,"in_reply_to":"9a1a9d01_93685489","updated":"2015-09-28 21:14:41.000000000","message":"I\u0027m inclined not to add them. There\u0027s a small performance impact but it feels like diminishing returns. Eventually i suspect this might need to be config driven.","commit_id":"65e26ed44208d083db15ec8e5767ac31fffa4b67"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a80d1dd686eb5d3ec1d37c09feffa68f5b4653eb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def facets_with_options(self):"},{"line_number":106,"context_line":"        return (\u0027OS-EXT-AZ:availability_zone\u0027, \u0027OS-EXT-SRV-ATTR:host\u0027,"},{"line_number":107,"context_line":"                \u0027status\u0027, \u0027image.id\u0027, \u0027flavor.id\u0027, \u0027networks.name\u0027,"},{"line_number":108,"context_line":"                \u0027security_groups.name\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @property"},{"line_number":111,"context_line":"    def facets_excluded(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_1b42e010","line":108,"updated":"2015-09-28 20:31:45.000000000","message":"How about these fields?\n\nNetworks subfields:\n  \"OS-EXT-IPS:type\": \"fixed\"\n  \"version\": 4,\n\nOther:\n  \"OS-DCF:diskConfig\": \"AUTO\",\n   \"config_drive\": \"True\",\n   \"hostId\"\n   \"OS-EXT-STS:vm_state\": \"stopped\",","commit_id":"89bc39362a6df9daf9e94b20771d0e1f3315f5cd"}]}
