)]}'
{"searchlight/api/v1/search.py":[{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"a3ad0a97f86f85e9ebcc5f12bdb5aea891433fa9","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _get_query(self, context, query, resource_types, all_projects\u003dFalse):"},{"line_number":281,"context_line":"        is_admin \u003d context.is_admin"},{"line_number":282,"context_line":"        if is_admin and all_projects:"},{"line_number":283,"context_line":"            query_params \u003d {"},{"line_number":284,"context_line":"                \u0027query\u0027: {"},{"line_number":285,"context_line":"                    \u0027query\u0027: query"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_0ee9dfb6","line":282,"updated":"2015-09-30 18:02:05.000000000","message":"If all_projects is false in the query param, then admin user would behave like a normal user in that project.\n\nWhat i think should happen is that admin user should still behave like a admin user in that project.\n\nFor ex. An image created by a user1 in project x with visibility as private should still be returned when admin retrieves the images.\n\nLet me know if I have missed the intention of this change.","commit_id":"c85f0794ab194f1df9c2c4a8befd6703ce2c003b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"1562fed34102043a17ccea9e5320b7eb7c6c8874","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _get_query(self, context, query, resource_types, all_projects\u003dFalse):"},{"line_number":281,"context_line":"        is_admin \u003d context.is_admin"},{"line_number":282,"context_line":"        if is_admin and all_projects:"},{"line_number":283,"context_line":"            query_params \u003d {"},{"line_number":284,"context_line":"                \u0027query\u0027: {"},{"line_number":285,"context_line":"                    \u0027query\u0027: query"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_31e0c4cc","line":282,"in_reply_to":"9a1a9d01_0ee9dfb6","updated":"2015-09-30 18:24:27.000000000","message":"Lakshmi, perhaps we aren\u0027t talking on the same page.  I\u0027ll clarify thoughts here and then let\u0027s see if I\u0027m missing your point.  My intent here is for this to work similar to how horizon works today.  In horizon, there is a project dashboard and an admin dashboard.  When a user logs in, admin or not, they get a token scoped to a particular project.  When they are in the project dashboard, they only see images for the currently scoped project.  When they go to the admin dashboard, they see images across projects.  This is currently controlled using an all_tenants parameters.  There are additional considerations we\u0027ll have to deal with for domain scoped tokens and properly limiting results, but that will be a per resource thing I think.\n\nScenarios that this supports:\n\nUser in project A creates image projectAimage as private.\nAdmin gets a token scoped to project A.\nAdmin lists images.  Admin would see projectAImage.\n\nAdmin gets a token scoped to project B.\nAdmin lists images.  Admin would NOT see projectAImage, because they are scoped to project B.\n\nAdmin still has a token scoped to project B, but they now want to see all images. They include param of all_projects\u003dtrue.  Admin now see projectAImage.","commit_id":"c85f0794ab194f1df9c2c4a8befd6703ce2c003b"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"9628879f4de82b24f20f7a43a931954e0d4a35f2","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _get_query(self, context, query, resource_types, all_projects\u003dFalse):"},{"line_number":281,"context_line":"        is_admin \u003d context.is_admin"},{"line_number":282,"context_line":"        if is_admin and all_projects:"},{"line_number":283,"context_line":"            query_params \u003d {"},{"line_number":284,"context_line":"                \u0027query\u0027: {"},{"line_number":285,"context_line":"                    \u0027query\u0027: query"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_f4e55adb","line":282,"in_reply_to":"9a1a9d01_31e0c4cc","updated":"2015-09-30 18:47:34.000000000","message":"Yeah my bad. I was thinking that \"private image\" is  private to user instead of project.","commit_id":"c85f0794ab194f1df9c2c4a8befd6703ce2c003b"}]}
