)]}'
{"searchlight/elasticsearch/plugins/base.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"466d5867e9d2a4186a34b0ee7ef171d0abdefc49","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                search_type\u003d\u0027count\u0027)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            agg_results \u003d results.get(\u0027aggregations\u0027, {})"},{"line_number":225,"context_line":"            facet_terms \u003d utils.transform_facets_results("},{"line_number":226,"context_line":"                agg_results,"},{"line_number":227,"context_line":"                self.get_document_type())"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_c71db9be","line":225,"updated":"2015-11-17 00:04:01.000000000","message":"You bug comment about not messing with e-s format too much kinda makes me wonder if we should support a non-transformed format as well.  I\u0027ll lean towards no for now, but hope this doesn\u0027t bite us.","commit_id":"7bfbdb61c6423213ed524053345988c0a0519939"}],"searchlight/elasticsearch/plugins/utils.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"466d5867e9d2a4186a34b0ee7ef171d0abdefc49","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            term_aggregations[facet_name] \u003d {"},{"line_number":47,"context_line":"                \"nested\": {\"path\": facet_name.split(\u0027.\u0027)[0]},"},{"line_number":48,"context_line":"                \"aggs\": {"},{"line_number":49,"context_line":"                    # TODO(sjmc7): Handle deeper nesting?"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"                    facet_name: {"},{"line_number":52,"context_line":"                        \u0027terms\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_a7775501","line":49,"updated":"2015-11-17 00:04:01.000000000","message":"One level seems to solve our use cases for now.","commit_id":"7bfbdb61c6423213ed524053345988c0a0519939"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"466d5867e9d2a4186a34b0ee7ef171d0abdefc49","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    return term_aggregations"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def transform_facets_results(result_aggregations, resource_type):"},{"line_number":72,"context_line":"    facet_terms \u003d {}"},{"line_number":73,"context_line":"    for term, aggregation in six.iteritems(result_aggregations):"},{"line_number":74,"context_line":"        if term in aggregation:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_c79059ef","line":71,"updated":"2015-11-17 00:04:01.000000000","message":"This function could use comments showing example input and expected output...","commit_id":"7bfbdb61c6423213ed524053345988c0a0519939"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"1503d0d0e2f416ab81c2e1695a6912368d176e14","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    return term_aggregations"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def transform_facets_results(result_aggregations, resource_type):"},{"line_number":72,"context_line":"    facet_terms \u003d {}"},{"line_number":73,"context_line":"    for term, aggregation in six.iteritems(result_aggregations):"},{"line_number":74,"context_line":"        if term in aggregation:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_ed9429e3","line":71,"in_reply_to":"ba8a016a_c79059ef","updated":"2015-11-17 20:21:38.000000000","message":"Agreed, done","commit_id":"7bfbdb61c6423213ed524053345988c0a0519939"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"008630e483b0a169d0c8f43faad6e155e957f72b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"          {\"key\": 4, \"doc_count\": 1},"},{"line_number":88,"context_line":"          {\"key\": 6, \"doc_count\": 2}"},{"line_number":89,"context_line":"       ]}"},{"line_number":90,"context_line":"    \"\"\""},{"line_number":91,"context_line":"    facet_terms \u003d {}"},{"line_number":92,"context_line":"    for term, aggregation in six.iteritems(result_aggregations):"},{"line_number":93,"context_line":"        if term in aggregation:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_39b26f95","line":90,"updated":"2015-11-17 21:43:37.000000000","message":"If you update this again, I\u0027d suggest having the not_nested and nested be similarly formatted (put the array contents on new line for not_nested as well).  It takes a bit to figure out the difference, otherwise.","commit_id":"9493d8b6241c742ac72b4202c419dd8e793ecd6c"}],"searchlight/tests/functional/test_api.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"466d5867e9d2a4186a34b0ee7ef171d0abdefc49","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        self.assertEqual(200, response.status)"},{"line_number":597,"context_line":"        self.assertEqual([tenant1_doc], self._get_hit_source(json_content))"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    def test_nested_facets(self):"},{"line_number":600,"context_line":"        server1 \u003d {"},{"line_number":601,"context_line":"            u\u0027networks\u0027: [{"},{"line_number":602,"context_line":"                u\u0027ipv4_addr\u0027: u\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_e70c7d44","line":599,"updated":"2015-11-17 00:04:01.000000000","message":"Would you mind adding a test for regular facets (top level facets) like status? That would make this a more complete test.  Also simple nested facets.","commit_id":"7bfbdb61c6423213ed524053345988c0a0519939"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"1503d0d0e2f416ab81c2e1695a6912368d176e14","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        self.assertEqual(200, response.status)"},{"line_number":597,"context_line":"        self.assertEqual([tenant1_doc], self._get_hit_source(json_content))"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    def test_nested_facets(self):"},{"line_number":600,"context_line":"        server1 \u003d {"},{"line_number":601,"context_line":"            u\u0027networks\u0027: [{"},{"line_number":602,"context_line":"                u\u0027ipv4_addr\u0027: u\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_b89c1dc1","line":599,"in_reply_to":"ba8a016a_e70c7d44","updated":"2015-11-17 20:21:38.000000000","message":"Done","commit_id":"7bfbdb61c6423213ed524053345988c0a0519939"}],"searchlight/tests/unit/test_plugin_utils.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"466d5867e9d2a4186a34b0ee7ef171d0abdefc49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hewlett-Packard Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_625e3beb","line":1,"updated":"2015-11-17 00:04:01.000000000","message":"I think HPE copyrights are supposed to have \"Enterprise in them now.\"","commit_id":"7bfbdb61c6423213ed524053345988c0a0519939"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"466d5867e9d2a4186a34b0ee7ef171d0abdefc49","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        ))"},{"line_number":31,"context_line":"        self.assertEqual(expected, aggregation_query)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_facet_result_transform(self):"},{"line_number":34,"context_line":"        agg_results \u003d {"},{"line_number":35,"context_line":"            \"simple\": {"},{"line_number":36,"context_line":"                \"doc_count_error_upper_bound\": 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_42e21705","line":33,"updated":"2015-11-17 00:04:01.000000000","message":"I suppose the below works as the documentation that I mentioned in my other comment.  Perhaps just a comment telling people to look at this test for expected input / output, although that is kind of implied.","commit_id":"7bfbdb61c6423213ed524053345988c0a0519939"}]}