)]}'
{"searchlight/listener.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"f3a60d7ee9093d2da3d08df79ad4a7a29b2d3475","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CONF \u003d cfg.CONF"},{"line_number":36,"context_line":"oslo_policy_opts._register(CONF)"},{"line_number":37,"context_line":"CONF.register_opts(service.LISTENER_OPTS, group\u003d\"listener\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class NotificationEndpoint(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_272a0f91","line":37,"updated":"2015-12-11 19:30:56.000000000","message":"Any reason to make this uppercase? Looks at opts.py, that doesn\u0027t seem to be the norm.","commit_id":"41ffc70c2acaca75d551d08e5ba17e1752825262"}],"searchlight/opts.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d1029b7effc0fc5693716e962705dc679af40844","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        (\u0027elasticsearch\u0027, searchlight.elasticsearch.search_opts),"},{"line_number":34,"context_line":"        (\u0027paste_deploy\u0027, searchlight.common.config.paste_deploy_opts),"},{"line_number":35,"context_line":"        (\u0027profiler\u0027, searchlight.common.wsgi.profiler_opts),"},{"line_number":36,"context_line":"        (\u0027listener\u0027, searchlight.service.OPTS),"},{"line_number":37,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_6cffc501","line":36,"updated":"2015-12-11 04:56:58.000000000","message":"I\u0027m thinking that the searchlight.service.opts should be changed to searchlight.service.LISTENER_OPTS to avoid future confusion. Or am I missing something?","commit_id":"d38b0c481a71a7f9c347ab1d4de7a083efa56879"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ef1f66d83af0379fdd6bc032326d5138e6434f49","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        (\u0027elasticsearch\u0027, searchlight.elasticsearch.search_opts),"},{"line_number":34,"context_line":"        (\u0027paste_deploy\u0027, searchlight.common.config.paste_deploy_opts),"},{"line_number":35,"context_line":"        (\u0027profiler\u0027, searchlight.common.wsgi.profiler_opts),"},{"line_number":36,"context_line":"        (\u0027listener\u0027, searchlight.service.OPTS),"},{"line_number":37,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_d2c3f255","line":36,"in_reply_to":"7a740942_6cffc501","updated":"2015-12-11 06:28:18.000000000","message":"Agreed to change to LISTENER_OPTS, thanks!","commit_id":"d38b0c481a71a7f9c347ab1d4de7a083efa56879"}],"searchlight/service.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ef25f1ad6474dc6501ae7723f0f7797853753e19","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               help\u003d\u0027Name of this node, which must be valid in an AMQP \u0027"},{"line_number":35,"context_line":"               \u0027key. Can be an opaque identifier. For ZeroMQ only, must \u0027"},{"line_number":36,"context_line":"               \u0027be a valid host name, FQDN, or IP address.\u0027),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027listener_workers\u0027,"},{"line_number":38,"context_line":"               default\u003d1,"},{"line_number":39,"context_line":"               help\u003d\u0027Number of workers for notification service. A single \u0027"},{"line_number":40,"context_line":"               \u0027notification agent is enabled by default.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_331c99c0","line":37,"updated":"2015-12-07 19:31:31.000000000","message":"I think you need to set the default here and get rid of the function below.\n\n default\u003dprocessutils.get_worker_count(),\n\nNote that this is how heat seems to do it: https://github.com/openstack/heat/blob/a32b6892e212d625d6a6de03f0ee63e128b48a9e/heat/common/config.py#L85\n\n\nI also found that none of these options are being generated in the sample config right now.  So, I\u0027ve opened a separate bug on that.\n\nhttps://bugs.launchpad.net/searchlight/+bug/1523639","commit_id":"f4cfb4e636a175b0a3bbadd4d9d40a75bfd63245"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"58199e343287057b15334110152954c2faba49dd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               help\u003d\u0027Name of this node, which must be valid in an AMQP \u0027"},{"line_number":35,"context_line":"               \u0027key. Can be an opaque identifier. For ZeroMQ only, must \u0027"},{"line_number":36,"context_line":"               \u0027be a valid host name, FQDN, or IP address.\u0027),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027listener_workers\u0027,"},{"line_number":38,"context_line":"               default\u003d1,"},{"line_number":39,"context_line":"               help\u003d\u0027Number of workers for notification service. A single \u0027"},{"line_number":40,"context_line":"               \u0027notification agent is enabled by default.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_f510e35a","line":37,"in_reply_to":"7a740942_331c99c0","updated":"2015-12-09 02:40:00.000000000","message":"Done","commit_id":"f4cfb4e636a175b0a3bbadd4d9d40a75bfd63245"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ef25f1ad6474dc6501ae7723f0f7797853753e19","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \"\"\"Exception for errors relating to service workers.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_workers(name):"},{"line_number":57,"context_line":"    return (getattr(CONF, \u0027%s_workers\u0027 % name, None) or"},{"line_number":58,"context_line":"            processutils.get_worker_count())"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_3354991f","line":56,"updated":"2015-12-07 19:31:31.000000000","message":"I\u0027m not understanding why we have this function.  I think the code which uses it should change to getting this from conf by name. Am I missing something?\n\nhttps://github.com/openstack/searchlight/blob/e129e72af6658848601cdfc759f95b5e75c0227f/searchlight/cmd/listener.py#L28","commit_id":"f4cfb4e636a175b0a3bbadd4d9d40a75bfd63245"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"58199e343287057b15334110152954c2faba49dd","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \"\"\"Exception for errors relating to service workers.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_workers(name):"},{"line_number":57,"context_line":"    return (getattr(CONF, \u0027%s_workers\u0027 % name, None) or"},{"line_number":58,"context_line":"            processutils.get_worker_count())"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_f5aea37f","line":56,"in_reply_to":"7a740942_3354991f","updated":"2015-12-09 02:40:00.000000000","message":"Done","commit_id":"f4cfb4e636a175b0a3bbadd4d9d40a75bfd63245"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"bd318c959d95c8f19ba2a750167a84fea0f14c68","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OPTS \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":33,"context_line":"               default\u003dsocket.gethostname(),"},{"line_number":34,"context_line":"               help\u003d\u0027Name of this node, which must be valid in an AMQP \u0027"},{"line_number":35,"context_line":"               \u0027key. Can be an opaque identifier. For ZeroMQ only, must \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_d7d9fd84","line":32,"updated":"2015-12-09 19:33:14.000000000","message":"Do we use this anywhere?","commit_id":"9b146aa3ee34ec1b4d9bc8273d280b62e2813fd0"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"b1699b228ebab61ad63dec3aa560c639e15e8478","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OPTS \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":33,"context_line":"               default\u003dsocket.gethostname(),"},{"line_number":34,"context_line":"               help\u003d\u0027Name of this node, which must be valid in an AMQP \u0027"},{"line_number":35,"context_line":"               \u0027key. Can be an opaque identifier. For ZeroMQ only, must \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1c98fe69","line":32,"in_reply_to":"7a740942_d7d9fd84","updated":"2015-12-10 01:05:58.000000000","message":"No, i don\u0027t think so, should i remove this, and same for http_timeout.","commit_id":"9b146aa3ee34ec1b4d9bc8273d280b62e2813fd0"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"bd318c959d95c8f19ba2a750167a84fea0f14c68","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027key. Can be an opaque identifier. For ZeroMQ only, must \u0027"},{"line_number":36,"context_line":"               \u0027be a valid host name, FQDN, or IP address.\u0027),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027workers\u0027,"},{"line_number":38,"context_line":"               default\u003dprocessutils.get_worker_count(),"},{"line_number":39,"context_line":"               help\u003d\u0027Number of workers for notification service. A single \u0027"},{"line_number":40,"context_line":"               \u0027notification agent is enabled by default.\u0027),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027http_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_579f4db4","line":38,"updated":"2015-12-09 19:33:14.000000000","message":"I\u0027m not totally convinced i like defaulting this to the CPU count, though I\u0027m ok being overridden. Heat does it because heat-engine executes very long-running operations and it\u0027s very common to be executing more than one template at a time. In our case that\u0027s not necessarily the case, and my opinion is that defaulting to 1 is more friendly for development, but i\u0027m not terribly concerned.","commit_id":"9b146aa3ee34ec1b4d9bc8273d280b62e2813fd0"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"55ebf30db1b50536adf38bbc73c5002c28aaf9b4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027key. Can be an opaque identifier. For ZeroMQ only, must \u0027"},{"line_number":36,"context_line":"               \u0027be a valid host name, FQDN, or IP address.\u0027),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027workers\u0027,"},{"line_number":38,"context_line":"               default\u003dprocessutils.get_worker_count(),"},{"line_number":39,"context_line":"               help\u003d\u0027Number of workers for notification service. A single \u0027"},{"line_number":40,"context_line":"               \u0027notification agent is enabled by default.\u0027),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027http_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_c8ff0ca9","line":38,"in_reply_to":"7a740942_579f4db4","updated":"2015-12-10 03:01:59.000000000","message":"agree to default to 1 for more friendly development.","commit_id":"9b146aa3ee34ec1b4d9bc8273d280b62e2813fd0"}]}