)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a2857a343f676d4a14116c488c9d61c65075e7bc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, the number of api workers is configed by option \u0027workers\u0027"},{"line_number":10,"context_line":"which is obscure. Change it to \u0027api_workers\u0027 to make it more clear."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I77c450f74d19b3faf0fefc663abfebbb3cd1ea06"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_29abba76","line":12,"updated":"2015-12-08 01:37:11.000000000","message":"I think you can reference this bug as partially closes, #1493975\n\nhttps://bugs.launchpad.net/searchlight/+bug/1493975\n\nEither that or you could take over this change and fully implement it:\n\nhttps://review.openstack.org/#/c/232200/","commit_id":"d2c1f3470d8ed851e9e08ac6819a4d3cbac79945"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c1a2e1558ebc8d037792e3ecc8bcec09d93f80b2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, the number of api workers is configed by option \u0027workers\u0027"},{"line_number":10,"context_line":"which is obscure. Change it to \u0027api_workers\u0027 to make it more clear."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I77c450f74d19b3faf0fefc663abfebbb3cd1ea06"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_da0ab678","line":12,"in_reply_to":"7a740942_29abba76","updated":"2015-12-09 03:34:03.000000000","message":"Done","commit_id":"d2c1f3470d8ed851e9e08ac6819a4d3cbac79945"}],"searchlight/cmd/api.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"add500047b04622b2f6242e92c82c91d4732962d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"from searchlight.common import wsgi"},{"line_number":52,"context_line":"from searchlight import notifier"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"CONF \u003d cfg.CONF"},{"line_number":55,"context_line":"CONF.import_group(\"profiler\", \"searchlight.common.wsgi\")"},{"line_number":56,"context_line":"logging.register_options(CONF)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_29041a16","line":54,"updated":"2015-12-08 01:56:21.000000000","message":"If the options were placed in the correct group (e.g. registered under the searchlight.listener group), then you would just import them:\n\nCONF.import_group(\"profiler\", \"searchlight.listener\")","commit_id":"d2c1f3470d8ed851e9e08ac6819a4d3cbac79945"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c1a2e1558ebc8d037792e3ecc8bcec09d93f80b2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"from searchlight.common import wsgi"},{"line_number":52,"context_line":"from searchlight import notifier"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"CONF \u003d cfg.CONF"},{"line_number":55,"context_line":"CONF.import_group(\"profiler\", \"searchlight.common.wsgi\")"},{"line_number":56,"context_line":"logging.register_options(CONF)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_1a159e9a","line":54,"in_reply_to":"7a740942_29041a16","updated":"2015-12-09 03:34:03.000000000","message":"Done","commit_id":"d2c1f3470d8ed851e9e08ac6819a4d3cbac79945"}],"searchlight/common/wsgi.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"1c4e337f75b14470895ab5e15d62f031a2323718","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                                  \u0027server securely.\u0027)),"},{"line_number":80,"context_line":"]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"eventlet_opts \u003d ["},{"line_number":83,"context_line":"    cfg.IntOpt(\u0027api_workers\u0027, default\u003dprocessutils.get_worker_count(),"},{"line_number":84,"context_line":"               help\u003d_(\u0027The number of API child process workers that will be \u0027"},{"line_number":85,"context_line":"                      \u0027created to service requests. The default will be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_a9b1ea02","line":82,"updated":"2015-12-08 01:34:08.000000000","message":"Similar to my comments on your other patch [0]:\n\nI think you need to set the default here and get rid of the function below.\n\n default\u003dprocessutils.get_worker_count(),\n\nNote that this is how heat seems to do it: \n\nhttps://github.com/openstack/heat/blob/a32b6892e212d625d6a6de03f0ee63e128b48a9e/heat/common/config.py#L85\n\n[0] https://review.openstack.org/#/c/253973/1/searchlight/service.py","commit_id":"d2c1f3470d8ed851e9e08ac6819a4d3cbac79945"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c1a2e1558ebc8d037792e3ecc8bcec09d93f80b2","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                                  \u0027server securely.\u0027)),"},{"line_number":80,"context_line":"]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"eventlet_opts \u003d ["},{"line_number":83,"context_line":"    cfg.IntOpt(\u0027api_workers\u0027, default\u003dprocessutils.get_worker_count(),"},{"line_number":84,"context_line":"               help\u003d_(\u0027The number of API child process workers that will be \u0027"},{"line_number":85,"context_line":"                      \u0027created to service requests. The default will be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_9a298ee8","line":82,"in_reply_to":"7a740942_a9b1ea02","updated":"2015-12-09 03:34:03.000000000","message":"Done","commit_id":"d2c1f3470d8ed851e9e08ac6819a4d3cbac79945"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"1c4e337f75b14470895ab5e15d62f031a2323718","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"ASYNC_EVENTLET_THREAD_POOL_LIST \u003d []"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"def get_workers(name):"},{"line_number":123,"context_line":"    return (getattr(CONF, \u0027%s_workers\u0027 % name, None) or"},{"line_number":124,"context_line":"            processutils.get_worker_count())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_a9da4a49","line":121,"updated":"2015-12-08 01:34:08.000000000","message":"See above","commit_id":"d2c1f3470d8ed851e9e08ac6819a4d3cbac79945"}]}