)]}'
{"searchlight/opts.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"08fbdf1afce6a6fbdd5d74e67099d80074934225","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        (\u0027service_credentials\u0027,"},{"line_number":36,"context_line":"         itertools.chain("},{"line_number":37,"context_line":"             searchlight.elasticsearch.plugins.openstack_clients.client_opts,"},{"line_number":38,"context_line":"             keystoneclient.auth.conf.get_common_conf_options())),"},{"line_number":39,"context_line":"        (\u0027resource_plugin\u0027,"},{"line_number":40,"context_line":"         searchlight.elasticsearch.plugins.base.indexer_opts),"},{"line_number":41,"context_line":"        (\u0027paste_deploy\u0027, searchlight.common.config.paste_deploy_opts),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_08b34eea","line":38,"updated":"2016-02-01 02:14:31.000000000","message":"This only generates options from client_opts and keystoneclient.auth. I think the options from keystoneclient.session are missing.","commit_id":"80ced5bdef2f031841935681dd5cde0a602256a0"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"7a33cc8c16c053e3cba2517cd2ceeab7066e0da2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        (\u0027service_credentials\u0027,"},{"line_number":36,"context_line":"         itertools.chain("},{"line_number":37,"context_line":"             searchlight.elasticsearch.plugins.openstack_clients.client_opts,"},{"line_number":38,"context_line":"             keystoneclient.auth.conf.get_common_conf_options())),"},{"line_number":39,"context_line":"        (\u0027resource_plugin\u0027,"},{"line_number":40,"context_line":"         searchlight.elasticsearch.plugins.base.indexer_opts),"},{"line_number":41,"context_line":"        (\u0027paste_deploy\u0027, searchlight.common.config.paste_deploy_opts),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_de9fd44e","line":38,"in_reply_to":"7a5de9d1_08b34eea","updated":"2016-02-02 16:04:29.000000000","message":"I\u0027ve added some of the session options (ca cert, timeout etc); it\u0027s harder to get the plugin options (e.g. password) since they\u0027re loaded more dynamically based on the auth version; we\u0027d need to decide to use v2 or v3. I guess we could just pick one?","commit_id":"80ced5bdef2f031841935681dd5cde0a602256a0"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"08fbdf1afce6a6fbdd5d74e67099d80074934225","unresolved":false,"context_lines":[{"line_number":37,"context_line":"             searchlight.elasticsearch.plugins.openstack_clients.client_opts,"},{"line_number":38,"context_line":"             keystoneclient.auth.conf.get_common_conf_options())),"},{"line_number":39,"context_line":"        (\u0027resource_plugin\u0027,"},{"line_number":40,"context_line":"         searchlight.elasticsearch.plugins.base.indexer_opts),"},{"line_number":41,"context_line":"        (\u0027paste_deploy\u0027, searchlight.common.config.paste_deploy_opts),"},{"line_number":42,"context_line":"        (\u0027profiler\u0027, searchlight.common.wsgi.profiler_opts),"},{"line_number":43,"context_line":"        (\u0027listener\u0027, searchlight.listener.listener_opts),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_e8e4b2e0","line":40,"updated":"2016-02-01 02:14:31.000000000","message":"There are two warnings: \u0027WARNING:oslo_config.generator:\"index_name\" is missing a help string\nWARNING:oslo_config.generator:\"notifications_topic\" is missing a help string\u0027. It is not related to this patch, but it would be very nice if help string added for these two options.","commit_id":"80ced5bdef2f031841935681dd5cde0a602256a0"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"7a33cc8c16c053e3cba2517cd2ceeab7066e0da2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"             searchlight.elasticsearch.plugins.openstack_clients.client_opts,"},{"line_number":38,"context_line":"             keystoneclient.auth.conf.get_common_conf_options())),"},{"line_number":39,"context_line":"        (\u0027resource_plugin\u0027,"},{"line_number":40,"context_line":"         searchlight.elasticsearch.plugins.base.indexer_opts),"},{"line_number":41,"context_line":"        (\u0027paste_deploy\u0027, searchlight.common.config.paste_deploy_opts),"},{"line_number":42,"context_line":"        (\u0027profiler\u0027, searchlight.common.wsgi.profiler_opts),"},{"line_number":43,"context_line":"        (\u0027listener\u0027, searchlight.listener.listener_opts),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_d13b4537","line":40,"in_reply_to":"7a5de9d1_e8e4b2e0","updated":"2016-02-02 16:04:29.000000000","message":"Done","commit_id":"80ced5bdef2f031841935681dd5cde0a602256a0"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"2b23b4b326979db29dac8d5dd717e74d47cfae35","unresolved":false,"context_lines":[{"line_number":37,"context_line":"             searchlight.elasticsearch.plugins.openstack_clients.client_opts,"},{"line_number":38,"context_line":"             keystoneclient.auth.conf.get_common_conf_options(),"},{"line_number":39,"context_line":"             # This will only get the generic options; we would need to"},{"line_number":40,"context_line":"             # explicitly pick a plugin (e.g. v3 password) to get more"},{"line_number":41,"context_line":"             keystoneclient.session.Session.get_conf_options())),"},{"line_number":42,"context_line":"        (\u0027resource_plugin\u0027,"},{"line_number":43,"context_line":"         searchlight.elasticsearch.plugins.base.indexer_opts),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_7fa02f91","line":40,"updated":"2016-02-03 02:42:45.000000000","message":"could get some options as neutron did: https://github.com/openstack/neutron/blob/master/neutron/opts.py#L279","commit_id":"6505fa9ed3ea14eff18c9e43ed68ed0bf6116fbc"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"7530d12f2e4b614fa83011a9867b9fd14819ef36","unresolved":false,"context_lines":[{"line_number":37,"context_line":"             searchlight.elasticsearch.plugins.openstack_clients.client_opts,"},{"line_number":38,"context_line":"             keystoneclient.auth.conf.get_common_conf_options(),"},{"line_number":39,"context_line":"             # This will only get the generic options; we would need to"},{"line_number":40,"context_line":"             # explicitly pick a plugin (e.g. v3 password) to get more"},{"line_number":41,"context_line":"             keystoneclient.session.Session.get_conf_options())),"},{"line_number":42,"context_line":"        (\u0027resource_plugin\u0027,"},{"line_number":43,"context_line":"         searchlight.elasticsearch.plugins.base.indexer_opts),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_16d21301","line":40,"in_reply_to":"5a5ae5dd_7fa02f91","updated":"2016-02-03 21:56:47.000000000","message":"You\u0027re right, thanks for the suggestion :)","commit_id":"6505fa9ed3ea14eff18c9e43ed68ed0bf6116fbc"}]}
