)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5bb4d29590fc0f11e08d914a101b2c0de963fb8d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Note: There is not python-searchlightclient"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"cd /opt/stack/requirements"},{"line_number":17,"context_line":"git review -d 268394"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cd /opt/stack/searchlight"},{"line_number":20,"context_line":"git review -d 268358"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a68dd71_ad4e2094","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":20},"updated":"2016-01-22 02:01:54.000000000","message":"I don\u0027t think this is needed for this test, since searchlightclient is installed directly from git","commit_id":"d5727a6cb6d090fdf04b22fbd5357996c17c21f6"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"78d1e53d64e1643ca1168b667bfb06d7aae84371","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Note: There is not python-searchlightclient"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"cd /opt/stack/requirements"},{"line_number":17,"context_line":"git review -d 268394"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cd /opt/stack/searchlight"},{"line_number":20,"context_line":"git review -d 268358"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a68dd71_6ce6c5b1","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":20},"in_reply_to":"9a68dd71_ac391da6","updated":"2016-01-22 16:36:45.000000000","message":"Thx for catching.  Forgot about this after changing since the first patch sets.","commit_id":"d5727a6cb6d090fdf04b22fbd5357996c17c21f6"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"44bcc3a8c14a05f68bbffa5f90f1c9ef052bca96","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Note: There is not python-searchlightclient"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"cd /opt/stack/requirements"},{"line_number":17,"context_line":"git review -d 268394"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cd /opt/stack/searchlight"},{"line_number":20,"context_line":"git review -d 268358"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a68dd71_ac391da6","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":20},"in_reply_to":"9a68dd71_ad4e2094","updated":"2016-01-22 16:24:09.000000000","message":"Agreed; global-reqs is ignored when installing from git. This\u0027ll only be necessary when we add to searchlight\u0027s requirements.txt.","commit_id":"d5727a6cb6d090fdf04b22fbd5357996c17c21f6"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"44bcc3a8c14a05f68bbffa5f90f1c9ef052bca96","unresolved":false,"context_lines":[{"line_number":16,"context_line":"cd /opt/stack/requirements"},{"line_number":17,"context_line":"git review -d 268394"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cd /opt/stack/searchlight"},{"line_number":20,"context_line":"git review -d 268358"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"cd \u003cdevstack_dir\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a68dd71_6c0d65e7","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":13},"updated":"2016-01-22 16:24:09.000000000","message":"We can probably remove the rest of the \u0027to test\u0027 instructions; it should be pretty straightforward, and i\u0027d rather this not be part of the commit message. Maybe add a review comment if it\u0027s worth preserving.","commit_id":"d5727a6cb6d090fdf04b22fbd5357996c17c21f6"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"78d1e53d64e1643ca1168b667bfb06d7aae84371","unresolved":false,"context_lines":[{"line_number":16,"context_line":"cd /opt/stack/requirements"},{"line_number":17,"context_line":"git review -d 268394"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cd /opt/stack/searchlight"},{"line_number":20,"context_line":"git review -d 268358"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"cd \u003cdevstack_dir\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a68dd71_0c2b8995","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":13},"in_reply_to":"9a68dd71_6c0d65e7","updated":"2016-01-22 16:36:45.000000000","message":"I kind of disagree here, but I don\u0027t care enough in this case to not do it.  I\u0027ve found having some test instructions in the commit to be helpful in commits on several projects.  Review comments can get lost. Since this is just a part of a bigger blueprint, can\u0027t really add to the blueprint or bug report...","commit_id":"d5727a6cb6d090fdf04b22fbd5357996c17c21f6"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"44bcc3a8c14a05f68bbffa5f90f1c9ef052bca96","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Change-Id: I9050ac6720dece11e855665b7f17a4717728e722"},{"line_number":42,"context_line":"Partially-Implements: blueprint openstack-client-search-initial-plugin"},{"line_number":43,"context_line":"Depends-On: I65ac651d7d02d5a751736b2fedcd02047bb8c01c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a68dd71_0cc06929","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":53},"updated":"2016-01-22 16:24:09.000000000","message":"Doesn\u0027t need this; see Li\u0027s comment above","commit_id":"d5727a6cb6d090fdf04b22fbd5357996c17c21f6"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"78d1e53d64e1643ca1168b667bfb06d7aae84371","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Change-Id: I9050ac6720dece11e855665b7f17a4717728e722"},{"line_number":42,"context_line":"Partially-Implements: blueprint openstack-client-search-initial-plugin"},{"line_number":43,"context_line":"Depends-On: I65ac651d7d02d5a751736b2fedcd02047bb8c01c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a68dd71_8cebf977","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":53},"in_reply_to":"9a68dd71_0cc06929","updated":"2016-01-22 16:36:45.000000000","message":"thx!","commit_id":"d5727a6cb6d090fdf04b22fbd5357996c17c21f6"}],"devstack/plugin.sh":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"0b64c0d6dc245a8a854f6af106a63a523e26d0fe","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"# install_searchlightclient - Collect source and prepare"},{"line_number":179,"context_line":"function install_searchlightclient {"},{"line_number":180,"context_line":"    if use_library_from_git \"python-searchlightlient\"; then"},{"line_number":181,"context_line":"        git_clone_by_name \"python-searchlightclient\""},{"line_number":182,"context_line":"        setup_dev_lib \"python-searchlightclient\""},{"line_number":183,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba63e191_dda4bd09","line":180,"range":{"start_line":180,"start_character":36,"end_line":180,"end_character":52},"updated":"2016-01-18 22:55:37.000000000","message":"It took me a ridiculously long time to realize you missed a \u0027c\u0027 :)","commit_id":"68af34180e9ff9b717ac5e3f47cc52d2b592837d"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"0b64c0d6dc245a8a854f6af106a63a523e26d0fe","unresolved":false,"context_lines":[{"line_number":178,"context_line":"# install_searchlightclient - Collect source and prepare"},{"line_number":179,"context_line":"function install_searchlightclient {"},{"line_number":180,"context_line":"    if use_library_from_git \"python-searchlightlient\"; then"},{"line_number":181,"context_line":"        git_clone_by_name \"python-searchlightclient\""},{"line_number":182,"context_line":"        setup_dev_lib \"python-searchlightclient\""},{"line_number":183,"context_line":"    else"},{"line_number":184,"context_line":"        pip_install_gr \"python-searchlightclient\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba63e191_3d3159a3","line":181,"range":{"start_line":181,"start_character":8,"end_line":181,"end_character":25},"updated":"2016-01-18 22:55:37.000000000","message":"git_clone_by_name looks for entries in the GITREPO, GITDIR and GITBRANCH maps. enable_plugin sets these up for searchlight, but not for the client; it would probably make more sense to call git_clone directly and pass the SEARCHLIGHTBRANCH and use SEARCHLIGHT_DIR and SEARCHLIgHT_REPO (replacing \u0027searchlight\u0027 with \u0027python-searchlight\u0027) for the other two.","commit_id":"68af34180e9ff9b717ac5e3f47cc52d2b592837d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"7c3d0a017c0f002814bb768c6cd5fec2d4a0c378","unresolved":false,"context_lines":[{"line_number":178,"context_line":"# install_searchlightclient - Collect source and prepare"},{"line_number":179,"context_line":"function install_searchlightclient {"},{"line_number":180,"context_line":"    if use_library_from_git \"python-searchlightlient\"; then"},{"line_number":181,"context_line":"        git_clone_by_name \"python-searchlightclient\""},{"line_number":182,"context_line":"        setup_dev_lib \"python-searchlightclient\""},{"line_number":183,"context_line":"    else"},{"line_number":184,"context_line":"        pip_install_gr \"python-searchlightclient\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a68dd71_8f0354b8","line":181,"range":{"start_line":181,"start_character":8,"end_line":181,"end_character":25},"in_reply_to":"ba63e191_3d3159a3","updated":"2016-01-20 23:57:09.000000000","message":"Okay, i switched to copy congress and zaqar.","commit_id":"68af34180e9ff9b717ac5e3f47cc52d2b592837d"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"44bcc3a8c14a05f68bbffa5f90f1c9ef052bca96","unresolved":false,"context_lines":[{"line_number":180,"context_line":"}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"# install_searchlightclient - Collect source and prepare"},{"line_number":183,"context_line":"function install_searchlightclient {"},{"line_number":184,"context_line":"    git_clone $SEARCHLIGHTCLIENT_REPO $SEARCHLIGHTCLIENT_DIR $SEARCHLIGHTCLIENT_BRANCH"},{"line_number":185,"context_line":"    setup_develop $SEARCHLIGHTCLIENT_DIR"},{"line_number":186,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9a68dd71_2cd1ad23","line":183,"range":{"start_line":183,"start_character":9,"end_line":183,"end_character":34},"updated":"2016-01-22 16:24:09.000000000","message":"This is a bit unusual, but i think it\u0027s ok. We should revisit once we have a released client version (I\u0027m getting inclined to do that once we have these base commands merged).","commit_id":"d5727a6cb6d090fdf04b22fbd5357996c17c21f6"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"78d1e53d64e1643ca1168b667bfb06d7aae84371","unresolved":false,"context_lines":[{"line_number":180,"context_line":"}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"# install_searchlightclient - Collect source and prepare"},{"line_number":183,"context_line":"function install_searchlightclient {"},{"line_number":184,"context_line":"    git_clone $SEARCHLIGHTCLIENT_REPO $SEARCHLIGHTCLIENT_DIR $SEARCHLIGHTCLIENT_BRANCH"},{"line_number":185,"context_line":"    setup_develop $SEARCHLIGHTCLIENT_DIR"},{"line_number":186,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9a68dd71_cfa243fd","line":183,"range":{"start_line":183,"start_character":9,"end_line":183,"end_character":34},"in_reply_to":"9a68dd71_2cd1ad23","updated":"2016-01-22 16:36:45.000000000","message":"Yeah, this is what congress and magnum do. I think we should switch back to libs from git methodology after releasing (my earlier patch sets), but I am actually a little hesitant on some of the commands still.  I think we need a bit more burn in before releasing, because backwards compatibility has become a hot topic on the clients.","commit_id":"d5727a6cb6d090fdf04b22fbd5357996c17c21f6"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"7771bc79c0f3a4497099de3f525ce3ad3a7ebfd3","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    iniset $SEARCHLIGHT_CONF resource_plugin:os_designate_recordset enabled False"},{"line_number":135,"context_line":"}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"function configure_searchlightclient {"},{"line_number":138,"context_line":"    setup_develop $SEARCHLIGHTCLIENT_DIR"},{"line_number":139,"context_line":"}"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"9a68dd71_18e928b7","line":137,"range":{"start_line":137,"start_character":9,"end_line":137,"end_character":36},"updated":"2016-01-25 18:43:36.000000000","message":"Don\u0027t think this is necessary; setup.py develop\u0027s already being called in install_","commit_id":"cd7e8f0743f1fd1002b08fb494d5cd64067c4e91"}],"requirements.txt":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"0b64c0d6dc245a8a854f6af106a63a523e26d0fe","unresolved":false,"context_lines":[{"line_number":46,"context_line":"python-designateclient\u003e\u003d1.5.0"},{"line_number":47,"context_line":"python-glanceclient\u003e\u003d1.2.0"},{"line_number":48,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0"},{"line_number":49,"context_line":"python-searchlightclient\u003e\u003d0.1.0"}],"source_content_type":"text/plain","patch_set":3,"id":"ba63e191_9d6885bc","line":49,"range":{"start_line":49,"start_character":7,"end_line":49,"end_character":24},"updated":"2016-01-18 22:55:37.000000000","message":"This won\u0027t work until there\u0027s something installable from pypi; it\u0027s also not necessary to have this AND the \u0027install from pip\u0027 option in the devstack plugin, because this\u0027ll force it to get installed","commit_id":"68af34180e9ff9b717ac5e3f47cc52d2b592837d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"7c3d0a017c0f002814bb768c6cd5fec2d4a0c378","unresolved":false,"context_lines":[{"line_number":46,"context_line":"python-designateclient\u003e\u003d1.5.0"},{"line_number":47,"context_line":"python-glanceclient\u003e\u003d1.2.0"},{"line_number":48,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0"},{"line_number":49,"context_line":"python-searchlightclient\u003e\u003d0.1.0"}],"source_content_type":"text/plain","patch_set":3,"id":"9a68dd71_e2af9e7b","line":49,"range":{"start_line":49,"start_character":7,"end_line":49,"end_character":24},"in_reply_to":"ba63e191_9d6885bc","updated":"2016-01-20 23:57:09.000000000","message":"This is how the libs from git support works in devstack.","commit_id":"68af34180e9ff9b717ac5e3f47cc52d2b592837d"}]}