)]}'
{"searchlight/api/v1/search.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f5253e938cffc78807e73da27ac3b1350352e5f2","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        # Filter out the role-separation field, and deletion field"},{"line_number":413,"context_line":"        query_params.setdefault(\u0027_source_exclude\u0027, []).extend("},{"line_number":414,"context_line":"            [searchlight.elasticsearch.ROLE_USER_FIELD,"},{"line_number":415,"context_line":"             searchlight.elasticsearch.DELETION_FIELD])"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_106ce0ce","line":413,"updated":"2016-02-06 00:39:41.000000000","message":"*maybe* these should be tracked as ALWAYS_EXCLUDE array in serchlight.elasticsearch.","commit_id":"a7f291358ff8129371b04faabdff914229959e5d"}],"searchlight/elasticsearch/__init__.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f5253e938cffc78807e73da27ac3b1350352e5f2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# It\u0027s not important exactly what this is, except that it\u0027s consistent"},{"line_number":30,"context_line":"# across all plugins, and doesn\u0027t interfere with any real fields."},{"line_number":31,"context_line":"ROLE_USER_FIELD \u003d \"__searchlight-user-role\""},{"line_number":32,"context_line":"DELETION_FIELD \u003d \"__deleted\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"search_opts \u003d ["},{"line_number":35,"context_line":"    cfg.ListOpt(\u0027hosts\u0027, default\u003d[\u0027127.0.0.1:9200\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_509d78ba","line":32,"updated":"2016-02-06 00:39:41.000000000","message":"I think we should also use the searchlight prefix here for namespacing and consistency. Also, if I\u0027m looking at the raw index in ES, I won\u0027t accidentally think this is an ES keyword field.","commit_id":"a7f291358ff8129371b04faabdff914229959e5d"}],"searchlight/elasticsearch/plugins/base.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f5253e938cffc78807e73da27ac3b1350352e5f2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"_LI \u003d i18n._LI"},{"line_number":35,"context_line":"_ \u003d i18n._"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"DEFAULT_DELETION_TTL \u003d \"10m\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"indexer_opts \u003d ["},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027index_name\u0027, default\u003d\"searchlight\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_90b77039","line":37,"updated":"2016-02-06 00:39:41.000000000","message":"I guess we have no basis for any number we might add to here.  Is this enough?","commit_id":"a7f291358ff8129371b04faabdff914229959e5d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f5253e938cffc78807e73da27ac3b1350352e5f2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            }"},{"line_number":145,"context_line":"            mapping[\u0027_ttl\u0027] \u003d {"},{"line_number":146,"context_line":"                \u0027enabled\u0027: True"},{"line_number":147,"context_line":"            }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        apply_common_mapping(type_mapping)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_30b31ceb","line":147,"updated":"2016-02-06 00:39:41.000000000","message":"I think you brought it up before during spec review, but what are we going to do about 2.0 deprecation in the future?  I guess we don\u0027t have to solve now, but ???","commit_id":"a7f291358ff8129371b04faabdff914229959e5d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f5253e938cffc78807e73da27ac3b1350352e5f2","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            role_filter \u003d request_context.user_role_filter"},{"line_number":260,"context_line":"            plugin_filters \u003d ["},{"line_number":261,"context_line":"                {\u0027term\u0027: {ROLE_USER_FIELD: role_filter}},"},{"line_number":262,"context_line":"                {\u0027not\u0027: {\u0027term\u0027: {DELETION_FIELD: True}}}"},{"line_number":263,"context_line":"            ]"},{"line_number":264,"context_line":"            if not (request_context.is_admin and all_projects):"},{"line_number":265,"context_line":"                plugin_filters.extend("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_d0972846","line":262,"updated":"2016-02-06 00:39:41.000000000","message":"This code and the code in search.py on line 274 is identical.  This is going to get really easy to get out of sync and miss. Common filters function like common mappings would be good.","commit_id":"a7f291358ff8129371b04faabdff914229959e5d"}]}
