)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"717d67f5b58095ab6fca4f941dc5563619c48324","unresolved":false,"context_lines":[{"line_number":15,"context_line":"It also increases the default delete GC time to 5 minutes from 1 minute"},{"line_number":16,"context_line":"(configurable)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I7bde5a496c01ffeb17a6560d5c3572c51b1be141"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5aef4532_934da240","line":18,"updated":"2016-03-09 23:20:24.000000000","message":"needs bp link","commit_id":"30989095f0fffdc526035bcb6bc010568b5317ff"}],"searchlight/elasticsearch/plugins/base.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"717d67f5b58095ab6fca4f941dc5563619c48324","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        pass"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def get_settings(self):"},{"line_number":368,"context_line":"        \"\"\"Get an index settings.\"\"\""},{"line_number":369,"context_line":"        return {"},{"line_number":370,"context_line":"            \"index\": {"},{"line_number":371,"context_line":"                \"gc_deletes\": CONF.elasticsearch.index_gc_deletes"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_3423d4a8","line":368,"updated":"2016-03-09 23:20:24.000000000","message":"an (remove)","commit_id":"30989095f0fffdc526035bcb6bc010568b5317ff"}],"searchlight/elasticsearch/plugins/glance/images_notification_handler.py":[{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"bde557cec88ab0b4eb634bb9e8e8734e200cb501","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        image_id \u003d payload[\u0027id\u0027]"},{"line_number":74,"context_line":"        try:"},{"line_number":75,"context_line":"            version \u003d self.get_version(payload, timestamp,"},{"line_number":76,"context_line":"                                       preferred_date_field\u003d\u0027deleted_at\u0027)"},{"line_number":77,"context_line":"            self.index_helper.delete_document("},{"line_number":78,"context_line":"                {\u0027_id\u0027: image_id, \u0027_version\u0027: version})"},{"line_number":79,"context_line":"        except Exception as exc:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_ca7669d6","line":76,"range":{"start_line":76,"start_character":71,"end_line":76,"end_character":73},"updated":"2016-03-09 14:33:47.000000000","message":"If we use deleted_at for computing version during delete, will it find the document when it was indexed using created/updated field?","commit_id":"e2a2ff7b40c9de77bdfc960d12e4f420ca4ab8d2"}],"searchlight/elasticsearch/plugins/utils.py":[{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"2e79d018fdaf5fa57f771e84c6be5b6d0422eaaf","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        \"\"\"\u0027document\u0027 must contain an \u0027_id\u0027, but can include \u0027_parent\u0027 and"},{"line_number":171,"context_line":"        \u0027_version\u0027, each of which will be passed to the bulk helper"},{"line_number":172,"context_line":"        \"\"\""},{"line_number":173,"context_line":"        self.delete_documents([document])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def delete_documents(self, documents, override_role_separation\u003dFalse):"},{"line_number":176,"context_line":"        \"\"\"Each document should be a dict with at an _id, and if"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_4616d1f1","line":173,"updated":"2016-03-03 08:12:02.000000000","message":"what\u0027s the difference between delete_document_by_id and delete_document, they look very similiar, can we just use delete_document?","commit_id":"7a62a9d66a77e2479b3fb72f69e095fc59adc970"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d30b5632237891a79b6dca78f72c5cf710e0ffbb","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        \"\"\"\u0027document\u0027 must contain an \u0027_id\u0027, but can include \u0027_parent\u0027 and"},{"line_number":171,"context_line":"        \u0027_version\u0027, each of which will be passed to the bulk helper"},{"line_number":172,"context_line":"        \"\"\""},{"line_number":173,"context_line":"        self.delete_documents([document])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def delete_documents(self, documents, override_role_separation\u003dFalse):"},{"line_number":176,"context_line":"        \"\"\"Each document should be a dict with at an _id, and if"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_c40392bd","line":173,"in_reply_to":"7af24918_4616d1f1","updated":"2016-03-04 17:49:01.000000000","message":"I kept delete_document_by_id for back-compatibility but maybe it\u0027s best to remove them all.","commit_id":"7a62a9d66a77e2479b3fb72f69e095fc59adc970"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"2e79d018fdaf5fa57f771e84c6be5b6d0422eaaf","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                LOG.warning("},{"line_number":219,"context_line":"                    _LE(\"Error deleting %(doc_type)s %(ids)s; newer versions \""},{"line_number":220,"context_line":"                        \"of some documents have been indexed\") %"},{"line_number":221,"context_line":"                    {\"doc_type\": self.plugin.document_type, \"ids\": doc_ids})"},{"line_number":222,"context_line":"            else:"},{"line_number":223,"context_line":"                raise"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_df0e343a","line":221,"updated":"2016-03-03 08:12:02.000000000","message":"Are there any other conflict exceptions here using 409 error code? From the doc it seems that only version conflict and create conflict use 409. Also why using _LE in LOG.warning, a little weird to me.","commit_id":"7a62a9d66a77e2479b3fb72f69e095fc59adc970"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d30b5632237891a79b6dca78f72c5cf710e0ffbb","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                LOG.warning("},{"line_number":219,"context_line":"                    _LE(\"Error deleting %(doc_type)s %(ids)s; newer versions \""},{"line_number":220,"context_line":"                        \"of some documents have been indexed\") %"},{"line_number":221,"context_line":"                    {\"doc_type\": self.plugin.document_type, \"ids\": doc_ids})"},{"line_number":222,"context_line":"            else:"},{"line_number":223,"context_line":"                raise"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_24e35607","line":221,"in_reply_to":"7af24918_df0e343a","updated":"2016-03-04 17:49:01.000000000","message":"I don\u0027t believe so; 409 is very tightly defined and i don\u0027t think there\u0027s any other operation that would cause it in elasticsearch.\n\nYou\u0027re right about the mismatch; i\u0027ll correct it to error.","commit_id":"7a62a9d66a77e2479b3fb72f69e095fc59adc970"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"22b311bed5fe6ec0e4d4f7791294101145636b21","unresolved":false,"context_lines":[{"line_number":30,"context_line":"USER_ID_SUFFIX \u003d \"_USER\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"_LE \u003d i18n._LE"},{"line_number":34,"context_line":"_LW \u003d i18n._LW"},{"line_number":35,"context_line":"VERSION_CONFLICT_MSG \u003d \u0027version_conflict_engine_exception\u0027"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_f316e1ef","line":33,"updated":"2016-03-09 06:53:24.000000000","message":"_LE is no longer used and can be removed.","commit_id":"e2a2ff7b40c9de77bdfc960d12e4f420ca4ab8d2"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"bde557cec88ab0b4eb634bb9e8e8734e200cb501","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if version:"},{"line_number":299,"context_line":"            for action in to_delete:"},{"line_number":300,"context_line":"                action[\u0027_version\u0027] \u003d version"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        self.delete_documents(to_delete, override_role_separation\u003dTrue)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_document(self, doc_id, for_admin\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_6f4f676b","line":301,"updated":"2016-03-09 14:33:47.000000000","message":"How can this work? If children of given parent_id are being deleted, how can we specify the version of parent to each of the child being deleted. Shouldn\u0027t it be each child\u0027s version?\n\nIf we can\u0027t know the version of each child being deleted, we might as well leave out the _version input since we want all children for this parent to be deleted irrespective of their latest versions.","commit_id":"e2a2ff7b40c9de77bdfc960d12e4f420ca4ab8d2"}]}