)]}'
{"searchlight/api/v1/search.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"9d7c83605b6615b1bdf63e498dfcf02da90c4aa7","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"                type_and_rbac_filters.append(plugin_filter)"},{"line_number":284,"context_line":"            except Exception as e:"},{"line_number":285,"context_line":"                msg \u003d _(\"Error processing %s RBAC filter\") % resource_type"},{"line_number":286,"context_line":"                LOG.error(_LE(\"Failed to retrieve RBAC filters \""},{"line_number":287,"context_line":"                              \"from search plugin \""},{"line_number":288,"context_line":"                              \"%(ext)s: %(e)s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_4d0490bf","line":285,"updated":"2016-03-02 02:14:58.000000000","message":"Replace RBAC with query","commit_id":"a80f7893a45496e805f5c66d9145e1f46ba7d602"}],"searchlight/elasticsearch/plugins/base.py":[{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"4ef30367759f3811cf0f3d3d063e62fefd964dc1","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            plugin_filters \u003d self._get_rbac_field_filters(request_context)"},{"line_number":384,"context_line":"            type_filter[\u0027indices\u0027][\u0027filter\u0027][\u0027and\u0027].extend(plugin_filters)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        return type_filter"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    @abc.abstractmethod"},{"line_number":389,"context_line":"    def _get_rbac_field_filters(self, request_context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_e0ac5ca2","line":386,"range":{"start_line":386,"start_character":15,"end_line":386,"end_character":26},"updated":"2016-03-16 20:02:44.000000000","message":"nit. for the sake of code readability consider renaming type_filter to query_filter or something that says that, returned filter is not always type_filter\n\nalternatively you could start with query_filter without any filters and add type_filter, rbac filters based on if checks.","commit_id":"b489683e5600aa9b08f8f997eb2bb42dbf72b55b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ed7fd733e08f9834ab4042bf26fab32279a0b0ab","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            plugin_filters \u003d self._get_rbac_field_filters(request_context)"},{"line_number":384,"context_line":"            type_filter[\u0027indices\u0027][\u0027filter\u0027][\u0027and\u0027].extend(plugin_filters)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        return type_filter"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    @abc.abstractmethod"},{"line_number":389,"context_line":"    def _get_rbac_field_filters(self, request_context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_eb3c3de4","line":386,"range":{"start_line":386,"start_character":15,"end_line":386,"end_character":26},"in_reply_to":"1af94dfe_e0ac5ca2","updated":"2016-03-16 20:33:40.000000000","message":"Done","commit_id":"b489683e5600aa9b08f8f997eb2bb42dbf72b55b"}]}
