)]}'
{"releasenotes/notes/use-doc-values-da5e83b92eaa0495.yaml":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"4bb53fc0ab3f559495ad1293746526ee24222907","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Use doc_values for appropriate fields in elasticsearch"},{"line_number":4,"context_line":"    mappings for plugins. See documentation at"},{"line_number":5,"context_line":"    https://www.elastic.co/guide/en/elasticsearch/guide/current/doc-values.html"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7af24918_19160aa7","line":6,"updated":"2016-03-02 21:06:39.000000000","message":"Since we are using doc values,should we consider reducing the heap size in the ElasticSearch config file (ES_HEAP_SIZE)? Or at least mention it in a comment in the config file.","commit_id":"eebd50ca59847592145b219c7d9ebd0f0c71a883"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"17ceaedcef3e65b009c293cde8101bbe5518724c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Use doc_values for appropriate fields in elasticsearch"},{"line_number":4,"context_line":"    mappings for plugins. See documentation at"},{"line_number":5,"context_line":"    https://www.elastic.co/guide/en/elasticsearch/guide/current/doc-values.html"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7af24918_34d4ab1e","line":6,"in_reply_to":"7af24918_19160aa7","updated":"2016-03-02 21:23:14.000000000","message":"We don\u0027t provide an ES config file. I will add a documentation note, though i don\u0027t think i\u0027d recommend changing much from the e-s suggestion of 50% heap/50% disk cache","commit_id":"eebd50ca59847592145b219c7d9ebd0f0c71a883"}],"searchlight/elasticsearch/__init__.py":[{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"a12064d15c6f01d1d3c183b1830f69d4d2edd75a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Use doc_values for all mapping types (except non_analyzed strings)"},{"line_number":35,"context_line":"# https://www.elastic.co/guide/en/elasticsearch/guide/current/doc-values.html"},{"line_number":36,"context_line":"doc_values \u003d True"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class MappingTypesMeta(type):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_91f78e8a","line":36,"range":{"start_line":36,"start_character":13,"end_line":36,"end_character":17},"updated":"2016-03-02 21:59:33.000000000","message":"This should come from config file. Deployer should be able to disable it from being indexed on file instead of memory based on the environment being deployed.","commit_id":"267c08a6c434008100707407fc00f1c89171c532"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"447e4aacf3195157f1c263c18f0ebd59149e8152","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Use doc_values for all mapping types (except non_analyzed strings)"},{"line_number":35,"context_line":"# https://www.elastic.co/guide/en/elasticsearch/guide/current/doc-values.html"},{"line_number":36,"context_line":"doc_values \u003d True"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class MappingTypesMeta(type):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_b7c6fa97","line":36,"range":{"start_line":36,"start_character":13,"end_line":36,"end_character":17},"in_reply_to":"7af24918_91f78e8a","updated":"2016-03-02 22:31:48.000000000","message":"Good suggestion, done.","commit_id":"267c08a6c434008100707407fc00f1c89171c532"}],"searchlight/tests/unit/test_plugin.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"4bb53fc0ab3f559495ad1293746526ee24222907","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        self.assertEqual(\u0027ip\u0027, MappingTypes.ip[\u0027type\u0027])"},{"line_number":144,"context_line":"        self.assertEqual(\u0027boolean\u0027, MappingTypes.boolean[\u0027type\u0027])"},{"line_number":145,"context_line":"        self.assertEqual(\u0027short\u0027, MappingTypes.short[\u0027type\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_f9dcfe13","line":145,"updated":"2016-03-02 21:06:39.000000000","message":"We should test all cases that are actually used by the plugins. This would include:\n    self.assertEqual(\u0027date\u0027, MappingTypes.date\u0027type\u0027])\n    self.assertEqual(\u0027integer\u0027, MappingTypes.integer[\u0027type\u0027])\n    self.assertEqual(\u0027long\u0027, MappingTypes.long[\u0027type\u0027])","commit_id":"eebd50ca59847592145b219c7d9ebd0f0c71a883"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"fb8ff6eb92abf56ab08e2dbd82ac58ab5cfce6b8","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        self.assertEqual(\u0027ip\u0027, MappingTypes.ip[\u0027type\u0027])"},{"line_number":144,"context_line":"        self.assertEqual(\u0027boolean\u0027, MappingTypes.boolean[\u0027type\u0027])"},{"line_number":145,"context_line":"        self.assertEqual(\u0027short\u0027, MappingTypes.short[\u0027type\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_94ac9f36","line":145,"in_reply_to":"7af24918_94c01f7e","updated":"2016-03-02 21:29:35.000000000","message":"It would be productive if it catches a regression due to a future change.","commit_id":"eebd50ca59847592145b219c7d9ebd0f0c71a883"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"285ab645fc792df64e68989cd51055e571abfd15","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        self.assertEqual(\u0027ip\u0027, MappingTypes.ip[\u0027type\u0027])"},{"line_number":144,"context_line":"        self.assertEqual(\u0027boolean\u0027, MappingTypes.boolean[\u0027type\u0027])"},{"line_number":145,"context_line":"        self.assertEqual(\u0027short\u0027, MappingTypes.short[\u0027type\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_eeef0fe7","line":145,"in_reply_to":"7af24918_f9dcfe13","updated":"2016-03-02 21:38:16.000000000","message":"Done","commit_id":"eebd50ca59847592145b219c7d9ebd0f0c71a883"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"17ceaedcef3e65b009c293cde8101bbe5518724c","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        self.assertEqual(\u0027ip\u0027, MappingTypes.ip[\u0027type\u0027])"},{"line_number":144,"context_line":"        self.assertEqual(\u0027boolean\u0027, MappingTypes.boolean[\u0027type\u0027])"},{"line_number":145,"context_line":"        self.assertEqual(\u0027short\u0027, MappingTypes.short[\u0027type\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_94c01f7e","line":145,"in_reply_to":"7af24918_f9dcfe13","updated":"2016-03-02 21:23:14.000000000","message":"I can add some more but it is basically a function that returns its own argument, so an exhaustive list isn\u0027t terribly productive","commit_id":"eebd50ca59847592145b219c7d9ebd0f0c71a883"}]}