)]}'
{"doc/source/authoring-plugins.rst":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"467a2148afdeeeb6b5683622445e76b8d8b3b133","unresolved":false,"context_lines":[{"line_number":141,"context_line":"which field data is stored. Prior to Elasticsearch 2.x field values by default"},{"line_number":142,"context_line":"were stored in \u0027fielddata\u0027 format, which could result in high memory usage under"},{"line_number":143,"context_line":"some sort and aggregation operations. An alternative format, called ``doc_values``"},{"line_number":144,"context_line":"trades slight increased disk usage for better memory efficiency. In Elasticsearch"},{"line_number":145,"context_line":"2.x ``doc_values`` is the default, and Searchlight uses this option as the default"},{"line_number":146,"context_line":"regardless of Elasticsearch version. For more information see the Elasticsearch"},{"line_number":147,"context_line":"documentation_."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_2cf9124e","line":144,"updated":"2016-03-09 00:11:21.000000000","message":"perhaps should be slightly instead of slight","commit_id":"9363033ec02ae8b03fd67626b3a28c15864af1df"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"467a2148afdeeeb6b5683622445e76b8d8b3b133","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Generally this default will be fine. However, there are three ways in which the"},{"line_number":152,"context_line":"default can be overriden:"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* In config::"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    [elasticsearch]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_076a31b3","line":153,"updated":"2016-03-09 00:11:21.000000000","message":"This ([elasticsearch]) seems like a deployer configuration setting, so although good to have here in the authoring guide, it should be mentioned in the deployer orietned configuration. It also should be more explicit about which config file this setting should be set in. Perhaps here:\n\nhttp://docs.openstack.org/developer/searchlight/plugins.html#searchlight-plugins\n\nor this file like you did in the other patch:\n\nhttps://review.openstack.org/#/c/287401/7/doc/source/elasticsearch.rst","commit_id":"9363033ec02ae8b03fd67626b3a28c15864af1df"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"350bb1a2c1eb7da2f58dd4924c2f884f07fea2fa","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Generally this default will be fine. However, there are three ways in which the"},{"line_number":152,"context_line":"default can be overriden:"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* In config::"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    [elasticsearch]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_295ef211","line":153,"in_reply_to":"5aef4532_076a31b3","updated":"2016-03-09 17:12:00.000000000","message":"Made it more explicit, altered it to refer to the [resource_plugin] section rather than [elasticsearch]","commit_id":"9363033ec02ae8b03fd67626b3a28c15864af1df"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e43bf7a7e859e1dfa6a55b62c2e16663b1579164","unresolved":false,"context_lines":[{"line_number":147,"context_line":"documentation_."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. _documentation: https://www.elastic.co/guide/en/elasticsearch/guide/current/doc-values.html"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Generally this default will be fine. However, there are several ways in which "},{"line_number":152,"context_line":"the default can be overriden:"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5aef4532_49fb70c1","line":150,"updated":"2016-03-09 19:37:14.000000000","message":"red","commit_id":"3fc84d3aac81c46acfa91404749666322f0d3271"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"962e67dc75eff46178dbaa89d1fbacaa0156ce14","unresolved":false,"context_lines":[{"line_number":147,"context_line":"documentation_."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. _documentation: https://www.elastic.co/guide/en/elasticsearch/guide/current/doc-values.html"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Generally this default will be fine. However, there are several ways in which "},{"line_number":152,"context_line":"the default can be overriden:"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3afc51ec_6879a12f","line":150,"in_reply_to":"5aef4532_49fb70c1","updated":"2016-03-11 17:29:57.000000000","message":"Done","commit_id":"3fc84d3aac81c46acfa91404749666322f0d3271"}],"searchlight/elasticsearch/__init__.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"441564e8246ecf448c97f247fcc7f5c49a34bec4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d\u0027List of nodes where Elasticsearch instances are \u0027"},{"line_number":36,"context_line":"                     \u0027running. A single node should be defined as an IP \u0027"},{"line_number":37,"context_line":"                     \u0027address and port number.\u0027),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027mapping_use_doc_values\u0027, default\u003dTrue,"},{"line_number":39,"context_line":"                help\u003d\u0027Use doc_values for mapped fields where applicable.\u0027"},{"line_number":40,"context_line":"                     \u0027Allows lower memory usage at the cost of some disk \u0027"},{"line_number":41,"context_line":"                     \u0027space. Recommended, especially in large deployments.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_e7e8e4e4","line":38,"updated":"2016-03-09 00:59:02.000000000","message":"After playing with this, I don\u0027t feel like this actually belongs here.  It feels like an elasticsearch setting when it is actually a searchlight setting.\n\nIt seems like it should be in here:\n\nsearchlight.elasticsearch.plugins.base.indexer_opts\n\nWhich puts it in the somewhat oddly named resource_plugin group, but it also makes some sense.  If it was there, then we could also forseeably make it a per plugin configuration value (not just a per-plugin hard coded value).  But basically, the default function in base.py could check to see if the resource type plugin overrides this setting and otherwise use the resource_plugin default setting.  A given plugin developer could chose to still override the base.py function to fully disallow doc_values.","commit_id":"9363033ec02ae8b03fd67626b3a28c15864af1df"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"350bb1a2c1eb7da2f58dd4924c2f884f07fea2fa","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d\u0027List of nodes where Elasticsearch instances are \u0027"},{"line_number":36,"context_line":"                     \u0027running. A single node should be defined as an IP \u0027"},{"line_number":37,"context_line":"                     \u0027address and port number.\u0027),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027mapping_use_doc_values\u0027, default\u003dTrue,"},{"line_number":39,"context_line":"                help\u003d\u0027Use doc_values for mapped fields where applicable.\u0027"},{"line_number":40,"context_line":"                     \u0027Allows lower memory usage at the cost of some disk \u0027"},{"line_number":41,"context_line":"                     \u0027space. Recommended, especially in large deployments.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a97fa264","line":38,"in_reply_to":"5aef4532_e7e8e4e4","updated":"2016-03-09 17:12:00.000000000","message":"I\u0027ll make it at resource_plugin; it\u0027ll automatically get implemented per-plugin unless explicitly overridden","commit_id":"9363033ec02ae8b03fd67626b3a28c15864af1df"}],"searchlight/elasticsearch/plugins/base.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"59cd8edd94197b24777ee68e2b5f8ce5d04ccdb8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def mapping_use_doc_values(self):"},{"line_number":80,"context_line":"        \"\"\"Set to true to disable doc_values for a plugin\u0027s entire mapping\"\"\""},{"line_number":81,"context_line":"        if self.options.mapping_use_doc_values is not None:"},{"line_number":82,"context_line":"            return self.options.mapping_use_doc_values"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            return cfg.CONF.resource_plugin.mapping_use_doc_values"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_3f6a96b3","line":81,"updated":"2016-03-09 20:04:38.000000000","message":"Will never be not None because of setting default below.","commit_id":"3fc84d3aac81c46acfa91404749666322f0d3271"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"962e67dc75eff46178dbaa89d1fbacaa0156ce14","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def mapping_use_doc_values(self):"},{"line_number":80,"context_line":"        \"\"\"Set to true to disable doc_values for a plugin\u0027s entire mapping\"\"\""},{"line_number":81,"context_line":"        if self.options.mapping_use_doc_values is not None:"},{"line_number":82,"context_line":"            return self.options.mapping_use_doc_values"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            return cfg.CONF.resource_plugin.mapping_use_doc_values"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_a81d69bf","line":81,"in_reply_to":"5aef4532_3f6a96b3","updated":"2016-03-11 17:29:57.000000000","message":"Done, copypasta","commit_id":"3fc84d3aac81c46acfa91404749666322f0d3271"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"59cd8edd94197b24777ee68e2b5f8ce5d04ccdb8","unresolved":false,"context_lines":[{"line_number":447,"context_line":"            cfg.StrOpt(\"index_name\"),"},{"line_number":448,"context_line":"            cfg.BoolOpt(\"enabled\", default\u003dTrue),"},{"line_number":449,"context_line":"            cfg.StrOpt(\"admin_only_fields\"),"},{"line_number":450,"context_line":"            cfg.BoolOpt(\u0027mapping_use_doc_values\u0027, default\u003dTrue)"},{"line_number":451,"context_line":"        ]"},{"line_number":452,"context_line":"        if cls.NotificationHandlerCls:"},{"line_number":453,"context_line":"            opts.extend(cls.NotificationHandlerCls.get_plugin_opts())"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_440eb73b","line":450,"updated":"2016-03-09 20:04:38.000000000","message":"This line here makes it so that line 81 will never hit the else statement.  Which effectively means you can\u0027t actually set mapping_use_doc_values on the global resource_plugin group.","commit_id":"3fc84d3aac81c46acfa91404749666322f0d3271"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"962e67dc75eff46178dbaa89d1fbacaa0156ce14","unresolved":false,"context_lines":[{"line_number":447,"context_line":"            cfg.StrOpt(\"index_name\"),"},{"line_number":448,"context_line":"            cfg.BoolOpt(\"enabled\", default\u003dTrue),"},{"line_number":449,"context_line":"            cfg.StrOpt(\"admin_only_fields\"),"},{"line_number":450,"context_line":"            cfg.BoolOpt(\u0027mapping_use_doc_values\u0027, default\u003dTrue)"},{"line_number":451,"context_line":"        ]"},{"line_number":452,"context_line":"        if cls.NotificationHandlerCls:"},{"line_number":453,"context_line":"            opts.extend(cls.NotificationHandlerCls.get_plugin_opts())"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_08129db4","line":450,"in_reply_to":"5aef4532_440eb73b","updated":"2016-03-11 17:29:57.000000000","message":"Oh my. You\u0027re correct, thanks. Corrected.","commit_id":"3fc84d3aac81c46acfa91404749666322f0d3271"}],"searchlight/elasticsearch/plugins/utils.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"467a2148afdeeeb6b5683622445e76b8d8b3b133","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        return sanitized_document"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    @classmethod"},{"line_number":351,"context_line":"    def apply_doc_values(cls, mapping):"},{"line_number":352,"context_line":"        \"\"\"Sets \u0027doc_values\u0027 on fields in a mapping which allows queries to be"},{"line_number":353,"context_line":"        run on fields directly off disk, saving memory in analysis operations."},{"line_number":354,"context_line":"        Currently all fields with the exception of analyzed strings can be set"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_4c08de2c","line":351,"updated":"2016-03-09 00:11:21.000000000","message":"if another patchset is required, we might consider a debug or trace statement showing final output of this function.","commit_id":"9363033ec02ae8b03fd67626b3a28c15864af1df"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"350bb1a2c1eb7da2f58dd4924c2f884f07fea2fa","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        return sanitized_document"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    @classmethod"},{"line_number":351,"context_line":"    def apply_doc_values(cls, mapping):"},{"line_number":352,"context_line":"        \"\"\"Sets \u0027doc_values\u0027 on fields in a mapping which allows queries to be"},{"line_number":353,"context_line":"        run on fields directly off disk, saving memory in analysis operations."},{"line_number":354,"context_line":"        Currently all fields with the exception of analyzed strings can be set"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_e9c36a87","line":351,"in_reply_to":"5aef4532_4c08de2c","updated":"2016-03-09 17:12:00.000000000","message":"The actual output will appear in the elasticsearch client library TRACE output i think?","commit_id":"9363033ec02ae8b03fd67626b3a28c15864af1df"}]}