)]}'
{"searchlight/elasticsearch/plugins/neutron/__init__.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"aced0d17db95fe9df941daa366fd894db8df1a55","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def serialize_network(network):"},{"line_number":22,"context_line":"    serialized \u003d copy.deepcopy(network)"},{"line_number":23,"context_line":"    # TODO(sjmc7): Once subnets are added, look at whether or not to"},{"line_number":24,"context_line":"    # leave this in dependent on what notifications are received"},{"line_number":25,"context_line":"    serialized.pop(\u0027subnets\u0027)"},{"line_number":26,"context_line":"    serialized[\u0027project_id\u0027] \u003d serialized[\u0027tenant_id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_18dc93e3","line":23,"updated":"2016-03-21 19:40:35.000000000","message":"subnets are added. does this affect your comment here?","commit_id":"09d701ff98e2abd134c2f7e709e3f9b9a9b82ac0"}],"searchlight/elasticsearch/plugins/neutron/networks.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"a182e8e2d29a3c600f37461767c11bd04a198928","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                \u0027ipv4_address_scope\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":46,"context_line":"                                       \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":47,"context_line":"                \u0027ipv4_address_scope\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":48,"context_line":"                                       \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":49,"context_line":"                \u0027name\u0027: {"},{"line_number":50,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":51,"context_line":"                    \u0027fields\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_c2ba1a23","line":48,"updated":"2016-03-22 01:31:49.000000000","message":"i think mtu is missed","commit_id":"09d701ff98e2abd134c2f7e709e3f9b9a9b82ac0"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"4856dd03e8ab3acfef888e1570fb409139da7024","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                \u0027description\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":44,"context_line":"                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":45,"context_line":"                \u0027ipv4_address_scope\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":46,"context_line":"                                       \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":47,"context_line":"                \u0027ipv4_address_scope\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":48,"context_line":"                                       \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":49,"context_line":"                \u0027mtu\u0027: {\u0027type\u0027: \u0027integer\u0027},"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_f86fedc2","line":46,"updated":"2016-03-22 16:28:53.000000000","message":"Why is this duplicated?","commit_id":"e44035519b73a7c35f35d1bffd8ae475074c4d16"}],"searchlight/elasticsearch/plugins/neutron/ports.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2f32ffa3d8e80b7c866af0f3209ee6869a6806ff","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027admin_state_up\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":48,"context_line":"                \u0027binding:host_id\u0027: string_not_analyzed,"},{"line_number":49,"context_line":"                \u0027binding:vif_details\u0027: {\u0027type\u0027: \u0027object\u0027, \u0027properties\u0027: {}},"},{"line_number":50,"context_line":"                \u0027binding:vif_type\u0027: string_not_analyzed,"},{"line_number":51,"context_line":"                \u0027binding:profile\u0027: {\u0027type\u0027: \u0027object\u0027, \u0027properties\u0027: {}},"},{"line_number":52,"context_line":"                # device_owner and device_id identifies e.g which router"},{"line_number":53,"context_line":"                # or instance \u0027owns\u0027 a port"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_8d08b629","line":50,"updated":"2016-03-18 20:11:29.000000000","message":"should this be a facet option?","commit_id":"8d67c513c91d6a06d1a9fccaa4b89954a3e2466e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2f32ffa3d8e80b7c866af0f3209ee6869a6806ff","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                \u0027binding:host_id\u0027: string_not_analyzed,"},{"line_number":49,"context_line":"                \u0027binding:vif_details\u0027: {\u0027type\u0027: \u0027object\u0027, \u0027properties\u0027: {}},"},{"line_number":50,"context_line":"                \u0027binding:vif_type\u0027: string_not_analyzed,"},{"line_number":51,"context_line":"                \u0027binding:profile\u0027: {\u0027type\u0027: \u0027object\u0027, \u0027properties\u0027: {}},"},{"line_number":52,"context_line":"                # device_owner and device_id identifies e.g which router"},{"line_number":53,"context_line":"                # or instance \u0027owns\u0027 a port"},{"line_number":54,"context_line":"                \u0027device_id\u0027: string_not_analyzed,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_0d1dc665","line":51,"updated":"2016-03-18 20:11:29.000000000","message":"facet option?\n\nI really don\u0027t know how many of these there could be.","commit_id":"8d67c513c91d6a06d1a9fccaa4b89954a3e2466e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2f32ffa3d8e80b7c866af0f3209ee6869a6806ff","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                \u0027name\u0027: ordered_string,"},{"line_number":74,"context_line":"                \u0027network_id\u0027: string_not_analyzed,"},{"line_number":75,"context_line":"                \u0027tenant_id\u0027: string_not_analyzed,"},{"line_number":76,"context_line":"                \u0027security_groups\u0027: string_not_analyzed,"},{"line_number":77,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":78,"context_line":"                # Unfortunately this doesn\u0027t come from neutron"},{"line_number":79,"context_line":"                \u0027updated_at\u0027: {\u0027type\u0027: \u0027date\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_cd447e4b","line":76,"updated":"2016-03-18 20:11:29.000000000","message":"facet option?","commit_id":"8d67c513c91d6a06d1a9fccaa4b89954a3e2466e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"a182e8e2d29a3c600f37461767c11bd04a198928","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                \u0027project_id\u0027: string_not_analyzed,"},{"line_number":79,"context_line":"                \u0027tenant_id\u0027: string_not_analyzed,"},{"line_number":80,"context_line":"                \u0027security_groups\u0027: string_not_analyzed,"},{"line_number":81,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":82,"context_line":"                \u0027updated_at\u0027: {\u0027type\u0027: \u0027date\u0027}"},{"line_number":83,"context_line":"            }"},{"line_number":84,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_d074a7d0","line":81,"updated":"2016-03-22 01:31:49.000000000","message":"why not use string_not_analyzed","commit_id":"09d701ff98e2abd134c2f7e709e3f9b9a9b82ac0"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"6edcfeae6c6bc9aac14c25c06e0880aba88483a6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class PortIndex(base.IndexBase):"},{"line_number":23,"context_line":"    NotificationHandlerCls \u003d notification_handlers.PortHandler"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    ADMIN_ONLY_FIELDS \u003d [\"binding:*\"]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def get_document_type(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_6ad77823","line":25,"range":{"start_line":25,"start_character":33,"end_line":25,"end_character":37},"updated":"2016-03-22 18:59:50.000000000","message":"binding:vnic_type is shown to non-admin users on neutron cli.","commit_id":"78936d2cd98066f2c8709dbbcfec4c38f71e34ca"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"cd002632cec76ed832840fa0857f2d5a22f5db7b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class PortIndex(base.IndexBase):"},{"line_number":23,"context_line":"    NotificationHandlerCls \u003d notification_handlers.PortHandler"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    ADMIN_ONLY_FIELDS \u003d [\"binding:*\"]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def get_document_type(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_0fd88b1c","line":25,"range":{"start_line":25,"start_character":33,"end_line":25,"end_character":37},"in_reply_to":"fa0719c6_6ad77823","updated":"2016-03-22 19:54:35.000000000","message":"This is a good catch, but I think we should stay a little conservative at this point of the release.  I\u0027d rather be over restrictive than under restrictive.  When looking at the neutron policy file [0], it worries me that something could be added that we don\u0027t catch.  I suggest we file a BP to enhance policy handling for neutron.\n\n[0] https://github.com/openstack/neutron/blob/master/etc/policy.json#L76-L79","commit_id":"78936d2cd98066f2c8709dbbcfec4c38f71e34ca"}]}