)]}'
{"searchlight/tests/functional/__init__.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"43668256f8efbc66c81e729ee815aa234666278a","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        self.configurePlugins()"},{"line_number":367,"context_line":"        self.images_plugin \u003d self.initialized_plugins[\u0027OS::Glance::Image\u0027]"},{"line_number":368,"context_line":"        self.metadefs_plugin \u003d self.initialized_plugins[\u0027OS::Glance::Metadef\u0027]"},{"line_number":369,"context_line":"        self.addCleanup(self.cleanup)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def configurePlugins(self, include_plugins\u003dNone, exclude_plugins\u003d()):"},{"line_number":372,"context_line":"        \"\"\"Specify \u0027exclude_plugins\u0027 or \u0027include_plugins\u0027 as a list of"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_e3c7f995","line":369,"range":{"start_line":369,"start_character":24,"end_line":369,"end_character":28},"updated":"2016-03-23 17:12:18.000000000","message":"This\u0027ll do the job but it needs to run before configurePlugins; the times I\u0027ve seen this error have included errors in initial plugin setup (mapping errors etc). It makes sense for this to run straight after start_with_retry. \n\nAlso, self.cleanup will get called twice on a successful test run (once in teardown, once during the cleanup handlers). I *think* that\u0027s ok (it looks like the stop handler in cmd/control.py will function correctly) but worth checking.","commit_id":"1b0e8b944e056f558b62616aa8d9d7b948358cea"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"0c2888e38b3662fd3fc5d1f5862795d328833d86","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        self.configurePlugins()"},{"line_number":367,"context_line":"        self.images_plugin \u003d self.initialized_plugins[\u0027OS::Glance::Image\u0027]"},{"line_number":368,"context_line":"        self.metadefs_plugin \u003d self.initialized_plugins[\u0027OS::Glance::Metadef\u0027]"},{"line_number":369,"context_line":"        self.addCleanup(self.cleanup)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def configurePlugins(self, include_plugins\u003dNone, exclude_plugins\u003d()):"},{"line_number":372,"context_line":"        \"\"\"Specify \u0027exclude_plugins\u0027 or \u0027include_plugins\u0027 as a list of"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_d27a6c23","line":369,"range":{"start_line":369,"start_character":24,"end_line":369,"end_character":28},"in_reply_to":"fa0719c6_e3c7f995","updated":"2016-03-24 01:25:07.000000000","message":"Checked, didn\u0027t find any issue yet:)","commit_id":"1b0e8b944e056f558b62616aa8d9d7b948358cea"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"74c067b95e52eea59f7a73af6757fd06a9b48639","unresolved":false,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        self.api_server.dump_log(\u0027api_server\u0027)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        for plugin_instance in self.initialized_plugins.values():"},{"line_number":450,"context_line":"            self.elastic_connection.indices.delete("},{"line_number":451,"context_line":"                index\u003dplugin_instance.alias_name_search,"},{"line_number":452,"context_line":"                ignore\u003d404)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_614978b7","line":449,"range":{"start_line":449,"start_character":12,"end_line":449,"end_character":27},"updated":"2016-04-23 02:38:54.000000000","message":"While testing this, i noticed a related issue - stick a \u0027raise Exception()\u0027 at the end of the setUp function in test_glance_image_plugin and you\u0027ll see a number of test failures caused by the index deletes below not getting called. It might make more sense to put those into the cleanUp function. Does that make sense?","commit_id":"2497ed63335e40b5fa0326e335954acc358ab56c"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"460187c3cb7b17faf62d49790afeda698d22ab25","unresolved":false,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        self.api_server.dump_log(\u0027api_server\u0027)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        for plugin_instance in self.initialized_plugins.values():"},{"line_number":450,"context_line":"            self.elastic_connection.indices.delete("},{"line_number":451,"context_line":"                index\u003dplugin_instance.alias_name_search,"},{"line_number":452,"context_line":"                ignore\u003d404)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_afb43bd4","line":449,"range":{"start_line":449,"start_character":12,"end_line":449,"end_character":27},"in_reply_to":"1a122d0e_614978b7","updated":"2016-05-03 07:01:51.000000000","message":"Make sense to me.","commit_id":"2497ed63335e40b5fa0326e335954acc358ab56c"}]}