)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ec9bdff1ea1ec81075b840a946d3ab3257b8a4b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We don\u0027t have any reliable way to index DHCP ports so for now we won\u0027t"},{"line_number":10,"context_line":"index them on initial indexing; patch also disables their indexing from"},{"line_number":11,"context_line":"notificaitons for consistency. If neutron starts sending notifications"},{"line_number":12,"context_line":"for them both pieces of code should be removed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia783a9b59fa05b7d89f5add95797fd509ad391a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_144d453e","line":11,"updated":"2016-03-22 18:32:31.000000000","message":"mis-spelling. non-blocker","commit_id":"1e939b3419f26dc94ec3d729f4cf2525af173030"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"35fa67a1647d2993c325b27c873c0da8539e6149","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We don\u0027t have any reliable way to index DHCP ports so for now we won\u0027t"},{"line_number":10,"context_line":"index them on initial indexing; patch also disables their indexing from"},{"line_number":11,"context_line":"notificaitons for consistency. If neutron starts sending notifications"},{"line_number":12,"context_line":"for them both pieces of code should be removed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia783a9b59fa05b7d89f5add95797fd509ad391a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_cf7df66f","line":11,"in_reply_to":"fa0719c6_144d453e","updated":"2016-03-22 18:43:06.000000000","message":"But fixed anyway","commit_id":"1e939b3419f26dc94ec3d729f4cf2525af173030"}],"searchlight/elasticsearch/plugins/neutron/notification_handlers.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ec9bdff1ea1ec81075b840a946d3ab3257b8a4b9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if payload[\u0027port\u0027].get(\u0027device_owner\u0027, None) \u003d\u003d \u0027network:dhcp\u0027:"},{"line_number":88,"context_line":"            # TODO(sjmc7): Remove this once we can get proper notifications"},{"line_number":89,"context_line":"            # about DHCP ports."},{"line_number":90,"context_line":"            #  See https://bugs.launchpad.net/searchlight/+bug/1558790"},{"line_number":91,"context_line":"            LOG.warning(_LW(\"Skipping notification for DHCP port %s. If \""},{"line_number":92,"context_line":"                            \"neutron is sending notifications for these \""},{"line_number":93,"context_line":"                            \"ports, this message can be removed\") % port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_d4362d51","line":90,"updated":"2016-03-22 18:32:31.000000000","message":"This message is kind of funny.  It seems like you\u0027d only reach this point if we got a notification for a dhcp port and it isn\u0027t just the message that can be removed. How about this?\n\n\"Skipping notification for DHCP port %s. If neutron is now sending notifications for DHCP ports, the Searchlight port plugin should be updated to process DHCP ports.\"\n\nI think this also might be too high of a log level.  I think info level might be more appropriate.","commit_id":"1e939b3419f26dc94ec3d729f4cf2525af173030"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"35fa67a1647d2993c325b27c873c0da8539e6149","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if payload[\u0027port\u0027].get(\u0027device_owner\u0027, None) \u003d\u003d \u0027network:dhcp\u0027:"},{"line_number":88,"context_line":"            # TODO(sjmc7): Remove this once we can get proper notifications"},{"line_number":89,"context_line":"            # about DHCP ports."},{"line_number":90,"context_line":"            #  See https://bugs.launchpad.net/searchlight/+bug/1558790"},{"line_number":91,"context_line":"            LOG.warning(_LW(\"Skipping notification for DHCP port %s. If \""},{"line_number":92,"context_line":"                            \"neutron is sending notifications for these \""},{"line_number":93,"context_line":"                            \"ports, this message can be removed\") % port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_4f92869f","line":90,"in_reply_to":"fa0719c6_d4362d51","updated":"2016-03-22 18:43:06.000000000","message":"For a given meaning of funny. Rephrased it and set to info","commit_id":"1e939b3419f26dc94ec3d729f4cf2525af173030"}]}
