)]}'
{"searchlight/cmd/manage.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"c40d96832322ae1aeef094c3aa8a4260d4fdc232","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        #   NB: The \"search\" alias remains unchanged for this step."},{"line_number":270,"context_line":"        for group, search, listen in resource_groups:"},{"line_number":271,"context_line":"            try:"},{"line_number":272,"context_line":"                # If the index no longer exists, ignore and continue."},{"line_number":273,"context_line":"                es_utils.delete_index(old_index[group])"},{"line_number":274,"context_line":"            except Exception as e:"},{"line_number":275,"context_line":"                LOG.error(encodeutils.exception_to_unicode(e))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_f1a73f4d","line":272,"range":{"start_line":272,"start_character":48,"end_line":272,"end_character":49},"updated":"2016-04-12 16:32:33.000000000","message":"You\u0027re catching this in the delete_index function (ignore\u003d404); the exception block here will trap EVERY error. That might be ok since it\u0027s probably best to continue and try to delete any other old indexes, but the comment is misleading","commit_id":"5f3dcfb56f17d3a6a48b0cce68f780e50bf70394"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c2ff5dd28ed71c0e5b279973da5c6157e082b419","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        #   NB: The \"search\" alias remains unchanged for this step."},{"line_number":270,"context_line":"        for group, search, listen in resource_groups:"},{"line_number":271,"context_line":"            try:"},{"line_number":272,"context_line":"                # If the index no longer exists, ignore and continue."},{"line_number":273,"context_line":"                es_utils.delete_index(old_index[group])"},{"line_number":274,"context_line":"            except Exception as e:"},{"line_number":275,"context_line":"                LOG.error(encodeutils.exception_to_unicode(e))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_0396daef","line":272,"range":{"start_line":272,"start_character":48,"end_line":272,"end_character":49},"in_reply_to":"5a18252c_f1a73f4d","updated":"2016-04-13 02:45:44.000000000","message":"Done","commit_id":"5f3dcfb56f17d3a6a48b0cce68f780e50bf70394"}],"searchlight/elasticsearch/plugins/utils.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"61e7eb59451ffa22e6d2fe4b155e63a7859a5542","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    try:"},{"line_number":184,"context_line":"        es_engine.indices.delete(index\u003dindex_name, ignore\u003d404)"},{"line_number":185,"context_line":"    except Exception as e:"},{"line_number":186,"context_line":"        # If the exception happens with the update, the alias may"},{"line_number":187,"context_line":"        # still refer to the index. We do not want to delete the"},{"line_number":188,"context_line":"        # index for this case. Log the error and continue."},{"line_number":189,"context_line":"        LOG.error(encodeutils.exception_to_unicode(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_fb86f5b7","line":186,"range":{"start_line":186,"start_character":17,"end_line":186,"end_character":26},"updated":"2016-03-29 14:38:29.000000000","message":"This comment is no longer valid; we\u0027re ignoring exceptions to try to delete any other remaining indices. I think really this exception block should be in the calling code; it\u0027s not clear that you\u0027d always want to ignore exceptions.","commit_id":"7aeeaba3f07d6aa2bd4a9cf0115f272c6b64e66d"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d9c64a1880ebfbb81f21fe04cdf4e7f122641d89","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    try:"},{"line_number":184,"context_line":"        es_engine.indices.delete(index\u003dindex_name, ignore\u003d404)"},{"line_number":185,"context_line":"    except Exception as e:"},{"line_number":186,"context_line":"        # If the exception happens with the update, the alias may"},{"line_number":187,"context_line":"        # still refer to the index. We do not want to delete the"},{"line_number":188,"context_line":"        # index for this case. Log the error and continue."},{"line_number":189,"context_line":"        LOG.error(encodeutils.exception_to_unicode(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_66b51030","line":186,"range":{"start_line":186,"start_character":17,"end_line":186,"end_character":26},"in_reply_to":"ba0121b8_fb86f5b7","updated":"2016-03-30 01:12:48.000000000","message":"Done","commit_id":"7aeeaba3f07d6aa2bd4a9cf0115f272c6b64e66d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"656a2c85c8a53f14fef9b88c308b5d5cd0d368eb","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    return old_index"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"def delete_index(index_name):"},{"line_number":322,"context_line":"    \"\"\"Delete the specified index. \"\"\""},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    es_engine \u003d searchlight.elasticsearch.get_api()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_b44d5e40","line":321,"updated":"2016-04-14 04:51:38.000000000","message":"To help future generations, I think adding a comment here noting that aliases get cleaned up automatically by ES when the index is deleted would be nice.","commit_id":"3b161bb91a21b73cb6340e5da504d2f868ebf4df"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"f4c8805dc46684da63f92c1c8a3f7166af2dc1eb","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    return old_index"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"def delete_index(index_name):"},{"line_number":322,"context_line":"    \"\"\"Delete the specified index. \"\"\""},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    es_engine \u003d searchlight.elasticsearch.get_api()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_5aaeb198","line":321,"in_reply_to":"5a18252c_b44d5e40","updated":"2016-04-14 06:28:56.000000000","message":"Done","commit_id":"3b161bb91a21b73cb6340e5da504d2f868ebf4df"}],"searchlight/tests/unit/test_reindexing.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"c1f3c634f941d193c1b92c50a2c84ff4d7930e7a","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            mock_engine.indices.update_aliases.assert_called_once_with(body)"},{"line_number":204,"context_line":"            self.assertIsNone(index)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_alias_listener_update(self):"},{"line_number":207,"context_line":"        old_ndx \u003d \u0027sl-old\u0027"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # Set up the ES mock."}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_e9d26bff","line":206,"range":{"start_line":206,"start_character":0,"end_line":206,"end_character":41},"updated":"2016-04-13 19:51:28.000000000","message":"Very small nit but not one i\u0027m going to -1 on - this could be renamed test_delete_index","commit_id":"3b161bb91a21b73cb6340e5da504d2f868ebf4df"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"f4c8805dc46684da63f92c1c8a3f7166af2dc1eb","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            mock_engine.indices.update_aliases.assert_called_once_with(body)"},{"line_number":204,"context_line":"            self.assertIsNone(index)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_alias_listener_update(self):"},{"line_number":207,"context_line":"        old_ndx \u003d \u0027sl-old\u0027"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # Set up the ES mock."}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_bad0a520","line":206,"range":{"start_line":206,"start_character":0,"end_line":206,"end_character":41},"in_reply_to":"5a18252c_545b2af6","updated":"2016-04-14 06:28:56.000000000","message":"Done","commit_id":"3b161bb91a21b73cb6340e5da504d2f868ebf4df"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"656a2c85c8a53f14fef9b88c308b5d5cd0d368eb","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            mock_engine.indices.update_aliases.assert_called_once_with(body)"},{"line_number":204,"context_line":"            self.assertIsNone(index)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_alias_listener_update(self):"},{"line_number":207,"context_line":"        old_ndx \u003d \u0027sl-old\u0027"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # Set up the ES mock."}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_545b2af6","line":206,"range":{"start_line":206,"start_character":0,"end_line":206,"end_character":41},"in_reply_to":"5a18252c_e9d26bff","updated":"2016-04-14 04:51:38.000000000","message":"Actually I think in this case it is worth a new patch set.","commit_id":"3b161bb91a21b73cb6340e5da504d2f868ebf4df"}]}