)]}'
{"searchlight/tests/utils.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"9cf02ce865f18b40d218c3187c50481e4e067f35","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # NOTE(bcwaldon): parse_args has to be called to register certain"},{"line_number":56,"context_line":"        # command-line options - specifically we need config_dir for"},{"line_number":57,"context_line":"        # the following policy tests"},{"line_number":58,"context_line":"        config.parse_args(args\u003d[])"},{"line_number":59,"context_line":"        self.addCleanup(CONF.reset)"},{"line_number":60,"context_line":"        mox_fixture \u003d self.useFixture(moxstubout.MoxStubout())"},{"line_number":61,"context_line":"        self.stubs \u003d mox_fixture.stubs"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_cceec4b3","line":58,"updated":"2016-03-29 22:36:19.000000000","message":"Achoo! I always have an allergic reaction to monkey patching. I\u0027ll look further into this, but will this do the same thing:\n\n    config.parse_args(args\u003d[], default_config_files\u003d[])\n\nPassing in default_config_files here will result in it being passed to oslo_config.cfg.CONF::__call__. This should bypass the call to find_config_files and use \"[]\" instead.","commit_id":"86e4fe0608ded0a001c8e8e708f5cc7606412122"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"aa5f8ec4614e2f73ea0db43ce9943968863ae301","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # NOTE(bcwaldon): parse_args has to be called to register certain"},{"line_number":56,"context_line":"        # command-line options - specifically we need config_dir for"},{"line_number":57,"context_line":"        # the following policy tests"},{"line_number":58,"context_line":"        config.parse_args(args\u003d[])"},{"line_number":59,"context_line":"        self.addCleanup(CONF.reset)"},{"line_number":60,"context_line":"        mox_fixture \u003d self.useFixture(moxstubout.MoxStubout())"},{"line_number":61,"context_line":"        self.stubs \u003d mox_fixture.stubs"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_da7da4b2","line":58,"in_reply_to":"ba0121b8_26e31807","updated":"2016-03-30 15:08:55.000000000","message":"Cowards! :)  But yeah, that\u0027s a better answer if nothing else calls find_config_files; i\u0027ll check. And if you don\u0027t like monkey patching, best not look at how \u0027mock\u0027 works :)","commit_id":"86e4fe0608ded0a001c8e8e708f5cc7606412122"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d48fc120dea6f4cf5b326dc0dc6e84c5800c3383","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # NOTE(bcwaldon): parse_args has to be called to register certain"},{"line_number":56,"context_line":"        # command-line options - specifically we need config_dir for"},{"line_number":57,"context_line":"        # the following policy tests"},{"line_number":58,"context_line":"        config.parse_args(args\u003d[])"},{"line_number":59,"context_line":"        self.addCleanup(CONF.reset)"},{"line_number":60,"context_line":"        mox_fixture \u003d self.useFixture(moxstubout.MoxStubout())"},{"line_number":61,"context_line":"        self.stubs \u003d mox_fixture.stubs"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_26e31807","line":58,"in_reply_to":"ba0121b8_cceec4b3","updated":"2016-03-30 01:24:36.000000000","message":"Yeah, this fixes the issue, agree to use config.parse_args(args\u003d[], default_config_files\u003d[]) instead of money patch.","commit_id":"86e4fe0608ded0a001c8e8e708f5cc7606412122"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"8f07285be9e93842ec770a8a344983c24b807b27","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # command-line options - specifically we need config_dir for"},{"line_number":57,"context_line":"        # the following policy tests"},{"line_number":58,"context_line":"        config.parse_args(args\u003d[])"},{"line_number":59,"context_line":"        self.addCleanup(CONF.reset)"},{"line_number":60,"context_line":"        mox_fixture \u003d self.useFixture(moxstubout.MoxStubout())"},{"line_number":61,"context_line":"        self.stubs \u003d mox_fixture.stubs"},{"line_number":62,"context_line":"        self.stubs.Set(exception, \u0027_FATAL_EXCEPTION_FORMAT_ERRORS\u0027, True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_52cfea7e","line":59,"updated":"2016-03-29 23:02:37.000000000","message":"I played around with this some more. I created a naughty config file. It had the following contents:\n\n    [DEFAULT]\n    THIS IS A BAD LINE THAT NEEDS TO BE WISHED TO THE CORNFIELD\n\nI seeded the system with this bad config file in all of the usual default oslo_config locations:\n\n    ~/.searchlight/searchlight.conf\n    ~/searchlight.conf\n    /etc/searchlight/searchlight.conf\n    /etc/searchlight.conf\n\nWhen I ran the tests, they failed as expected with a config file error, \"No \u0027:\u0027 or \u0027\u003d\u0027 found in assignment\".\n\nWhen I made the changes to config.parse_args as described above, the tests all passed. It\u0027s a Good Life.\n\nSo I think we do not need to monkey patch anything.","commit_id":"86e4fe0608ded0a001c8e8e708f5cc7606412122"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"aa5f8ec4614e2f73ea0db43ce9943968863ae301","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # command-line options - specifically we need config_dir for"},{"line_number":57,"context_line":"        # the following policy tests"},{"line_number":58,"context_line":"        config.parse_args(args\u003d[])"},{"line_number":59,"context_line":"        self.addCleanup(CONF.reset)"},{"line_number":60,"context_line":"        mox_fixture \u003d self.useFixture(moxstubout.MoxStubout())"},{"line_number":61,"context_line":"        self.stubs \u003d mox_fixture.stubs"},{"line_number":62,"context_line":"        self.stubs.Set(exception, \u0027_FATAL_EXCEPTION_FORMAT_ERRORS\u0027, True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_c8a83f7a","line":59,"in_reply_to":"ba0121b8_52cfea7e","updated":"2016-03-30 15:08:55.000000000","message":"yep - ./etc/searchlight.conf is the other one (and how i found this)","commit_id":"86e4fe0608ded0a001c8e8e708f5cc7606412122"}]}