)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f5121697d43686ee3ab5ebace584f8c496c2608a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This patch adds unit tests for the Zero Downtime functionality."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifc2a6fa7dd0cb5fabcb778fddaa455933ba99a4f"},{"line_number":15,"context_line":"Implements-blueprint: zero-downtime-reindexing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a061dce_35cda2b7","line":15,"updated":"2016-04-07 00:06:05.000000000","message":"This should be Partially-Implements: blueprint zero-downtime-reindexing. i\u0027ll let it through this time.","commit_id":"ca1aeede690b69c83caffdfbc0d695f0e8406669"}],"searchlight/elasticsearch/plugins/utils.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"9773ac596768ab48bb86f4a816e1e517a1b50f7b","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        current_indices \u003d es_engine.indices.get_alias("},{"line_number":240,"context_line":"            name\u003dalias_search, ignore\u003d404)"},{"line_number":241,"context_line":"        # Grab first (and only) index in the list from get_alias()."},{"line_number":242,"context_line":"        old_index \u003d list(current_indices.keys())[0]"},{"line_number":243,"context_line":"        if old_index \u003d\u003d index_name:"},{"line_number":244,"context_line":"            return None"},{"line_number":245,"context_line":"        body[\u0027actions\u0027].insert(0,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_8c5417cb","line":242,"range":{"start_line":242,"start_character":24,"end_line":242,"end_character":25},"updated":"2016-04-01 20:33:09.000000000","message":"This is a python 3 change?","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"46a9829003b9adbfc26c606d92839aec6897ea5d","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        current_indices \u003d es_engine.indices.get_alias("},{"line_number":240,"context_line":"            name\u003dalias_search, ignore\u003d404)"},{"line_number":241,"context_line":"        # Grab first (and only) index in the list from get_alias()."},{"line_number":242,"context_line":"        old_index \u003d list(current_indices.keys())[0]"},{"line_number":243,"context_line":"        if old_index \u003d\u003d index_name:"},{"line_number":244,"context_line":"            return None"},{"line_number":245,"context_line":"        body[\u0027actions\u0027].insert(0,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_1deca1c6","line":242,"range":{"start_line":242,"start_character":24,"end_line":242,"end_character":25},"in_reply_to":"ba0121b8_8c5417cb","updated":"2016-04-04 14:02:44.000000000","message":"Yes.","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"65ff94ea007dbc1c9578eff6ca6bde7042bd6a0f","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                                   \u0027index\u0027: old_index,"},{"line_number":248,"context_line":"                                   \u0027alias\u0027: alias_search}})"},{"line_number":249,"context_line":"    except Exception:"},{"line_number":250,"context_line":"        # Alias doesn\u0027t exist. strange. Nothing to remove, only an add."},{"line_number":251,"context_line":"        old_index \u003d None"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_1c0495be","line":250,"range":{"start_line":250,"start_character":16,"end_line":250,"end_character":21},"updated":"2016-04-04 18:05:35.000000000","message":"This isn\u0027t valid any longer; get_alias uses ignore\u003d404. Should we be catching KeyError here instead?","commit_id":"d7c191e07fe5c91b668eff3ea428164655d989a0"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"f23503e5918bc5dad8b20ea44a8c6c4c25218a9e","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                                   \u0027index\u0027: old_index,"},{"line_number":248,"context_line":"                                   \u0027alias\u0027: alias_search}})"},{"line_number":249,"context_line":"    except Exception:"},{"line_number":250,"context_line":"        # Alias doesn\u0027t exist. strange. Nothing to remove, only an add."},{"line_number":251,"context_line":"        old_index \u003d None"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_3c823453","line":250,"range":{"start_line":250,"start_character":16,"end_line":250,"end_character":21},"in_reply_to":"9a061dce_1c0495be","updated":"2016-04-04 19:48:25.000000000","message":"per our discussion, we\u0027ll remove the ignore and catch the 404 here.","commit_id":"d7c191e07fe5c91b668eff3ea428164655d989a0"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"c44f817a016c04b1788635081968321be6fad14a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                                   \u0027alias\u0027: alias_search}})"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    except es_exc.NotFoundError:"},{"line_number":250,"context_line":"        # Alias doesn\u0027t exist. Strange. Nothing to remove, only an add."},{"line_number":251,"context_line":"        old_index \u003d None"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a061dce_d555cb1d","line":250,"range":{"start_line":250,"start_character":24,"end_line":250,"end_character":29},"updated":"2016-04-04 21:31:53.000000000","message":"Or it\u0027s a first time index","commit_id":"ca1aeede690b69c83caffdfbc0d695f0e8406669"}],"searchlight/tests/fake_plugins.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"435e131922a452df6b02a07d0c6f224852ee58d8","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    def serialize(self, doc):"},{"line_number":169,"context_line":"        return doc"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def get_version(self):"},{"line_number":172,"context_line":"        super(NonRoleSeparatedPlugin, self).get_version()"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_d2efb3ae","line":171,"range":{"start_line":171,"start_character":8,"end_line":171,"end_character":19},"updated":"2016-04-04 15:05:55.000000000","message":"Not sure what this is needed for - it looks like it\u0027s not mentioned in the new test code","commit_id":"471212311ef8e6519ff7b3a311edb7e542c68e10"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"17de59d0977c5ee1f8e0895502148d370140fb87","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    def serialize(self, doc):"},{"line_number":169,"context_line":"        return doc"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def get_version(self):"},{"line_number":172,"context_line":"        super(NonRoleSeparatedPlugin, self).get_version()"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_755a1185","line":171,"range":{"start_line":171,"start_character":8,"end_line":171,"end_character":19},"in_reply_to":"9a061dce_d2efb3ae","updated":"2016-04-04 15:44:49.000000000","message":"It can be deleted. Thus it was explained, thus it came to pass.","commit_id":"471212311ef8e6519ff7b3a311edb7e542c68e10"}],"searchlight/tests/unit/test_plugin.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"9773ac596768ab48bb86f4a816e1e517a1b50f7b","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            doc_type, mapping \u003d six.next(plugin.get_full_mapping())"},{"line_number":236,"context_line":"            self.assertNotIn(\u0027doc_values\u0027, mapping[\u0027properties\u0027][\u0027id\u0027])"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def test_setup_index_settings(self):"},{"line_number":239,"context_line":"        mock_engine \u003d mock.Mock()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        # Test #1: Use the default settings for the plugin."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_acbd9bd9","line":238,"range":{"start_line":238,"start_character":8,"end_line":238,"end_character":33},"updated":"2016-04-01 20:33:09.000000000","message":"I actually have a bit of a problem having this function in the plugin base class at all; it\u0027s great to have a test for it but would it make sense at this point to move this elsewhere? Or a separate patch?","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"46a9829003b9adbfc26c606d92839aec6897ea5d","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            doc_type, mapping \u003d six.next(plugin.get_full_mapping())"},{"line_number":236,"context_line":"            self.assertNotIn(\u0027doc_values\u0027, mapping[\u0027properties\u0027][\u0027id\u0027])"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def test_setup_index_settings(self):"},{"line_number":239,"context_line":"        mock_engine \u003d mock.Mock()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        # Test #1: Use the default settings for the plugin."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_3d0c0594","line":238,"range":{"start_line":238,"start_character":8,"end_line":238,"end_character":33},"in_reply_to":"ba0121b8_acbd9bd9","updated":"2016-04-04 14:02:44.000000000","message":"If we do want to change the base plugin, we should do that as a separate patch. I\u0027m open to moving setup_index_settings elsewhere, but it is done on a per-plugin basis. That is why in the past it has been a part of the base plugin class.","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"9773ac596768ab48bb86f4a816e1e517a1b50f7b","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        def fake_settings(self):"},{"line_number":254,"context_line":"            return None"},{"line_number":255,"context_line":"        mock_engine.reset_mock()"},{"line_number":256,"context_line":"        plugin.get_settings \u003d types.MethodType(fake_settings, plugin)"},{"line_number":257,"context_line":"        plugin.setup_index_settings(index_name\u003d\u0027fake\u0027)"},{"line_number":258,"context_line":"        mock_engine.indices.put_settings.assert_not_called()"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_ecb313e8","line":256,"range":{"start_line":256,"start_character":15,"end_line":256,"end_character":27},"updated":"2016-04-01 20:33:09.000000000","message":"A better way to do this is\n\n  with mock.patch.object(plugin, \u0027get_settings\u0027, return_value\u003dNone):\n    plugin.setup_index_settings\n\nDirectly modifying attributes can lead to problems (not in this case, but in general).","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"32bb1366258b0605bf52c14ff16b356b42c70a4c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        def fake_settings(self):"},{"line_number":254,"context_line":"            return None"},{"line_number":255,"context_line":"        mock_engine.reset_mock()"},{"line_number":256,"context_line":"        plugin.get_settings \u003d types.MethodType(fake_settings, plugin)"},{"line_number":257,"context_line":"        plugin.setup_index_settings(index_name\u003d\u0027fake\u0027)"},{"line_number":258,"context_line":"        mock_engine.indices.put_settings.assert_not_called()"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_15017e05","line":256,"range":{"start_line":256,"start_character":15,"end_line":256,"end_character":27},"in_reply_to":"9a061dce_ddcb491d","updated":"2016-04-06 23:57:59.000000000","message":"good idea.","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"46a9829003b9adbfc26c606d92839aec6897ea5d","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        def fake_settings(self):"},{"line_number":254,"context_line":"            return None"},{"line_number":255,"context_line":"        mock_engine.reset_mock()"},{"line_number":256,"context_line":"        plugin.get_settings \u003d types.MethodType(fake_settings, plugin)"},{"line_number":257,"context_line":"        plugin.setup_index_settings(index_name\u003d\u0027fake\u0027)"},{"line_number":258,"context_line":"        mock_engine.indices.put_settings.assert_not_called()"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_ddcb491d","line":256,"range":{"start_line":256,"start_character":15,"end_line":256,"end_character":27},"in_reply_to":"ba0121b8_ecb313e8","updated":"2016-04-04 14:02:44.000000000","message":"Agreed. And to prove it I made the change! I went back and reviewed the other testing code. We are doing this elsewhere. Maybe we should re-look at the other instances and change them also (if needed).","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"9773ac596768ab48bb86f4a816e1e517a1b50f7b","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                \u0027IndexBase.setup_index_settings\u0027)"},{"line_number":264,"context_line":"    @mock.patch(\u0027searchlight.elasticsearch.plugins.base.\u0027"},{"line_number":265,"context_line":"                \u0027IndexBase.check_mapping_sort_fields\u0027)"},{"line_number":266,"context_line":"    def test_prepare_index(self, mock_check, mock_settings, mock_mapping):"},{"line_number":267,"context_line":"        mock_engine \u003d mock.Mock()"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Test #1: Plugin with no children."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_ac159b9c","line":266,"range":{"start_line":266,"start_character":8,"end_line":266,"end_character":26},"updated":"2016-04-01 20:33:09.000000000","message":"What is this testing exactly? Maybe a brief comment since it\u0027s quite a long function","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"46a9829003b9adbfc26c606d92839aec6897ea5d","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                \u0027IndexBase.setup_index_settings\u0027)"},{"line_number":264,"context_line":"    @mock.patch(\u0027searchlight.elasticsearch.plugins.base.\u0027"},{"line_number":265,"context_line":"                \u0027IndexBase.check_mapping_sort_fields\u0027)"},{"line_number":266,"context_line":"    def test_prepare_index(self, mock_check, mock_settings, mock_mapping):"},{"line_number":267,"context_line":"        mock_engine \u003d mock.Mock()"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Test #1: Plugin with no children."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_fdbbad73","line":266,"range":{"start_line":266,"start_character":8,"end_line":266,"end_character":26},"in_reply_to":"ba0121b8_ac159b9c","updated":"2016-04-04 14:02:44.000000000","message":"I added a comment. As I was doing so, I noticed that we do not have any unit tests for IndexBase::check_mapping_sort_fields(). So I expanded these tests to also verify that functionality.","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"9773ac596768ab48bb86f4a816e1e517a1b50f7b","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            return \"1234\""},{"line_number":299,"context_line":"        mock_engine.reset_mock()"},{"line_number":300,"context_line":"        plugin \u003d fake_plugins.NonRoleSeparatedPlugin(es_engine\u003dmock_engine)"},{"line_number":301,"context_line":"        plugin.NotificationHandlerCls.get_version \u003d \\"},{"line_number":302,"context_line":"            types.MethodType(fake_version, plugin)"},{"line_number":303,"context_line":"        plugin.initial_indexing(index_name\u003d\u0027fake\u0027)"},{"line_number":304,"context_line":"        mock_save.assert_called_once_with(fake_plugins.NON_ROLE_SEPARATED_DATA,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_acbf5b5f","line":301,"range":{"start_line":301,"start_character":15,"end_line":301,"end_character":37},"updated":"2016-04-01 20:33:09.000000000","message":"This is a very bad idea; it will override get_version globally, not just for this test. See mock.patch and mock.patch.object (in this case mock.patch is best)","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"46a9829003b9adbfc26c606d92839aec6897ea5d","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            return \"1234\""},{"line_number":299,"context_line":"        mock_engine.reset_mock()"},{"line_number":300,"context_line":"        plugin \u003d fake_plugins.NonRoleSeparatedPlugin(es_engine\u003dmock_engine)"},{"line_number":301,"context_line":"        plugin.NotificationHandlerCls.get_version \u003d \\"},{"line_number":302,"context_line":"            types.MethodType(fake_version, plugin)"},{"line_number":303,"context_line":"        plugin.initial_indexing(index_name\u003d\u0027fake\u0027)"},{"line_number":304,"context_line":"        mock_save.assert_called_once_with(fake_plugins.NON_ROLE_SEPARATED_DATA,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_3d440573","line":301,"range":{"start_line":301,"start_character":15,"end_line":301,"end_character":37},"in_reply_to":"ba0121b8_acbf5b5f","updated":"2016-04-04 14:02:44.000000000","message":"Done. Once again I went back and reviewed the rest of the test code and found other instances of this. We should probably relook at them.","commit_id":"b8fbb368986f3fe703c6563edaacb750547c1450"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"435e131922a452df6b02a07d0c6f224852ee58d8","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            mock_settings.assert_not_called()"},{"line_number":301,"context_line":"            mock_mapping.assert_not_called()"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # Test #3: Plugin with two children. No \"raw\" mapping fields."},{"line_number":304,"context_line":"        mock_mapping.reset_mock()"},{"line_number":305,"context_line":"        mock_settings.reset_mock()"},{"line_number":306,"context_line":"        parent_plugin \u003d fake_plugins.FakeSimplePlugin(es_engine\u003dmock_engine)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_d29053ef","line":303,"range":{"start_line":303,"start_character":19,"end_line":303,"end_character":25},"updated":"2016-04-04 15:05:55.000000000","message":"For future reference, arguably this could be its own test but i\u0027m not too bothered either way. We\u0027ve got other tests that are much longer (many of which i am guilty of) but in general it\u0027s nice to try to make tests as single-purpose as possible (so, one test mapping for sort field and one for checking that calls are only made once per parent-child hierarchy). But as i say, not too concerned.","commit_id":"471212311ef8e6519ff7b3a311edb7e542c68e10"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"17de59d0977c5ee1f8e0895502148d370140fb87","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            mock_settings.assert_not_called()"},{"line_number":301,"context_line":"            mock_mapping.assert_not_called()"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # Test #3: Plugin with two children. No \"raw\" mapping fields."},{"line_number":304,"context_line":"        mock_mapping.reset_mock()"},{"line_number":305,"context_line":"        mock_settings.reset_mock()"},{"line_number":306,"context_line":"        parent_plugin \u003d fake_plugins.FakeSimplePlugin(es_engine\u003dmock_engine)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_0bd8d652","line":303,"range":{"start_line":303,"start_character":19,"end_line":303,"end_character":25},"in_reply_to":"9a061dce_d29053ef","updated":"2016-04-04 15:44:49.000000000","message":"I considered that. It seems that check_mapping_sort_fields was too low level to do a direct unit test against. And since prepare_index is a minimal routine, I thought verifying both of these methods wouldn\u0027t be too much extra complexity.","commit_id":"471212311ef8e6519ff7b3a311edb7e542c68e10"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"435e131922a452df6b02a07d0c6f224852ee58d8","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        mock_engine \u003d mock.Mock()"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        # Test #1: Index with two documents."},{"line_number":323,"context_line":"        mock_engine.reset_mock()"},{"line_number":324,"context_line":"        mock_vers.return_value \u003d \u00271234\u0027"},{"line_number":325,"context_line":"        plugin \u003d fake_plugins.NonRoleSeparatedPlugin(es_engine\u003dmock_engine)"},{"line_number":326,"context_line":"        plugin.initial_indexing(index_name\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_dea5ffb5","line":323,"range":{"start_line":323,"start_character":20,"end_line":323,"end_character":30},"updated":"2016-04-04 15:05:55.000000000","message":"This isn\u0027t necessary","commit_id":"471212311ef8e6519ff7b3a311edb7e542c68e10"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"17de59d0977c5ee1f8e0895502148d370140fb87","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        mock_engine \u003d mock.Mock()"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        # Test #1: Index with two documents."},{"line_number":323,"context_line":"        mock_engine.reset_mock()"},{"line_number":324,"context_line":"        mock_vers.return_value \u003d \u00271234\u0027"},{"line_number":325,"context_line":"        plugin \u003d fake_plugins.NonRoleSeparatedPlugin(es_engine\u003dmock_engine)"},{"line_number":326,"context_line":"        plugin.initial_indexing(index_name\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_8be4e60d","line":323,"range":{"start_line":323,"start_character":20,"end_line":323,"end_character":30},"in_reply_to":"9a061dce_dea5ffb5","updated":"2016-04-04 15:44:49.000000000","message":"Let\u0027s see, we create the mock in the previous line. You\u0027re right, it\u0027s gone.","commit_id":"471212311ef8e6519ff7b3a311edb7e542c68e10"}],"searchlight/tests/unit/test_reindexing.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"65ff94ea007dbc1c9578eff6ca6bde7042bd6a0f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            mock_engine.reset_mock()"},{"line_number":132,"context_line":"            mock_engine.indices.exists_alias.side_effect \u003d [False]"},{"line_number":133,"context_line":"            mock_engine.indices.put_alias.side_effect \u003d [TypeError]"},{"line_number":134,"context_line":"            # self.assertRaises(TypeError, plugin_utils.setup_alias,"},{"line_number":135,"context_line":"            #                   (ndx, ndx_s, ndx_l))"},{"line_number":136,"context_line":"            try:"},{"line_number":137,"context_line":"                plugin_utils.setup_alias(ndx, ndx_s, ndx_l)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_1c6db598","line":134,"range":{"start_line":134,"start_character":12,"end_line":134,"end_character":13},"updated":"2016-04-04 18:05:35.000000000","message":"This way looks preferably to manually try... catching. Any reason not to use it? I don\u0027t think the arguments should be passed as a tuple though - assertRaises accepts positional and keyword args","commit_id":"d7c191e07fe5c91b668eff3ea428164655d989a0"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"f23503e5918bc5dad8b20ea44a8c6c4c25218a9e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            mock_engine.reset_mock()"},{"line_number":132,"context_line":"            mock_engine.indices.exists_alias.side_effect \u003d [False]"},{"line_number":133,"context_line":"            mock_engine.indices.put_alias.side_effect \u003d [TypeError]"},{"line_number":134,"context_line":"            # self.assertRaises(TypeError, plugin_utils.setup_alias,"},{"line_number":135,"context_line":"            #                   (ndx, ndx_s, ndx_l))"},{"line_number":136,"context_line":"            try:"},{"line_number":137,"context_line":"                plugin_utils.setup_alias(ndx, ndx_s, ndx_l)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_fc627cd7","line":134,"range":{"start_line":134,"start_character":12,"end_line":134,"end_character":13},"in_reply_to":"9a061dce_1c6db598","updated":"2016-04-04 19:48:25.000000000","message":"Good catch. I was debugging something with the exceptions and forgot to change it back.","commit_id":"d7c191e07fe5c91b668eff3ea428164655d989a0"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"65ff94ea007dbc1c9578eff6ca6bde7042bd6a0f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            mock_engine.reset_mock()"},{"line_number":144,"context_line":"            mock_engine.indices.exists_alias.side_effect \u003d [True, False]"},{"line_number":145,"context_line":"            mock_engine.indices.put_alias.side_effect \u003d [Exception]"},{"line_number":146,"context_line":"            # self.assertRaises(TypeError, plugin_utils.setup_alias,"},{"line_number":147,"context_line":"            #                   (ndx, ndx_s, ndx_l))"},{"line_number":148,"context_line":"            try:"},{"line_number":149,"context_line":"                plugin_utils.setup_alias(ndx, ndx_s, ndx_l)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_fc69e18c","line":146,"range":{"start_line":146,"start_character":32,"end_line":146,"end_character":41},"updated":"2016-04-04 18:05:35.000000000","message":"Same as above","commit_id":"d7c191e07fe5c91b668eff3ea428164655d989a0"}]}