)]}'
{"searchlight/elasticsearch/plugins/cinder/volumes.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"76017e5b28663cb1571c90a21ce23a25e43cf0a6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                        \u0027raw\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027}"},{"line_number":98,"context_line":"                    }"},{"line_number":99,"context_line":"                },"},{"line_number":100,"context_line":"                # Using long here to consistent with glance.images"},{"line_number":101,"context_line":"                \u0027size\u0027: {\u0027type\u0027: \u0027long\u0027},"},{"line_number":102,"context_line":"                \u0027snapshot_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":103,"context_line":"                \u0027source_volid\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_d0d4dd48","line":100,"updated":"2016-04-15 13:50:26.000000000","message":"Glad you added this comment, this should prevent someone from coming along and \"fixing\" the data type.","commit_id":"5db561268b1ab1f157862911bf3351d0423e9343"}],"searchlight/elasticsearch/plugins/glance/images.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"0544cb9b03a51a8724b3926db6ee10a14a5312f4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                \u0027description\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                \u0027tags\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":57,"context_line":"                \u0027disk_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"                \u0027container_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"                \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":60,"context_line":"                \u0027virtual_size\u0027: {\u0027type\u0027: \u0027long\u0027},"},{"line_number":61,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_1e6b6df2","line":58,"updated":"2016-04-14 14:47:02.000000000","message":"Images are in bytes and volume size is in GB. If we want to make them consistent for querying then integer is not big enough to hold image size. \n\n(2^31 - 1) / 8) / 1024 / 1024 \u003d ~256 MB","commit_id":"817ebe03c61b4e824c98949d58b595d279e66792"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"63e0155f438b89bb04a218f828ef8b45f427db12","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                \u0027description\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                \u0027tags\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":57,"context_line":"                \u0027disk_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"                \u0027container_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"                \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":60,"context_line":"                \u0027virtual_size\u0027: {\u0027type\u0027: \u0027long\u0027},"},{"line_number":61,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_32749d66","line":58,"in_reply_to":"5a18252c_1e6b6df2","updated":"2016-04-14 14:50:51.000000000","message":"Yes, I think we\u0027ll need to go with long. If we normalized the units we\u0027d probably need to use MB since glance images are typically DVD sized (or in the case of cirros, much much smaller) where cinder volumes are always  multiple MB. I suggest for this, changing the cinder type to long, and if we normalize them (size_mb) we can do that separately.","commit_id":"817ebe03c61b4e824c98949d58b595d279e66792"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"8e98039356e50b2d792f99a6000b222eae9b75d2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                \u0027description\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                \u0027tags\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":57,"context_line":"                \u0027disk_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"                \u0027container_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"                \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":60,"context_line":"                \u0027virtual_size\u0027: {\u0027type\u0027: \u0027long\u0027},"},{"line_number":61,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_72745535","line":58,"in_reply_to":"5a18252c_32749d66","updated":"2016-04-14 14:53:29.000000000","message":"I\u0027m okay with switching volume to long and release noting it. Let the API user beware of the implication.","commit_id":"817ebe03c61b4e824c98949d58b595d279e66792"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"40fada57f960125c47647697cd8cba8988d4bbd3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                \u0027description\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                \u0027tags\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":57,"context_line":"                \u0027disk_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"                \u0027container_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"                \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":60,"context_line":"                \u0027virtual_size\u0027: {\u0027type\u0027: \u0027long\u0027},"},{"line_number":61,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_bc25055d","line":58,"in_reply_to":"5a18252c_72745535","updated":"2016-04-15 01:12:16.000000000","message":"Done","commit_id":"817ebe03c61b4e824c98949d58b595d279e66792"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"37678f02c265edf14dbae0cd99db7983d7bc8948","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                \u0027description\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                \u0027tags\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":57,"context_line":"                \u0027disk_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"                \u0027container_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"                \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":60,"context_line":"                \u0027virtual_size\u0027: {\u0027type\u0027: \u0027long\u0027},"},{"line_number":61,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_d546f379","line":58,"in_reply_to":"5a18252c_72745535","updated":"2016-04-14 15:11:39.000000000","message":"Just a point of information, in some large public clouds, the mean image size is roughly 40GB, and I\u0027ve seen many on the order of 680GB.","commit_id":"817ebe03c61b4e824c98949d58b595d279e66792"}]}