)]}'
{"releasenotes/notes/bp-facet-totals-369e7cd81b15f658.yaml":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"834e71471472789a877bfb37cfb7190d78950eda","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - The /facets API response will return different"},{"line_number":13,"context_line":"    structures based on the presence or absence of"},{"line_number":14,"context_line":"    the include_totals parameter, to retain Mitaka API"},{"line_number":15,"context_line":"    compatibility."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dab17558_608c45d7","line":15,"updated":"2016-05-17 23:45:09.000000000","message":"Good for it to go in with backwards compatibility in newton 1, but we might want to cut over and remove backwards compatibility in newton-3 since it is a major increment.","commit_id":"95858b77fef8b3eb3e1d1ecc2fa683e8451e3b94"}],"searchlight/api/v1/search.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"42e7669ed123a9d92c920a94686fdac40d789ae9","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def facets(self, req, index_name\u003dNone, doc_type\u003dNone,"},{"line_number":105,"context_line":"               all_projects\u003dFalse, limit_terms\u003d0, include_fields\u003dTrue,"},{"line_number":106,"context_line":"               include_totals\u003dTrue):"},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            search_repo \u003d self.gateway.get_catalog_search_repo(req.context)"},{"line_number":109,"context_line":"            return search_repo.facets(index_name, doc_type,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_a2183d76","line":106,"updated":"2016-07-21 01:29:27.000000000","message":"we can pass include_fields\u003dFalse and  include_totals\u003dFalse at the same time, and the request will return nothing useful in this case, so i suggest adding a check here either include_fields or include_totals is needed for the req.","commit_id":"ac1535e420046690a42b95d2e67f5aac2654843c"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"785263b0b5fb501f03606e1b6af754c0d3085008","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def facets(self, req, index_name\u003dNone, doc_type\u003dNone,"},{"line_number":105,"context_line":"               all_projects\u003dFalse, limit_terms\u003d0, include_fields\u003dTrue,"},{"line_number":106,"context_line":"               include_totals\u003dTrue):"},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            search_repo \u003d self.gateway.get_catalog_search_repo(req.context)"},{"line_number":109,"context_line":"            return search_repo.facets(index_name, doc_type,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_6e34024a","line":106,"in_reply_to":"dada55a8_5493c85a","updated":"2016-07-22 19:40:21.000000000","message":"include_totals is now redundant; I\u0027m going to remove the option entirely. The count query costs nothing if you request fields, and if you don\u0027t you\u0027ll get nothing back anyway so it\u0027s pointless. The only reason perhaps to leave it is if we add an option to return the mappings only but it\u0027s likely that will go into the plugins_info call.","commit_id":"ac1535e420046690a42b95d2e67f5aac2654843c"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"ca2538aa82a1488ff7e703b876b8f9cb656d0a81","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def facets(self, req, index_name\u003dNone, doc_type\u003dNone,"},{"line_number":105,"context_line":"               all_projects\u003dFalse, limit_terms\u003d0, include_fields\u003dTrue,"},{"line_number":106,"context_line":"               include_totals\u003dTrue):"},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            search_repo \u003d self.gateway.get_catalog_search_repo(req.context)"},{"line_number":109,"context_line":"            return search_repo.facets(index_name, doc_type,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_5493c85a","line":106,"in_reply_to":"dada55a8_a2183d76","updated":"2016-07-21 22:00:53.000000000","message":"I\u0027m not sure I agree. It seems to be working correctly (and as expected) if the user passes in False for both. The response is a list of resource types with no data associated with them.\n\nThis response may not be consider useful, but it is what the user requested :)\n\nMaybe I\u0027m not understanding what should happen in a check if both fields are False. Should we return an error or just an empty list (e.g. no list of resource types)? Is it to provide a more meaningful user experience by alerting the user that they accidentally specified a request that is not useful?","commit_id":"ac1535e420046690a42b95d2e67f5aac2654843c"}],"searchlight/elasticsearch/__init__.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"ca2538aa82a1488ff7e703b876b8f9cb656d0a81","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                # Add field facets if include_fields is true"},{"line_number":114,"context_line":"                field_facets, doc_count \u003d plugin.obj.get_facets("},{"line_number":115,"context_line":"                    self.context, all_projects, limit_terms,"},{"line_number":116,"context_line":"                    include_fields\u003dinclude_fields)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"                if include_fields:"},{"line_number":119,"context_line":"                    type_facets[\"facets\"] \u003d field_facets"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_316c6607","line":116,"updated":"2016-07-21 22:00:53.000000000","message":"Is there a reason we aren\u0027t passing \"include_totals\" as a parameter here? It\u0027s a parameter for get_facets(). It looks like the code will still handle it correctly. Since include_totals defaults to True in get_facets() it will do the work required, but at line 121 we will just discard it.\n\nIt would be a shame to not use such a wonderful parameter to get_facets() :)","commit_id":"ac1535e420046690a42b95d2e67f5aac2654843c"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"785263b0b5fb501f03606e1b6af754c0d3085008","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                # Add field facets if include_fields is true"},{"line_number":114,"context_line":"                field_facets, doc_count \u003d plugin.obj.get_facets("},{"line_number":115,"context_line":"                    self.context, all_projects, limit_terms,"},{"line_number":116,"context_line":"                    include_fields\u003dinclude_fields)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"                if include_fields:"},{"line_number":119,"context_line":"                    type_facets[\"facets\"] \u003d field_facets"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_0e3586f6","line":116,"in_reply_to":"dada55a8_316c6607","updated":"2016-07-22 19:40:21.000000000","message":"I\u0027ll remove include_totals; there\u0027s no reason for it not to be True","commit_id":"ac1535e420046690a42b95d2e67f5aac2654843c"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"55fe4cfe20e86e7e0acf83d6349e6dcf3f2e428d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        return plugin_list"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def facets(self, for_index, for_doc_types, all_projects, limit_terms,"},{"line_number":99,"context_line":"               include_fields\u003dTrue, include_totals\u003dTrue):"},{"line_number":100,"context_line":"        \"\"\"include_totals is for mitaka-compatibility and will be removed"},{"line_number":101,"context_line":"        (and thus always present) post-Newton."},{"line_number":102,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_c5578900","line":99,"range":{"start_line":99,"start_character":36,"end_line":99,"end_character":55},"updated":"2016-07-25 18:05:59.000000000","message":"We forgot to remove include_totals from here. It\u0027s not used.","commit_id":"9bb5ddd977f963279cc5e06e40e0ed27b87e1d32"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"86268680574a90a41699a6dbf5b9bc66e5b4e10b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        return plugin_list"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def facets(self, for_index, for_doc_types, all_projects, limit_terms,"},{"line_number":99,"context_line":"               include_fields\u003dTrue, include_totals\u003dTrue):"},{"line_number":100,"context_line":"        \"\"\"include_totals is for mitaka-compatibility and will be removed"},{"line_number":101,"context_line":"        (and thus always present) post-Newton."},{"line_number":102,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_5b7c1aeb","line":99,"range":{"start_line":99,"start_character":36,"end_line":99,"end_character":55},"in_reply_to":"dada55a8_c5578900","updated":"2016-07-25 18:41:25.000000000","message":"Done","commit_id":"9bb5ddd977f963279cc5e06e40e0ed27b87e1d32"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"55fe4cfe20e86e7e0acf83d6349e6dcf3f2e428d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"               include_fields\u003dTrue, include_totals\u003dTrue):"},{"line_number":100,"context_line":"        \"\"\"include_totals is for mitaka-compatibility and will be removed"},{"line_number":101,"context_line":"        (and thus always present) post-Newton."},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        facets \u003d {}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        for resource_type, plugin in six.iteritems(self.plugins):"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_2547854c","line":102,"updated":"2016-07-25 18:05:59.000000000","message":"This comment can be deleted.","commit_id":"9bb5ddd977f963279cc5e06e40e0ed27b87e1d32"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"86268680574a90a41699a6dbf5b9bc66e5b4e10b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"               include_fields\u003dTrue, include_totals\u003dTrue):"},{"line_number":100,"context_line":"        \"\"\"include_totals is for mitaka-compatibility and will be removed"},{"line_number":101,"context_line":"        (and thus always present) post-Newton."},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        facets \u003d {}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        for resource_type, plugin in six.iteritems(self.plugins):"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_9b8692d9","line":102,"in_reply_to":"dada55a8_2547854c","updated":"2016-07-25 18:41:25.000000000","message":"Done","commit_id":"9bb5ddd977f963279cc5e06e40e0ed27b87e1d32"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"55fe4cfe20e86e7e0acf83d6349e6dcf3f2e428d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                if include_fields:"},{"line_number":119,"context_line":"                    type_facets[\"facets\"] \u003d field_facets"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"                if include_totals:"},{"line_number":122,"context_line":"                    type_facets[\"doc_count\"] \u003d doc_count"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"                facets[resource_type] \u003d type_facets"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_255e6512","line":121,"updated":"2016-07-25 18:05:59.000000000","message":"Remove this check and always set type_facets[\"doc_count\"].","commit_id":"9bb5ddd977f963279cc5e06e40e0ed27b87e1d32"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"86268680574a90a41699a6dbf5b9bc66e5b4e10b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                if include_fields:"},{"line_number":119,"context_line":"                    type_facets[\"facets\"] \u003d field_facets"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"                if include_totals:"},{"line_number":122,"context_line":"                    type_facets[\"doc_count\"] \u003d doc_count"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"                facets[resource_type] \u003d type_facets"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_fb6d0e33","line":121,"in_reply_to":"dada55a8_255e6512","updated":"2016-07-25 18:41:25.000000000","message":"Done","commit_id":"9bb5ddd977f963279cc5e06e40e0ed27b87e1d32"}],"searchlight/elasticsearch/plugins/base.py":[{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"a6d8d2384c2985c9b3610d6ed891066e346108a0","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            agg_results,"},{"line_number":286,"context_line":"            self.get_document_type())"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if not agg_results:"},{"line_number":289,"context_line":"            LOG.warning(_LW("},{"line_number":290,"context_line":"                \"No aggregations found for %(resource_type)s. There may \""},{"line_number":291,"context_line":"                \"be a mapping problem.\") %"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_9c77f6d3","line":288,"updated":"2016-05-06 12:36:37.000000000","message":"if only count info is requested, no need to log the warning.","commit_id":"685828f569d8c4d5ad724f1ee6762aa1d1af8e9d"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"41b27d9e74b15d197d709404cf258d9c40b9e907","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            agg_results,"},{"line_number":286,"context_line":"            self.get_document_type())"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if not agg_results:"},{"line_number":289,"context_line":"            LOG.warning(_LW("},{"line_number":290,"context_line":"                \"No aggregations found for %(resource_type)s. There may \""},{"line_number":291,"context_line":"                \"be a mapping problem.\") %"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_685cb1ed","line":288,"in_reply_to":"dab17558_9c77f6d3","updated":"2016-05-09 23:05:38.000000000","message":"Thanks, will correct","commit_id":"685828f569d8c4d5ad724f1ee6762aa1d1af8e9d"}],"searchlight/tests/functional/__init__.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"55fe4cfe20e86e7e0acf83d6349e6dcf3f2e428d","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        if include_fields is not None:"},{"line_number":518,"context_line":"            params[\u0027include_fields\u0027] \u003d \"true\" if include_fields else \"false\""},{"line_number":519,"context_line":"        if include_totals is not None:"},{"line_number":520,"context_line":"            params[\u0027include_totals\u0027] \u003d \"true\" if include_totals else \"false\""},{"line_number":521,"context_line":"        url +\u003d \u0027?\u0027 + urllib.parse.urlencode(params)"},{"line_number":522,"context_line":"        return self._request(\"GET\", url, tenant, role\u003drole,"},{"line_number":523,"context_line":"                             decode_json\u003ddecode_json)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_e591ed9b","line":520,"updated":"2016-07-25 18:05:59.000000000","message":"Since \"include_totals\" has gone away, these two lines should be removed.","commit_id":"9bb5ddd977f963279cc5e06e40e0ed27b87e1d32"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"86268680574a90a41699a6dbf5b9bc66e5b4e10b","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        if include_fields is not None:"},{"line_number":518,"context_line":"            params[\u0027include_fields\u0027] \u003d \"true\" if include_fields else \"false\""},{"line_number":519,"context_line":"        if include_totals is not None:"},{"line_number":520,"context_line":"            params[\u0027include_totals\u0027] \u003d \"true\" if include_totals else \"false\""},{"line_number":521,"context_line":"        url +\u003d \u0027?\u0027 + urllib.parse.urlencode(params)"},{"line_number":522,"context_line":"        return self._request(\"GET\", url, tenant, role\u003drole,"},{"line_number":523,"context_line":"                             decode_json\u003ddecode_json)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_1b73c216","line":520,"in_reply_to":"dada55a8_e591ed9b","updated":"2016-07-25 18:41:25.000000000","message":"Done","commit_id":"9bb5ddd977f963279cc5e06e40e0ed27b87e1d32"}]}